coreboot-gerrit April 2018

coreboot-gerrit@coreboot.org

1 participants
2168 discussions

Change in coreboot[master]: lib/bootmem: Add method to walk memory tables
by build bot (Jenkins) (Code Review) 10 Apr '18

10 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25583 ) Change subject: lib/bootmem: Add method to walk memory tables ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/24112/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/69825/ : SUCCESS -- To view, visit https://review.coreboot.org/25583 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0004e5ad5fe2289827f370f0d0f9979d3cbd3926 Gerrit-Change-Number: 25583 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 10 Apr 2018 08:56:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src/lib: Add uImage support
by build bot (Jenkins) (Code Review) 10 Apr '18

10 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25019 ) Change subject: src/lib: Add uImage support ...................................................................... Patch Set 16: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/24110/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/69823/ : SUCCESS -- To view, visit https://review.coreboot.org/25019 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0f27b92a5e074966f893399eb401eb97d784850d Gerrit-Change-Number: 25019 Gerrit-PatchSet: 16 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 10 Apr 2018 08:42:30 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: lib/bootmem: Introduce new memory type
by build bot (Jenkins) (Code Review) 10 Apr '18

10 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25383 ) Change subject: lib/bootmem: Introduce new memory type ...................................................................... Patch Set 9: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/24109/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/69822/ : SUCCESS -- To view, visit https://review.coreboot.org/25383 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c983ce43616147c519a43edee3b61d54eadbb9a Gerrit-Change-Number: 25383 Gerrit-PatchSet: 9 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 10 Apr 2018 08:41:31 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: lib/memrange: Introduce method to clone memrange
by build bot (Jenkins) (Code Review) 10 Apr '18

10 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25582 ) Change subject: lib/memrange: Introduce method to clone memrange ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/24111/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/69824/ : SUCCESS -- To view, visit https://review.coreboot.org/25582 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64b27bf2611ca310385ef680f030a3e4aa0c2680 Gerrit-Change-Number: 25582 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 10 Apr 2018 08:37:55 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: lib/bootmem: Add method to walk memory tables
by Patrick Rudolph (Code Review) 10 Apr '18

10 Apr '18

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/25583 Change subject: lib/bootmem: Add method to walk memory tables ...................................................................... lib/bootmem: Add method to walk memory tables Add a method to walk specified memory tables and call a function for each memory range. Merge LB_MEM_RAM_DONT_OVERLAP into LB_MEM_RAM on request, to ease working with memory regions intended for payloads. Required for uImage support in coreboot. Tested on Cavium SoC. Change-Id: I0004e5ad5fe2289827f370f0d0f9979d3cbd3926 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/include/bootmem.h M src/lib/bootmem.c 2 files changed, 48 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/25583/1 diff --git a/src/include/bootmem.h b/src/include/bootmem.h index b825272..b16bcc0 100644 --- a/src/include/bootmem.h +++ b/src/include/bootmem.h @@ -41,6 +41,23 @@ /* Print current range map of boot memory. */ void bootmem_dump_ranges(void); +typedef bool (*range_action_t)(const struct range_entry *r, void *arg); + +/** + * Walk memory tables and call the provided function, for every region, + * that is bigger than min_size. The caller has to return false to break + * out of the loop any time, or return true to continue. + * + * @param merge_ram_dont_overlap If true, LB_MEM_RAM_DONT_OVERLAP regions + * appear as usable RAM and will never appear in one callback. + * The regions are merged with usable RAM regions. + * If false, all regions are provided as is. + * @param action The function to call for each memory range. + * @param Pointer passed to function @action. Set to NULL if unused. + */ +void bootmem_walk(const bool merge_ram_dont_overlap, range_action_t action, + void *arg); + /* Return 1 if region targets usable RAM, 0 otherwise. */ int bootmem_region_targets_usable_ram(uint64_t start, uint64_t size); diff --git a/src/lib/bootmem.c b/src/lib/bootmem.c index f00ce13..f34e773 100644 --- a/src/lib/bootmem.c +++ b/src/lib/bootmem.c @@ -133,6 +133,37 @@ } } +void bootmem_walk(const bool merge_ram_dont_overlap, range_action_t action, + void *arg) +{ + const struct range_entry *r; + struct memranges *memranges; + struct memranges bm; + + assert (action); + + if (merge_ram_dont_overlap) { + /** + * Convert LB_MEM_RAM_DONT_OVERLAP to LB_MEM_RAM and merge + * ranges: + * The caller doesn't care about memory used by firmware. + */ + memranges_clone(&bm, &bootmem); + memranges_update_tag(&bm, LB_MEM_RAM_DONT_OVERLAP, LB_MEM_RAM); + } + + memranges = merge_ram_dont_overlap ? &bm : &bootmem ; + + memranges_each_entry(r, memranges) { + if (!action(r, arg)) + goto out; + } + +out: + if (merge_ram_dont_overlap) + memranges_teardown(&bm); +} + int bootmem_region_targets_usable_ram(uint64_t start, uint64_t size) { const struct range_entry *r; -- To view, visit https://review.coreboot.org/25583 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0004e5ad5fe2289827f370f0d0f9979d3cbd3926 Gerrit-Change-Number: 25583 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>

1 0

Change in coreboot[master]: lib/memrange: Introduce method to clone memrange
by Patrick Rudolph (Code Review) 10 Apr '18

10 Apr '18

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/25582 Change subject: lib/memrange: Introduce method to clone memrange ...................................................................... lib/memrange: Introduce method to clone memrange Add a new method to clone an existing memrange with all of its entries. Required for new bootmem type LB_MEM_RAM_DONT_OVERLAP. Change-Id: I64b27bf2611ca310385ef680f030a3e4aa0c2680 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/include/memrange.h M src/lib/memrange.c 2 files changed, 19 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/25582/1 diff --git a/src/include/memrange.h b/src/include/memrange.h index 46a992a..7f42aa2 100644 --- a/src/include/memrange.h +++ b/src/include/memrange.h @@ -98,6 +98,9 @@ unsigned long mask, unsigned long match, unsigned long tag); +/* Clone a memrange. The new memrange has the same entries as the old one. */ +void memranges_clone(struct memranges *newranges, struct memranges *oldranges); + /* Remove and free all entries within the memranges structure. */ void memranges_teardown(struct memranges *ranges); diff --git a/src/lib/memrange.c b/src/lib/memrange.c index d3cda12..96d7524 100644 --- a/src/lib/memrange.c +++ b/src/lib/memrange.c @@ -310,6 +310,22 @@ memranges_add_resources(ranges, mask, match, tag); } +/* Clone a memrange. The new memrange has the same entries as the old one. */ +void memranges_clone(struct memranges *newranges, struct memranges *oldranges) +{ + struct range_entry *r, *cur; + struct range_entry **prev_ptr; + + memranges_init_empty(newranges, NULL, 0); + + prev_ptr = &newranges->entries; + memranges_each_entry(r, oldranges) { + cur = range_list_add(newranges, prev_ptr, r->begin, r->end, + r->tag); + prev_ptr = &cur->next; + } +} + void memranges_teardown(struct memranges *ranges) { while (ranges->entries != NULL) { -- To view, visit https://review.coreboot.org/25582 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I64b27bf2611ca310385ef680f030a3e4aa0c2680 Gerrit-Change-Number: 25582 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>

1 0

Change in coreboot[master]: soc/intel/common: Configure all possible GFX DSM memory reserve range
by build bot (Jenkins) (Code Review) 10 Apr '18

10 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25562 ) Change subject: soc/intel/common: Configure all possible GFX DSM memory reserve range ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/69821/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/24108/ : SUCCESS -- To view, visit https://review.coreboot.org/25562 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I99735e9a2ee57626bd9d7258e700f7f39ef02e58 Gerrit-Change-Number: 25562 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Tue, 10 Apr 2018 07:15:29 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: drivers/intel/wifi: Add support for Harrison Peak (HrP)
by build bot (Jenkins) (Code Review) 10 Apr '18

10 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25561 ) Change subject: drivers/intel/wifi: Add support for Harrison Peak (HrP) ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/69820/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/24107/ : SUCCESS -- To view, visit https://review.coreboot.org/25561 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2d15f3f4a68887521ddbb1b99daf9d98cfa5c8b Gerrit-Change-Number: 25561 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Tue, 10 Apr 2018 07:10:29 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy: Disable rear camera for all vayne sku
by build bot (Jenkins) (Code Review) 10 Apr '18

10 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25563 ) Change subject: mb/google/poppy: Disable rear camera for all vayne sku ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/69819/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/24106/ : SUCCESS -- To view, visit https://review.coreboot.org/25563 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e7c1e8791462f00ad8336372954ee0a9465d9b8 Gerrit-Change-Number: 25563 Gerrit-PatchSet: 2 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 10 Apr 2018 06:25:17 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Enable DPTF and configure DPTF parameters
by build bot (Jenkins) (Code Review) 10 Apr '18

10 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25564 ) Change subject: mb/google/poppy/variants/nami: Enable DPTF and configure DPTF parameters ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/69818/ : SUCCESS -- To view, visit https://review.coreboot.org/25564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b7ae34ee64f19ef783a8c1571831b2293105a18 Gerrit-Change-Number: 25564 Gerrit-PatchSet: 4 Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kaiyen Chang <kaiyen.chang(a)intel.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: luke yang <luke_yang(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Tue, 10 Apr 2018 05:42:15 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2018