coreboot-gerrit April 2018

coreboot-gerrit@coreboot.org

1 participants
2168 discussions

Change in coreboot[master]: util/lint: Fix execution on OpenBSD
by Philipp Deppenwiese (Code Review) 17 Apr '18

17 Apr '18

Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/19745 ) Change subject: util/lint: Fix execution on OpenBSD ...................................................................... util/lint: Fix execution on OpenBSD util/lint/lint creates a file using mktemp. mktemp on OpenBSD requires at least 6 X's, while only 5 are in the template. Change-Id: I0b80214dd83d21e12e16a5002c68127a7ca2e41b Signed-off-by: Piotr Kubaj <pkubaj(a)anongoth.pl> Reviewed-on: https://review.coreboot.org/19745 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Reviewed-by: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> --- M util/lint/lint 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Philipp Deppenwiese: Looks good to me, approved Philippe Mathieu-Daudé: Looks good to me, but someone else must approve diff --git a/util/lint/lint b/util/lint/lint index 0cbe010..253a6e6 100755 --- a/util/lint/lint +++ b/util/lint/lint @@ -31,7 +31,7 @@ exit 1 fi -LINTLOG=$(mktemp .tmpconfig.lintXXXXX); +LINTLOG=$(mktemp .tmpconfig.lintXXXXXX); XMLFILE="$(dirname "$0")/junit.xml" if [ "$1" = "lint-extended" ]; then XMLFILE="$(dirname "$0")/extended-junit.xml" -- To view, visit https://review.coreboot.org/19745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0b80214dd83d21e12e16a5002c68127a7ca2e41b Gerrit-Change-Number: 19745 Gerrit-PatchSet: 2 Gerrit-Owner: Piotr Kubaj <pkubaj(a)anongoth.pl> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: util/lint: Fix execution on OpenBSD
by Philipp Deppenwiese (Code Review) 17 Apr '18

17 Apr '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/19745 ) Change subject: util/lint: Fix execution on OpenBSD ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/19745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0b80214dd83d21e12e16a5002c68127a7ca2e41b Gerrit-Change-Number: 19745 Gerrit-PatchSet: 1 Gerrit-Owner: Piotr Kubaj <pkubaj(a)anongoth.pl> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 16 Apr 2018 22:19:05 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: nvramtool: Fix build with OpenBSD
by Philipp Deppenwiese (Code Review) 17 Apr '18

17 Apr '18

Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/19741 ) Change subject: nvramtool: Fix build with OpenBSD ...................................................................... nvramtool: Fix build with OpenBSD OpenBSD needs the same includes as NetBSD. It also doesn't have x86_64_iopl function, but amd64_iopl. Change-Id: I28273d4d87a3a77cf35412a0695325c0535e42e5 Signed-off-by: Piotr Kubaj <pkubaj(a)anongoth.pl> Reviewed-on: https://review.coreboot.org/19741 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-by: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Reviewed-by: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> --- M util/nvramtool/Makefile M util/nvramtool/accessors/cmos-hw-unix.c 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Philipp Deppenwiese: Looks good to me, approved Arthur Heymans: Looks good to me, but someone else must approve Philippe Mathieu-Daudé: Looks good to me, but someone else must approve diff --git a/util/nvramtool/Makefile b/util/nvramtool/Makefile index bb623bb..8da7c76 100644 --- a/util/nvramtool/Makefile +++ b/util/nvramtool/Makefile @@ -34,7 +34,7 @@ ifeq ($(OS_ARCH), Darwin) LDFLAGS = -framework DirectHW endif -ifeq ($(OS_ARCH), NetBSD) +ifeq ($(OS_ARCH),$(filter $(OS_ARCH),NetBSD OpenBSD)) LDFLAGS = -l$(shell uname -p) endif ifeq ($(shell uname -o 2>/dev/null), Cygwin) diff --git a/util/nvramtool/accessors/cmos-hw-unix.c b/util/nvramtool/accessors/cmos-hw-unix.c index 33d6994..c66fa3e 100644 --- a/util/nvramtool/accessors/cmos-hw-unix.c +++ b/util/nvramtool/accessors/cmos-hw-unix.c @@ -17,7 +17,7 @@ #if (defined(__MACH__) && defined(__APPLE__)) #include <DirectHW/DirectHW.h> #endif -#if defined(__NetBSD__) +#if defined(__NetBSD__) || defined(__OpenBSD__) #if defined(__i386__) || defined(__x86_64__) #include <machine/sysarch.h> @@ -58,8 +58,12 @@ } #endif #ifdef __x86_64__ +#ifdef __OpenBSD__ +#define iopl amd64_iopl +#else #define iopl x86_64_iopl #endif +#endif #ifdef __i386__ #define iopl i386_iopl #endif -- To view, visit https://review.coreboot.org/19741 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I28273d4d87a3a77cf35412a0695325c0535e42e5 Gerrit-Change-Number: 19741 Gerrit-PatchSet: 5 Gerrit-Owner: Piotr Kubaj <pkubaj(a)anongoth.pl> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Piotr Kubaj <pkubaj(a)anongoth.pl> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: nvramtool: Fix build with OpenBSD
by Philipp Deppenwiese (Code Review) 17 Apr '18

17 Apr '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/19741 ) Change subject: nvramtool: Fix build with OpenBSD ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/19741 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28273d4d87a3a77cf35412a0695325c0535e42e5 Gerrit-Change-Number: 19741 Gerrit-PatchSet: 4 Gerrit-Owner: Piotr Kubaj <pkubaj(a)anongoth.pl> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Piotr Kubaj <pkubaj(a)anongoth.pl> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 16 Apr 2018 22:18:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/octopus: Enable Yorp EC software sync
by build bot (Jenkins) (Code Review) 17 Apr '18

17 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25692 ) Change subject: mb/google/octopus: Enable Yorp EC software sync ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/24432/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/70200/ : SUCCESS -- To view, visit https://review.coreboot.org/25692 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4969b254c6a58fba9dd8d2f31feb25b55c7a0c65 Gerrit-Change-Number: 25692 Gerrit-PatchSet: 2 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jett Rink <jettrink(a)chromium.org> Gerrit-CC: Scott Collyer <scollyer(a)google.com> Gerrit-Comment-Date: Mon, 16 Apr 2018 22:17:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/octopus: Enable Yorp EC software sync
by build bot (Jenkins) (Code Review) 17 Apr '18

17 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25692 ) Change subject: mb/google/octopus: Enable Yorp EC software sync ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/70199/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/24431/ : SUCCESS -- To view, visit https://review.coreboot.org/25692 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4969b254c6a58fba9dd8d2f31feb25b55c7a0c65 Gerrit-Change-Number: 25692 Gerrit-PatchSet: 1 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jett Rink <jettrink(a)chromium.org> Gerrit-CC: Scott Collyer <scollyer(a)google.com> Gerrit-Comment-Date: Mon, 16 Apr 2018 22:11:14 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/octopus: Enable Yorp EC software sync
by Justin TerAvest (Code Review) 17 Apr '18

17 Apr '18

Justin TerAvest has uploaded this change for review. ( https://review.coreboot.org/25692 Change subject: mb/google/octopus: Enable Yorp EC software sync ...................................................................... mb/google/octopus: Enable Yorp EC software sync With one additional EC change, Yorp is able to flash the EC as part of software sync and successfully boot. This change is only made for Yorp as we want this disabled for Bip bringup. BRANCH=none BUG=b:77874283 TEST=Successful flash and boot on Yorp with this change TEST=Checked GBB flags on Yorp and Bip images with gbb_utility CQ-DEPEND=CL:1014397 Change-Id: I4969b254c6a58fba9dd8d2f31feb25b55c7a0c65 Signed-off-by: Justin TerAvest <teravest(a)chromium.org> --- M src/mainboard/google/octopus/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/25692/1 diff --git a/src/mainboard/google/octopus/Kconfig b/src/mainboard/google/octopus/Kconfig index 656c6a3..e4c520e 100644 --- a/src/mainboard/google/octopus/Kconfig +++ b/src/mainboard/google/octopus/Kconfig @@ -26,7 +26,7 @@ bool default y select EC_GOOGLE_CHROMEEC_SWITCHES - select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC + select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC if BOARD_GOOGLE_BIP select VBOOT_LID_SWITCH config MAINBOARD_DIR -- To view, visit https://review.coreboot.org/25692 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4969b254c6a58fba9dd8d2f31feb25b55c7a0c65 Gerrit-Change-Number: 25692 Gerrit-PatchSet: 1 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org>

1 0

Change in coreboot[master]: Makefile.inc: Update `build.h` when needed
by build bot (Jenkins) (Code Review) 17 Apr '18

17 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25685 ) Change subject: Makefile.inc: Update `build.h` when needed ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/24430/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/70198/ : SUCCESS -- To view, visit https://review.coreboot.org/25685 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabd1a1ef78b38dab124944fbc837838daee6155e Gerrit-Change-Number: 25685 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Thiessen <alex.thiessen.de+coreboot(a)gmail.com> Gerrit-Reviewer: Alex Thiessen <alex.thiessen.de+coreboot(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 16 Apr 2018 22:04:16 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: checkpatch: Ignore marcos with flow control
by build bot (Jenkins) (Code Review) 17 Apr '18

17 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25686 ) Change subject: checkpatch: Ignore marcos with flow control ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70196/ : SUCCESS -- To view, visit https://review.coreboot.org/25686 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e10dc81740945f2d0dd16aac7189b2a937bf2f6 Gerrit-Change-Number: 25686 Gerrit-PatchSet: 2 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 16 Apr 2018 19:50:46 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: clang-format: Update .clang-format to be compliant with linux kernel ...
by build bot (Jenkins) (Code Review) 17 Apr '18

17 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25687 ) Change subject: clang-format: Update .clang-format to be compliant with linux kernel coding style ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/24429/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/70197/ : SUCCESS -- To view, visit https://review.coreboot.org/25687 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I61a32ed951d18d5865be201bb38d18e50dd76f08 Gerrit-Change-Number: 25687 Gerrit-PatchSet: 3 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 16 Apr 2018 19:50:20 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2018