Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/25399 )
Change subject: util/intelmetool: Add support for platforms without RCBA
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/25399
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7926aa80b132d5be9fece0724516701d74dd4d3d
Gerrit-Change-Number: 25399
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 16 Apr 2018 22:27:01 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/25398 )
Change subject: util/intelmetool: Fix crash on strict devmem kernels
......................................................................
util/intelmetool: Fix crash on strict devmem kernels
Don't crash if mapping MEI PCI memory fails.
This can happen if CONFIG_STRICT_DEVMEM is enabled.
Change-Id: I33c75a7cccb4cefaa26f70aed4bdc4bd620cdad0
Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Reviewed-on: https://review.coreboot.org/25398
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
Reviewed-by: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
---
M util/intelmetool/intelmetool.c
M util/intelmetool/me.c
2 files changed, 9 insertions(+), 4 deletions(-)
Approvals:
build bot (Jenkins): Verified
Paul Menzel: Looks good to me, but someone else must approve
Philipp Deppenwiese: Looks good to me, approved
diff --git a/util/intelmetool/intelmetool.c b/util/intelmetool/intelmetool.c
index 14cb035..bc5f26c 100644
--- a/util/intelmetool/intelmetool.c
+++ b/util/intelmetool/intelmetool.c
@@ -288,17 +288,21 @@
printf("ME: has a broken implementation on your board with"
"this firmware\n");
- intel_mei_setup(dev);
+ if (intel_mei_setup(dev))
+ goto out;
usleep(ME_COMMAND_DELAY);
mei_reset();
usleep(ME_COMMAND_DELAY);
- mkhi_get_fw_version(&ME_major_ver, &ME_minor_ver);
+ if (mkhi_get_fw_version(&ME_major_ver, &ME_minor_ver))
+ goto out;
usleep(ME_COMMAND_DELAY);
mei_reset();
usleep(ME_COMMAND_DELAY);
- mkhi_get_fwcaps();
+ if (mkhi_get_fwcaps())
+ goto out;
usleep(ME_COMMAND_DELAY);
+out:
rehide_me();
}
diff --git a/util/intelmetool/me.c b/util/intelmetool/me.c
index 6517022..f14f4cd 100644
--- a/util/intelmetool/me.c
+++ b/util/intelmetool/me.c
@@ -582,7 +582,8 @@
mei_mmap = map_physical(pagerounded, 0x2000);
mei_mmap += mei_base_address - pagerounded;
if (mei_mmap == NULL) {
- printf("Could not map ME setup memory\n");
+ printf("Could not map ME setup memory.\n"
+ "Do you have cmdline argument 'iomem=relaxed' set ?\n");
return 1;
}
--
To view, visit https://review.coreboot.org/25398
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I33c75a7cccb4cefaa26f70aed4bdc4bd620cdad0
Gerrit-Change-Number: 25398
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/25398 )
Change subject: util/intelmetool: Fix crash on strict devmem kernels
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/25398
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I33c75a7cccb4cefaa26f70aed4bdc4bd620cdad0
Gerrit-Change-Number: 25398
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 16 Apr 2018 22:26:43 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Angel Pons has removed Dan Elkouby from this change. ( https://review.coreboot.org/25691 )
Change subject: mainboard/asus/p5ql_pro: Add new mainboard (FOR REVIEW ONLY)
......................................................................
Removed reviewer Dan Elkouby.
--
To view, visit https://review.coreboot.org/25691
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I6ed434a691e8ef2a61e0acb1f986a59b8e1ad818
Gerrit-Change-Number: 25691
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>