coreboot-gerrit April 2018

coreboot-gerrit@coreboot.org

1 participants
2168 discussions

Change in coreboot[master]: soc/amd/stoneyridge/include/soc/gpio.h: Remove vendor code reference
by Richard Spiegel (Code Review) 17 Apr '18

17 Apr '18

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/25695 Change subject: soc/amd/stoneyridge/include/soc/gpio.h: Remove vendor code reference ...................................................................... soc/amd/stoneyridge/include/soc/gpio.h: Remove vendor code reference With the exception of code that deals directly or indirectly with AGESA, all other code should be independent of vendor code reference. Therefor, remove vendor code reference from any GPIO code. BUG=b:77999987 TEST=Build and boot grunt. Change-Id: I9ba78767a269ad6b9b06fa11993d8a12350e4bad Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M src/mainboard/amd/gardenia/gpio.c M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h M src/soc/amd/stoneyridge/include/soc/gpio.h 3 files changed, 4 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/25695/1 diff --git a/src/mainboard/amd/gardenia/gpio.c b/src/mainboard/amd/gardenia/gpio.c index cb10e74..6672ea5 100644 --- a/src/mainboard/amd/gardenia/gpio.c +++ b/src/mainboard/amd/gardenia/gpio.c @@ -13,8 +13,6 @@ * GNU General Public License for more details. */ -#include <amdblocks/agesawrapper.h> -#include <amdblocks/BiosCallOuts.h> #include <soc/southbridge.h> #include <stdlib.h> #include <soc/gpio.h> diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h index bc35ff5..e827a72 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h +++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h @@ -20,7 +20,6 @@ #include <stddef.h> #include <soc/smi.h> #include <soc/southbridge.h> -#include <amdblocks/agesawrapper.h> const struct sci_source *get_gpe_table(size_t *num); uint8_t variant_memory_sku(void); diff --git a/src/soc/amd/stoneyridge/include/soc/gpio.h b/src/soc/amd/stoneyridge/include/soc/gpio.h index e1ae5dd..664c074 100644 --- a/src/soc/amd/stoneyridge/include/soc/gpio.h +++ b/src/soc/amd/stoneyridge/include/soc/gpio.h @@ -46,14 +46,6 @@ #define GPIO_INT_STATUS (1 << 28) #define GPIO_WAKE_STATUS (1 << 29) -/* - * The definitions below should be used to make GPIO arrays compact and - * easy to understand. - */ -#define INPUT 0 -#define OUTPUT_H (FCH_GPIO_OUTPUT_ENABLE | FCH_GPIO_OUTPUT_VALUE) -#define OUTPUT_L FCH_GPIO_OUTPUT_ENABLE - /* GPIO_0 - GPIO_62 */ #define GPIO_BANK0_CONTROL(gpio) \ (AMD_SB_ACPI_MMIO_ADDR + 0x1500 + ((gpio) * 4)) @@ -333,11 +325,11 @@ #define GPIO_148_IOMUX_I2C1_SDA 0 #define GPIO_148_IOMUX_GPIOxx 1 -#define GPIO_OUTPUT_OUT_HIGH (FCH_GPIO_OUTPUT_ENABLE | FCH_GPIO_OUTPUT_VALUE) -#define GPIO_OUTPUT_OUT_LOW FCH_GPIO_OUTPUT_ENABLE +#define GPIO_OUTPUT_OUT_HIGH (BIT(6) | BIT(7)) +#define GPIO_OUTPUT_OUT_LOW BIT(7) -#define GPIO_PULL_PULL_UP FCH_GPIO_PULL_UP_ENABLE -#define GPIO_PULL_PULL_DOWN FCH_GPIO_PULL_DOWN_ENABLE +#define GPIO_PULL_PULL_UP BIT(4) +#define GPIO_PULL_PULL_DOWN BIT(5) #define GPIO_PULL_PULL_NONE 0 /* Native function pad configuration */ -- To view, visit https://review.coreboot.org/25695 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9ba78767a269ad6b9b06fa11993d8a12350e4bad Gerrit-Change-Number: 25695 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>

1 0

Change in coreboot[master]: mb/google/kahlee/variants/kahlee/gpio.c: Convert GPIO to new format
by Richard Spiegel (Code Review) 17 Apr '18

17 Apr '18

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/25694 Change subject: mb/google/kahlee/variants/kahlee/gpio.c: Convert GPIO to new format ...................................................................... mb/google/kahlee/variants/kahlee/gpio.c: Convert GPIO to new format As part of preparing to make GPIO code independent of vendor code references, convert GPIO table format using newly defined macros. BUG=b:77999987 TEST=Build and boot kahlee. Change-Id: I0af768bb4dbcbfef0d2d08ffe869c1dfb6827974 Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M src/mainboard/google/kahlee/variants/kahlee/gpio.c 1 file changed, 24 insertions(+), 24 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/25694/1 diff --git a/src/mainboard/google/kahlee/variants/kahlee/gpio.c b/src/mainboard/google/kahlee/variants/kahlee/gpio.c index 2f40546..29d7817 100644 --- a/src/mainboard/google/kahlee/variants/kahlee/gpio.c +++ b/src/mainboard/google/kahlee/variants/kahlee/gpio.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */ -#include <amdblocks/agesawrapper.h> #include <baseboard/variants.h> #include <soc/smi.h> #include <soc/southbridge.h> @@ -27,65 +26,66 @@ */ const struct soc_amd_stoneyridge_gpio gpio_set_stage_reset[] = { /* AGPIO2, to become event generator */ - { GPIO_2, Function1, FCH_GPIO_PULL_UP_ENABLE | INPUT }, + PAD_GPI(GPIO_2, PULL_UP), /* SER_TX */ - { GPIO_8, Function1, FCH_GPIO_PULL_UP_ENABLE | OUTPUT_H }, + PAD_NF(GPIO_8, SerPortTX_OUT, PULL_UP), /* SER RX */ - { GPIO_9, Function1, FCH_GPIO_PULL_UP_ENABLE | INPUT }, + PAD_NF(GPIO_9, SerPortRX_OUT, PULL_UP), /* EC_IN_RW */ - {GPIO_15, Function1, FCH_GPIO_PULL_UP_ENABLE | INPUT }, + PAD_GPI(GPIO_15, PULL_UP), /* APU_I2C_3_SCL */ - {GPIO_19, Function1, FCH_GPIO_PULL_UP_ENABLE | INPUT }, + PAD_NF(GPIO_19, I2C3_SCL, PULL_UP), /* APU_I2C_3_SDA */ - {GPIO_20, Function1, FCH_GPIO_PULL_UP_ENABLE | INPUT }, + PAD_NF(GPIO_20, I2C3_SDA, PULL_UP), /* AGPIO22 EC_SCI */ - {GPIO_22, Function1, FCH_GPIO_PULL_UP_ENABLE | INPUT }, + PAD_GPI(GPIO_22, PULL_UP), /* SPI_TPM_CS_L */ - {GPIO_76, Function1, FCH_GPIO_PULL_DOWN_ENABLE | OUTPUT_H }, + PAD_NF(GPIO_76, SPI_TPM_CS_L, PULL_DOWN), /* BD_ID1 */ - {GPIO_135, Function1, INPUT }, + PAD_GPI(GPIO_135, PULL_NONE), /* GPIO_136 - UART_FCH_RX_DEBUG_RX */ - {GPIO_136, Function0, INPUT }, + PAD_NF(GPIO_136, UART0_RXD, PULL_NONE), /* GPIO_138 - UART_FCH_TX_DEBUG_RX */ - {GPIO_138, Function0, INPUT }, + PAD_NF(GPIO_138, UART0_TXD, PULL_NONE), /* TPM_SERIRQ# */ - {GPIO_139, Function1, FCH_GPIO_PULL_UP_ENABLE | INPUT }, + PAD_GPI(GPIO_139, PULL_UP), /* BD_ID2 */ - {GPIO_140, Function1, INPUT }, + PAD_GPI(GPIO_140, PULL_NONE), /* APU_SPI_WP */ - {GPIO_142, Function1, FCH_GPIO_PULL_UP_ENABLE | INPUT }, + PAD_GPI(GPIO_142, PULL_UP), /* BD_ID3 */ - {GPIO_144, Function1, INPUT } + PAD_GPI(GPIO_144, PULL_NONE), }; const struct soc_amd_stoneyridge_gpio gpio_set_stage_ram[] = { /* AGPIO 12 */ - { GPIO_12, Function2, FCH_GPIO_PULL_UP_ENABLE | INPUT }, + PAD_GPI(GPIO_12, PULL_UP), /* TS_EN_SOC (TouchScreen enable GPIO) */ - {GPIO_13, Function1, FCH_GPIO_PULL_UP_ENABLE | OUTPUT_H}, + PAD_GPO(GPIO_13, HIGH), /* CAM_PWRON (Camera enable GPIO) */ - {GPIO_14, Function1, FCH_GPIO_PULL_UP_ENABLE | OUTPUT_H }, + PAD_GPO(GPIO_14, HIGH), + /* APU_BT_ON# */ - {GPIO_24, Function1, FCH_GPIO_PULL_UP_ENABLE | OUTPUT_H }, + PAD_GPO(GPIO_24, HIGH), /* DEVSLP1_SSD */ - {67, Function1, FCH_GPIO_PULL_UP_ENABLE | INPUT }, + PAD_NF(GPIO_67, DEVSLP0, PULL_UP), /* DEVSLP1_EMMC */ /* No Connect for now. @@ -93,13 +93,13 @@ */ /* CAM_LED# */ - {GPIO_84, Function1, FCH_GPIO_PULL_UP_ENABLE | OUTPUT_H }, + PAD_GPO(GPIO_84, HIGH), /* TS_RST# (TouchScreen Reset) */ - {GPIO_85, Function1, FCH_GPIO_PULL_UP_ENABLE | OUTPUT_H }, + PAD_GPO(GPIO_85, HIGH), /* WLAN_RST#_AUX */ - {GPIO_119, Function2, FCH_GPIO_PULL_UP_ENABLE | OUTPUT_H }, + PAD_GPO(GPIO_119, HIGH), }; const struct soc_amd_stoneyridge_gpio *variant_early_gpio_table(size_t *size) -- To view, visit https://review.coreboot.org/25694 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0af768bb4dbcbfef0d2d08ffe869c1dfb6827974 Gerrit-Change-Number: 25694 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>

1 0

Change in coreboot[master]: Documentation: Remove old Documentation directory
by Philipp Deppenwiese (Code Review) 17 Apr '18

17 Apr '18

Philipp Deppenwiese has abandoned this change. ( https://review.coreboot.org/23068 ) Change subject: Documentation: Remove old Documentation directory ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/23068 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Ia4788d48b673af959e5f6804706d3c1dcf91d252 Gerrit-Change-Number: 23068 Gerrit-PatchSet: 1 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: util/crossgcc: Toolchain verified sources
by Philipp Deppenwiese (Code Review) 17 Apr '18

17 Apr '18

Philipp Deppenwiese has abandoned this change. ( https://review.coreboot.org/15170 ) Change subject: util/crossgcc: Toolchain verified sources ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/15170 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Id45097fc7e8435fadce4bda75769592af2730b0c Gerrit-Change-Number: 15170 Gerrit-PatchSet: 37 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Anonymous Coward #1001824 Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Jonathan Schleifer <js(a)heap.zone> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Zheng Bao <fishbaozi(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: util/tss-generator: WIP - Add TSS generator
by Philipp Deppenwiese (Code Review) 17 Apr '18

17 Apr '18

Philipp Deppenwiese has abandoned this change. ( https://review.coreboot.org/14135 ) Change subject: util/tss-generator: WIP - Add TSS generator ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/14135 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I93ef112111b403a23c0dce4cf109b9e87424bc1a Gerrit-Change-Number: 14135 Gerrit-PatchSet: 1 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Georg Wicherski <gw(a)oxff.net> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: drivers/pc80/tpm: Refactor init_tpm() implementation
by Philipp Deppenwiese (Code Review) 17 Apr '18

17 Apr '18

Philipp Deppenwiese has abandoned this change. ( https://review.coreboot.org/19555 ) Change subject: drivers/pc80/tpm: Refactor init_tpm() implementation ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/19555 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I2c51ce402f43466e211bc1990335fd320d685829 Gerrit-Change-Number: 19555 Gerrit-PatchSet: 9 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: device/Kconfig: Make VGA_BIOS_FILE generic if VGA_BIOS_ID is known.
by Philipp Deppenwiese (Code Review) 17 Apr '18

17 Apr '18

Philipp Deppenwiese has abandoned this change. ( https://review.coreboot.org/17895 ) Change subject: device/Kconfig: Make VGA_BIOS_FILE generic if VGA_BIOS_ID is known. ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/17895 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I1791dcd4ddd037b4c95f3424bd629f7f1f3ab51a Gerrit-Change-Number: 17895 Gerrit-PatchSet: 3 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: Documentation: WIP refactor existing documentation
by Philipp Deppenwiese (Code Review) 17 Apr '18

17 Apr '18

Philipp Deppenwiese has abandoned this change. ( https://review.coreboot.org/16853 ) Change subject: Documentation: WIP refactor existing documentation ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/16853 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I9120da6bd24783872c63087139f8730771dde9ad Gerrit-Change-Number: 16853 Gerrit-PatchSet: 6 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Myles Watson <mylesgw(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: DO NOT MERGE: TPM Merge API Changeset
by Philipp Deppenwiese (Code Review) 17 Apr '18

17 Apr '18

Philipp Deppenwiese has abandoned this change. ( https://review.coreboot.org/10542 ) Change subject: DO NOT MERGE: TPM Merge API Changeset ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/10542 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I8cbcd723d83ffcc0c1c47c58438dccdb16bb7cf7 Gerrit-Change-Number: 10542 Gerrit-PatchSet: 31 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Georg Wicherski <gw(a)oxff.net> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)google.com> Gerrit-Reviewer: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: TPM: WIP - Add TCPA Log support
by Philipp Deppenwiese (Code Review) 17 Apr '18

17 Apr '18

Philipp Deppenwiese has abandoned this change. ( https://review.coreboot.org/14137 ) Change subject: TPM: WIP - Add TCPA Log support ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/14137 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Ia36817c9840b9ebe59265d641691276edc9c9e06 Gerrit-Change-Number: 14137 Gerrit-PatchSet: 5 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2018