coreboot-gerrit April 2018

coreboot-gerrit@coreboot.org

1 participants
2168 discussions

Change in coreboot[master]: RISC-V boards: Remove PAGETABLES sections from memlayout.ld
by Jonathan Neuschäfer (Code Review) 17 Apr '18

17 Apr '18

Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/25701 Change subject: RISC-V boards: Remove PAGETABLES sections from memlayout.ld ...................................................................... RISC-V boards: Remove PAGETABLES sections from memlayout.ld RISC-V doesn't setup page tables anymore, since commit b26759d703 ("arch/riscv: Don't set up virtual memory"). Change-Id: Id1e759b63fb0bc88ab256994d3849d16814affa0 Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- M src/arch/riscv/include/arch/memlayout.h M src/mainboard/emulation/qemu-riscv/memlayout.ld M src/mainboard/emulation/spike-riscv/memlayout.ld M src/mainboard/lowrisc/nexys4ddr/memlayout.ld 4 files changed, 2 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/25701/1 diff --git a/src/arch/riscv/include/arch/memlayout.h b/src/arch/riscv/include/arch/memlayout.h index 5d01141..9097cf5 100644 --- a/src/arch/riscv/include/arch/memlayout.h +++ b/src/arch/riscv/include/arch/memlayout.h @@ -19,7 +19,6 @@ #define __ARCH_MEMLAYOUT_H #define STACK(addr, size) REGION(stack, addr, size, 4096) -#define PAGETABLES(addr, size) REGION(pagetables, addr, size, 4096) /* TODO: Need to add DMA_COHERENT region like on ARM? */ diff --git a/src/mainboard/emulation/qemu-riscv/memlayout.ld b/src/mainboard/emulation/qemu-riscv/memlayout.ld index 8cc6d41..615d1f2 100644 --- a/src/mainboard/emulation/qemu-riscv/memlayout.ld +++ b/src/mainboard/emulation/qemu-riscv/memlayout.ld @@ -24,6 +24,5 @@ ROMSTAGE(0x20000, 128K) STACK(0x40000, 0x3ff00) PRERAM_CBMEM_CONSOLE(0x80000, 8K) - PAGETABLES(0x80000+8K, 60K) RAMSTAGE(0x100000, 16M) } diff --git a/src/mainboard/emulation/spike-riscv/memlayout.ld b/src/mainboard/emulation/spike-riscv/memlayout.ld index 8596723..bae414f 100644 --- a/src/mainboard/emulation/spike-riscv/memlayout.ld +++ b/src/mainboard/emulation/spike-riscv/memlayout.ld @@ -24,7 +24,7 @@ DRAM_START(START) BOOTBLOCK(START, 64K) STACK(START + 8M, 4K) - PAGETABLES(START + 8M + 4K, 60K) + /* hole at (START + 8M + 4K, 60K) */ ROMSTAGE(START + 8M + 64K, 128K) PRERAM_CBMEM_CONSOLE(START + 8M + 192k, 8K) RAMSTAGE(START + 8M + 200K, 256K) diff --git a/src/mainboard/lowrisc/nexys4ddr/memlayout.ld b/src/mainboard/lowrisc/nexys4ddr/memlayout.ld index 0348c47..86f3667 100644 --- a/src/mainboard/lowrisc/nexys4ddr/memlayout.ld +++ b/src/mainboard/lowrisc/nexys4ddr/memlayout.ld @@ -26,6 +26,6 @@ STACK(START + 8M, 64K) ROMSTAGE(START + 8M + 64K, 128K) PRERAM_CBMEM_CONSOLE(START + 8M + 192k, 8K) - PAGETABLES(START + 8M + 200K, 56K) + /* hole at (START + 8M + 200K, 56K) */ RAMSTAGE(START + 8M + 256K, 256K) } -- To view, visit https://review.coreboot.org/25701 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id1e759b63fb0bc88ab256994d3849d16814affa0 Gerrit-Change-Number: 25701 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>

1 0

Change in coreboot[master]: util/riscvtools: Rename to util/riscv/
by Jonathan Neuschäfer (Code Review) 17 Apr '18

17 Apr '18

Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/25700 Change subject: util/riscvtools: Rename to util/riscv/ ...................................................................... util/riscvtools: Rename to util/riscv/ There's no good reason to use the more complicated name. Change-Id: I515e2df3b87580ddd31d18fe63451a98e92ead61 Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- M src/mainboard/emulation/spike-riscv/Kconfig.name R util/riscv/make-spike-elf.sh R util/riscv/spike-elf.ld 3 files changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/25700/1 diff --git a/src/mainboard/emulation/spike-riscv/Kconfig.name b/src/mainboard/emulation/spike-riscv/Kconfig.name index 66266f7..2869425 100644 --- a/src/mainboard/emulation/spike-riscv/Kconfig.name +++ b/src/mainboard/emulation/spike-riscv/Kconfig.name @@ -3,5 +3,5 @@ help To run coreboot in spike: * run "make" as usual - * util/riscvtools/make-spike-elf.sh build/coreboot.{rom,elf} + * util/riscv/make-spike-elf.sh build/coreboot.{rom,elf} * spike -m1024 build/coreboot.elf diff --git a/util/riscvtools/make-spike-elf.sh b/util/riscv/make-spike-elf.sh similarity index 100% rename from util/riscvtools/make-spike-elf.sh rename to util/riscv/make-spike-elf.sh diff --git a/util/riscvtools/spike-elf.ld b/util/riscv/spike-elf.ld similarity index 100% rename from util/riscvtools/spike-elf.ld rename to util/riscv/spike-elf.ld -- To view, visit https://review.coreboot.org/25700 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I515e2df3b87580ddd31d18fe63451a98e92ead61 Gerrit-Change-Number: 25700 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>

1 0

Change in coreboot[master]: util/intelmetool: Be explicit about *kernel* cmdline arguments
by build bot (Jenkins) (Code Review) 17 Apr '18

17 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25699 ) Change subject: util/intelmetool: Be explicit about *kernel* cmdline arguments ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/24453/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/70225/ : SUCCESS -- To view, visit https://review.coreboot.org/25699 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d5df9acb30948f786f4ced895bbaeed80153fdb Gerrit-Change-Number: 25699 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 17 Apr 2018 11:15:06 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/intelmetool: Be explicit about *kernel* cmdline arguments
by Jonathan Neuschäfer (Code Review) 17 Apr '18

17 Apr '18

Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/25699 Change subject: util/intelmetool: Be explicit about *kernel* cmdline arguments ...................................................................... util/intelmetool: Be explicit about *kernel* cmdline arguments Reduce the potential for confusion. Change-Id: I1d5df9acb30948f786f4ced895bbaeed80153fdb Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- M util/intelmetool/me.c M util/intelmetool/rcba.c 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/25699/1 diff --git a/util/intelmetool/me.c b/util/intelmetool/me.c index f14f4cd..4867bbc 100644 --- a/util/intelmetool/me.c +++ b/util/intelmetool/me.c @@ -583,7 +583,7 @@ mei_mmap += mei_base_address - pagerounded; if (mei_mmap == NULL) { printf("Could not map ME setup memory.\n" - "Do you have cmdline argument 'iomem=relaxed' set ?\n"); + "Do you have kernel cmdline argument 'iomem=relaxed' set ?\n"); return 1; } diff --git a/util/intelmetool/rcba.c b/util/intelmetool/rcba.c index ee43e65..6a09af6 100644 --- a/util/intelmetool/rcba.c +++ b/util/intelmetool/rcba.c @@ -69,7 +69,7 @@ rcba = map_physical((off_t)rcba_phys, size); if (rcba == NULL) { printf("Could not map RCBA\n" - "Do you have cmdline argument 'iomem=relaxed' set ?\n"); + "Do you have kernel cmdline argument 'iomem=relaxed' set ?\n"); return 1; } *(uint32_t *)(rcba + addr) = val; @@ -95,7 +95,7 @@ rcba = map_physical((off_t)rcba_phys, size); if (rcba == NULL) { printf("Could not map RCBA\n" - "Do you have cmdline argument 'iomem=relaxed' set ?\n"); + "Do you have kernel cmdline argument 'iomem=relaxed' set ?\n"); return 1; } -- To view, visit https://review.coreboot.org/25699 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1d5df9acb30948f786f4ced895bbaeed80153fdb Gerrit-Change-Number: 25699 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>

1 0

Change in coreboot[master]: soc/intel/common: Move lockdown.c file to common folder
by build bot (Jenkins) (Code Review) 17 Apr '18

17 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25688 ) Change subject: soc/intel/common: Move lockdown.c file to common folder ...................................................................... Patch Set 11: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/24452/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/70224/ : SUCCESS -- To view, visit https://review.coreboot.org/25688 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0b81bbc54f737cb4e7120f44bbe705039b45ccb3 Gerrit-Change-Number: 25688 Gerrit-PatchSet: 11 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 17 Apr 2018 11:04:28 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Move SOC dependent functions to common file.
by build bot (Jenkins) (Code Review) 17 Apr '18

17 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25656 ) Change subject: soc/intel/cannonlake: Move SOC dependent functions to common file. ...................................................................... Patch Set 10: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/24451/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/70223/ : SUCCESS -- To view, visit https://review.coreboot.org/25656 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17c69e3b1840c30b856b9a3a077302923b31681f Gerrit-Change-Number: 25656 Gerrit-PatchSet: 10 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 17 Apr 2018 10:57:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/cannonlake: Move SOC dependent functions to common file.
by build bot (Jenkins) (Code Review) 17 Apr '18

17 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25656 ) Change subject: soc/intel/cannonlake: Move SOC dependent functions to common file. ...................................................................... Patch Set 9: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70222/ : SUCCESS -- To view, visit https://review.coreboot.org/25656 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17c69e3b1840c30b856b9a3a077302923b31681f Gerrit-Change-Number: 25656 Gerrit-PatchSet: 9 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 17 Apr 2018 10:44:51 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/cannonlake: Move SOC dependent functions to common file.
by build bot (Jenkins) (Code Review) 17 Apr '18

17 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25656 ) Change subject: soc/intel/cannonlake: Move SOC dependent functions to common file. ...................................................................... Patch Set 8: Build Failed https://qa.coreboot.org/job/coreboot-gerrit/70221/ : ABORTED -- To view, visit https://review.coreboot.org/25656 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17c69e3b1840c30b856b9a3a077302923b31681f Gerrit-Change-Number: 25656 Gerrit-PatchSet: 8 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 17 Apr 2018 10:32:13 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Move SOC dependent functions to common file.
by build bot (Jenkins) (Code Review) 17 Apr '18

17 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25656 ) Change subject: soc/intel/cannonlake: Move SOC dependent functions to common file. ...................................................................... Patch Set 7: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/70219/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/24449/ : SUCCESS -- To view, visit https://review.coreboot.org/25656 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17c69e3b1840c30b856b9a3a077302923b31681f Gerrit-Change-Number: 25656 Gerrit-PatchSet: 7 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 17 Apr 2018 10:23:11 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/common: Move lockdown.c file to common folder
by build bot (Jenkins) (Code Review) 17 Apr '18

17 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25688 ) Change subject: soc/intel/common: Move lockdown.c file to common folder ...................................................................... Patch Set 10: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/24450/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/70220/ : SUCCESS -- To view, visit https://review.coreboot.org/25688 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0b81bbc54f737cb4e7120f44bbe705039b45ccb3 Gerrit-Change-Number: 25688 Gerrit-PatchSet: 10 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 17 Apr 2018 10:16:52 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2018