Philipp Deppenwiese has uploaded this change for review. ( https://review.coreboot.org/25686
Change subject: checkpatch: Ignore marcos with flow control
......................................................................
checkpatch: Ignore marcos with flow control
Change-Id: I0e10dc81740945f2d0dd16aac7189b2a937bf2f6
Signed-off-by: zaolin <zaolin(a)das-labor.org>
---
M .checkpatch.conf
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/25686/1
diff --git a/.checkpatch.conf b/.checkpatch.conf
index c53fe35..4852e53 100644
--- a/.checkpatch.conf
+++ b/.checkpatch.conf
@@ -17,6 +17,7 @@
--ignore CONFIG_DESCRIPTION
--ignore MISSING_SPACE
--ignore CORRUPTED_PATCH
+--ignore MACRO_WITH_FLOW_CONTROL
# FILE_PATH_CHANGES seems to not be working correctly. It will
# choke on added / deleted files even if the MAINTAINERS file
--
To view, visit https://review.coreboot.org/25686
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0e10dc81740945f2d0dd16aac7189b2a937bf2f6
Gerrit-Change-Number: 25686
Gerrit-PatchSet: 1
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/25297 )
Change subject: security/general: Add section for general security features
......................................................................
Patch Set 1:
> Patch Set 1:
>
> Just wondering, do you have a use case where locking down the platform in one function is more convenient than using the per device device_ops.final ? (Having separate .final functions for CPU, northbridge, lpc-bridge,... is for instance quite convenient on Intel targets)
Sure it's called security ;)
--
To view, visit https://review.coreboot.org/25297
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7bb63e2769c7bfd65dc9e4237300b583bd09ad3
Gerrit-Change-Number: 25297
Gerrit-PatchSet: 1
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Mon, 16 Apr 2018 14:49:52 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
Alex Thiessen has uploaded this change for review. ( https://review.coreboot.org/25685
Change subject: Makefile.inc: Update `build.h` when needed
......................................................................
Makefile.inc: Update `build.h` when needed
Update `build.h` when its content is out of date. This condition depends
on a few parameters, e.g. TIMELESS_BUILD variable or `git` status, so
it's not easy to track the dependencies by means of the usual `make`
prerequisite mechanism. Re-creating `build.h` needlessly every time
would cause a cascade of target updates, which is undesirable.
Create a new temporary `build.h` and check if its content has changed
compared to the existing one. If so, rename the file to `build.h`, else
don't touch `build.h` at all.
Change-Id: Iabd1a1ef78b38dab124944fbc837838daee6155e
Signed-off-by: Alex Thiessen <alex.thiessen.de+coreboot(a)gmail.com>
---
M Makefile.inc
A util/genbuild_h/genbuild_h_update.sh
2 files changed, 50 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/25685/1
diff --git a/Makefile.inc b/Makefile.inc
index b11f6e2..264faa1 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -456,11 +456,10 @@
#######################################################################
# generate build support files
-$(obj)/build.h: .xcompile
+$(obj)/build.h: $(shell util/genbuild_h/genbuild_h_update.sh $(obj)/build.h) \
+ .xcompile
@printf " GEN build.h\n"
- rm -f $(obj)/build.h
- util/genbuild_h/genbuild_h.sh > $(obj)/build.ht
- mv $(obj)/build.ht $(obj)/build.h
+ mv $< $@
build-dirs:
mkdir -p $(objcbfs) $(objgenerated)
diff --git a/util/genbuild_h/genbuild_h_update.sh b/util/genbuild_h/genbuild_h_update.sh
new file mode 100644
index 0000000..33aa7ac
--- /dev/null
+++ b/util/genbuild_h/genbuild_h_update.sh
@@ -0,0 +1,47 @@
+#!/bin/sh
+
+##
+## This file is part of the coreboot project.
+##
+## Copyright (C) 2018 Alex Thiessen <alex.thiessen.de+coreboot(a)gmail.com>
+##
+## This program is free software; you can redistribute it and/or modify
+## it under the terms of the GNU General Public License as published by
+## the Free Software Foundation; version 3 or later of the License.
+##
+## This program is distributed in the hope that it will be useful,
+## but WITHOUT ANY WARRANTY; without even the implied warranty of
+## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+## GNU General Public License for more details.
+##
+## SPDX-License-Identifier: GPL-3.0-or-later
+## <https://spdx.org/licenses/GPL-3.0-or-later.html>
+##
+
+# Purpose of this script is to check if `build.h` is out of date by running
+# `genbuild_h.sh` and comparing its outcome with the existing `build.h`. In case
+# there was a change, file name of the new `build.h` is output so that it can be
+# used as a `make` target prerequisite. Case of missing `build.h` is handled
+# implicitly.
+#
+# Usage: genbuild_h_update.sh FILE
+# where `FILE` is the name of `build.h`
+# e.g. `genbuild_h_update.sh build/build.h`
+
+set -e # errexit
+set -u # nounset
+
+BUILD_H=${1}
+
+TMP_BUILD_H=$(mktemp -t "$(basename "${BUILD_H}").XXXXXXXX")
+util/genbuild_h/genbuild_h.sh > "${TMP_BUILD_H}"
+
+if cmp --quiet "${BUILD_H}" "${TMP_BUILD_H}"
+then
+ # same
+ rm "${TMP_BUILD_H}"
+ exit 0
+fi
+
+# different
+echo "${TMP_BUILD_H}"
--
To view, visit https://review.coreboot.org/25685
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iabd1a1ef78b38dab124944fbc837838daee6155e
Gerrit-Change-Number: 25685
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Thiessen <alex.thiessen.de+coreboot(a)gmail.com>