coreboot-gerrit March 2018

coreboot-gerrit@coreboot.org

1 participants
1399 discussions

Change in coreboot[master]: soc/amd/stoneyridge: Call sb_acpi_mmio_decode()
by Garrett Kirkendall (Code Review) 14 Mar '18

14 Mar '18

Garrett Kirkendall has uploaded this change for review. ( https://review.coreboot.org/25161 Change subject: soc/amd/stoneyridge: Call sb_acpi_mmio_decode() ...................................................................... soc/amd/stoneyridge: Call sb_acpi_mmio_decode() Call funciton sb_acpi_mmio_decode() from bootblock_fch_early_init(). This enables decoding of the FCH ACPI MMIO regions 0xfed80000 - 0xfed81fff. This is another step to moving AGESA out of the bootblock for StoneyRidge BUG=b:74586747 BRANCH=master TEST=Build and boot on Grunt. Change-Id: I8cf329e5cd2002b225742fefa5c1ddd2598de674 Signed-off-by: Garrett Kirkendall <garrett.kirkendall(a)amd.corp-partner.google.com> --- M src/soc/amd/stoneyridge/southbridge.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/25161/1 diff --git a/src/soc/amd/stoneyridge/southbridge.c b/src/soc/amd/stoneyridge/southbridge.c index bb3157d..e05b7dd 100644 --- a/src/soc/amd/stoneyridge/southbridge.c +++ b/src/soc/amd/stoneyridge/southbridge.c @@ -559,6 +559,7 @@ sb_enable_rom(); sb_lpc_port80(); sb_lpc_decode(); + sb_acpi_mmio_decode(); } void sb_enable(device_t dev) -- To view, visit https://review.coreboot.org/25161 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8cf329e5cd2002b225742fefa5c1ddd2598de674 Gerrit-Change-Number: 25161 Gerrit-PatchSet: 1 Gerrit-Owner: Garrett Kirkendall <garrett.kirkendall(a)amd.corp-partner.google.com>

1 0

Change in coreboot[master]: soc/intel/common/opregion: Get rid of opregion.c
by build bot (Jenkins) (Code Review) 14 Mar '18

14 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21703 ) Change subject: soc/intel/common/opregion: Get rid of opregion.c ...................................................................... Patch Set 10: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22945/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68538/ : SUCCESS -- To view, visit https://review.coreboot.org/21703 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f78e9030df12da5369d142dda5c59e576ebcef7 Gerrit-Change-Number: 21703 Gerrit-PatchSet: 10 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Abhay Kumar <abhay.kumar(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Mar 2018 17:54:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Use GPP_B4 as Touchscreen Power Enable
by build bot (Jenkins) (Code Review) 14 Mar '18

14 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25154 ) Change subject: mb/google/poppy/variants/nami: Use GPP_B4 as Touchscreen Power Enable ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22944/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68537/ : SUCCESS -- To view, visit https://review.coreboot.org/25154 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b1794d44f25c0d42d082d63b9e3ec3dfcef7528 Gerrit-Change-Number: 25154 Gerrit-PatchSet: 2 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Mar 2018 17:40:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Use GPP_B4 as Touchscreen Power Enable
by build bot (Jenkins) (Code Review) 14 Mar '18

14 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25154 ) Change subject: mb/google/poppy/variants/nami: Use GPP_B4 as Touchscreen Power Enable ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22943/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68536/ : SUCCESS -- To view, visit https://review.coreboot.org/25154 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b1794d44f25c0d42d082d63b9e3ec3dfcef7528 Gerrit-Change-Number: 25154 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Mar 2018 17:18:26 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Use GPP_B4 as Touchscreen Power Enable
by Shelley Chen (Code Review) 14 Mar '18

14 Mar '18

Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/25154 Change subject: mb/google/poppy/variants/nami: Use GPP_B4 as Touchscreen Power Enable ...................................................................... mb/google/poppy/variants/nami: Use GPP_B4 as Touchscreen Power Enable Per latest schematics (EVT), touchscreen power enable for Nami has moved from GBB_C22 to GPP_B4. BUG=b:74347464 BRANCH=None TEST=./util/abuild/abuild -p none -t google/poppy -x -a Change-Id: I3b1794d44f25c0d42d082d63b9e3ec3dfcef7528 Signed-off-by: Shelley Chen <shchen(a)chromium.org> --- M src/mainboard/google/poppy/variants/nami/devicetree.cb M src/mainboard/google/poppy/variants/nami/gpio.c 2 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/25154/1 diff --git a/src/mainboard/google/poppy/variants/nami/devicetree.cb b/src/mainboard/google/poppy/variants/nami/devicetree.cb index 8e2ebc1..602e41b 100644 --- a/src/mainboard/google/poppy/variants/nami/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nami/devicetree.cb @@ -254,7 +254,7 @@ register "probed" = "1" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_B3)" register "reset_delay_ms" = "20" - register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C22)" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B4)" register "enable_delay_ms" = "1" register "has_power_resource" = "1" device i2c 10 on end diff --git a/src/mainboard/google/poppy/variants/nami/gpio.c b/src/mainboard/google/poppy/variants/nami/gpio.c index f0cf99f..8337e72 100644 --- a/src/mainboard/google/poppy/variants/nami/gpio.c +++ b/src/mainboard/google/poppy/variants/nami/gpio.c @@ -70,8 +70,8 @@ PAD_CFG_NC(GPP_B2), /* B3 : CPU_GP2 ==> TOUCHSCREEN_RST# */ PAD_CFG_GPO(GPP_B3, 0, DEEP), - /* B4 : CPU_GP3 ==> NC */ - PAD_CFG_NC(GPP_B4), + /* B4 : CPU_GP3 ==> EN_PP3300_DX_TOUCHSCREEN */ + PAD_CFG_GPO(GPP_B4, 0, DEEP), /* B5 : SRCCLKREQ0# ==> NC */ PAD_CFG_NC(GPP_B5), /* B6 : SRCCLKREQ1# ==> CLKREQ_PCIE#1 */ @@ -155,8 +155,8 @@ PAD_CFG_NF(GPP_C20, NONE, DEEP, NF1), /* C21 : UART2_TXD ==> PCHTX_SERVORX_UART */ PAD_CFG_NF(GPP_C21, NONE, DEEP, NF1), - /* C22 : UART2_RTS# ==> EN_PP3300_DX_TOUCHSCREEN */ - PAD_CFG_GPO(GPP_C22, 0, DEEP), + /* C22 : UART2_RTS# ==> NC */ + PAD_CFG_NC(GPP_C22), /* C23 : UART2_CTS# ==> PCH_WP */ PAD_CFG_GPI_GPIO_DRIVER(GPP_C23, 20K_PU, DEEP), -- To view, visit https://review.coreboot.org/25154 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3b1794d44f25c0d42d082d63b9e3ec3dfcef7528 Gerrit-Change-Number: 25154 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen <shchen(a)google.com>

1 0

Change in coreboot[master]: util/crossgcc: Build Linux toolchain
by build bot (Jenkins) (Code Review) 14 Mar '18

14 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25151 ) Change subject: util/crossgcc: Build Linux toolchain ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22939/ : SUCCESS https://qa.coreboot.org/job/coreboot-toolchain/401/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68533/ : SUCCESS -- To view, visit https://review.coreboot.org/25151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3bb0c39077859551568f2945f6475f9b241f7ccc Gerrit-Change-Number: 25151 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Mar 2018 16:53:33 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/eve: Update DPTF parameters
by Furquan Shaikh (Code Review) 14 Mar '18

14 Mar '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/25153 ) Change subject: mb/google/eve: Update DPTF parameters ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/25153 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib660dcb25422fea0aa692fac5ba65b49808965ba Gerrit-Change-Number: 25153 Gerrit-PatchSet: 1 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Mar 2018 16:27:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/eve: Update DPTF parameters
by build bot (Jenkins) (Code Review) 14 Mar '18

14 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25153 ) Change subject: mb/google/eve: Update DPTF parameters ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22942/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68535/ : SUCCESS -- To view, visit https://review.coreboot.org/25153 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib660dcb25422fea0aa692fac5ba65b49808965ba Gerrit-Change-Number: 25153 Gerrit-PatchSet: 1 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Mar 2018 16:23:51 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/eve: Update DPTF parameters
by Duncan Laurie (Code Review) 14 Mar '18

14 Mar '18

Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/25153 Change subject: mb/google/eve: Update DPTF parameters ...................................................................... mb/google/eve: Update DPTF parameters 1) Set the critical temperature threshold to 100C to match changes on other boards. This is intended to reduce DPTF-initiated thermal shutdowns before it has had a chance to react. 2) Reduce the CPU passive threshold sample rate from 5 seconds to 1 second so DPTF will react faster to rapid temperature increases. BUG=b:67459049 BRANCH=eve TEST=manual performance/power testing on Eve hardware Change-Id: Ib660dcb25422fea0aa692fac5ba65b49808965ba Signed-off-by: Duncan Laurie <dlaurie(a)chromium.org> --- M src/mainboard/google/eve/acpi/dptf.asl 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/25153/1 diff --git a/src/mainboard/google/eve/acpi/dptf.asl b/src/mainboard/google/eve/acpi/dptf.asl index 8937ee9..7dd4249 100644 --- a/src/mainboard/google/eve/acpi/dptf.asl +++ b/src/mainboard/google/eve/acpi/dptf.asl @@ -15,7 +15,7 @@ */ #define DPTF_CPU_PASSIVE 80 -#define DPTF_CPU_CRITICAL 99 +#define DPTF_CPU_CRITICAL 100 #define DPTF_TSR0_SENSOR_ID 1 #define DPTF_TSR0_SENSOR_NAME "Ambient" @@ -50,7 +50,7 @@ Name (DTRT, Package () { /* CPU Throttle Effect on CPU */ - Package () { \_SB.PCI0.B0D4, \_SB.PCI0.B0D4, 100, 50, 0, 0, 0, 0 }, + Package () { \_SB.PCI0.B0D4, \_SB.PCI0.B0D4, 100, 10, 0, 0, 0, 0 }, /* CPU Effect on Ambient */ Package () { \_SB.PCI0.B0D4, \_SB.DPTF.TSR0, 100, 600, 0, 0, 0, 0 }, -- To view, visit https://review.coreboot.org/25153 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib660dcb25422fea0aa692fac5ba65b49808965ba Gerrit-Change-Number: 25153 Gerrit-PatchSet: 1 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org>

1 0

Change in coreboot[master]: [WIP]src/lib: Add uImage support
by build bot (Jenkins) (Code Review) 14 Mar '18

14 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25019 ) Change subject: [WIP]src/lib: Add uImage support ...................................................................... Patch Set 6: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/68534/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/22941/ : SUCCESS -- To view, visit https://review.coreboot.org/25019 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0f27b92a5e074966f893399eb401eb97d784850d Gerrit-Change-Number: 25019 Gerrit-PatchSet: 6 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Mar 2018 15:12:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2018