coreboot-gerrit March 2018

coreboot-gerrit@coreboot.org

1 participants
1399 discussions

Change in coreboot[master]: 3rdparty/blobs: Commit updated blobs
by Richard Spiegel (Code Review) 15 Mar '18

15 Mar '18

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/25183 Change subject: 3rdparty/blobs: Commit updated blobs ...................................................................... 3rdparty/blobs: Commit updated blobs AGESA.bin was merged to blobs/pi/amd/00670F00/FT4. Commit the updated blobs and update AGESA.h to match AGESA.bin. BUG=b:70338633 TEST=build kahlee. Change-Id: I5a07f1c539d00aed34cfe45d6d7ef60c1dc56566 Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M 3rdparty/blobs M src/vendorcode/amd/pi/00670F00/AGESA.h 2 files changed, 20 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/25183/1 diff --git a/3rdparty/blobs b/3rdparty/blobs index 19dea8d..a4b5613 160000 --- a/3rdparty/blobs +++ b/3rdparty/blobs @@ -1 +1 @@ -Subproject commit 19dea8d171544f01f12ee6b78af0cc356ab994aa +Subproject commit a4b561391f59e09059ce851fa19b64ca945672d5 diff --git a/src/vendorcode/amd/pi/00670F00/AGESA.h b/src/vendorcode/amd/pi/00670F00/AGESA.h index 17f6986..2b2a8b6 100644 --- a/src/vendorcode/amd/pi/00670F00/AGESA.h +++ b/src/vendorcode/amd/pi/00670F00/AGESA.h @@ -67,6 +67,7 @@ #define AGESA_RUNFUNC_ON_ALL_APS 0x00028106ul #define AGESA_IDLE_AN_AP 0x00028107ul #define AGESA_WAIT_FOR_ALL_APS 0x00028108ul +#define AGESA_HALT_THIS_AP 0x00028109ul // AGESA ADVANCED CALLOUTS, Memory #define AGESA_READ_SPD 0x00028140ul @@ -2514,6 +2515,18 @@ IN OUT MEM_DATA_STRUCT *MemData; ///< Location of the MemData structure, for reference } AGESA_READ_SPD_PARAMS; +/// Parameters structure for the interface call-out AGESA_HALT_THIS_AP +typedef struct { + IN OUT AMD_CONFIG_PARAMS StdHeader; ///< Standard configuration header + IN BOOLEAN ExecWbinvd; ///< Indicates whether to execute + /// WBINVD + IN BOOLEAN PrimaryCore; ///< Indicates whether current core + /// is the primary core of the + /// compute unit + IN BOOLEAN CacheEn; ///< Indicates whether cache should + /// be enabled +} AGESA_HALT_THIS_AP_PARAMS; + /// VoltageType values typedef enum { VTYPE_CPU_VREF, ///< Cpu side Vref @@ -2625,6 +2638,12 @@ ); AGESA_STATUS +AgesaHaltThisAp ( + IN UINTN FcnData, + IN AGESA_HALT_THIS_AP_PARAMS *HaltApParams +); + +AGESA_STATUS AgesaHookBeforeDramInit ( IN UINTN SocketIdModuleId, IN OUT MEM_DATA_STRUCT *MemData -- To view, visit https://review.coreboot.org/25183 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5a07f1c539d00aed34cfe45d6d7ef60c1dc56566 Gerrit-Change-Number: 25183 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>

1 0

Change in coreboot[master]: soc/amd/stoneyridge/southbridge.c: Create AOAC initialization code
by build bot (Jenkins) (Code Review) 14 Mar '18

14 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25142 ) Change subject: soc/amd/stoneyridge/southbridge.c: Create AOAC initialization code ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22950/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68546/ : SUCCESS -- To view, visit https://review.coreboot.org/25142 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I359791c2a332629aa991f2f17a67e94726a21eb5 Gerrit-Change-Number: 25142 Gerrit-PatchSet: 3 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Garrett Kirkendall <garrett.kirkendall(a)amd.corp-partner.google.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshall.dawson(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Mar 2018 22:52:59 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Create a HALT_THIS_AP callout
by build bot (Jenkins) (Code Review) 14 Mar '18

14 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24999 ) Change subject: soc/amd/stoneyridge: Create a HALT_THIS_AP callout ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22949/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68545/ : SUCCESS -- To view, visit https://review.coreboot.org/24999 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I05ee405812211d93dfdbdc5ee7d9978c2eb585e1 Gerrit-Change-Number: 24999 Gerrit-PatchSet: 6 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Mar 2018 20:48:31 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Create a HALT_THIS_AP callout
by build bot (Jenkins) (Code Review) 14 Mar '18

14 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24999 ) Change subject: soc/amd/stoneyridge: Create a HALT_THIS_AP callout ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68544/ : SUCCESS -- To view, visit https://review.coreboot.org/24999 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I05ee405812211d93dfdbdc5ee7d9978c2eb585e1 Gerrit-Change-Number: 24999 Gerrit-PatchSet: 5 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Mar 2018 20:33:39 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Create a HALT_THIS_AP callout
by build bot (Jenkins) (Code Review) 14 Mar '18

14 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24999 ) Change subject: soc/amd/stoneyridge: Create a HALT_THIS_AP callout ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22948/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68543/ : SUCCESS -- To view, visit https://review.coreboot.org/24999 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I05ee405812211d93dfdbdc5ee7d9978c2eb585e1 Gerrit-Change-Number: 24999 Gerrit-PatchSet: 4 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Mar 2018 20:23:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [WIP]src/lib: Add uImage support
by build bot (Jenkins) (Code Review) 14 Mar '18

14 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25019 ) Change subject: [WIP]src/lib: Add uImage support ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22941/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68542/ : SUCCESS -- To view, visit https://review.coreboot.org/25019 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0f27b92a5e074966f893399eb401eb97d784850d Gerrit-Change-Number: 25019 Gerrit-PatchSet: 6 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Mar 2018 20:22:13 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Call sb_acpi_mmio_decode()
by build bot (Jenkins) (Code Review) 14 Mar '18

14 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25161 ) Change subject: soc/amd/stoneyridge: Call sb_acpi_mmio_decode() ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68541/ : SUCCESS -- To view, visit https://review.coreboot.org/25161 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8cf329e5cd2002b225742fefa5c1ddd2598de674 Gerrit-Change-Number: 25161 Gerrit-PatchSet: 2 Gerrit-Owner: Garrett Kirkendall <garrett.kirkendall(a)amd.corp-partner.google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Garrett Kirkendall <garrett.kirkendall(a)amd.corp-partner.google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Mar 2018 19:02:57 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Add gpio-keys ACPI node for PENH
by build bot (Jenkins) (Code Review) 14 Mar '18

14 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25162 ) Change subject: mb/google/poppy/variants/nami: Add gpio-keys ACPI node for PENH ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22947/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68540/ : SUCCESS -- To view, visit https://review.coreboot.org/25162 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d87d938ac3a4e52e676850b9d8b80e83726275d Gerrit-Change-Number: 25162 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Mar 2018 18:35:46 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Add gpio-keys ACPI node for PENH
by Shelley Chen (Code Review) 14 Mar '18

14 Mar '18

Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/25162 Change subject: mb/google/poppy/variants/nami: Add gpio-keys ACPI node for PENH ...................................................................... mb/google/poppy/variants/nami: Add gpio-keys ACPI node for PENH Use gpio_keys driver to add ACPI node for pen eject event. Also setting gpio wake pin for wake events. BUG=b:73121017 BRANCH=None TEST=./util/abuild/abuild -p none -t google/poppy -x -a Change-Id: I5d87d938ac3a4e52e676850b9d8b80e83726275d Signed-off-by: Shelley Chen <shchen(a)chromium.org> --- M src/mainboard/google/poppy/variants/nami/devicetree.cb M src/mainboard/google/poppy/variants/nami/gpio.c 2 files changed, 13 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/25162/1 diff --git a/src/mainboard/google/poppy/variants/nami/devicetree.cb b/src/mainboard/google/poppy/variants/nami/devicetree.cb index 602e41b..913d29e 100644 --- a/src/mainboard/google/poppy/variants/nami/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nami/devicetree.cb @@ -282,6 +282,15 @@ register "hid_desc_reg_offset" = "0x1" device i2c 0x9 on end end + chip drivers/generic/gpio_keys + register "name" = ""PENH"" + register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPP_E8)" + register "key.dev_name" = ""EJCT"" + register "key.linux_code" = "SW_PEN_INSERTED" + register "key.linux_input_type" = "EV_SW" + register "key.label" = ""pen_eject"" + device generic 0 on end + end end # I2C #2 device pci 15.3 on chip drivers/generic/max98357a diff --git a/src/mainboard/google/poppy/variants/nami/gpio.c b/src/mainboard/google/poppy/variants/nami/gpio.c index 8337e72..01204e7 100644 --- a/src/mainboard/google/poppy/variants/nami/gpio.c +++ b/src/mainboard/google/poppy/variants/nami/gpio.c @@ -211,8 +211,8 @@ /* E0 : SATAXPCI0 ==> H1_PCH_INT_ODL */ PAD_CFG_GPI_APIC_INVERT(GPP_E0, NONE, PLTRST), - /* E1 : SATAXPCIE1 ==> SATA_GP1 */ - PAD_CFG_NF(GPP_E1, NONE, DEEP, NF1), + /* E1 : SATAXPCIE1 ==> PEN_EJECT_ODL - for wake event */ + PAD_CFG_GPI_GPIO_DRIVER(GPP_E1, NONE, DEEP), /* E2 : SATAXPCIE2 ==> NC(TP916) */ PAD_CFG_NC(GPP_E2), /* E3 : CPU_GP0 ==> TRACKPAD_INT# */ @@ -225,8 +225,8 @@ PAD_CFG_NC(GPP_E6), /* E7 : CPU_GP1 ==> TOUCHSCREEN_INT# */ PAD_CFG_GPI_APIC(GPP_E7, NONE, PLTRST), - /* E8 : SATALED# ==> NC */ - PAD_CFG_NC(GPP_E8), + /* E8 : SATALED# ==> PEN_EJECT_ODL - for notification */ + PAD_CFG_GPI_ACPI_SCI(GPP_E8, NONE, DEEP, NONE), /* E9 : USB2_OCO# ==> USB_C0_OC# */ PAD_CFG_NF(GPP_E9, NONE, DEEP, NF1), /* E10 : USB2_OC1# ==> USB_C1_OC# */ -- To view, visit https://review.coreboot.org/25162 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5d87d938ac3a4e52e676850b9d8b80e83726275d Gerrit-Change-Number: 25162 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen <shchen(a)google.com>

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Call sb_acpi_mmio_decode()
by build bot (Jenkins) (Code Review) 14 Mar '18

14 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25161 ) Change subject: soc/amd/stoneyridge: Call sb_acpi_mmio_decode() ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22946/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68539/ : SUCCESS -- To view, visit https://review.coreboot.org/25161 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8cf329e5cd2002b225742fefa5c1ddd2598de674 Gerrit-Change-Number: 25161 Gerrit-PatchSet: 1 Gerrit-Owner: Garrett Kirkendall <garrett.kirkendall(a)amd.corp-partner.google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Mar 2018 18:16:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2018