coreboot-gerrit March 2018

coreboot-gerrit@coreboot.org

1 participants
1399 discussions

Change in coreboot[master]: payloads/external/GRUB2: add veyron support
by build bot (Jenkins) (Code Review) 15 Mar '18

15 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23342 ) Change subject: payloads/external/GRUB2: add veyron support ...................................................................... Patch Set 5: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/68554/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/22958/ : SUCCESS -- To view, visit https://review.coreboot.org/23342 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f01e2f3360e2bb317b8300d32cbaae97193e259 Gerrit-Change-Number: 23342 Gerrit-PatchSet: 5 Gerrit-Owner: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Mar 2018 01:01:42 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: payloads/external/GRUB2: configurable modules
by build bot (Jenkins) (Code Review) 15 Mar '18

15 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23339 ) Change subject: payloads/external/GRUB2: configurable modules ...................................................................... Patch Set 4: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/68551/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/22954/ : SUCCESS -- To view, visit https://review.coreboot.org/23339 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9203f164277a53946bb29ef2f2bc4b45a48b52cf Gerrit-Change-Number: 23339 Gerrit-PatchSet: 4 Gerrit-Owner: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Mar 2018 01:01:28 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: payloads/external/GRUB2: add arm support
by build bot (Jenkins) (Code Review) 15 Mar '18

15 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23340 ) Change subject: payloads/external/GRUB2: add arm support ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22956/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68552/ : SUCCESS -- To view, visit https://review.coreboot.org/23340 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37ec1191fede8e333d9571b2fd34353ed38b8fd1 Gerrit-Change-Number: 23340 Gerrit-PatchSet: 5 Gerrit-Owner: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Mar 2018 01:01:06 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: payloads/external/GRUB2: add support for vexpress
by build bot (Jenkins) (Code Review) 15 Mar '18

15 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23341 ) Change subject: payloads/external/GRUB2: add support for vexpress ...................................................................... Patch Set 5: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/68553/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/22957/ : SUCCESS -- To view, visit https://review.coreboot.org/23341 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id62e7397807ff51ebfb7cd4f3210457f2b3e3666 Gerrit-Change-Number: 23341 Gerrit-PatchSet: 5 Gerrit-Owner: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Mar 2018 00:59:54 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: payloads/external/GRUB2: Pass the architecture to grub's configure sc...
by build bot (Jenkins) (Code Review) 15 Mar '18

15 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23172 ) Change subject: payloads/external/GRUB2: Pass the architecture to grub's configure script ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22955/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68550/ : SUCCESS -- To view, visit https://review.coreboot.org/23172 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied7a5535cd93ffc2b69563a55e69dc7370db4793 Gerrit-Change-Number: 23172 Gerrit-PatchSet: 4 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Mar 2018 00:55:35 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Add gpio-keys ACPI node for PENH
by Furquan Shaikh (Code Review) 15 Mar '18

15 Mar '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/25162 ) Change subject: mb/google/poppy/variants/nami: Add gpio-keys ACPI node for PENH ...................................................................... Patch Set 1: (3 comments) https://review.coreboot.org/#/c/25162/1/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/nami/devicetree.cb: https://review.coreboot.org/#/c/25162/1/src/mainboard/google/poppy/variants… PS1, Line 281: register "generic.disable_gpio_export_in_crs" = "1" register "generic.wake" = "GPE0_DW2_01" https://review.coreboot.org/#/c/25162/1/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/nami/gpio.c: https://review.coreboot.org/#/c/25162/1/src/mainboard/google/poppy/variants… PS1, Line 215: PAD_CFG_GPI_GPIO_DRIVER This should be ACPI_SCI https://review.coreboot.org/#/c/25162/1/src/mainboard/google/poppy/variants… PS1, Line 229: ACPI_SCI and this should be GPIO_DRIVER -- To view, visit https://review.coreboot.org/25162 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d87d938ac3a4e52e676850b9d8b80e83726275d Gerrit-Change-Number: 25162 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Mar 2018 00:30:44 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: security/tpm: Fix TPM software stack vulnerability
by build bot (Jenkins) (Code Review) 15 Mar '18

15 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25184 ) Change subject: security/tpm: Fix TPM software stack vulnerability ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22953/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68549/ : SUCCESS -- To view, visit https://review.coreboot.org/25184 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1618b2cc579d189bccca7a781e2bed0976a8b471 Gerrit-Change-Number: 25184 Gerrit-PatchSet: 1 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Comment-Date: Thu, 15 Mar 2018 00:03:53 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: security/tpm: Fix TPM software stack vulnerability
by Philipp Deppenwiese (Code Review) 15 Mar '18

15 Mar '18

Philipp Deppenwiese has uploaded this change for review. ( https://review.coreboot.org/25184 Change subject: security/tpm: Fix TPM software stack vulnerability ...................................................................... security/tpm: Fix TPM software stack vulnerability * Fix tlcl_read() for TPM 1.2 * https://github.com/nccgroup/TPMGenie Change-Id: I1618b2cc579d189bccca7a781e2bed0976a8b471 Signed-off-by: zaolin <zaolin(a)das-labor.org> --- M src/security/tpm/tss/tcg-1.2/tss.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/25184/1 diff --git a/src/security/tpm/tss/tcg-1.2/tss.c b/src/security/tpm/tss/tcg-1.2/tss.c index b7b2d94..3e2e049 100644 --- a/src/security/tpm/tss/tcg-1.2/tss.c +++ b/src/security/tpm/tss/tcg-1.2/tss.c @@ -238,6 +238,7 @@ if (result == TPM_SUCCESS && length > 0) { uint8_t *nv_read_cursor = response + kTpmResponseHeaderLength; from_tpm_uint32(nv_read_cursor, &result_length); + assert(result_length > length); nv_read_cursor += sizeof(uint32_t); memcpy(data, nv_read_cursor, result_length); } -- To view, visit https://review.coreboot.org/25184 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1618b2cc579d189bccca7a781e2bed0976a8b471 Gerrit-Change-Number: 25184 Gerrit-PatchSet: 1 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Create a HALT_THIS_AP callout
by build bot (Jenkins) (Code Review) 15 Mar '18

15 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24999 ) Change subject: soc/amd/stoneyridge: Create a HALT_THIS_AP callout ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22952/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68548/ : SUCCESS -- To view, visit https://review.coreboot.org/24999 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I05ee405812211d93dfdbdc5ee7d9978c2eb585e1 Gerrit-Change-Number: 24999 Gerrit-PatchSet: 7 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Mar 2018 23:37:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: 3rdparty/blobs: Commit updated blobs
by build bot (Jenkins) (Code Review) 15 Mar '18

15 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25183 ) Change subject: 3rdparty/blobs: Commit updated blobs ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22951/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68547/ : SUCCESS -- To view, visit https://review.coreboot.org/25183 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a07f1c539d00aed34cfe45d6d7ef60c1dc56566 Gerrit-Change-Number: 25183 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Mar 2018 23:23:10 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2018