coreboot-gerrit March 2018

coreboot-gerrit@coreboot.org

1 participants
1399 discussions

Change in coreboot[master]: stoneyridge: Update AGESA binary and AGESA.h
by build bot (Jenkins) (Code Review) 15 Mar '18

15 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25183 ) Change subject: stoneyridge: Update AGESA binary and AGESA.h ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68582/ : SUCCESS -- To view, visit https://review.coreboot.org/25183 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a07f1c539d00aed34cfe45d6d7ef60c1dc56566 Gerrit-Change-Number: 25183 Gerrit-PatchSet: 3 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Mar 2018 14:25:16 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: security/tpm: Fix TPM software stack vulnerability
by build bot (Jenkins) (Code Review) 15 Mar '18

15 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25184 ) Change subject: security/tpm: Fix TPM software stack vulnerability ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22980/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68581/ : SUCCESS -- To view, visit https://review.coreboot.org/25184 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1618b2cc579d189bccca7a781e2bed0976a8b471 Gerrit-Change-Number: 25184 Gerrit-PatchSet: 2 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Comment-Date: Thu, 15 Mar 2018 11:43:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: security/tpm: Fix TPM software stack vulnerability
by Philipp Deppenwiese (Code Review) 15 Mar '18

15 Mar '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/25184 ) Change subject: security/tpm: Fix TPM software stack vulnerability ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/25184/1/src/security/tpm/tss/tcg-1.2/tss.c File src/security/tpm/tss/tcg-1.2/tss.c: https://review.coreboot.org/#/c/25184/1/src/security/tpm/tss/tcg-1.2/tss.c@… PS1, Line 241: if (result_length > length) > I am not a fun of asserts - what if this is just a glitch, do we want to crash the device? […] Ack -- To view, visit https://review.coreboot.org/25184 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1618b2cc579d189bccca7a781e2bed0976a8b471 Gerrit-Change-Number: 25184 Gerrit-PatchSet: 2 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Comment-Date: Thu, 15 Mar 2018 11:42:12 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: security/tpm: Fix TPM software stack vulnerability
by Philipp Deppenwiese (Code Review) 15 Mar '18

15 Mar '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/25184 ) Change subject: security/tpm: Fix TPM software stack vulnerability ...................................................................... Patch Set 2: (2 comments) https://review.coreboot.org/#/c/25184/2//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/25184/2//COMMIT_MSG@10 PS2, Line 10: * https://github.com/nccgroup/TPMGenie > Did you use this tool to reproduce the issue? If yes, maybe document how. https://github.com/nccgroup/TPMGenie/blob/master/docs/NCC_Group_Jeremy_Boon… https://review.coreboot.org/#/c/25184/2//COMMIT_MSG@11 PS2, Line 11: > Please add a line: […] Done -- To view, visit https://review.coreboot.org/25184 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1618b2cc579d189bccca7a781e2bed0976a8b471 Gerrit-Change-Number: 25184 Gerrit-PatchSet: 2 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Comment-Date: Thu, 15 Mar 2018 11:41:59 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Modify touchscreen enable for EVT build
by build bot (Jenkins) (Code Review) 15 Mar '18

15 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25191 ) Change subject: mb/google/poppy/variants/nami: Modify touchscreen enable for EVT build ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/68580/ : FAILURE -- To view, visit https://review.coreboot.org/25191 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9195fb789e0bf44e5e69a622a0cb7fcfc506e398 Gerrit-Change-Number: 25191 Gerrit-PatchSet: 2 Gerrit-Owner: Jasper Lee <jasper_lee(a)compal.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jasper Lee <jasper_lee(a)compal.com> Gerrit-Reviewer: Jimmy M Wang <jimmym_wang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: luke yang <luke_yang(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Thu, 15 Mar 2018 11:09:54 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: storage: Pass the firmware sdhci data to depthcharge
by build bot (Jenkins) (Code Review) 15 Mar '18

15 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25189 ) Change subject: storage: Pass the firmware sdhci data to depthcharge ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22978/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68578/ : SUCCESS -- To view, visit https://review.coreboot.org/25189 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I38e26cb7b3daa5d6bc6d38c3b9efb6640ab78a86 Gerrit-Change-Number: 25189 Gerrit-PatchSet: 2 Gerrit-Owner: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Mar 2018 11:09:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/skylake: Use common EMMC block code
by build bot (Jenkins) (Code Review) 15 Mar '18

15 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25190 ) Change subject: soc/intel/skylake: Use common EMMC block code ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22979/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68579/ : SUCCESS -- To view, visit https://review.coreboot.org/25190 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie23fbbf7fa46f331eaff8b2e22e7fec3128a9334 Gerrit-Change-Number: 25190 Gerrit-PatchSet: 2 Gerrit-Owner: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Mar 2018 11:08:37 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: intel/common/block/emmc: Add intel common EMMC init code over AP
by build bot (Jenkins) (Code Review) 15 Mar '18

15 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25188 ) Change subject: intel/common/block/emmc: Add intel common EMMC init code over AP ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22977/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68577/ : SUCCESS -- To view, visit https://review.coreboot.org/25188 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10e91b4d9b5385331100f7eabc3be2f1e47bf377 Gerrit-Change-Number: 25188 Gerrit-PatchSet: 2 Gerrit-Owner: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Mar 2018 10:59:39 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: intel/common/block/emmc: Add intel common EMMC init code over AP
by Barnali Sarkar (Code Review) 15 Mar '18

15 Mar '18

Hello Subrata Banik, Balaji Manigandan, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/25188 to look at the new patch set (#2). Change subject: intel/common/block/emmc: Add intel common EMMC init code over AP ...................................................................... intel/common/block/emmc: Add intel common EMMC init code over AP This patch adds new block to do multi-threaded EMMC controller initialization code. Thus on selecting this block from SOC, EMMC controller init code will get executed in parallel thread, without disturbing the already running code in BSP. This is done to save around 100-300 msecs of booting time for emmc initialization depending on different booting scenarios. BUG=none BRANCH=none TEST=Done 3K Stability Test in Soraka (SKL) to see the boot time optimizations in the following scenarios - * Warm Reboot --> ~100-150 msecs * Cold Reboot --> ~100-150 msecs * EC Reeboot --> ~300 msecs Change-Id: I10e91b4d9b5385331100f7eabc3be2f1e47bf377 Signed-off-by: Barnali Sarkar <barnali.sarkar(a)intel.com> Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- A src/soc/intel/common/block/emmc/Kconfig A src/soc/intel/common/block/emmc/Makefile.inc A src/soc/intel/common/block/emmc/emmc_ap_init.c 3 files changed, 231 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/25188/2 -- To view, visit https://review.coreboot.org/25188 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I10e91b4d9b5385331100f7eabc3be2f1e47bf377 Gerrit-Change-Number: 25188 Gerrit-PatchSet: 2 Gerrit-Owner: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Modify touchscreen enable for EVT build
by build bot (Jenkins) (Code Review) 15 Mar '18

15 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25191 ) Change subject: mb/google/poppy/variants/nami: Modify touchscreen enable for EVT build ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22976/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68576/ : SUCCESS -- To view, visit https://review.coreboot.org/25191 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9195fb789e0bf44e5e69a622a0cb7fcfc506e398 Gerrit-Change-Number: 25191 Gerrit-PatchSet: 1 Gerrit-Owner: Jasper Lee <jasper_lee(a)compal.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jasper Lee <jasper_lee(a)compal.com> Gerrit-Reviewer: Jimmy M Wang <jimmym_wang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: luke yang <luke_yang(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Thu, 15 Mar 2018 10:50:44 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2018