coreboot-gerrit March 2018

coreboot-gerrit@coreboot.org

1 participants
1399 discussions

Change in coreboot[master]: mainboard/opencellular/rotundu: Fix vboot and TPM support
by build bot (Jenkins) (Code Review) 19 Mar '18

19 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25084 ) Change subject: mainboard/opencellular/rotundu: Fix vboot and TPM support ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23142/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68751/ : SUCCESS -- To view, visit https://review.coreboot.org/25084 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49d97a9d324207e45520d43b814b03a20005122a Gerrit-Change-Number: 25084 Gerrit-PatchSet: 4 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 19 Mar 2018 14:30:23 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: security/flash: Add hook for get write protect state
by build bot (Jenkins) (Code Review) 19 Mar '18

19 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25262 ) Change subject: security/flash: Add hook for get write protect state ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23136/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68745/ : SUCCESS -- To view, visit https://review.coreboot.org/25262 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icda8ac0b60d84fb5f020e790ccda093d477c738c Gerrit-Change-Number: 25262 Gerrit-PatchSet: 2 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 19 Mar 2018 14:30:16 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: opencellular/rotundu: Introduce variants for OC
by build bot (Jenkins) (Code Review) 19 Mar '18

19 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22924 ) Change subject: opencellular/rotundu: Introduce variants for OC ...................................................................... Patch Set 18: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23140/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68749/ : SUCCESS -- To view, visit https://review.coreboot.org/22924 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id20e9d4ed7ac071d25a69eee63c9ec544d2ad152 Gerrit-Change-Number: 22924 Gerrit-PatchSet: 18 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 19 Mar 2018 14:26:51 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: opencellular/rotundu: Add LPC TPM support
by build bot (Jenkins) (Code Review) 19 Mar '18

19 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22829 ) Change subject: opencellular/rotundu: Add LPC TPM support ...................................................................... Patch Set 15: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23139/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68748/ : SUCCESS -- To view, visit https://review.coreboot.org/22829 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4154841de553d198d5a5d113e31b7be14a12dcd0 Gerrit-Change-Number: 22829 Gerrit-PatchSet: 15 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Bernard Adongo <bernard(a)brck.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Reg Orton <reg(a)brck.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 19 Mar 2018 14:23:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: [WIP]drivers/spi: Add status register lockdown
by build bot (Jenkins) (Code Review) 19 Mar '18

19 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25106 ) Change subject: [WIP]drivers/spi: Add status register lockdown ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23134/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68743/ : SUCCESS -- To view, visit https://review.coreboot.org/25106 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If99fc7d61692e3926cd1a92e40c9d64f8fa5463d Gerrit-Change-Number: 25106 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 19 Mar 2018 14:10:43 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: security/flash: Add SPI flash protection
by build bot (Jenkins) (Code Review) 19 Mar '18

19 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25196 ) Change subject: security/flash: Add SPI flash protection ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23135/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68744/ : SUCCESS -- To view, visit https://review.coreboot.org/25196 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12656d7c111ed3622fab5578f6e0c462fe5d4796 Gerrit-Change-Number: 25196 Gerrit-PatchSet: 5 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 19 Mar 2018 14:04:18 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [WIP]drivers/spi: Winbond specific writeprotection enable
by build bot (Jenkins) (Code Review) 19 Mar '18

19 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25105 ) Change subject: [WIP]drivers/spi: Winbond specific writeprotection enable ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23133/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68742/ : SUCCESS -- To view, visit https://review.coreboot.org/25105 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3765b013855538eca37bc7800d3f9d5d09b8402 Gerrit-Change-Number: 25105 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Comment-Date: Mon, 19 Mar 2018 13:59:53 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: [WIP]src/drivers/spi: Read Winbond's flash protection bits
by build bot (Jenkins) (Code Review) 19 Mar '18

19 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25082 ) Change subject: [WIP]src/drivers/spi: Read Winbond's flash protection bits ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23132/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68741/ : SUCCESS -- To view, visit https://review.coreboot.org/25082 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I933a8abdc28174ec32acf323c102d606b58c1ea5 Gerrit-Change-Number: 25082 Gerrit-PatchSet: 6 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-Comment-Date: Mon, 19 Mar 2018 13:53:32 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [WIP]drivers/spi: Add status register lockdown
by build bot (Jenkins) (Code Review) 19 Mar '18

19 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25106 ) Change subject: [WIP]drivers/spi: Add status register lockdown ...................................................................... Patch Set 3: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/68740/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/23131/ : SUCCESS -- To view, visit https://review.coreboot.org/25106 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If99fc7d61692e3926cd1a92e40c9d64f8fa5463d Gerrit-Change-Number: 25106 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 19 Mar 2018 13:52:27 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [WIP]src/drivers/spi: Read Winbond's flash protection bits
by Philipp Deppenwiese (Code Review) 19 Mar '18

19 Mar '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/25082 ) Change subject: [WIP]src/drivers/spi: Read Winbond's flash protection bits ...................................................................... Patch Set 5: (9 comments) https://review.coreboot.org/#/c/25082/1/src/drivers/spi/spi_flash.c File src/drivers/spi/spi_flash.c: https://review.coreboot.org/#/c/25082/1/src/drivers/spi/spi_flash.c@69 PS1, Line 69: printk(BIOS_WARNING, : "SF: Failed t > Now that the command can contain more than one byte do you want to do something like this: […] Done https://review.coreboot.org/#/c/25082/1/src/drivers/spi/spi_flash.c@438 PS1, Line 438: t > || !region Done https://review.coreboot.org/#/c/25082/1/src/drivers/spi/winbond.c File src/drivers/spi/winbond.c: https://review.coreboot.org/#/c/25082/1/src/drivers/spi/winbond.c@199 PS1, Line 199: > part Done https://review.coreboot.org/#/c/25082/1/src/drivers/spi/winbond.c@204 PS1, Line 204: > size_t i Done https://review.coreboot.org/#/c/25082/1/src/drivers/spi/winbond.c@219 PS1, Line 219: > use a macro for this? Done https://review.coreboot.org/#/c/25082/1/src/drivers/spi/winbond.c@233 PS1, Line 233: prot > part Done https://review.coreboot.org/#/c/25082/1/src/drivers/spi/winbond.c@238 PS1, Line 238: f a p > size_t? Done https://review.coreboot.org/#/c/25082/1/src/drivers/spi/winbond.c@266 PS1, Line 266: &re > Do you really need to divide by KiB? […] Done https://review.coreboot.org/#/c/25082/1/src/drivers/spi/winbond.c@285 PS1, Line 285: s > magic value. […] Done -- To view, visit https://review.coreboot.org/25082 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I933a8abdc28174ec32acf323c102d606b58c1ea5 Gerrit-Change-Number: 25082 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-Comment-Date: Mon, 19 Mar 2018 13:37:02 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2018