coreboot-gerrit March 2018

coreboot-gerrit@coreboot.org

1 participants
1399 discussions

Change in coreboot[master]: ifdtool: dump all PCH Straps
by build bot (Jenkins) (Code Review) 20 Mar '18

20 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25296 ) Change subject: ifdtool: dump all PCH Straps ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23203/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68820/ : SUCCESS -- To view, visit https://review.coreboot.org/25296 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56c02c00923e018bbd6a0409a08715f39b854d0a Gerrit-Change-Number: 25296 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Mar 2018 12:26:06 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/hp: Add Elitebook Folio 9470m
by build bot (Jenkins) (Code Review) 20 Mar '18

20 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25218 ) Change subject: mainboard/hp: Add Elitebook Folio 9470m ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23202/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68819/ : SUCCESS -- To view, visit https://review.coreboot.org/25218 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52e549ec18e8aa661a506a16dbc7f83417c0da78 Gerrit-Change-Number: 25218 Gerrit-PatchSet: 5 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Mar 2018 12:21:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: ifdtool: dump all PCH Straps
by Thomas Heijligen (Code Review) 20 Mar '18

20 Mar '18

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/25296 Change subject: ifdtool: dump all PCH Straps ...................................................................... ifdtool: dump all PCH Straps The length of the PCH Strap is defined in FLMAP1 as ISL. Use this value to dump all PCH Straps. Set MAX_PCHSTRP to 0x58 (Skylake-H), the lagest value known to me. Change-Id: I56c02c00923e018bbd6a0409a08715f39b854d0a Signed-off-by: Thomas Heijligen <src(a)posteo.de> --- M util/ifdtool/ifdtool.c M util/ifdtool/ifdtool.h 2 files changed, 7 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/25296/1 diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index 8397f5c..4fade18 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -411,11 +411,13 @@ (fcba->flpb & 0xfff) << 12); } -static void dump_fpsba(const fpsba_t *fpsba) +static void dump_fpsba(const fpsba_t *fpsba, const uint32_t isl) { - unsigned int i; printf("Found PCH Strap Section\n"); - for (i = 0; i < ARRAY_SIZE(fpsba->pchstrp); i++) + if (isl > MAX_PCHSTRP) + printf("PCH Strap Length is bigger than known\n"); + uint32_t i; + for (i = 0; i < isl; i++) printf("PCHSTRP%u:%s 0x%08x\n", i, i < 10 ? " " : "", fpsba->pchstrp[i]); printf("\n"); @@ -622,7 +624,7 @@ if (frba && fcba && fpsba && fmba && fmsba) { dump_frba(frba); dump_fcba(fcba); - dump_fpsba(fpsba); + dump_fpsba(fpsba, (fdb->flmap1 >> 24) & 0xff); dump_fmba(fmba); dump_fmsba(fmsba); } else { diff --git a/util/ifdtool/ifdtool.h b/util/ifdtool/ifdtool.h index cd5af79..bbb94f0 100644 --- a/util/ifdtool/ifdtool.h +++ b/util/ifdtool/ifdtool.h @@ -73,7 +73,7 @@ } __attribute__((packed)) fcba_t; // pch strap -#define MAX_PCHSTRP 18 +#define MAX_PCHSTRP 0x58 typedef struct { uint32_t pchstrp[MAX_PCHSTRP]; -- To view, visit https://review.coreboot.org/25296 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I56c02c00923e018bbd6a0409a08715f39b854d0a Gerrit-Change-Number: 25296 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>

1 0

Change in coreboot[master]: soc/intel/skylake: Use common EMMC block code
by build bot (Jenkins) (Code Review) 20 Mar '18

20 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25190 ) Change subject: soc/intel/skylake: Use common EMMC block code ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23200/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68817/ : SUCCESS -- To view, visit https://review.coreboot.org/25190 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie23fbbf7fa46f331eaff8b2e22e7fec3128a9334 Gerrit-Change-Number: 25190 Gerrit-PatchSet: 3 Gerrit-Owner: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Mar 2018 11:38:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: drivers/i2c/designware: Fix indentation
by Naresh Solanki (Code Review) 20 Mar '18

20 Mar '18

Naresh Solanki has posted comments on this change. ( https://review.coreboot.org/25295 ) Change subject: drivers/i2c/designware: Fix indentation ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/25295 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id82239f74ac030f25000a08764637f6d1b52b87b Gerrit-Change-Number: 25295 Gerrit-PatchSet: 1 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Mar 2018 11:34:50 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: drivers/i2c/designware: Fix indentation
by build bot (Jenkins) (Code Review) 20 Mar '18

20 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25295 ) Change subject: drivers/i2c/designware: Fix indentation ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23201/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68818/ : SUCCESS -- To view, visit https://review.coreboot.org/25295 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id82239f74ac030f25000a08764637f6d1b52b87b Gerrit-Change-Number: 25295 Gerrit-PatchSet: 1 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Mar 2018 11:34:26 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: intel/common/block/emmc: Add intel common EMMC init code over AP
by build bot (Jenkins) (Code Review) 20 Mar '18

20 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25188 ) Change subject: intel/common/block/emmc: Add intel common EMMC init code over AP ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23198/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68815/ : SUCCESS -- To view, visit https://review.coreboot.org/25188 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10e91b4d9b5385331100f7eabc3be2f1e47bf377 Gerrit-Change-Number: 25188 Gerrit-PatchSet: 3 Gerrit-Owner: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Comment-Date: Tue, 20 Mar 2018 11:27:56 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: drivers/i2c/designware: Fix indentation
by Maulik V Vaghela (Code Review) 20 Mar '18

20 Mar '18

Maulik V Vaghela has uploaded this change for review. ( https://review.coreboot.org/25295 Change subject: drivers/i2c/designware: Fix indentation ...................................................................... drivers/i2c/designware: Fix indentation Remove extra tab before printk statement. Change-Id: Id82239f74ac030f25000a08764637f6d1b52b87b Signed-off-by: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> --- M src/drivers/i2c/designware/dw_i2c.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/25295/1 diff --git a/src/drivers/i2c/designware/dw_i2c.c b/src/drivers/i2c/designware/dw_i2c.c index 3db34ff..12284b6 100644 --- a/src/drivers/i2c/designware/dw_i2c.c +++ b/src/drivers/i2c/designware/dw_i2c.c @@ -398,7 +398,7 @@ int j; for (j = 0; j < segments->len; j++) printk(BIOS_DEBUG, "%02x ", segments->buf[j]); - printk(BIOS_DEBUG, "\n"); + printk(BIOS_DEBUG, "\n"); } segments++; -- To view, visit https://review.coreboot.org/25295 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id82239f74ac030f25000a08764637f6d1b52b87b Gerrit-Change-Number: 25295 Gerrit-PatchSet: 1 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>

1 0

Change in coreboot[master]: storage: Pass the firmware sdhci data to depthcharge
by build bot (Jenkins) (Code Review) 20 Mar '18

20 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25189 ) Change subject: storage: Pass the firmware sdhci data to depthcharge ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23199/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68816/ : SUCCESS -- To view, visit https://review.coreboot.org/25189 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I38e26cb7b3daa5d6bc6d38c3b9efb6640ab78a86 Gerrit-Change-Number: 25189 Gerrit-PatchSet: 3 Gerrit-Owner: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Mar 2018 11:24:57 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/coffeelake: Make initial soc commit for coffeelake
by build bot (Jenkins) (Code Review) 20 Mar '18

20 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25121 ) Change subject: soc/intel/coffeelake: Make initial soc commit for coffeelake ...................................................................... Patch Set 9: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23196/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68813/ : SUCCESS -- To view, visit https://review.coreboot.org/25121 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I657332df31bdf75a2423dc9bb3296b3b4d608304 Gerrit-Change-Number: 25121 Gerrit-PatchSet: 9 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Kin Wai Ng <kin.wai.ng(a)intel.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Mar 2018 11:15:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2018