coreboot-gerrit March 2018

coreboot-gerrit@coreboot.org

1 participants
1399 discussions

Change in coreboot[master]: mb/google/octopus: Add CLKREQ and de-emphasis settings for PCIe Wi-FI
by build bot (Jenkins) (Code Review) 20 Mar '18

20 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25288 ) Change subject: mb/google/octopus: Add CLKREQ and de-emphasis settings for PCIe Wi-FI ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68828/ : SUCCESS -- To view, visit https://review.coreboot.org/25288 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic73ad38ad9a12bec614e530f7f35619246b9f57f Gerrit-Change-Number: 25288 Gerrit-PatchSet: 4 Gerrit-Owner: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Roy Mingi Park <roy.mingi.park(a)intel.com> Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: Venkateswarlu V Vinjamuri <venkateswarlu.v.vinjamuri(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Mar 2018 15:29:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: security/flash: Refactor flash protection logic
by build bot (Jenkins) (Code Review) 20 Mar '18

20 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25283 ) Change subject: security/flash: Refactor flash protection logic ...................................................................... Patch Set 8: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/68827/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/23209/ : SUCCESS -- To view, visit https://review.coreboot.org/25283 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic0a859e6ce9aba32278f666a38a952ec8b4c1b4d Gerrit-Change-Number: 25283 Gerrit-PatchSet: 8 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Tue, 20 Mar 2018 14:56:37 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: security/flash: Refactor flash protection logic
by build bot (Jenkins) (Code Review) 20 Mar '18

20 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25283 ) Change subject: security/flash: Refactor flash protection logic ...................................................................... Patch Set 7: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/68826/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/23208/ : SUCCESS -- To view, visit https://review.coreboot.org/25283 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic0a859e6ce9aba32278f666a38a952ec8b4c1b4d Gerrit-Change-Number: 25283 Gerrit-PatchSet: 7 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Tue, 20 Mar 2018 14:41:48 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: security/general: Add section for general security features
by build bot (Jenkins) (Code Review) 20 Mar '18

20 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25297 ) Change subject: security/general: Add section for general security features ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/68825/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/23207/ : SUCCESS -- To view, visit https://review.coreboot.org/25297 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7bb63e2769c7bfd65dc9e4237300b583bd09ad3 Gerrit-Change-Number: 25297 Gerrit-PatchSet: 1 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Mar 2018 14:34:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: security/flash: Refactor flash protection logic
by build bot (Jenkins) (Code Review) 20 Mar '18

20 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25283 ) Change subject: security/flash: Refactor flash protection logic ...................................................................... Patch Set 6: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/68824/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/23206/ : SUCCESS -- To view, visit https://review.coreboot.org/25283 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic0a859e6ce9aba32278f666a38a952ec8b4c1b4d Gerrit-Change-Number: 25283 Gerrit-PatchSet: 6 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Tue, 20 Mar 2018 14:31:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: security/general: Add section for general security features
by Philipp Deppenwiese (Code Review) 20 Mar '18

20 Mar '18

Philipp Deppenwiese has uploaded this change for review. ( https://review.coreboot.org/25297 Change subject: security/general: Add section for general security features ...................................................................... security/general: Add section for general security features * Add platform lockdown support. * Add basic general security section. Change-Id: Ic7bb63e2769c7bfd65dc9e4237300b583bd09ad3 Signed-off-by: zaolin <zaolin(a)das-labor.org> --- M src/security/Kconfig M src/security/Makefile.inc A src/security/general/Kconfig A src/security/general/Makefile.inc A src/security/general/general.h A src/security/general/lockdown.c 6 files changed, 71 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/25297/1 diff --git a/src/security/Kconfig b/src/security/Kconfig index b9acf2d..7d731d9 100644 --- a/src/security/Kconfig +++ b/src/security/Kconfig @@ -12,6 +12,7 @@ ## GNU General Public License for more details. ## +source "src/security/general/Kconfig" source "src/security/vboot/Kconfig" source "src/security/tpm/Kconfig" source "src/security/crypto/Kconfig" diff --git a/src/security/Makefile.inc b/src/security/Makefile.inc index 0d126f7..6acf205 100644 --- a/src/security/Makefile.inc +++ b/src/security/Makefile.inc @@ -1,3 +1,4 @@ +subdirs-y += general subdirs-y += vboot subdirs-y += tpm subdirs-y += crypto diff --git a/src/security/general/Kconfig b/src/security/general/Kconfig new file mode 100644 index 0000000..27bac4c --- /dev/null +++ b/src/security/general/Kconfig @@ -0,0 +1,24 @@ +## This file is part of the coreboot project. +## +## Copyright (C) 2018 Facebook, Inc. +## +## This program is free software; you can redistribute it and/or modify +## it under the terms of the GNU General Public License as published by +## the Free Software Foundation; version 2 of the License. +## +## This program is distributed in the hope that it will be useful, +## but WITHOUT ANY WARRANTY; without even the implied warranty of +## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +## GNU General Public License for more details. +## + +menu "General" + +config GENERAL_PLATFORM_LOCKDOWN + bool "Platform Lockdown" + default n + help + Enable platform lockdown globally. If a platform is missing the implementation + you will be informed through the coreboot log. + +endmenu diff --git a/src/security/general/Makefile.inc b/src/security/general/Makefile.inc new file mode 100644 index 0000000..d10c2ad --- /dev/null +++ b/src/security/general/Makefile.inc @@ -0,0 +1 @@ +ramstage-$(CONFIG_GENERAL_PLATFORM_LOCKDOWN) += lockdown.c diff --git a/src/security/general/general.h b/src/security/general/general.h new file mode 100644 index 0000000..cf42b867 --- /dev/null +++ b/src/security/general/general.h @@ -0,0 +1,21 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2018 Facebook Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef GENERAL_H_ +#define GENERAL_H_ + +void platform_lockdown_setup(void *unused); + +#endif /* GENERAL_H_ */ diff --git a/src/security/general/lockdown.c b/src/security/general/lockdown.c new file mode 100644 index 0000000..dfa0969 --- /dev/null +++ b/src/security/general/lockdown.c @@ -0,0 +1,23 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2018 Facebook Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +__attribute__((weak)) void platform_lockdown_setup(void *unused) +{ + printk(BIOS_WARNING, "No platform lockdown support, please implement " + "platform_lockdown_setup(void *unused)"); +} + +BOOT_STATE_INIT_ENTRY(BS_DEV_RESOURCES, BS_ON_EXIT, platform_lockdown_setup, + NULL); -- To view, visit https://review.coreboot.org/25297 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic7bb63e2769c7bfd65dc9e4237300b583bd09ad3 Gerrit-Change-Number: 25297 Gerrit-PatchSet: 1 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>

1 0

Change in coreboot[master]: security/flash: Refactor flash protection logic
by build bot (Jenkins) (Code Review) 20 Mar '18

20 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25283 ) Change subject: security/flash: Refactor flash protection logic ...................................................................... Patch Set 5: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/68822/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/23205/ : SUCCESS -- To view, visit https://review.coreboot.org/25283 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic0a859e6ce9aba32278f666a38a952ec8b4c1b4d Gerrit-Change-Number: 25283 Gerrit-PatchSet: 5 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Tue, 20 Mar 2018 14:14:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: ifdtool: dump all PCH Straps
by build bot (Jenkins) (Code Review) 20 Mar '18

20 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25296 ) Change subject: ifdtool: dump all PCH Straps ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68823/ : SUCCESS -- To view, visit https://review.coreboot.org/25296 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56c02c00923e018bbd6a0409a08715f39b854d0a Gerrit-Change-Number: 25296 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Mar 2018 14:05:43 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: security/flash: Refactor flash protection logic
by build bot (Jenkins) (Code Review) 20 Mar '18

20 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25283 ) Change subject: security/flash: Refactor flash protection logic ...................................................................... Patch Set 4: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/68821/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/23204/ : SUCCESS -- To view, visit https://review.coreboot.org/25283 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic0a859e6ce9aba32278f666a38a952ec8b4c1b4d Gerrit-Change-Number: 25283 Gerrit-PatchSet: 4 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Tue, 20 Mar 2018 13:55:32 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: security/flash: Refactor flash protection logic
by Philipp Deppenwiese (Code Review) 20 Mar '18

20 Mar '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/25283 to look at the new patch set (#4). Change subject: security/flash: Refactor flash protection logic ...................................................................... security/flash: Refactor flash protection logic Change-Id: Ic0a859e6ce9aba32278f666a38a952ec8b4c1b4d Signed-off-by: zaolin <zaolin(a)das-labor.org> --- M src/drivers/mrc_cache/mrc_cache.c M src/drivers/spi/spi_flash.c M src/security/flash/Kconfig M src/security/flash/Makefile.inc M src/security/flash/flash.c M src/security/flash/flash.h A src/security/flash/wp.c M src/security/vboot/vboot_handoff.c 8 files changed, 165 insertions(+), 69 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/25283/4 -- To view, visit https://review.coreboot.org/25283 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic0a859e6ce9aba32278f666a38a952ec8b4c1b4d Gerrit-Change-Number: 25283 Gerrit-PatchSet: 4 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2018