coreboot-gerrit March 2018

coreboot-gerrit@coreboot.org

1 participants
1399 discussions

Change in coreboot[master]: arch/x86/smbios: Consider corner case of Part Number
by build bot (Jenkins) (Code Review) 27 Mar '18

27 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25377 ) Change subject: arch/x86/smbios: Consider corner case of Part Number ...................................................................... Patch Set 7: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/69123/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/23476/ : SUCCESS -- To view, visit https://review.coreboot.org/25377 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id870c983584771dc1b60b1c99e95bbe7c0d25c4c Gerrit-Change-Number: 25377 Gerrit-PatchSet: 7 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Raul Rangel <rrangel(a)google.com> Gerrit-Comment-Date: Tue, 27 Mar 2018 18:41:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: cpu/amd/microcode/microcode.c: Remove unneeded whitespace
by build bot (Jenkins) (Code Review) 27 Mar '18

27 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25388 ) Change subject: cpu/amd/microcode/microcode.c: Remove unneeded whitespace ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/69121/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/23474/ : SUCCESS -- To view, visit https://review.coreboot.org/25388 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6f73dc0b0d11f6b66b7dbdd33cd6785359191ab Gerrit-Change-Number: 25388 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Mar 2018 18:09:51 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/lenovo/w520: Add ThinkPad W520 support
by build bot (Jenkins) (Code Review) 27 Mar '18

27 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23564 ) Change subject: mb/lenovo/w520: Add ThinkPad W520 support ...................................................................... Patch Set 10: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/69122/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/23475/ : SUCCESS -- To view, visit https://review.coreboot.org/23564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1deb0436a807950c605dcd590deedcb3169bf8c5 Gerrit-Change-Number: 23564 Gerrit-PatchSet: 10 Gerrit-Owner: Nico Rikken <nico(a)nicorikken.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Reviewer: Nico Rikken <nico(a)nicorikken.eu> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Mar 2018 18:06:15 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: cpu/amd/microcode/microcode.c: Remove unneeded whitespace
by Elyes HAOUAS (Code Review) 27 Mar '18

27 Mar '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/25388 Change subject: cpu/amd/microcode/microcode.c: Remove unneeded whitespace ...................................................................... cpu/amd/microcode/microcode.c: Remove unneeded whitespace Change-Id: Ib6f73dc0b0d11f6b66b7dbdd33cd6785359191ab Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/cpu/amd/microcode/microcode.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/25388/1 diff --git a/src/cpu/amd/microcode/microcode.c b/src/cpu/amd/microcode/microcode.c index ec7e733..71ecc01 100644 --- a/src/cpu/amd/microcode/microcode.c +++ b/src/cpu/amd/microcode/microcode.c @@ -175,7 +175,7 @@ cur_section_hdr = c + 4 + blob_size; sec_hdr_id = read32(cur_section_hdr); - c = cur_section_hdr + 4; + c = cur_section_hdr + 4; } } -- To view, visit https://review.coreboot.org/25388 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib6f73dc0b0d11f6b66b7dbdd33cd6785359191ab Gerrit-Change-Number: 25388 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: arch/x86/smbios: Consider corner case of Part Number
by build bot (Jenkins) (Code Review) 27 Mar '18

27 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25377 ) Change subject: arch/x86/smbios: Consider corner case of Part Number ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/69120/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/23473/ : SUCCESS -- To view, visit https://review.coreboot.org/25377 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id870c983584771dc1b60b1c99e95bbe7c0d25c4c Gerrit-Change-Number: 25377 Gerrit-PatchSet: 6 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Raul Rangel <rrangel(a)google.com> Gerrit-Comment-Date: Tue, 27 Mar 2018 17:57:15 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: arch/x86/smbios: Consider corner case of Part Number
by build bot (Jenkins) (Code Review) 27 Mar '18

27 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25377 ) Change subject: arch/x86/smbios: Consider corner case of Part Number ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/69119/ : SUCCESS -- To view, visit https://review.coreboot.org/25377 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id870c983584771dc1b60b1c99e95bbe7c0d25c4c Gerrit-Change-Number: 25377 Gerrit-PatchSet: 5 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Raul Rangel <rrangel(a)google.com> Gerrit-Comment-Date: Tue, 27 Mar 2018 17:41:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/octopus: update SSP port to enable audio
by build bot (Jenkins) (Code Review) 27 Mar '18

27 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25387 ) Change subject: mb/google/octopus: update SSP port to enable audio ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/69118/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/23472/ : SUCCESS -- To view, visit https://review.coreboot.org/25387 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I101ed80f4421925120116b018424ef19d95a2a3a Gerrit-Change-Number: 25387 Gerrit-PatchSet: 1 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naveen Manohar <naveen.m(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Mar 2018 16:32:44 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/octopus: update SSP port to enable audio
by Hannah Williams (Code Review) 27 Mar '18

27 Mar '18

Hello Naveen Manohar, I'd like you to do a code review. Please visit https://review.coreboot.org/25387 to review the following change. Change subject: mb/google/octopus: update SSP port to enable audio ...................................................................... mb/google/octopus: update SSP port to enable audio Patch corrects the SSP configuration to enable audio on GLK boards. Change-Id: I101ed80f4421925120116b018424ef19d95a2a3a Signed-off-by: Naveen Manohar <naveen.m(a)intel.com> --- M src/mainboard/google/octopus/variants/baseboard/nhlt.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/25387/1 diff --git a/src/mainboard/google/octopus/variants/baseboard/nhlt.c b/src/mainboard/google/octopus/variants/baseboard/nhlt.c index 7439b73..c936198 100644 --- a/src/mainboard/google/octopus/variants/baseboard/nhlt.c +++ b/src/mainboard/google/octopus/variants/baseboard/nhlt.c @@ -28,10 +28,10 @@ * Headset codec is bi-directional but uses the same configuration * settings for render and capture endpoints. */ - if (!nhlt_soc_add_da7219(nhlt, AUDIO_LINK_SSP1)) + if (!nhlt_soc_add_da7219(nhlt, AUDIO_LINK_SSP2)) printk(BIOS_ERR, "Added Dialog_7219 codec.\n"); /* MAXIM Smart Amps for left and right speakers. */ - if (!nhlt_soc_add_max98357(nhlt, AUDIO_LINK_SSP5)) + if (!nhlt_soc_add_max98357(nhlt, AUDIO_LINK_SSP1)) printk(BIOS_ERR, "Added Maxim_98357 codec.\n"); } -- To view, visit https://review.coreboot.org/25387 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I101ed80f4421925120116b018424ef19d95a2a3a Gerrit-Change-Number: 25387 Gerrit-PatchSet: 1 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Naveen Manohar <naveen.m(a)intel.com>

1 0

Change in coreboot[master]: mb/google/kahlee: Fix IRQ routing
by build bot (Jenkins) (Code Review) 27 Mar '18

27 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25107 ) Change subject: mb/google/kahlee: Fix IRQ routing ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/69117/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/23471/ : SUCCESS -- To view, visit https://review.coreboot.org/25107 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb048d3e728dc562cb31b9ddd50bfd8fb032017e Gerrit-Change-Number: 25107 Gerrit-PatchSet: 8 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Mar 2018 15:00:07 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/hp: Add new port compaq_8200_elite_sff
by build bot (Jenkins) (Code Review) 27 Mar '18

27 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25385 ) Change subject: mb/hp: Add new port compaq_8200_elite_sff ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/69115/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/23469/ : SUCCESS -- To view, visit https://review.coreboot.org/25385 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ee8da6349222fda8b6c30a7210ffdd65c183439 Gerrit-Change-Number: 25385 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Mar 2018 14:53:29 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2018