coreboot-gerrit March 2018

coreboot-gerrit@coreboot.org

1 participants
1399 discussions

Change in coreboot[master]: mb/google/nautilus: Correct LINK FREQ of imx258 sensor
by Andy Yeh (Code Review) 05 Mar '18

05 Mar '18

Hello Naresh Solanki, Rajmohan Mani, Rizwan Qureshi, build bot (Jenkins), Martin Roth, Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/24990 to look at the new patch set (#2). Change subject: mb/google/nautilus: Correct LINK FREQ of imx258 sensor ...................................................................... mb/google/nautilus: Correct LINK FREQ of imx258 sensor Per vendor datasheet, corrected linkfreq of imx258 as {650000000, 325000000} BUG=None BRANCH=None TEST=Verified the MIPI and USB camera function on DUT board Change-Id: Ie5beed44c15e26b9f82cb305a91b8ff90a9ea867 Signed-off-by: Andy Yeh <andy.yeh(a)intel.com> --- M src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/24990/2 -- To view, visit https://review.coreboot.org/24990 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie5beed44c15e26b9f82cb305a91b8ff90a9ea867 Gerrit-Change-Number: 24990 Gerrit-PatchSet: 2 Gerrit-Owner: Andy Yeh <andy.yeh(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/nautilus: Correct LINK FREQ for imx258
by build bot (Jenkins) (Code Review) 05 Mar '18

05 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24990 ) Change subject: mb/google/nautilus: Correct LINK FREQ for imx258 ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22667/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68220/ : SUCCESS -- To view, visit https://review.coreboot.org/24990 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie5beed44c15e26b9f82cb305a91b8ff90a9ea867 Gerrit-Change-Number: 24990 Gerrit-PatchSet: 1 Gerrit-Owner: Andy Yeh <andy.yeh(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 05 Mar 2018 05:49:58 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/nautilus: Correct LINK FREQ for imx258
by Andy Yeh (Code Review) 05 Mar '18

05 Mar '18

Andy Yeh has uploaded this change for review. ( https://review.coreboot.org/24990 Change subject: mb/google/nautilus: Correct LINK FREQ for imx258 ...................................................................... mb/google/nautilus: Correct LINK FREQ for imx258 Per vendor datasheet, correct linkfreq for imx258 to {650000000, 325000000} BUG=None BRANCH=None TEST=Verified the MIPI and USB camera function on DUT board Change-Id: Ie5beed44c15e26b9f82cb305a91b8ff90a9ea867 Signed-off-by: Andy Yeh <andy.yeh(a)intel.com> --- M src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/24990/1 diff --git a/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl b/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl index ee1c811..6ac6e5f 100644 --- a/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl +++ b/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl @@ -74,7 +74,7 @@ Package () { 1, 2, 3, 4 } }, Package () { "link-frequencies", - Package() { 540000000, 270000000 } + Package() { 650000000, 325000000 } }, Package () { "remote-endpoint", Package() { \_SB.PCI0.CIO2, 0, 0 } -- To view, visit https://review.coreboot.org/24990 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie5beed44c15e26b9f82cb305a91b8ff90a9ea867 Gerrit-Change-Number: 24990 Gerrit-PatchSet: 1 Gerrit-Owner: Andy Yeh <andy.yeh(a)intel.com>

1 0

Change in coreboot[master]: mb/google/nautilus: Configure PLL reference clock for 24 MHz OSC input
by build bot (Jenkins) (Code Review) 05 Mar '18

05 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24910 ) Change subject: mb/google/nautilus: Configure PLL reference clock for 24 MHz OSC input ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68219/ : SUCCESS -- To view, visit https://review.coreboot.org/24910 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia93bee1fc07434c13a5fa4227e100ddaff2de74a Gerrit-Change-Number: 24910 Gerrit-PatchSet: 4 Gerrit-Owner: Andy Yeh <andy.yeh(a)intel.corp-partner.google.com> Gerrit-Reviewer: Andy Yeh Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 05 Mar 2018 05:03:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: WIP / lib: Add blob_provider interface
by build bot (Jenkins) (Code Review) 05 Mar '18

05 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24942 ) Change subject: WIP / lib: Add blob_provider interface ...................................................................... Patch Set 11: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22666/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68218/ : SUCCESS -- To view, visit https://review.coreboot.org/24942 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f161f680cb36fa6481a8bce6cf233263a828bf7 Gerrit-Change-Number: 24942 Gerrit-PatchSet: 11 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 05 Mar 2018 01:26:27 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: security/vboot: Make vboot first class citizen
by build bot (Jenkins) (Code Review) 05 Mar '18

05 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23873 ) Change subject: security/vboot: Make vboot first class citizen ...................................................................... Patch Set 6: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22663/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68215/ : SUCCESS -- To view, visit https://review.coreboot.org/23873 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1ac6db16647eba4ddb28b74d1e0501224c841df Gerrit-Change-Number: 23873 Gerrit-PatchSet: 6 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 05 Mar 2018 01:23:33 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: WIP / lib: Add blob_provider interface
by build bot (Jenkins) (Code Review) 05 Mar '18

05 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24942 ) Change subject: WIP / lib: Add blob_provider interface ...................................................................... Patch Set 10: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/68217/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/22665/ : SUCCESS -- To view, visit https://review.coreboot.org/24942 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f161f680cb36fa6481a8bce6cf233263a828bf7 Gerrit-Change-Number: 24942 Gerrit-PatchSet: 10 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 05 Mar 2018 01:20:50 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: WIP / lib: Add blob_provider interface
by build bot (Jenkins) (Code Review) 05 Mar '18

05 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24942 ) Change subject: WIP / lib: Add blob_provider interface ...................................................................... Patch Set 9: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22664/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68216/ : SUCCESS -- To view, visit https://review.coreboot.org/24942 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f161f680cb36fa6481a8bce6cf233263a828bf7 Gerrit-Change-Number: 24942 Gerrit-PatchSet: 9 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 05 Mar 2018 01:02:23 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: WIP / lib: Add blob_provider interface
by Philipp Deppenwiese (Code Review) 05 Mar '18

05 Mar '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/24942 ) Change subject: WIP / lib: Add blob_provider interface ...................................................................... Patch Set 9: (15 comments) https://review.coreboot.org/#/c/24942/3/src/include/blob_provider.h File src/include/blob_provider.h: https://review.coreboot.org/#/c/24942/3/src/include/blob_provider.h@29 PS3, Line 29: > why can't we just use struct blob_locator? What do we gain from typedef'ing aside from not writing ' […] Done https://review.coreboot.org/#/c/24942/3/src/include/blob_provider.h@48 PS3, Line 48: ID_DATA_NVRAM_VPD_RO_REGION = 17, > put DATA_CODE_SPLIT in here? Done https://review.coreboot.org/#/c/24942/3/src/include/blob_provider.h@234 PS3, Line 234: ******* > What's the purpose of the fixed width return type? And what are the expected return value? Done https://review.coreboot.org/#/c/24942/3/src/include/blob_provider.h@238 PS3, Line 238: > same question as above Done https://review.coreboot.org/#/c/24942/3/src/include/blob_provider.h@242 PS3, Line 242: > cli means what? Done https://review.coreboot.org/#/c/24942/3/src/lib/blob_provider.c File src/lib/blob_provider.c: https://review.coreboot.org/#/c/24942/3/src/lib/blob_provider.c@27 PS3, Line 27: > Why are we passing a full object instead of just a const pointer? Done https://review.coreboot.org/#/c/24942/3/src/lib/blob_provider.c@30 PS3, Line 30: > this is a weird name -- all caps and also not just cbfs. Done https://review.coreboot.org/#/c/24942/3/src/lib/blob_provider.c@45 PS3, Line 45: 0) { > Why are we specifying policy on location based on id? […] Done https://review.coreboot.org/#/c/24942/3/src/lib/blob_provider.c@80 PS3, Line 80: } > Is there a reason to explode out all parameters? Why not jus tpass struct blob_locator? Done https://review.coreboot.org/#/c/24942/3/src/lib/blob_provider.c@87 PS3, Line 87: > What's this mean? Done https://review.coreboot.org/#/c/24942/3/src/lib/blob_provider.c@87 PS3, Line 87: > this is true only for x86 Done https://review.coreboot.org/#/c/24942/3/src/lib/blob_provider.c@88 PS3, Line 88: *size = region_device_sz(&data); > So we do mmap_full then munmap to make the hook read things? Done https://review.coreboot.org/#/c/24942/3/src/lib/blob_provider.c@94 PS3, Line 94: ev > What does rd stand for? Done https://review.coreboot.org/#/c/24942/3/src/lib/blob_provider.c@104 PS3, Line 104: printk(BIOS_ERR, "Can't use auto mmap function on code blob."); > ? Done https://review.coreboot.org/#/c/24942/3/src/lib/coreboot_table.c File src/lib/coreboot_table.c: https://review.coreboot.org/#/c/24942/3/src/lib/coreboot_table.c@511 PS3, Line 511: blob_read_map(BLOB_DATA_NVRAM_CMOS_LAYOUT, NULL); > this should really be turned into a read. Done -- To view, visit https://review.coreboot.org/24942 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f161f680cb36fa6481a8bce6cf233263a828bf7 Gerrit-Change-Number: 24942 Gerrit-PatchSet: 9 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 05 Mar 2018 00:58:49 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: WIP / lib: Add blob_provider interface
by build bot (Jenkins) (Code Review) 05 Mar '18

05 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24942 ) Change subject: WIP / lib: Add blob_provider interface ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22662/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68214/ : SUCCESS -- To view, visit https://review.coreboot.org/24942 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f161f680cb36fa6481a8bce6cf233263a828bf7 Gerrit-Change-Number: 24942 Gerrit-PatchSet: 8 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 05 Mar 2018 00:51:18 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2018