February 2018 - coreboot-gerrit

Change in coreboot[master]: mb/intel/glkrvp: Configure PERST GPIO for PCIE WiFi card
by Roy Mingi Park (Code Review) Feb. 27, 2018

Feb. 27, 2018

Hello Srinidhi N Kaushik, Shamile Khan, Bora Guvendik, build bot (Jenkins), Hannah Williams, I'd like you to reexamine a change. Please visit https://review.coreboot.org/24909 to look at the new patch set (#2). Change subject: mb/intel/glkrvp: Configure PERST GPIO for PCIE WiFi card ...................................................................... mb/intel/glkrvp: Configure PERST GPIO for PCIE WiFi card PERST signal is required for WiFi. When the system resumes from S0ix, WiFi will come out of D3 correctly. Change-Id: Ic594c5a088af79079a8742f5287ed66dcc0ff067 Signed-off-by: Roy Mingi Park <roy.mingi.park(a)intel.com> --- M src/mainboard/intel/glkrvp/variants/baseboard/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/24909/2 -- To view, visit https://review.coreboot.org/24909 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic594c5a088af79079a8742f5287ed66dcc0ff067 Gerrit-Change-Number: 24909 Gerrit-PatchSet: 2 Gerrit-Owner: Roy Mingi Park <roy.mingi.park(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: security/tpm: Implement hashing function in TSS
by build bot (Jenkins) (Code Review) Feb. 27, 2018

Feb. 27, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24908 ) Change subject: security/tpm: Implement hashing function in TSS ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68021/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22496/ : SUCCESS -- To view, visit https://review.coreboot.org/24908 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c570a6725ff2f26c9d480303eff273ae9d5ac3b Gerrit-Change-Number: 24908 Gerrit-PatchSet: 3 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Feb 2018 23:27:46 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: drivers/tpm: Add TPM ramstage driver for devices without vboot.
by build bot (Jenkins) (Code Review) Feb. 27, 2018

Feb. 27, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24905 ) Change subject: drivers/tpm: Add TPM ramstage driver for devices without vboot. ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68019/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22494/ : SUCCESS -- To view, visit https://review.coreboot.org/24905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7536c9734732aeaa85ccc7916c12eecb9ca26b2e Gerrit-Change-Number: 24905 Gerrit-PatchSet: 5 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Feb 2018 23:27:28 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: security/tpm: Implement hashing function in TSS
by build bot (Jenkins) (Code Review) Feb. 27, 2018

Feb. 27, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24908 ) Change subject: security/tpm: Implement hashing function in TSS ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/68020/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/22495/ : SUCCESS -- To view, visit https://review.coreboot.org/24908 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c570a6725ff2f26c9d480303eff273ae9d5ac3b Gerrit-Change-Number: 24908 Gerrit-PatchSet: 2 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Feb 2018 23:23:33 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: security/vboot: Add interface for FSP 2.0 mrc caching
by build bot (Jenkins) (Code Review) Feb. 27, 2018

Feb. 27, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24904 ) Change subject: security/vboot: Add interface for FSP 2.0 mrc caching ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68017/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22492/ : SUCCESS -- To view, visit https://review.coreboot.org/24904 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41a458186c7981adaf3fea8974adec2ca8668f14 Gerrit-Change-Number: 24904 Gerrit-PatchSet: 4 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Feb 2018 23:20:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: drivers/tpm: Add TPM ramstage driver for devices without vboot.
by build bot (Jenkins) (Code Review) Feb. 27, 2018

Feb. 27, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24905 ) Change subject: drivers/tpm: Add TPM ramstage driver for devices without vboot. ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68018/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22493/ : SUCCESS -- To view, visit https://review.coreboot.org/24905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7536c9734732aeaa85ccc7916c12eecb9ca26b2e Gerrit-Change-Number: 24905 Gerrit-PatchSet: 4 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Feb 2018 23:18:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src/mainboard/intel: Configure PERST GPIO for PCIE WiFi card
by Furquan Shaikh (Code Review) Feb. 27, 2018

Feb. 27, 2018

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/24909 ) Change subject: src/mainboard/intel: Configure PERST GPIO for PCIE WiFi card ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/#/c/24909/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/24909/1//COMMIT_MSG@7 PS1, Line 7: src/mainboard/intel mb/intel/glkrvp https://review.coreboot.org/#/c/24909/1/src/mainboard/intel/glkrvp/variants… File src/mainboard/intel/glkrvp/variants/baseboard/gpio.c: https://review.coreboot.org/#/c/24909/1/src/mainboard/intel/glkrvp/variants… PS1, Line 198: GPIO_163 Is there an external pull-up on this? Else, you might want to do this configuration early in bootblock. -- To view, visit https://review.coreboot.org/24909 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic594c5a088af79079a8742f5287ed66dcc0ff067 Gerrit-Change-Number: 24909 Gerrit-PatchSet: 1 Gerrit-Owner: Roy Mingi Park <roy.mingi.park(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-Comment-Date: Tue, 27 Feb 2018 23:09:40 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: src/mainboard/intel: Configure PERST GPIO for PCIE WiFi card
by build bot (Jenkins) (Code Review) Feb. 27, 2018

Feb. 27, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24909 ) Change subject: src/mainboard/intel: Configure PERST GPIO for PCIE WiFi card ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68016/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22491/ : SUCCESS -- To view, visit https://review.coreboot.org/24909 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic594c5a088af79079a8742f5287ed66dcc0ff067 Gerrit-Change-Number: 24909 Gerrit-PatchSet: 1 Gerrit-Owner: Roy Mingi Park <roy.mingi.park(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Feb 2018 23:08:35 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src/mainboard/intel: Configure PERST GPIO for PCIE WiFi card
by Roy Mingi Park (Code Review) Feb. 27, 2018

Feb. 27, 2018

Roy Mingi Park has uploaded this change for review. ( https://review.coreboot.org/24909 Change subject: src/mainboard/intel: Configure PERST GPIO for PCIE WiFi card ...................................................................... src/mainboard/intel: Configure PERST GPIO for PCIE WiFi card PERST signal is required for WiFi. When the system resumes from S0ix, WiFi will come out of D3 correctly. Change-Id: Ic594c5a088af79079a8742f5287ed66dcc0ff067 Signed-off-by: Roy Mingi Park <roy.mingi.park(a)intel.com> --- M src/mainboard/intel/glkrvp/variants/baseboard/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/24909/1 diff --git a/src/mainboard/intel/glkrvp/variants/baseboard/gpio.c b/src/mainboard/intel/glkrvp/variants/baseboard/gpio.c index 0646bcf..6ea7e4c 100644 --- a/src/mainboard/intel/glkrvp/variants/baseboard/gpio.c +++ b/src/mainboard/intel/glkrvp/variants/baseboard/gpio.c @@ -195,7 +195,7 @@ PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_160, 0, DEEP, UP_20K, IGNORE, SAME),/*SD_MODE for spk*/ PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_161, 1, DEEP, UP_20K, IGNORE, SAME),/*Touch panel reset*/ PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_162, DN_20K, DEEP, NF1, HIZCRx1, SAME),/*AVS_I2S1_BCLK*/ - PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_163, DN_20K, DEEP, NF1, HIZCRx1, SAME),/*AVS_I2S1_WS_SYNC*/ + PAD_CFG_GPO(GPIO_163, 1, DEEP),/*WIFI RST*/ PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_164, 1, DEEP, UP_20K, TxDRxE, ENPD),/*Touch Panel Power Enable*/ PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_165, DN_20K, DEEP, NF1, HIZCRx1, SAME),/*AVS_I2S1_SDO*/ -- To view, visit https://review.coreboot.org/24909 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic594c5a088af79079a8742f5287ed66dcc0ff067 Gerrit-Change-Number: 24909 Gerrit-PatchSet: 1 Gerrit-Owner: Roy Mingi Park <roy.mingi.park(a)intel.com>

1 0

Change in coreboot[master]: mb/google/octopus: Add gpio configs for communities
by build bot (Jenkins) (Code Review) Feb. 27, 2018

Feb. 27, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23799 ) Change subject: mb/google/octopus: Add gpio configs for communities ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68015/ : SUCCESS -- To view, visit https://review.coreboot.org/23799 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc16edd96f4ef6d55f3a99b195bf4920929b1578 Gerrit-Change-Number: 23799 Gerrit-PatchSet: 8 Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Feb 2018 22:58:26 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0