Julien Viard de Galbert has uploaded this change for review. ( https://review.coreboot.org/24911
Change subject: mb/scaleway/tagada: set SMBIOS Enclosure Type in Kconfig.
......................................................................
mb/scaleway/tagada: set SMBIOS Enclosure Type in Kconfig.
Change-Id: I7acffcf3fc36742c77ce00b253f5b0a68d435798
Signed-off-by: Julien Viard de Galbert <jviarddegalbert(a)online.net>
---
M src/mainboard/scaleway/tagada/Kconfig
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/24911/1
diff --git a/src/mainboard/scaleway/tagada/Kconfig b/src/mainboard/scaleway/tagada/Kconfig
index 53c1f6d..b0a52c2 100644
--- a/src/mainboard/scaleway/tagada/Kconfig
+++ b/src/mainboard/scaleway/tagada/Kconfig
@@ -2,6 +2,7 @@
## This file is part of the coreboot project.
##
## Copyright (C) 2014 - 2017 Intel Corporation.
+## Copyright (C) 2017 - 2018 Online SAS.
##
## This program is free software; you can redistribute it and/or modify
## it under the terms of the GNU General Public License as published by
@@ -33,4 +34,8 @@
string
default "Scaleway"
+config SMBIOS_ENCLOSURE_TYPE
+ hex
+ default 0x19
+
endif # BOARD_SCALEWAY_TAGADA
--
To view, visit https://review.coreboot.org/24911
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7acffcf3fc36742c77ce00b253f5b0a68d435798
Gerrit-Change-Number: 24911
Gerrit-PatchSet: 1
Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert(a)online.net>
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24910 )
Change subject: mb/google/nautilus: Modify the XTDV = 210 due to different OSC from Poppy
......................................................................
Patch Set 1: Verified+1
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/68042/ : SUCCESS
https://qa.coreboot.org/job/coreboot-checkpatch/22512/ : SUCCESS
--
To view, visit https://review.coreboot.org/24910
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia93bee1fc07434c13a5fa4227e100ddaff2de74a
Gerrit-Change-Number: 24910
Gerrit-PatchSet: 1
Gerrit-Owner: Andy Yeh <andy.yeh(a)intel.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 28 Feb 2018 09:38:56 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Andy Yeh has uploaded this change for review. ( https://review.coreboot.org/24910
Change subject: mb/google/nautilus: Modify the XTDV = 210 due to different OSC from Poppy
......................................................................
mb/google/nautilus: Modify the XTDV = 210 due to different OSC from Poppy
It is to change MCLK output in 19.2Mhz (currently 23.04Mhz) because
nautilus uses different OSC for TI PMIC.
According to PMIC datasheet (tps68470), the MCLK for camera depends on
the frequency of OSC. In poppy, the frequency of OSC is 20 MHz, the
PLL_REF_CLK = 20M / [XTDV (170) + 30] = 100kHz.
If we want to keep the PLL_REF_CLK in nautilus with 24 MHz OSC, we
should change XDTV to 210.
BUG=b:73987684
TEST: Verified the MIPI camera fps on DUT board.
TODO: If OEM will fix OSC on next build. This patch could be reverted.
Change-Id: Ia93bee1fc07434c13a5fa4227e100ddaff2de74a
Signed-off-by: Andy Yeh <andy.yeh(a)intel.com>
---
M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/24910/1
diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl
index b74fba9..3210da1d 100644
--- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl
+++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl
@@ -354,7 +354,13 @@
/* Set the PLL_REF_CLK cyles */
PSWR = 19
/* Set the reference crystal divider */
+ /* SW Workaround to generate 19.2Mhz
+ MCLK on Nautilus */
+#if IS_ENABLED(CONFIG_BOARD_GOOGLE_NAUTILUS)
+ XTDV = 210
+#else
XTDV = 170
+#endif
/* Set PLL feedback divider */
PLDV = 32
/* Set PLL output divider for HCLK_A */
--
To view, visit https://review.coreboot.org/24910
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia93bee1fc07434c13a5fa4227e100ddaff2de74a
Gerrit-Change-Number: 24910
Gerrit-PatchSet: 1
Gerrit-Owner: Andy Yeh <andy.yeh(a)intel.corp-partner.google.com>