February 2018 - coreboot-gerrit

Change in coreboot[master]: ec/google/chromeec: Add note before error message
by Martin Roth (Code Review) Feb. 28, 2018

Feb. 28, 2018

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/24914 Change subject: ec/google/chromeec: Add note before error message ...................................................................... ec/google/chromeec: Add note before error message When clearing events from the EC, an error is returned when we try to clear an event that doesn't exist. This is normal, but can be distracting when trying to track down an error, so add a message saying that the error is expected. BUG=None Test=Build Grunt with SMM debug enabled. See message before "EC returned error result code 1". Change-Id: Ib2e684e357e821c795de4b59658432c91a8d63fc Signed-off-by: Martin Roth <martinroth(a)google.com> --- M src/ec/google/chromeec/smihandler.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/24914/1 diff --git a/src/ec/google/chromeec/smihandler.c b/src/ec/google/chromeec/smihandler.c index 54aa4bf..cab7192 100644 --- a/src/ec/google/chromeec/smihandler.c +++ b/src/ec/google/chromeec/smihandler.c @@ -53,6 +53,7 @@ while (google_chromeec_get_event() != 0) ; + printk(BIOS_DEBUG,"Clearing pending EC events. Error code 1 is expected.\n"); while (google_chromeec_get_mkbp_event(&mkbp_event) == 0) ; } -- To view, visit https://review.coreboot.org/24914 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib2e684e357e821c795de4b59658432c91a8d63fc Gerrit-Change-Number: 24914 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Enable elan touchscreen
by Martin Roth (Code Review) Feb. 28, 2018

Feb. 28, 2018

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/23872 ) Change subject: mb/google/poppy/variants/nami: Enable elan touchscreen ...................................................................... mb/google/poppy/variants/nami: Enable elan touchscreen BUG=b:72062694 BRANCH=master TEST=Verify touchscreen on nami works with this change. Change-Id: Iaec71a11121b3d2849f12d18cda0e506be2ace09 Signed-off-by: Crystal Lin <crystal_lin(a)compal.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/23872 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Furquan Shaikh <furquan(a)google.com> --- M src/mainboard/google/poppy/variants/nami/devicetree.cb 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved diff --git a/src/mainboard/google/poppy/variants/nami/devicetree.cb b/src/mainboard/google/poppy/variants/nami/devicetree.cb index b830912..c4aabcf 100644 --- a/src/mainboard/google/poppy/variants/nami/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nami/devicetree.cb @@ -243,7 +243,20 @@ device pci 14.0 on end # USB xHCI device pci 14.1 off end # USB xDCI (OTG) device pci 14.2 on end # Thermal Subsystem - device pci 15.0 on end # I2C #0 + device pci 15.0 on + chip drivers/i2c/generic + register "hid" = ""ELAN0001"" + register "desc" = ""ELAN Touchscreen"" + register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_E7_IRQ)" + register "probed" = "1" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_B3)" + register "reset_delay_ms" = "20" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C22)" + register "enable_delay_ms" = "1" + register "has_power_resource" = "1" + device i2c 10 on end + end + end # I2C #0 device pci 15.1 on chip drivers/i2c/generic register "hid" = ""ELAN0000"" -- To view, visit https://review.coreboot.org/23872 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iaec71a11121b3d2849f12d18cda0e506be2ace09 Gerrit-Change-Number: 23872 Gerrit-PatchSet: 3 Gerrit-Owner: Crystal Lin <crystal_lin(a)compal.corp-partner.google.com> Gerrit-Reviewer: Crystal Lin <crystal_lin(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jimmy M Wang <jimmym_wang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: util/cbfstool: Add ARM64 Image support
by build bot (Jenkins) (Code Review) Feb. 28, 2018

Feb. 28, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23869 ) Change subject: util/cbfstool: Add ARM64 Image support ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68064/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22532/ : SUCCESS -- To view, visit https://review.coreboot.org/23869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a8183a87de4dc3a4c4f038fe5b4912ada5d75f9 Gerrit-Change-Number: 23869 Gerrit-PatchSet: 6 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 28 Feb 2018 16:53:34 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: security/vboot: Make vboot first class citizen
by build bot (Jenkins) (Code Review) Feb. 28, 2018

Feb. 28, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23873 ) Change subject: security/vboot: Make vboot first class citizen ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68063/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22531/ : SUCCESS -- To view, visit https://review.coreboot.org/23873 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1ac6db16647eba4ddb28b74d1e0501224c841df Gerrit-Change-Number: 23873 Gerrit-PatchSet: 5 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 28 Feb 2018 16:26:30 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: security/vboot: Add boot mode selection
by build bot (Jenkins) (Code Review) Feb. 28, 2018

Feb. 28, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23756 ) Change subject: security/vboot: Add boot mode selection ...................................................................... Patch Set 23: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68062/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22530/ : SUCCESS -- To view, visit https://review.coreboot.org/23756 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43d233d5a8766af2dd7f07cc0b64293a80d5d7d2 Gerrit-Change-Number: 23756 Gerrit-PatchSet: 23 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 28 Feb 2018 16:19:42 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: drivers/i2c: Add i2c TPM support for different stages
by build bot (Jenkins) (Code Review) Feb. 28, 2018

Feb. 28, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23759 ) Change subject: drivers/i2c: Add i2c TPM support for different stages ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68060/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22528/ : SUCCESS -- To view, visit https://review.coreboot.org/23759 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib0839933f8b59f0c87cdda4e5374828bd6f1099f Gerrit-Change-Number: 23759 Gerrit-PatchSet: 7 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 28 Feb 2018 16:01:26 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/broadcom/cygnus: Increase romstage SRAM size in memlayout
by build bot (Jenkins) (Code Review) Feb. 28, 2018

Feb. 28, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23764 ) Change subject: soc/broadcom/cygnus: Increase romstage SRAM size in memlayout ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68061/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22529/ : SUCCESS -- To view, visit https://review.coreboot.org/23764 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5bbdf19cc886103e9e7a6b75219d6881cfe9c757 Gerrit-Change-Number: 23764 Gerrit-PatchSet: 3 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 28 Feb 2018 16:00:01 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: security/tpm: Add SW hash functions for measurements
by build bot (Jenkins) (Code Review) Feb. 28, 2018

Feb. 28, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23711 ) Change subject: security/tpm: Add SW hash functions for measurements ...................................................................... Patch Set 9: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68059/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22527/ : SUCCESS -- To view, visit https://review.coreboot.org/23711 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice8a0de0294fe619ff725dc5126319fc2bc657ad Gerrit-Change-Number: 23711 Gerrit-PatchSet: 9 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 28 Feb 2018 15:50:18 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/cbfstool: Add ARM64 Image support
by build bot (Jenkins) (Code Review) Feb. 28, 2018

Feb. 28, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23869 ) Change subject: util/cbfstool: Add ARM64 Image support ...................................................................... Patch Set 5: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/68054/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/22523/ : SUCCESS -- To view, visit https://review.coreboot.org/23869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a8183a87de4dc3a4c4f038fe5b4912ada5d75f9 Gerrit-Change-Number: 23869 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 28 Feb 2018 13:23:16 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/scaleway/tagada: Set DIMM slot information from mainboard
by build bot (Jenkins) (Code Review) Feb. 28, 2018

Feb. 28, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24912 ) Change subject: mb/scaleway/tagada: Set DIMM slot information from mainboard ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68053/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22522/ : SUCCESS -- To view, visit https://review.coreboot.org/24912 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6fdf3520da62336a5c654575ed8d1f33eb4f4dc5 Gerrit-Change-Number: 24912 Gerrit-PatchSet: 1 Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert(a)online.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 28 Feb 2018 13:18:55 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0