Julien Viard de Galbert has uploaded this change for review. ( https://review.coreboot.org/24912
Change subject: mb/scaleway/tagada: Set DIMM slot information from mainboard
......................................................................
mb/scaleway/tagada: Set DIMM slot information from mainboard
This field is not provided by the soc code so adding it.
Change-Id: I6fdf3520da62336a5c654575ed8d1f33eb4f4dc5
Signed-off-by: Julien Viard de Galbert <jviarddegalbert(a)online.net>
---
M src/mainboard/scaleway/tagada/ramstage.c
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/24912/1
diff --git a/src/mainboard/scaleway/tagada/ramstage.c b/src/mainboard/scaleway/tagada/ramstage.c
index 0aa6f13..539e67f 100644
--- a/src/mainboard/scaleway/tagada/ramstage.c
+++ b/src/mainboard/scaleway/tagada/ramstage.c
@@ -18,9 +18,19 @@
#include <console/console.h>
#include <fsp/api.h>
#include <soc/ramstage.h>
+#include <spd.h>
void mainboard_silicon_init_params(FSPS_UPD *params)
{
/* Disable eMMC */
params->FspsConfig.PcdEnableEmmc = 0;
}
+
+/* Add any mainboard specific information for dimm */
+void mainboard_add_dimm_info(
+ struct memory_info *mem_info,
+ int channel, int dimm, int index)
+{
+ /* Mainboard only has DDR4 DIMM slots */
+ mem_info->dimm[index].mod_type = SPD_UDIMM;
+}
--
To view, visit https://review.coreboot.org/24912
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6fdf3520da62336a5c654575ed8d1f33eb4f4dc5
Gerrit-Change-Number: 24912
Gerrit-PatchSet: 1
Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert(a)online.net>
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24911 )
Change subject: mb/scaleway/tagada: set SMBIOS Enclosure Type in Kconfig
......................................................................
Patch Set 3:
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/68051/ : SUCCESS
https://qa.coreboot.org/job/coreboot-checkpatch/22520/ : SUCCESS
--
To view, visit https://review.coreboot.org/24911
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7acffcf3fc36742c77ce00b253f5b0a68d435798
Gerrit-Change-Number: 24911
Gerrit-PatchSet: 3
Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert(a)online.net>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 28 Feb 2018 13:00:33 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23869 )
Change subject: util/cbfstool: Add ARM64 Image support
......................................................................
Patch Set 4:
Build Unstable
https://qa.coreboot.org/job/coreboot-gerrit/68049/ : UNSTABLE
--
To view, visit https://review.coreboot.org/23869
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a8183a87de4dc3a4c4f038fe5b4912ada5d75f9
Gerrit-Change-Number: 23869
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 28 Feb 2018 12:17:10 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23869 )
Change subject: util/cbfstool: Add ARM64 Image support
......................................................................
Patch Set 3: Verified-1
Build Failed
https://qa.coreboot.org/job/coreboot-gerrit/68046/ : FAILURE
https://qa.coreboot.org/job/coreboot-checkpatch/22516/ : SUCCESS
--
To view, visit https://review.coreboot.org/23869
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a8183a87de4dc3a4c4f038fe5b4912ada5d75f9
Gerrit-Change-Number: 23869
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 28 Feb 2018 11:06:53 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes