build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22831 )
Change subject: security/tpm: Add TPM_PCRRead function to the TSS
......................................................................
Patch Set 13:
Build Failed
https://qa.coreboot.org/job/coreboot-gerrit/68025/ : ABORTED
https://qa.coreboot.org/job/coreboot-checkpatch/22498/ : SUCCESS
--
To view, visit https://review.coreboot.org/22831
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic85517a8a69f352a02d20a67fbba3d910ef03a1c
Gerrit-Change-Number: 22831
Gerrit-PatchSet: 13
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 28 Feb 2018 01:26:50 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
Roy Mingi Park has posted comments on this change. ( https://review.coreboot.org/24909 )
Change subject: mb/intel/glkrvp: Configure PERST GPIO for PCIE WiFi card
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/24909/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/24909/1//COMMIT_MSG@7
PS1, Line 7: src/mainboard/intel
> mb/intel/glkrvp
Done
--
To view, visit https://review.coreboot.org/24909
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic594c5a088af79079a8742f5287ed66dcc0ff067
Gerrit-Change-Number: 24909
Gerrit-PatchSet: 1
Gerrit-Owner: Roy Mingi Park <roy.mingi.park(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Roy Mingi Park <roy.mingi.park(a)intel.com>
Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com>
Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 27 Feb 2018 23:43:45 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Srinidhi N Kaushik has removed a vote on this change.
Change subject: mb/intel/glkrvp: Configure PERST GPIO for PCIE WiFi card
......................................................................
Removed Code-Review+1 by Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
--
To view, visit https://review.coreboot.org/24909
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ic594c5a088af79079a8742f5287ed66dcc0ff067
Gerrit-Change-Number: 24909
Gerrit-PatchSet: 2
Gerrit-Owner: Roy Mingi Park <roy.mingi.park(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com>
Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Furquan Shaikh has removed a vote on this change.
Change subject: mb/intel/glkrvp: Configure PERST GPIO for PCIE WiFi card
......................................................................
Removed Code-Review+2 by Furquan Shaikh <furquan(a)google.com>
--
To view, visit https://review.coreboot.org/24909
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ic594c5a088af79079a8742f5287ed66dcc0ff067
Gerrit-Change-Number: 24909
Gerrit-PatchSet: 2
Gerrit-Owner: Roy Mingi Park <roy.mingi.park(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com>
Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Hannah Williams has posted comments on this change. ( https://review.coreboot.org/24909 )
Change subject: mb/intel/glkrvp: Configure PERST GPIO for PCIE WiFi card
......................................................................
Patch Set 2:
This GPIO has a conflict with a audio gpio - so let's not merge this for glkrvp
--
To view, visit https://review.coreboot.org/24909
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic594c5a088af79079a8742f5287ed66dcc0ff067
Gerrit-Change-Number: 24909
Gerrit-PatchSet: 2
Gerrit-Owner: Roy Mingi Park <roy.mingi.park(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com>
Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 27 Feb 2018 23:40:23 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
Srinidhi N Kaushik has posted comments on this change. ( https://review.coreboot.org/24909 )
Change subject: mb/intel/glkrvp: Configure PERST GPIO for PCIE WiFi card
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/24909
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic594c5a088af79079a8742f5287ed66dcc0ff067
Gerrit-Change-Number: 24909
Gerrit-PatchSet: 2
Gerrit-Owner: Roy Mingi Park <roy.mingi.park(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com>
Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 27 Feb 2018 23:39:50 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/24909 )
Change subject: mb/intel/glkrvp: Configure PERST GPIO for PCIE WiFi card
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/24909
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic594c5a088af79079a8742f5287ed66dcc0ff067
Gerrit-Change-Number: 24909
Gerrit-PatchSet: 2
Gerrit-Owner: Roy Mingi Park <roy.mingi.park(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com>
Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 27 Feb 2018 23:38:30 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24909 )
Change subject: mb/intel/glkrvp: Configure PERST GPIO for PCIE WiFi card
......................................................................
Patch Set 2:
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/68022/ : SUCCESS
--
To view, visit https://review.coreboot.org/24909
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic594c5a088af79079a8742f5287ed66dcc0ff067
Gerrit-Change-Number: 24909
Gerrit-PatchSet: 2
Gerrit-Owner: Roy Mingi Park <roy.mingi.park(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com>
Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 27 Feb 2018 23:38:30 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No