February 2018 - coreboot-gerrit

Change in coreboot[master]: mb/{amd/gardenia, google/kahlee}: Initialize GPIOs earlier
by build bot (Jenkins) (Code Review) Feb. 28, 2018

Feb. 28, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24916 ) Change subject: mb/{amd/gardenia,google/kahlee}: Initialize GPIOs earlier ...................................................................... Patch Set 5: Build Failed https://qa.coreboot.org/job/coreboot-gerrit/68071/ : ABORTED -- To view, visit https://review.coreboot.org/24916 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I568a3240a54817ab6dcf15fe39f7f1336943852b Gerrit-Change-Number: 24916 Gerrit-PatchSet: 5 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 28 Feb 2018 19:35:29 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/kahlee: Initialize GPIOs earlier
by build bot (Jenkins) (Code Review) Feb. 28, 2018

Feb. 28, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24916 ) Change subject: mb/google/kahlee: Initialize GPIOs earlier ...................................................................... Patch Set 4: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/68070/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/22538/ : SUCCESS -- To view, visit https://review.coreboot.org/24916 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I568a3240a54817ab6dcf15fe39f7f1336943852b Gerrit-Change-Number: 24916 Gerrit-PatchSet: 4 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 28 Feb 2018 19:29:20 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/kahlee: Initialize WLAN GPIOs early.
by build bot (Jenkins) (Code Review) Feb. 28, 2018

Feb. 28, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24916 ) Change subject: mb/google/kahlee: Initialize WLAN GPIOs early. ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68069/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22537/ : SUCCESS -- To view, visit https://review.coreboot.org/24916 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I568a3240a54817ab6dcf15fe39f7f1336943852b Gerrit-Change-Number: 24916 Gerrit-PatchSet: 3 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 28 Feb 2018 19:15:14 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/kahlee: Initialize WLAN GPIOs early.
by build bot (Jenkins) (Code Review) Feb. 28, 2018

Feb. 28, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24916 ) Change subject: mb/google/kahlee: Initialize WLAN GPIOs early. ...................................................................... Patch Set 2: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/68068/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/22536/ : SUCCESS -- To view, visit https://review.coreboot.org/24916 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I568a3240a54817ab6dcf15fe39f7f1336943852b Gerrit-Change-Number: 24916 Gerrit-PatchSet: 2 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 28 Feb 2018 19:08:57 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/kahlee: Initialize WLAN GPIOs early.
by build bot (Jenkins) (Code Review) Feb. 28, 2018

Feb. 28, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24916 ) Change subject: mb/google/kahlee: Initialize WLAN GPIOs early. ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68066/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22534/ : SUCCESS -- To view, visit https://review.coreboot.org/24916 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I568a3240a54817ab6dcf15fe39f7f1336943852b Gerrit-Change-Number: 24916 Gerrit-PatchSet: 1 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 28 Feb 2018 18:54:05 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Remove printk for GPIO
by build bot (Jenkins) (Code Review) Feb. 28, 2018

Feb. 28, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24915 ) Change subject: soc/amd/stoneyridge: Remove printk for GPIO ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68067/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22535/ : SUCCESS -- To view, visit https://review.coreboot.org/24915 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I064291decf47d86132e36469e029b3262ec20172 Gerrit-Change-Number: 24915 Gerrit-PatchSet: 1 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 28 Feb 2018 18:51:48 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Remove printk for GPIO
by Justin TerAvest (Code Review) Feb. 28, 2018

Feb. 28, 2018

Justin TerAvest has uploaded this change for review. ( https://review.coreboot.org/24915 Change subject: soc/amd/stoneyridge: Remove printk for GPIO ...................................................................... soc/amd/stoneyridge: Remove printk for GPIO The printk() calls in sb_program_gpios() aren't necessary, and incur a 13 second delay if the function is called from bootblock_mainboard_early_init(). This commit removes them so GPIOs can be set up earlier. TEST=call sb_program_gpios from bootblock_mainboard_early_init BUG=None Change-Id: I064291decf47d86132e36469e029b3262ec20172 Signed-off-by: Justin TerAvest <teravest(a)chromium.org> --- M src/soc/amd/stoneyridge/southbridge.c 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/24915/1 diff --git a/src/soc/amd/stoneyridge/southbridge.c b/src/soc/amd/stoneyridge/southbridge.c index 5d7b73d..3d0cc74 100644 --- a/src/soc/amd/stoneyridge/southbridge.c +++ b/src/soc/amd/stoneyridge/southbridge.c @@ -161,7 +161,6 @@ void *tmp_ptr; uint8_t control, mux, index; - printk(BIOS_SPEW, "GPIO programming stage %s\n", STR_GPIO_STAGE); for (index = 0; index < size; index++) { mux = gpio_ptr[index].function; control = gpio_ptr[index].control; @@ -176,7 +175,6 @@ AMD_GPIO_CONTROL + 2); write8(tmp_ptr, control); } - printk(BIOS_SPEW, "End GPIO programming\n"); } /** -- To view, visit https://review.coreboot.org/24915 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I064291decf47d86132e36469e029b3262ec20172 Gerrit-Change-Number: 24915 Gerrit-PatchSet: 1 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org>

1 0

Change in coreboot[master]: mb/google/kahlee: Initialize WLAN GPIOs early.
by Justin TerAvest (Code Review) Feb. 28, 2018

Feb. 28, 2018

Justin TerAvest has uploaded this change for review. ( https://review.coreboot.org/24916 Change subject: mb/google/kahlee: Initialize WLAN GPIOs early. ...................................................................... mb/google/kahlee: Initialize WLAN GPIOs early. The GPIOs for PCIe reset and power enable for WLAN must be set up before amdinitearly for wlan to function. BUG=b:73898539 TEST=Boot, see WLAN controller in lspci Change-Id: I568a3240a54817ab6dcf15fe39f7f1336943852b Signed-off-by: Justin TerAvest <teravest(a)chromium.org> --- M src/mainboard/google/kahlee/bootblock/bootblock.c M src/mainboard/google/kahlee/variants/baseboard/gpio.c M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/kahlee/variants/kahlee/gpio.c 4 files changed, 34 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/24916/1 diff --git a/src/mainboard/google/kahlee/bootblock/bootblock.c b/src/mainboard/google/kahlee/bootblock/bootblock.c index 4a65d8f..e125c2c 100644 --- a/src/mainboard/google/kahlee/bootblock/bootblock.c +++ b/src/mainboard/google/kahlee/bootblock/bootblock.c @@ -20,6 +20,15 @@ #include <variant/ec.h> #include <variant/gpio.h> + +void bootblock_mainboard_early_init(void) +{ + size_t num_gpios; + const struct soc_amd_stoneyridge_gpio *gpios; + gpios = variant_pre_init_gpio_table(&num_gpios); + sb_program_gpios(gpios, num_gpios); +} + void bootblock_mainboard_init(void) { size_t num_gpios; diff --git a/src/mainboard/google/kahlee/variants/baseboard/gpio.c b/src/mainboard/google/kahlee/variants/baseboard/gpio.c index de70be4..e23c9cf 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/gpio.c +++ b/src/mainboard/google/kahlee/variants/baseboard/gpio.c @@ -20,6 +20,17 @@ #include <stdlib.h> /* + * Pins that must be set up before amdinitearly go here. + */ +const static struct soc_amd_stoneyridge_gpio gpio_set_stage_pre_init[] = { + /* GPIO_4 - EN_PP3300_WLAN */ + PAD_GPO(GPIO_4, HIGH), + + /* GPIO_70 - WLAN_PE_RST_L */ + PAD_GPO(GPIO_70, HIGH), +}; + +/* * As a rule of thumb, GPIO pins used by coreboot should be initialized at * bootblock while GPIO pins used only by the OS should be initialized at * ramstage. @@ -34,9 +45,6 @@ /* GPIO_3 - MEM_VOLT_SEL */ PAD_GPI(GPIO_3, PULL_UP), - /* GPIO_4 - EN_PP3300_WLAN */ - PAD_GPO(GPIO_4, HIGH), - /* GPIO_5 - PCH_TRACKPAD_INT_3V3_ODL, SCI */ PAD_GPI(GPIO_5, PULL_UP), @@ -89,9 +97,6 @@ /* GPIO_42 - S5_MUX_CTRL */ PAD_NF(GPIO_42, S5_MUX_CTRL, PULL_NONE), - /* GPIO_70 - WLAN_PE_RST_L */ - PAD_GPO(GPIO_70, HIGH), - /* GPIO_74 - LPC_CLK0_EC_R */ PAD_NF(GPIO_74, LPCCLK0, PULL_DOWN), @@ -255,6 +260,13 @@ }; const __attribute__((weak)) +struct soc_amd_stoneyridge_gpio *variant_pre_init_gpio_table(size_t *size) +{ + *size = ARRAY_SIZE(gpio_set_stage_pre_init); + return gpio_set_stage_pre_init; +} + +const __attribute__((weak)) struct soc_amd_stoneyridge_gpio *variant_early_gpio_table(size_t *size) { *size = ARRAY_SIZE(gpio_set_stage_reset); diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h index 83ee119..188d35c 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h +++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h @@ -27,6 +27,7 @@ int variant_mainboard_read_spd(uint8_t spdAddress, char *buf, size_t len); int variant_get_xhci_oc_map(uint16_t *usb_oc_map); int variant_get_ehci_oc_map(uint16_t *usb_oc_map); +const struct soc_amd_stoneyridge_gpio *variant_pre_init_gpio_table(size_t *size); const struct soc_amd_stoneyridge_gpio *variant_early_gpio_table(size_t *size); const struct soc_amd_stoneyridge_gpio *variant_gpio_table(size_t *size); diff --git a/src/mainboard/google/kahlee/variants/kahlee/gpio.c b/src/mainboard/google/kahlee/variants/kahlee/gpio.c index d1cc017..ec1888f 100644 --- a/src/mainboard/google/kahlee/variants/kahlee/gpio.c +++ b/src/mainboard/google/kahlee/variants/kahlee/gpio.c @@ -96,6 +96,12 @@ {GPIO_119, Function2, FCH_GPIO_PULL_UP_ENABLE | OUTPUT_H }, }; +const struct soc_amd_stoneyridge_gpio *variant_pre_init_gpio_table(size_t *size) +{ + *size = 0; + return NULL; +} + const struct soc_amd_stoneyridge_gpio *variant_early_gpio_table(size_t *size) { *size = ARRAY_SIZE(gpio_set_stage_reset); -- To view, visit https://review.coreboot.org/24916 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I568a3240a54817ab6dcf15fe39f7f1336943852b Gerrit-Change-Number: 24916 Gerrit-PatchSet: 1 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org>

1 0

Change in coreboot[master]: ec/google/chromeec: Add note before error message
by Furquan Shaikh (Code Review) Feb. 28, 2018

Feb. 28, 2018

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/24914 ) Change subject: ec/google/chromeec: Add note before error message ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/24914 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2e684e357e821c795de4b59658432c91a8d63fc Gerrit-Change-Number: 24914 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 28 Feb 2018 18:47:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: ec/google/chromeec: Add note before error message
by build bot (Jenkins) (Code Review) Feb. 28, 2018

Feb. 28, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24914 ) Change subject: ec/google/chromeec: Add note before error message ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68065/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22533/ : SUCCESS -- To view, visit https://review.coreboot.org/24914 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2e684e357e821c795de4b59658432c91a8d63fc Gerrit-Change-Number: 24914 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 28 Feb 2018 18:21:33 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0