coreboot-gerrit February 2018

coreboot-gerrit@coreboot.org

1 participants
1573 discussions

Change in coreboot[master]: security/vboot: Add boot mode selection
by build bot (Jenkins) (Code Review) 14 Feb '18

14 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23756 ) Change subject: security/vboot: Add boot mode selection ...................................................................... Patch Set 14: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67494/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22030/ : SUCCESS -- To view, visit https://review.coreboot.org/23756 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43d233d5a8766af2dd7f07cc0b64293a80d5d7d2 Gerrit-Change-Number: 23756 Gerrit-PatchSet: 14 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Feb 2018 21:48:10 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: security/vboot: Add boot mode selection
by Philipp Deppenwiese (Code Review) 14 Feb '18

14 Feb '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/23756 to look at the new patch set (#14). Change subject: security/vboot: Add boot mode selection ...................................................................... security/vboot: Add boot mode selection * Add Measured Boot mode. Now a boot mode is selectable: -> Verified Boot (default) -> Verified Boot without TPM (antirollback protection is disabled) -> Verified & Measured Boot * Measurements start in verstage for bootblock/verstage because of different bootblock sizes and issues related to it. * prog_run() hook offers ability to measure every stage. * Supported stages: romstage, postcar, ramstage, payload. Change-Id: I43d233d5a8766af2dd7f07cc0b64293a80d5d7d2 Signed-off-by: Philipp Deppenwiese <zaolin(a)das-labor.org> --- M src/arch/x86/postcar_loader.c M src/drivers/i2c/tpm/Makefile.inc M src/drivers/pc80/tpm/Makefile.inc M src/drivers/spi/tpm/Makefile.inc M src/include/program_loading.h M src/lib/prog_ops.c M src/mainboard/google/poppy/Kconfig M src/mainboard/google/rotor/Kconfig M src/mainboard/intel/cannonlake_rvp/Kconfig M src/mainboard/intel/kblrvp/Kconfig M src/security/tpm/tspi.h M src/security/vboot/Kconfig M src/security/vboot/Makefile.inc M src/security/vboot/antirollback.h A src/security/vboot/secdata_measurements.c M src/security/vboot/secdata_mock.c M src/security/vboot/secdata_tpm.c M src/security/vboot/vboot_logic.c 18 files changed, 210 insertions(+), 46 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/23756/14 -- To view, visit https://review.coreboot.org/23756 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I43d233d5a8766af2dd7f07cc0b64293a80d5d7d2 Gerrit-Change-Number: 23756 Gerrit-PatchSet: 14 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: drivers/i2c: Add i2c TPM support for different stages
by build bot (Jenkins) (Code Review) 14 Feb '18

14 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23759 ) Change subject: drivers/i2c: Add i2c TPM support for different stages ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67491/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22027/ : SUCCESS -- To view, visit https://review.coreboot.org/23759 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib0839933f8b59f0c87cdda4e5374828bd6f1099f Gerrit-Change-Number: 23759 Gerrit-PatchSet: 6 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Feb 2018 20:58:53 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: security/vboot: Add boot mode selection
by build bot (Jenkins) (Code Review) 14 Feb '18

14 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23756 ) Change subject: security/vboot: Add boot mode selection ...................................................................... Patch Set 13: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67493/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22029/ : SUCCESS -- To view, visit https://review.coreboot.org/23756 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43d233d5a8766af2dd7f07cc0b64293a80d5d7d2 Gerrit-Change-Number: 23756 Gerrit-PatchSet: 13 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Feb 2018 20:56:33 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/broadcom/cygnus: Increase romstage SRAM size in memlayout
by build bot (Jenkins) (Code Review) 14 Feb '18

14 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23764 ) Change subject: soc/broadcom/cygnus: Increase romstage SRAM size in memlayout ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67492/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22028/ : SUCCESS -- To view, visit https://review.coreboot.org/23764 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5bbdf19cc886103e9e7a6b75219d6881cfe9c757 Gerrit-Change-Number: 23764 Gerrit-PatchSet: 2 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Feb 2018 20:48:16 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/broadcom/cygnus: Increase romstage SRAM size in memlayout
by build bot (Jenkins) (Code Review) 14 Feb '18

14 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23764 ) Change subject: soc/broadcom/cygnus: Increase romstage SRAM size in memlayout ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/67490/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/22026/ : SUCCESS -- To view, visit https://review.coreboot.org/23764 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5bbdf19cc886103e9e7a6b75219d6881cfe9c757 Gerrit-Change-Number: 23764 Gerrit-PatchSet: 1 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Feb 2018 20:41:32 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/broadcom/cygnus: Increase romstage SRAM size in memlayout
by Philipp Deppenwiese (Code Review) 14 Feb '18

14 Feb '18

Philipp Deppenwiese has uploaded this change for review. ( https://review.coreboot.org/23764 Change subject: soc/broadcom/cygnus: Increase romstage SRAM size in memlayout ...................................................................... soc/broadcom/cygnus: Increase romstage SRAM size in memlayout * Needed for additional code in later patches. * SOC is obsolete anyway. Change-Id: I5bbdf19cc886103e9e7a6b75219d6881cfe9c757 Signed-off-by: Philipp Deppenwiese <zaolin(a)das-labor.org> --- M src/soc/broadcom/cygnus/include/soc/memlayout.ld 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/23764/1 diff --git a/src/soc/broadcom/cygnus/include/soc/memlayout.ld b/src/soc/broadcom/cygnus/include/soc/memlayout.ld index 219ea13..42b59da 100644 --- a/src/soc/broadcom/cygnus/include/soc/memlayout.ld +++ b/src/soc/broadcom/cygnus/include/soc/memlayout.ld @@ -25,9 +25,9 @@ TTB_SUBTABLES(0x02008000, 1K) REGION(reserved_for_maskrom, 0x02009400, 4K, 4) BOOTBLOCK(0x0200A440, 18K) - PRERAM_CBMEM_CONSOLE(0x0200F000, 4K) - VBOOT2_WORK(0x02010000, 16K) - OVERLAP_VERSTAGE_ROMSTAGE(0x02014000, 120K) + PRERAM_CBMEM_CONSOLE(0x0200F000, 2K) + VBOOT2_WORK(0x0200f800, 16K) + OVERLAP_VERSTAGE_ROMSTAGE(0x02013800, 122K) PRERAM_CBFS_CACHE(0x02032000, 1K) TIMESTAMP(0x02032400, 1K) STACK(0x02033000, 12K) -- To view, visit https://review.coreboot.org/23764 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5bbdf19cc886103e9e7a6b75219d6881cfe9c757 Gerrit-Change-Number: 23764 Gerrit-PatchSet: 1 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>

1 0

Change in coreboot[master]: security/vboot: Add boot mode selection
by build bot (Jenkins) (Code Review) 14 Feb '18

14 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23756 ) Change subject: security/vboot: Add boot mode selection ...................................................................... Patch Set 12: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/67489/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/22025/ : SUCCESS -- To view, visit https://review.coreboot.org/23756 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43d233d5a8766af2dd7f07cc0b64293a80d5d7d2 Gerrit-Change-Number: 23756 Gerrit-PatchSet: 12 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Feb 2018 20:35:02 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: drivers/i2c: Add i2c TPM support for different stages
by build bot (Jenkins) (Code Review) 14 Feb '18

14 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23759 ) Change subject: drivers/i2c: Add i2c TPM support for different stages ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67487/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22023/ : SUCCESS -- To view, visit https://review.coreboot.org/23759 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib0839933f8b59f0c87cdda4e5374828bd6f1099f Gerrit-Change-Number: 23759 Gerrit-PatchSet: 5 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Feb 2018 20:25:42 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: security/vboot: Add boot mode selection
by build bot (Jenkins) (Code Review) 14 Feb '18

14 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23756 ) Change subject: security/vboot: Add boot mode selection ...................................................................... Patch Set 11: Build Failed https://qa.coreboot.org/job/coreboot-gerrit/67488/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/22024/ : SUCCESS -- To view, visit https://review.coreboot.org/23756 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43d233d5a8766af2dd7f07cc0b64293a80d5d7d2 Gerrit-Change-Number: 23756 Gerrit-PatchSet: 11 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Feb 2018 20:25:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2018