coreboot-gerrit February 2018

coreboot-gerrit@coreboot.org

1 participants
1573 discussions

Change in coreboot[master]: security/vboot: Add boot mode selection
by build bot (Jenkins) (Code Review) 14 Feb '18

14 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23756 ) Change subject: security/vboot: Add boot mode selection ...................................................................... Patch Set 5: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/67474/ : ABORTED -- To view, visit https://review.coreboot.org/23756 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43d233d5a8766af2dd7f07cc0b64293a80d5d7d2 Gerrit-Change-Number: 23756 Gerrit-PatchSet: 5 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Feb 2018 17:35:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: security/vboot: Add boot mode selection
by Philipp Deppenwiese (Code Review) 14 Feb '18

14 Feb '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/23756 to look at the new patch set (#5). Change subject: security/vboot: Add boot mode selection ...................................................................... security/vboot: Add boot mode selection * Add Measured Boot mode. Change-Id: I43d233d5a8766af2dd7f07cc0b64293a80d5d7d2 Signed-off-by: Philipp Deppenwiese <zaolin(a)das-labor.org> --- M src/arch/x86/postcar_loader.c M src/drivers/i2c/tpm/Makefile.inc M src/drivers/pc80/tpm/Makefile.inc M src/drivers/spi/tpm/Makefile.inc M src/include/program_loading.h M src/lib/prog_ops.c M src/mainboard/google/poppy/Kconfig M src/mainboard/google/rotor/Kconfig M src/mainboard/intel/cannonlake_rvp/Kconfig M src/mainboard/intel/kblrvp/Kconfig M src/security/tpm/tspi.h M src/security/vboot/Kconfig M src/security/vboot/Makefile.inc M src/security/vboot/antirollback.h A src/security/vboot/secdata_measurements.c M src/security/vboot/secdata_mock.c M src/security/vboot/secdata_tpm.c M src/security/vboot/vboot_logic.c 18 files changed, 215 insertions(+), 45 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/23756/5 -- To view, visit https://review.coreboot.org/23756 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I43d233d5a8766af2dd7f07cc0b64293a80d5d7d2 Gerrit-Change-Number: 23756 Gerrit-PatchSet: 5 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/intel/skylake: Generate ACPI DMAR table
by build bot (Jenkins) (Code Review) 14 Feb '18

14 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21588 ) Change subject: soc/intel/skylake: Generate ACPI DMAR table ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67471/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22008/ : SUCCESS -- To view, visit https://review.coreboot.org/21588 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8176401dd19aee7ad09a8a145b7a3801fe5b2ae1 Gerrit-Change-Number: 21588 Gerrit-PatchSet: 5 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Feb 2018 17:33:06 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/common/block/s3/s3_resume.c: Check mrc_cache_get_current() re...
by build bot (Jenkins) (Code Review) 14 Feb '18

14 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23761 ) Change subject: soc/amd/common/block/s3/s3_resume.c: Check mrc_cache_get_current() return ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67472/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22009/ : SUCCESS -- To view, visit https://review.coreboot.org/23761 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0f6a58380a38d13120e997dcd966423d3c2af091 Gerrit-Change-Number: 23761 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Feb 2018 17:30:19 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/common/block/s3/s3_resume.c: Check mrc_cache_get_current() re...
by Richard Spiegel (Code Review) 14 Feb '18

14 Feb '18

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/23761 Change subject: soc/amd/common/block/s3/s3_resume.c: Check mrc_cache_get_current() return ...................................................................... soc/amd/common/block/s3/s3_resume.c: Check mrc_cache_get_current() return Procedure mrc_cache_get_current() returns -1 for error, 0 for pass. Do check the return in procedure get_s3nv_info. This fixes CID 1385943 BUG=b:73333332 TEST=Build kahlee Change-Id: I0f6a58380a38d13120e997dcd966423d3c2af091 Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M src/soc/amd/common/block/s3/s3_resume.c 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/23761/1 diff --git a/src/soc/amd/common/block/s3/s3_resume.c b/src/soc/amd/common/block/s3/s3_resume.c index 4883fa5..1ba9468 100644 --- a/src/soc/amd/common/block/s3/s3_resume.c +++ b/src/soc/amd/common/block/s3/s3_resume.c @@ -27,7 +27,11 @@ { struct region_device rdev; - mrc_cache_get_current(MRC_TRAINING_DATA, DEFAULT_MRC_VERSION, &rdev); + if (mrc_cache_get_current(MRC_TRAINING_DATA, DEFAULT_MRC_VERSION, + &rdev)) { + printk(BIOS_ERR, "mrc_cache_get_current returned error\n"); + return; + } *base = rdev_mmap_full(&rdev); *size = region_device_sz(&rdev); if (!*base || !*size) -- To view, visit https://review.coreboot.org/23761 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0f6a58380a38d13120e997dcd966423d3c2af091 Gerrit-Change-Number: 23761 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>

1 0

Change in coreboot[master]: drivers/generic/adau7002/adau7002.c: Fix null pointer dereference
by build bot (Jenkins) (Code Review) 14 Feb '18

14 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23760 ) Change subject: drivers/generic/adau7002/adau7002.c: Fix null pointer dereference ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67469/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22006/ : SUCCESS -- To view, visit https://review.coreboot.org/23760 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcdf905100d22a1d828394f8685641eb432bb836 Gerrit-Change-Number: 23760 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Feb 2018 17:00:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: security/vboot: Add boot mode selection
by build bot (Jenkins) (Code Review) 14 Feb '18

14 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23756 ) Change subject: security/vboot: Add boot mode selection ...................................................................... Patch Set 4: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/67468/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/22005/ : SUCCESS -- To view, visit https://review.coreboot.org/23756 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43d233d5a8766af2dd7f07cc0b64293a80d5d7d2 Gerrit-Change-Number: 23756 Gerrit-PatchSet: 4 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Feb 2018 16:59:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: drivers/generic/adau7002/adau7002.c: Fix null pointer dereference
by Richard Spiegel (Code Review) 14 Feb '18

14 Feb '18

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/23760 Change subject: drivers/generic/adau7002/adau7002.c: Fix null pointer dereference ...................................................................... drivers/generic/adau7002/adau7002.c: Fix null pointer dereference Procedures acpi_device_scope() and acpi_device_name() can under certain conditions return NULL. Check the return before using them. This fixes CID 1385944 BUG=b:73331544 TEST=Build kahlee. Change-Id: Ifcdf905100d22a1d828394f8685641eb432bb836 Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M src/drivers/generic/adau7002/adau7002.c 1 file changed, 7 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/23760/1 diff --git a/src/drivers/generic/adau7002/adau7002.c b/src/drivers/generic/adau7002/adau7002.c index d21d513..1e1acf0 100644 --- a/src/drivers/generic/adau7002/adau7002.c +++ b/src/drivers/generic/adau7002/adau7002.c @@ -32,9 +32,14 @@ if (!dev->enabled) return; + const char *scope = acpi_device_scope(dev); + const char *name = acpi_device_name(dev); + if (!scope || !name) + return; + /* Device */ - acpigen_write_scope(acpi_device_scope(dev)); - acpigen_write_device(acpi_device_name(dev)); + acpigen_write_scope(scope); + acpigen_write_device(name); acpigen_write_name_string("_HID", ADAU7002_ACPI_HID); acpigen_write_name_integer("_UID", 0); acpigen_write_name_string("_DDN", dev->chip_ops->name); -- To view, visit https://review.coreboot.org/23760 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ifcdf905100d22a1d828394f8685641eb432bb836 Gerrit-Change-Number: 23760 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>

1 0

Change in coreboot[master]: security/vboot: Add boot mode selection
by Philipp Deppenwiese (Code Review) 14 Feb '18

14 Feb '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/23756 to look at the new patch set (#4). Change subject: security/vboot: Add boot mode selection ...................................................................... security/vboot: Add boot mode selection * Add Measured Boot mode. Change-Id: I43d233d5a8766af2dd7f07cc0b64293a80d5d7d2 Signed-off-by: Philipp Deppenwiese <zaolin(a)das-labor.org> --- M src/arch/x86/postcar_loader.c M src/drivers/i2c/tpm/Makefile.inc M src/drivers/pc80/tpm/Makefile.inc M src/drivers/spi/tpm/Makefile.inc M src/include/program_loading.h M src/lib/prog_ops.c M src/mainboard/google/poppy/Kconfig M src/mainboard/google/rotor/Kconfig M src/mainboard/intel/cannonlake_rvp/Kconfig M src/mainboard/intel/kblrvp/Kconfig M src/security/tpm/tspi.h M src/security/vboot/Kconfig M src/security/vboot/Makefile.inc M src/security/vboot/antirollback.h M src/security/vboot/secdata_mock.c M src/security/vboot/secdata_tpm.c M src/security/vboot/vboot_logic.c 17 files changed, 200 insertions(+), 45 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/23756/4 -- To view, visit https://review.coreboot.org/23756 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I43d233d5a8766af2dd7f07cc0b64293a80d5d7d2 Gerrit-Change-Number: 23756 Gerrit-PatchSet: 4 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: security/vboot: Add boot mode selection
by build bot (Jenkins) (Code Review) 14 Feb '18

14 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23756 ) Change subject: security/vboot: Add boot mode selection ...................................................................... Patch Set 3: Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/67467/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/22004/ : SUCCESS -- To view, visit https://review.coreboot.org/23756 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43d233d5a8766af2dd7f07cc0b64293a80d5d7d2 Gerrit-Change-Number: 23756 Gerrit-PatchSet: 3 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Feb 2018 16:22:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2018