coreboot-gerrit February 2018

coreboot-gerrit@coreboot.org

1 participants
1573 discussions

Change in coreboot[master]: mb/google/kahlee/OemCustomize.c: Fix AGESA warning
by build bot (Jenkins) (Code Review) 14 Feb '18

14 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23763 ) Change subject: mb/google/kahlee/OemCustomize.c: Fix AGESA warning ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67479/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22015/ : SUCCESS -- To view, visit https://review.coreboot.org/23763 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice9270f9b10051dbb622344919223cf5439f5d7b Gerrit-Change-Number: 23763 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Feb 2018 19:20:42 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/kahlee/OemCustomize.c: Fix AGESA warning
by Richard Spiegel (Code Review) 14 Feb '18

14 Feb '18

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/23763 Change subject: mb/google/kahlee/OemCustomize.c: Fix AGESA warning ...................................................................... mb/google/kahlee/OemCustomize.c: Fix AGESA warning AmdInitPost returns AGESA_WARNING. This is because AGESA by default enables bank interleaving, while the HW does not meet the requirements for it. Disable bank interleaving, thus clearing AGESA_WARNING. BUG=b:65221558 TEST= Build and run kahlee. Search for "agesawrapper_amdinitpost() returned AGESA_SUCCESS". Change-Id: Ice9270f9b10051dbb622344919223cf5439f5d7b Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M src/mainboard/google/kahlee/OemCustomize.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/23763/1 diff --git a/src/mainboard/google/kahlee/OemCustomize.c b/src/mainboard/google/kahlee/OemCustomize.c index 8ab8e54..d9cfbc2 100644 --- a/src/mainboard/google/kahlee/OemCustomize.c +++ b/src/mainboard/google/kahlee/OemCustomize.c @@ -39,4 +39,5 @@ { PostParams->MemConfig.PlatformMemoryConfiguration = (PSO_ENTRY *)DDR4PlatformMemoryConfiguration; + PostParams->MemConfig.EnableBankIntlv = FALSE; } -- To view, visit https://review.coreboot.org/23763 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ice9270f9b10051dbb622344919223cf5439f5d7b Gerrit-Change-Number: 23763 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>

1 0

Change in coreboot[master]: util/superiotool/winbond: Fix 0x4f Bank 0 value
by build bot (Jenkins) (Code Review) 14 Feb '18

14 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23762 ) Change subject: util/superiotool/winbond: Fix 0x4f Bank 0 value ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67478/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22014/ : SUCCESS -- To view, visit https://review.coreboot.org/23762 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaf21da25281bfc1479b7d15fa29dcebf014570e5 Gerrit-Change-Number: 23762 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Feb 2018 19:12:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/superiotool/winbond: Fix 0x4f Bank 0 value
by Elyes HAOUAS (Code Review) 14 Feb '18

14 Feb '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/23762 Change subject: util/superiotool/winbond: Fix 0x4f Bank 0 value ...................................................................... util/superiotool/winbond: Fix 0x4f Bank 0 value Regarding W83627EHF_EHG_EF_EG.pdf page# 101 Vendor ID Register - Index 4Fh (bank 0) is a 16 bits size and the default value is 0x5ca3 Tested on W83627EHF/EF/EHG/EG: https://pastebin.com/tbmTyTgm Change-Id: Iaf21da25281bfc1479b7d15fa29dcebf014570e5 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M util/superiotool/winbond.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/23762/1 diff --git a/util/superiotool/winbond.c b/util/superiotool/winbond.c index 281c179..dd8b859 100644 --- a/util/superiotool/winbond.c +++ b/util/superiotool/winbond.c @@ -795,7 +795,7 @@ {0x40,0x41,0x42,0x43,0x44,0x45,0x46,0x47,0x48,0x49, 0x4a,0x4b,0x4c,0x4d,0x4e,0x4f,EOT}, {0x03,0x00,0x00,0xde,0xff,RSVD,0x07,0x55,0x2d,RSVD, - 0x64,0x44,0x10,0x15,0x80,0x5c,EOT}}, + 0x64,0x44,0x10,0x15,0x80,0xa3,EOT}}, {0x0, "Bank 0", {0x50,0x51,0x52,0x53,0x54,0x55,0x56,0x57,0x58,0x59, 0x5a,0x5b,0x5c,0x5d,0x5e,0x5f,0x60,0x61,0x62,0x63, -- To view, visit https://review.coreboot.org/23762 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iaf21da25281bfc1479b7d15fa29dcebf014570e5 Gerrit-Change-Number: 23762 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: mb/google/octopus: Add new board
by build bot (Jenkins) (Code Review) 14 Feb '18

14 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23685 ) Change subject: mb/google/octopus: Add new board ...................................................................... Patch Set 9: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67477/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22013/ : SUCCESS -- To view, visit https://review.coreboot.org/23685 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8c25b3fafbfef31b8b3b802acb3bc53ee7146b6 Gerrit-Change-Number: 23685 Gerrit-PatchSet: 9 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Feb 2018 18:49:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/soraka: Set psys_max to 45W
by Furquan Shaikh (Code Review) 14 Feb '18

14 Feb '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/23757 ) Change subject: mb/google/soraka: Set psys_max to 45W ...................................................................... Patch Set 4: (1 comment) > Patch Set 4: > > This should apply to all poppy derivatives, not just soraka. > > Otherwise LGTM if the PSYS value matches values from the battery. +1 https://review.coreboot.org/#/c/23757/4//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/23757/4//COMMIT_MSG@12 PS4, Line 12: 66066340 b:66066340 -- To view, visit https://review.coreboot.org/23757 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6f624733830b462329b5f539c20e2aea664143e Gerrit-Change-Number: 23757 Gerrit-PatchSet: 4 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nicolas Boichat <drinkcat(a)chromium.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Comment-Date: Wed, 14 Feb 2018 18:37:31 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: security/vboot: Add boot mode selection
by build bot (Jenkins) (Code Review) 14 Feb '18

14 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23756 ) Change subject: security/vboot: Add boot mode selection ...................................................................... Patch Set 6: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/67476/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/22012/ : SUCCESS -- To view, visit https://review.coreboot.org/23756 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43d233d5a8766af2dd7f07cc0b64293a80d5d7d2 Gerrit-Change-Number: 23756 Gerrit-PatchSet: 6 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Feb 2018 18:00:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: drivers/i2c: Add i2c TPM support for different stages
by build bot (Jenkins) (Code Review) 14 Feb '18

14 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23759 ) Change subject: drivers/i2c: Add i2c TPM support for different stages ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67473/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22010/ : SUCCESS -- To view, visit https://review.coreboot.org/23759 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib0839933f8b59f0c87cdda4e5374828bd6f1099f Gerrit-Change-Number: 23759 Gerrit-PatchSet: 2 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Feb 2018 17:53:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: drivers/generic/adau7002/adau7002.c: Fix null pointer dereference
by build bot (Jenkins) (Code Review) 14 Feb '18

14 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23760 ) Change subject: drivers/generic/adau7002/adau7002.c: Fix null pointer dereference ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67475/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22011/ : SUCCESS -- To view, visit https://review.coreboot.org/23760 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcdf905100d22a1d828394f8685641eb432bb836 Gerrit-Change-Number: 23760 Gerrit-PatchSet: 2 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Feb 2018 17:45:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/skylake: Enable VT-d and X2APIC
by build bot (Jenkins) (Code Review) 14 Feb '18

14 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21597 ) Change subject: soc/intel/skylake: Enable VT-d and X2APIC ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67470/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22007/ : SUCCESS -- To view, visit https://review.coreboot.org/21597 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77f87c385736615c127143760bbd144f97986b37 Gerrit-Change-Number: 21597 Gerrit-PatchSet: 5 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Feb 2018 17:38:20 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2018