coreboot-gerrit February 2018

coreboot-gerrit@coreboot.org

1 participants
1573 discussions

Change in coreboot[master]: security/vboot: Add boot mode selection
by build bot (Jenkins) (Code Review) 15 Feb '18

15 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23756 ) Change subject: security/vboot: Add boot mode selection ...................................................................... Patch Set 15: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/67502/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/22035/ : SUCCESS -- To view, visit https://review.coreboot.org/23756 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43d233d5a8766af2dd7f07cc0b64293a80d5d7d2 Gerrit-Change-Number: 23756 Gerrit-PatchSet: 15 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Feb 2018 01:26:54 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: security/vboot: Add boot mode selection
by Philipp Deppenwiese (Code Review) 15 Feb '18

15 Feb '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/23756 ) Change subject: security/vboot: Add boot mode selection ...................................................................... Patch Set 14: (9 comments) https://review.coreboot.org/#/c/23756/14/src/drivers/i2c/tpm/Makefile.inc File src/drivers/i2c/tpm/Makefile.inc: https://review.coreboot.org/#/c/23756/14/src/drivers/i2c/tpm/Makefile.inc@5 PS14, Line 5: postcar-$(CONFIG_DRIVER_TIS_DEFAULT) += tis.c > you shouldn't replace bootblock with postcar. you should add postcar. Done https://review.coreboot.org/#/c/23756/14/src/drivers/spi/tpm/Makefile.inc File src/drivers/spi/tpm/Makefile.inc: https://review.coreboot.org/#/c/23756/14/src/drivers/spi/tpm/Makefile.inc@4 PS14, Line 4: postcar-$(CONFIG_SPI_TPM) += tis.c tpm.c > need bootblock here too Done https://review.coreboot.org/#/c/23756/14/src/mainboard/google/poppy/Kconfig File src/mainboard/google/poppy/Kconfig: https://review.coreboot.org/#/c/23756/14/src/mainboard/google/poppy/Kconfig… PS14, Line 123: select VARIANT_HAS_I2C_TPM > What's this one for? What's the interaction when VBOOT_MOCK_SECDATA is enabled? Only enable the tpm if antirollback protection isn't disabled. Does not make sense because can be set through defconfig https://review.coreboot.org/#/c/23756/14/src/security/vboot/Makefile.inc File src/security/vboot/Makefile.inc: https://review.coreboot.org/#/c/23756/14/src/security/vboot/Makefile.inc@75 PS14, Line 75: verstage-y += secdata_measurements.c > This should be based on a Kconfig. Done https://review.coreboot.org/#/c/23756/14/src/security/vboot/secdata_measure… File src/security/vboot/secdata_measurements.c: https://review.coreboot.org/#/c/23756/14/src/security/vboot/secdata_measure… PS14, Line 21: uint32_t vboot_measure_self(void) > 'self' is not really self. It's only bootblock. Sounds like you want vboot_measure_bootblock(). vboot_measure_crtm() -> core root of trust for measurement https://review.coreboot.org/#/c/23756/14/src/security/vboot/secdata_measure… PS14, Line 24: PROG_UNKNOWN > Why not have PROG_BOOTBLOCK? You could just call measured_prog_run() in that case instead of hardcod […] Done https://review.coreboot.org/#/c/23756/14/src/security/vboot/secdata_measure… PS14, Line 30: if (cbfs_boot_locate(&file1, prog_name(&bootblock), NULL)) > So this is assuming SEPARATE_VERSTAGE it seems? Done https://review.coreboot.org/#/c/23756/14/src/security/vboot/secdata_tpm.c File src/security/vboot/secdata_tpm.c: https://review.coreboot.org/#/c/23756/14/src/security/vboot/secdata_tpm.c@a… PS14, Line 448: > Where is this being done now? vboot_logic at the beginning of verstage_main() https://review.coreboot.org/#/c/23756/14/src/security/vboot/vboot_logic.c File src/security/vboot/vboot_logic.c: https://review.coreboot.org/#/c/23756/14/src/security/vboot/vboot_logic.c@3… PS14, Line 315: #if IS_ENABLED(CONFIG_VBOOT_MODE_VERIFIED_AND_MEASURED_BOOT) > no #ifs Done -- To view, visit https://review.coreboot.org/23756 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43d233d5a8766af2dd7f07cc0b64293a80d5d7d2 Gerrit-Change-Number: 23756 Gerrit-PatchSet: 14 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Feb 2018 01:15:57 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: libpayload: usbhid: Zero-initialize all parts of usbhid instance struct
by build bot (Jenkins) (Code Review) 15 Feb '18

15 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23766 ) Change subject: libpayload: usbhid: Zero-initialize all parts of usbhid instance struct ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67501/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22034/ : SUCCESS -- To view, visit https://review.coreboot.org/23766 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic987de2daaceaad2ae401a1e12b1bee397f802ee Gerrit-Change-Number: 23766 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Feb 2018 00:57:16 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: libpayload: usbhid: Zero-initialize all parts of usbhid instance struct
by Julius Werner (Code Review) 15 Feb '18

15 Feb '18

Hello Nico Huber, Patrick Georgi, I'd like you to do a code review. Please visit https://review.coreboot.org/23766 to review the following change. Change subject: libpayload: usbhid: Zero-initialize all parts of usbhid instance struct ...................................................................... libpayload: usbhid: Zero-initialize all parts of usbhid instance struct The USBHID driver zero-initializes some but not all of the fields in its usbhid_inst_t structure. This is a problem because under some circumstances, some of the uninitialized fields may be read and lead to incorrect behavior. Some (broken) USB keyboards keep sending reports that contain all zeroes even when they have no new keys... these usually get silently ignored, but if the usbhid_inst_t structure is in an inconsistent state where 'previous' is zeroed out but 'lastkeypress' is non-zero because it wasn't properly initialized, these reports will be interpreted as keyrepeats of the bogus 'lastkeypress'. This patch changes the code to just xzalloc() the whole structure so we won't have to worry about initialization issues anymore. Change-Id: Ic987de2daaceaad2ae401a1e12b1bee397f802ee Signed-off-by: Julius Werner <jwerner(a)chromium.org> --- M payloads/libpayload/drivers/usb/usbhid.c 1 file changed, 1 insertion(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/23766/1 diff --git a/payloads/libpayload/drivers/usb/usbhid.c b/payloads/libpayload/drivers/usb/usbhid.c index 3100d37..68130f8 100644 --- a/payloads/libpayload/drivers/usb/usbhid.c +++ b/payloads/libpayload/drivers/usb/usbhid.c @@ -439,11 +439,7 @@ boot_protos[interface->bInterfaceProtocol]); switch (interface->bInterfaceProtocol) { case hid_boot_proto_keyboard: - dev->data = malloc (sizeof (usbhid_inst_t)); - if (!dev->data) - fatal("Not enough memory for USB HID device.\n"); - memset(&HID_INST(dev)->previous, 0x00, - sizeof(HID_INST(dev)->previous)); + dev->data = xzalloc (sizeof (usbhid_inst_t)); usb_debug (" configuring...\n"); usb_hid_set_protocol(dev, interface, hid_proto_boot); usb_hid_set_idle(dev, interface, KEYBOARD_REPEAT_MS); -- To view, visit https://review.coreboot.org/23766 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic987de2daaceaad2ae401a1e12b1bee397f802ee Gerrit-Change-Number: 23766 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: chromeec: Add google_chromeec_wait_for_display
by build bot (Jenkins) (Code Review) 15 Feb '18

15 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23745 ) Change subject: chromeec: Add google_chromeec_wait_for_display ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67500/ : SUCCESS -- To view, visit https://review.coreboot.org/23745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieee5db77bd6e147936ea8fc735dcbeffec98c0f8 Gerrit-Change-Number: 23745 Gerrit-PatchSet: 3 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Feb 2018 00:11:46 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/fizz: Wait until display is ready
by build bot (Jenkins) (Code Review) 15 Feb '18

15 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23746 ) Change subject: mb/google/fizz: Wait until display is ready ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67499/ : SUCCESS -- To view, visit https://review.coreboot.org/23746 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90befe94f93e13904987acda50b2598d034b0031 Gerrit-Change-Number: 23746 Gerrit-PatchSet: 3 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Feb 2018 00:00:13 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: chromeec: Add google_chromeec_get_alternate_mode
by build bot (Jenkins) (Code Review) 14 Feb '18

14 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23744 ) Change subject: chromeec: Add google_chromeec_get_alternate_mode ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67498/ : SUCCESS -- To view, visit https://review.coreboot.org/23744 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9b4ad06b61326fa167c77758603e038d817f928 Gerrit-Change-Number: 23744 Gerrit-PatchSet: 3 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Feb 2018 23:58:38 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: chromeec: Add google_chromeec_wait_for_display
by build bot (Jenkins) (Code Review) 14 Feb '18

14 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23745 ) Change subject: chromeec: Add google_chromeec_wait_for_display ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67496/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22032/ : SUCCESS -- To view, visit https://review.coreboot.org/23745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieee5db77bd6e147936ea8fc735dcbeffec98c0f8 Gerrit-Change-Number: 23745 Gerrit-PatchSet: 2 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Feb 2018 22:21:50 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/fizz: Wait until display is ready
by build bot (Jenkins) (Code Review) 14 Feb '18

14 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23746 ) Change subject: mb/google/fizz: Wait until display is ready ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67497/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22033/ : SUCCESS -- To view, visit https://review.coreboot.org/23746 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90befe94f93e13904987acda50b2598d034b0031 Gerrit-Change-Number: 23746 Gerrit-PatchSet: 2 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Feb 2018 22:13:17 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: chromeec: Add google_chromeec_get_alternate_mode
by build bot (Jenkins) (Code Review) 14 Feb '18

14 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23744 ) Change subject: chromeec: Add google_chromeec_get_alternate_mode ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67495/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22031/ : SUCCESS -- To view, visit https://review.coreboot.org/23744 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9b4ad06b61326fa167c77758603e038d817f928 Gerrit-Change-Number: 23744 Gerrit-PatchSet: 2 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Feb 2018 22:12:57 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2018