coreboot-gerrit February 2018

coreboot-gerrit@coreboot.org

1 participants
1573 discussions

Change in coreboot[master]: security/vboot: Add boot mode selection
by build bot (Jenkins) (Code Review) 15 Feb '18

15 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23756 ) Change subject: security/vboot: Add boot mode selection ...................................................................... Patch Set 16: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/67523/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/22053/ : SUCCESS -- To view, visit https://review.coreboot.org/23756 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43d233d5a8766af2dd7f07cc0b64293a80d5d7d2 Gerrit-Change-Number: 23756 Gerrit-PatchSet: 16 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Feb 2018 13:23:56 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: tianocore: fix Makefile to build a custom revision or branch
by build bot (Jenkins) (Code Review) 15 Feb '18

15 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22983 ) Change subject: tianocore: fix Makefile to build a custom revision or branch ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67521/ : SUCCESS -- To view, visit https://review.coreboot.org/22983 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9711a370eeade3cba0a9e127deb3d96d82adc512 Gerrit-Change-Number: 22983 Gerrit-PatchSet: 2 Gerrit-Owner: Gergely Kiss <mail.gery(a)gmail.com> Gerrit-Reviewer: Gergely Kiss <mail.gery(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Feb 2018 12:48:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mainboard/asus/am1i-a: fix interrupt routing definitions in DSDT
by build bot (Jenkins) (Code Review) 15 Feb '18

15 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23771 ) Change subject: mainboard/asus/am1i-a: fix interrupt routing definitions in DSDT ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67522/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22052/ : SUCCESS -- To view, visit https://review.coreboot.org/23771 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c95be7ba6207697afc7983d4b5f9d9a28584723 Gerrit-Change-Number: 23771 Gerrit-PatchSet: 1 Gerrit-Owner: Gergely Kiss <mail.gery(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Feb 2018 12:36:31 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/asus/am1i-a: fix interrupt routing definitions in DSDT
by Gergely Kiss (Code Review) 15 Feb '18

15 Feb '18

Gergely Kiss has uploaded this change for review. ( https://review.coreboot.org/23771 Change subject: mainboard/asus/am1i-a: fix interrupt routing definitions in DSDT ...................................................................... mainboard/asus/am1i-a: fix interrupt routing definitions in DSDT Incorrect interrupt routing configuration prevented handling interrupts for devices behind PCIe bridges 00:02.1 and 00:02.5. With the new configuration, devices work as expected. Tested with Linux 4.10 booted with the "pci=nomsi" parameter. Change-Id: I3c95be7ba6207697afc7983d4b5f9d9a28584723 Signed-off-by: Gergely Kiss <mail.gery(a)gmail.com> --- M src/mainboard/asus/am1i-a/acpi/routing.asl 1 file changed, 14 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/23771/1 diff --git a/src/mainboard/asus/am1i-a/acpi/routing.asl b/src/mainboard/asus/am1i-a/acpi/routing.asl index 76d1c47..95881fa 100644 --- a/src/mainboard/asus/am1i-a/acpi/routing.asl +++ b/src/mainboard/asus/am1i-a/acpi/routing.asl @@ -61,14 +61,14 @@ /* Bus 0, Dev 1, Func 0 - PCI Bridge for Internal Graphics(IGP) */ /* Bus 0, Dev 1, Func 1 - HDMI Audio Controller */ - Package(){0x0001FFFF, 0, 0, 16 }, - Package(){0x0001FFFF, 1, 0, 17 }, + Package(){0x0001FFFF, 0, 0, 44 }, + Package(){0x0001FFFF, 1, 0, 45 }, /* Bus 0, Dev 2 - PCIe Bridges */ - Package(){0x0002FFFF, 0, 0, 16 }, - Package(){0x0002FFFF, 1, 0, 17 }, - Package(){0x0002FFFF, 2, 0, 18 }, - Package(){0x0002FFFF, 3, 0, 19 }, + Package(){0x0002FFFF, 0, 0, 24 }, + Package(){0x0002FFFF, 1, 0, 25 }, + Package(){0x0002FFFF, 2, 0, 26 }, + Package(){0x0002FFFF, 3, 0, 27 }, /* SB devices in APIC mode */ /* Bus 0, Dev 20 - F0:SMBus/ACPI,F2:HDAudio;F3:LPC;F7:SD */ @@ -102,10 +102,10 @@ Package(){0x0000FFFF, 3, INTD, 0 }, }) Name(APS4, Package(){ - Package(){0x0000FFFF, 0, 0, 16 }, - Package(){0x0000FFFF, 1, 0, 17 }, - Package(){0x0000FFFF, 2, 0, 18 }, - Package(){0x0000FFFF, 3, 0, 19 }, + Package(){0x0000FFFF, 0, 0, 24 }, + Package(){0x0000FFFF, 1, 0, 25 }, + Package(){0x0000FFFF, 2, 0, 26 }, + Package(){0x0000FFFF, 3, 0, 27 }, }) /* GPP 1 - not used */ @@ -158,8 +158,8 @@ Package(){0x0000FFFF, 3, INTA, 0 }, }) Name(APS8, Package(){ - Package(){0x0000FFFF, 0, 0, 17 }, - Package(){0x0000FFFF, 1, 0, 18 }, - Package(){0x0000FFFF, 2, 0, 19 }, - Package(){0x0000FFFF, 3, 0, 16 }, + Package(){0x0000FFFF, 0, 0, 40 }, + Package(){0x0000FFFF, 1, 0, 41 }, + Package(){0x0000FFFF, 2, 0, 42 }, + Package(){0x0000FFFF, 3, 0, 43 }, }) -- To view, visit https://review.coreboot.org/23771 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3c95be7ba6207697afc7983d4b5f9d9a28584723 Gerrit-Change-Number: 23771 Gerrit-PatchSet: 1 Gerrit-Owner: Gergely Kiss <mail.gery(a)gmail.com>

1 0

Change in coreboot[master]: mb/google/zoombini/variants/meowth: enable FPMCU interrupt
by build bot (Jenkins) (Code Review) 15 Feb '18

15 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23769 ) Change subject: mb/google/zoombini/variants/meowth: enable FPMCU interrupt ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67519/ : SUCCESS -- To view, visit https://review.coreboot.org/23769 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic0cf03d2a3508148b6482a5a595eaa213eff52c7 Gerrit-Change-Number: 23769 Gerrit-PatchSet: 2 Gerrit-Owner: Vincent Palatin <vpalatin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Vincent Palatin <vpalatin(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Feb 2018 11:49:55 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/{soraka, poppy, nami, nautilus}: Set psys_max to 45W
by build bot (Jenkins) (Code Review) 15 Feb '18

15 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23757 ) Change subject: mb/google/{soraka,poppy,nami,nautilus}: Set psys_max to 45W ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67518/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22050/ : SUCCESS -- To view, visit https://review.coreboot.org/23757 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6f624733830b462329b5f539c20e2aea664143e Gerrit-Change-Number: 23757 Gerrit-PatchSet: 7 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Nicolas Boichat <drinkcat(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Feb 2018 11:13:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/{soraka, poppy, nami, nautilus}: Set psys_max to 45W
by build bot (Jenkins) (Code Review) 15 Feb '18

15 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23757 ) Change subject: mb/google/{soraka,poppy,nami,nautilus}: Set psys_max to 45W ...................................................................... Patch Set 6: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/67517/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/22049/ : SUCCESS -- To view, visit https://review.coreboot.org/23757 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6f624733830b462329b5f539c20e2aea664143e Gerrit-Change-Number: 23757 Gerrit-PatchSet: 6 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Nicolas Boichat <drinkcat(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Feb 2018 10:49:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/{soraka, poppy, nami, nautilus}: Set psys_max to 45W
by Naresh Solanki (Code Review) 15 Feb '18

15 Feb '18

Hello Sumeet R Pawnikar, Nicolas Boichat, Rizwan Qureshi, build bot (Jenkins), Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/23757 to look at the new patch set (#6). Change subject: mb/google/{soraka,poppy,nami,nautilus}: Set psys_max to 45W ...................................................................... mb/google/{soraka,poppy,nami,nautilus}: Set psys_max to 45W Soraka and variants are designed to operate at max power of 45 Watt. Hence set psys_max to 45W. BUG=b:66066340 BRANCH=None TEST=Build and boot soraka. Change-Id: If6f624733830b462329b5f539c20e2aea664143e Signed-off-by: Naresh G Solanki <naresh.solanki(a)intel.com> --- M src/drivers/generic/adau7002/chip.h M src/drivers/i2c/designware/dw_i2c.h A src/drivers/i2c/pca9538/Kconfig A src/drivers/i2c/pca9538/Makefile.inc A src/drivers/i2c/pca9538/chip.h A src/drivers/i2c/pca9538/pca9538.c A src/drivers/i2c/pca9538/pca9538.h M src/mainboard/google/kahlee/variants/grunt/spd/Makefile.inc M src/mainboard/google/poppy/variants/baseboard/devicetree.cb M src/mainboard/google/poppy/variants/nami/devicetree.cb M src/mainboard/google/poppy/variants/nautilus/devicetree.cb M src/mainboard/google/poppy/variants/soraka/devicetree.cb M src/mainboard/google/zoombini/variants/zoombini/spd/Makefile.inc M src/mainboard/intel/cannonlake_rvp/spd/Makefile.inc M src/mainboard/intel/kblrvp/spd/Makefile.inc M src/mainboard/siemens/mc_bdx1/Kconfig M src/mainboard/siemens/mc_bdx1/devicetree.cb M src/mainboard/siemens/mc_bdx1/mainboard.c M src/soc/amd/stoneyridge/model_15_init.c M src/soc/intel/cannonlake/romstage/romstage.c M src/vendorcode/intel/fsp/fsp2_0/cannonlake/FspmUpd.h M src/vendorcode/intel/fsp/fsp2_0/cannonlake/FspsUpd.h A src/vendorcode/intel/fsp/fsp2_0/cannonlake/FsptUpd.h M src/vendorcode/intel/fsp/fsp2_0/cannonlake/MemInfoHob.h 24 files changed, 440 insertions(+), 62 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/23757/6 -- To view, visit https://review.coreboot.org/23757 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If6f624733830b462329b5f539c20e2aea664143e Gerrit-Change-Number: 23757 Gerrit-PatchSet: 6 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Nicolas Boichat <drinkcat(a)chromium.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mainboard/google/zoombini/variants/meowth: enable FPMCU interrupt
by build bot (Jenkins) (Code Review) 15 Feb '18

15 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23769 ) Change subject: mainboard/google/zoombini/variants/meowth: enable FPMCU interrupt ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67516/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22048/ : SUCCESS -- To view, visit https://review.coreboot.org/23769 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic0cf03d2a3508148b6482a5a595eaa213eff52c7 Gerrit-Change-Number: 23769 Gerrit-PatchSet: 1 Gerrit-Owner: Vincent Palatin <vpalatin(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Feb 2018 08:59:35 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/zoombini/variants/meowth: enable FPMCU interrupt
by Vincent Palatin (Code Review) 15 Feb '18

15 Feb '18

Vincent Palatin has uploaded this change for review. ( https://review.coreboot.org/23769 Change subject: mainboard/google/zoombini/variants/meowth: enable FPMCU interrupt ...................................................................... mainboard/google/zoombini/variants/meowth: enable FPMCU interrupt Enable the micro-controller interrupt line as a real IRQ. BUG=b:71986991 BRANCH=none TEST=on Meowth, run 'ectool --name=cros_fp fpmode capture' and see the number of interrupts incrementing and the MKBP event happening. Change-Id: Ic0cf03d2a3508148b6482a5a595eaa213eff52c7 Signed-off-by: Vincent Palatin <vpalatin(a)chromium.org> --- M src/mainboard/google/zoombini/variants/meowth/gpio.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/23769/1 diff --git a/src/mainboard/google/zoombini/variants/meowth/gpio.c b/src/mainboard/google/zoombini/variants/meowth/gpio.c index 21c4bbc..7869dea 100644 --- a/src/mainboard/google/zoombini/variants/meowth/gpio.c +++ b/src/mainboard/google/zoombini/variants/meowth/gpio.c @@ -40,7 +40,8 @@ /* ISH_GP1 */ PAD_NC(GPP_A19, NONE), /* ISH_GP2 */ PAD_NC(GPP_A20, NONE), /* ISH_GP3 */ PAD_CFG_GPO(GPP_A21, 0, DEEP), /* PCH_FPMCU_BOOT0 */ -/* ISH_GP4 */ PAD_CFG_GPI(GPP_A22, NONE, DEEP), /* FPMCU_INT */ +/* ISH_GP4 */ PAD_CFG_GPI_APIC(GPP_A22, NONE, DEEP, LEVEL, + NONE), /* FPMCU_INT */ /* ISH_GP5 */ PAD_CFG_GPO(GPP_A23, 1, DEEP), /* PCH_FPMCU_RST_ODL */ /* CORE_VID0 */ PAD_CFG_NF(GPP_B0, NONE, DEEP, NF1), /* CORE_VID0 */ /* CORE_VID1 */ PAD_CFG_NF(GPP_B1, NONE, DEEP, NF1), /* CORE_VID1 */ -- To view, visit https://review.coreboot.org/23769 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic0cf03d2a3508148b6482a5a595eaa213eff52c7 Gerrit-Change-Number: 23769 Gerrit-PatchSet: 1 Gerrit-Owner: Vincent Palatin <vpalatin(a)chromium.org>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2018