coreboot-gerrit February 2018

coreboot-gerrit@coreboot.org

1 participants
1573 discussions

Change in coreboot[master]: mb/google/soraka: Set psys_max to 45W
by Nicolas Boichat (Code Review) 15 Feb '18

15 Feb '18

Nicolas Boichat has posted comments on this change. ( https://review.coreboot.org/23757 ) Change subject: mb/google/soraka: Set psys_max to 45W ...................................................................... Patch Set 5: > > This should apply to all poppy derivatives, not just soraka. > > > > Otherwise LGTM if the PSYS value matches values from the battery. > > I agree with you but I don't have exact data about other variants. > Can you please help confirm ? I Assume its 45W All poppy derivatives use the same 45W scale (that is, they use the same resistor on PSYS to turn the current source into voltage). -- To view, visit https://review.coreboot.org/23757 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6f624733830b462329b5f539c20e2aea664143e Gerrit-Change-Number: 23757 Gerrit-PatchSet: 5 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Nicolas Boichat <drinkcat(a)chromium.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Feb 2018 08:27:26 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: libpayload/drivers/usb: Fix broken retry counter
by build bot (Jenkins) (Code Review) 15 Feb '18

15 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23688 ) Change subject: libpayload/drivers/usb: Fix broken retry counter ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67512/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22045/ : SUCCESS -- To view, visit https://review.coreboot.org/23688 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c881c08d94636a43223338e46c876b5f3e27d47 Gerrit-Change-Number: 23688 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shawn Nematbakhsh <shawnn(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Feb 2018 07:14:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: libpayload/usb: Disable ports for unused devices
by build bot (Jenkins) (Code Review) 15 Feb '18

15 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23768 ) Change subject: libpayload/usb: Disable ports for unused devices ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67515/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22047/ : SUCCESS -- To view, visit https://review.coreboot.org/23768 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4882ba81cc0bed8dc0001f31142dc783e1f4259d Gerrit-Change-Number: 23768 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Feb 2018 07:10:20 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: libpayload/drivers/usb/uhci: Fix infinite loop
by build bot (Jenkins) (Code Review) 15 Feb '18

15 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23687 ) Change subject: libpayload/drivers/usb/uhci: Fix infinite loop ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67514/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22046/ : SUCCESS -- To view, visit https://review.coreboot.org/23687 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic652311e995e7addd807d2dda8e1c8f385a0d45c Gerrit-Change-Number: 23687 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Feb 2018 07:09:10 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: libpayload/drivers/usb: Fix leaks
by build bot (Jenkins) (Code Review) 15 Feb '18

15 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23689 ) Change subject: libpayload/drivers/usb: Fix leaks ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67513/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22044/ : SUCCESS -- To view, visit https://review.coreboot.org/23689 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2d80dd4590aa0dacdf2da3b614c6505c931d0be Gerrit-Change-Number: 23689 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Feb 2018 07:08:39 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: libpayload/drivers/usb/uhci: Fix regression
by build bot (Jenkins) (Code Review) 15 Feb '18

15 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23686 ) Change subject: libpayload/drivers/usb/uhci: Fix regression ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67511/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22043/ : SUCCESS -- To view, visit https://review.coreboot.org/23686 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I823521e24f6f9e04c86d36fda751c449cd884ce3 Gerrit-Change-Number: 23686 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Feb 2018 07:01:56 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: libpayload/usb: Disable ports for unused devices
by Patrick Rudolph (Code Review) 15 Feb '18

15 Feb '18

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/23768 Change subject: libpayload/usb: Disable ports for unused devices ...................................................................... libpayload/usb: Disable ports for unused devices USB devices that aren't controlled by libpayload due to missing driver support do have an address assigned libpayload doesn't know about. To avoid address conflicts disable the hub port if no driver is loaded after probing the device. Change-Id: I4882ba81cc0bed8dc0001f31142dc783e1f4259d Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M payloads/libpayload/drivers/usb/ehci_rh.c M payloads/libpayload/drivers/usb/generic_hub.c M payloads/libpayload/drivers/usb/ohci_rh.c M payloads/libpayload/drivers/usb/uhci_rh.c M payloads/libpayload/drivers/usb/usbhub.c M payloads/libpayload/drivers/usb/xhci_rh.c 6 files changed, 57 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/23768/1 diff --git a/payloads/libpayload/drivers/usb/ehci_rh.c b/payloads/libpayload/drivers/usb/ehci_rh.c index da8d8af..4eb8dfd 100644 --- a/payloads/libpayload/drivers/usb/ehci_rh.c +++ b/payloads/libpayload/drivers/usb/ehci_rh.c @@ -149,6 +149,22 @@ RH_INST(dev)->devices[port] = usb_attach_device(dev->controller , dev->address, port, port_speed); } + + if (RH_INST(dev)->devices[port] == -1) { + // Keep software and hardware state in sync. + // Disable port to make sure that the assigned address isn't + // valid any more. + // Deassert enable, assert reset. These must change atomically. + RH_INST(dev)->ports[port] = + (RH_INST(dev)->ports[port] & ~P_PORT_ENABLE) | P_PORT_RESET; + + /* Wait a bit while reset is active (+1 to avoid Tegra race). */ + mdelay(50 + 1); // usb20 spec 7.1.7.5 (TDRSTR) + + /* Deassert reset. */ + RH_INST(dev)->ports[port] &= ~P_PORT_RESET; + } + /* RW/C register, so clear it by writing 1 */ RH_INST(dev)->ports[port] |= P_CONN_STATUS_CHANGE; } diff --git a/payloads/libpayload/drivers/usb/generic_hub.c b/payloads/libpayload/drivers/usb/generic_hub.c index 9f86705..ea2b71f 100644 --- a/payloads/libpayload/drivers/usb/generic_hub.c +++ b/payloads/libpayload/drivers/usb/generic_hub.c @@ -177,6 +177,15 @@ hub->ports[port] = usb_attach_device( dev->controller, dev->address, port, speed); } + + if ((hub->ports[port] == -1) && hub->ops->disable_port) { + // Keep software and hardware state in sync. + // Disable port to make sure that the assigned address isn't + // valid any more. + if (hub->ops->disable_port(dev, port) < 0) + return -1; + } + return 0; } diff --git a/payloads/libpayload/drivers/usb/ohci_rh.c b/payloads/libpayload/drivers/usb/ohci_rh.c index 5d82bd5..770a563 100644 --- a/payloads/libpayload/drivers/usb/ohci_rh.c +++ b/payloads/libpayload/drivers/usb/ohci_rh.c @@ -128,6 +128,13 @@ usb_speed speed = (OHCI_INST(dev->controller)->opreg->HcRhPortStatus[port] & LowSpeedDeviceAttached) != 0; RH_INST (dev)->port[port] = usb_attach_device(dev->controller, dev->address, port, speed); + + if (RH_INST(dev)->port[port] == -1) { + // Keep software and hardware state in sync. + // Disable port to make sure that the assigned address isn't + // valid any more. + ohci_rh_disable_port(dev, port); + } } static int diff --git a/payloads/libpayload/drivers/usb/uhci_rh.c b/payloads/libpayload/drivers/usb/uhci_rh.c index e08cce1..742d491 100644 --- a/payloads/libpayload/drivers/usb/uhci_rh.c +++ b/payloads/libpayload/drivers/usb/uhci_rh.c @@ -137,6 +137,13 @@ RH_INST (dev)->port[offset] = usb_attach_device(dev->controller, dev->address, portsc, speed); } + + if (RH_INST(dev)->port[offset] == -1) { + // Keep software and hardware state in sync. + // Disable port to make sure that the assigned address isn't + // valid any more. + uhci_rh_disable_port(dev, port); + } } static int diff --git a/payloads/libpayload/drivers/usb/usbhub.c b/payloads/libpayload/drivers/usb/usbhub.c index 340e47a..18ed406 100644 --- a/payloads/libpayload/drivers/usb/usbhub.c +++ b/payloads/libpayload/drivers/usb/usbhub.c @@ -119,6 +119,12 @@ } static int +usb_hub_disable_port(usbdev_t *const dev, const int port) +{ + return clear_feature(dev, port, SEL_PORT_POWER, DR_PORT); +} + +static int usb_hub_start_port_reset(usbdev_t *const dev, const int port) { return set_feature (dev, port, SEL_PORT_RESET, DR_PORT); @@ -153,7 +159,7 @@ .port_enabled = usb_hub_port_enabled, .port_speed = usb_hub_port_speed, .enable_port = usb_hub_enable_port, - .disable_port = NULL, + .disable_port = usb_hub_disable_port, .start_port_reset = usb_hub_start_port_reset, .reset_port = generic_hub_resetport, }; diff --git a/payloads/libpayload/drivers/usb/xhci_rh.c b/payloads/libpayload/drivers/usb/xhci_rh.c index d7ba82c..5650076 100644 --- a/payloads/libpayload/drivers/usb/xhci_rh.c +++ b/payloads/libpayload/drivers/usb/xhci_rh.c @@ -136,6 +136,16 @@ return 0; } +static int +xhci_rh_disable_port(usbdev_t *const dev, int port) +{ + xhci_t *const xhci = XHCI_INST(dev->controller); + volatile u32 *const portsc = + &xhci->opreg->prs[port - 1].portsc; + + *portsc = ((*portsc & PORTSC_RW_MASK) | PORTSC_PED) & ~PORTSC_PP; + return 0; +} static const generic_hub_ops_t xhci_rh_ops = { .hub_status_changed = xhci_rh_hub_status_changed, @@ -145,7 +155,7 @@ .port_enabled = xhci_rh_port_enabled, .port_speed = xhci_rh_port_speed, .enable_port = xhci_rh_enable_port, - .disable_port = NULL, + .disable_port = xhci_rh_disable_port, .start_port_reset = NULL, .reset_port = xhci_rh_reset_port, }; -- To view, visit https://review.coreboot.org/23768 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4882ba81cc0bed8dc0001f31142dc783e1f4259d Gerrit-Change-Number: 23768 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: [TESTONLY]mb/google/soraka: Fix the Camera Switching issue.
by V Sowmya (Code Review) 15 Feb '18

15 Feb '18

V Sowmya has abandoned this change. ( https://review.coreboot.org/22897 ) Change subject: [TESTONLY]mb/google/soraka: Fix the Camera Switching issue. ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/22897 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I5a54b45bec5fbc297701e9c2c46ef3911eb8a65c Gerrit-Change-Number: 22897 Gerrit-PatchSet: 1 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jenny Tc <jenny.tc(a)intel.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>

1 0

Change in coreboot[master]: siemens/mc_bdx1: Show mainboard hardware version on console
by build bot (Jenkins) (Code Review) 15 Feb '18

15 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23750 ) Change subject: siemens/mc_bdx1: Show mainboard hardware version on console ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67510/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22042/ : SUCCESS -- To view, visit https://review.coreboot.org/23750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33bae8b340fce13c0cbe525521828929038b069a Gerrit-Change-Number: 23750 Gerrit-PatchSet: 5 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Alex Thiessen <alex.thiessen.de+coreboot(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Feb 2018 05:32:49 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: siemens/mc_bdx1: Enable PCA9538 I/O expander
by build bot (Jenkins) (Code Review) 15 Feb '18

15 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23749 ) Change subject: siemens/mc_bdx1: Enable PCA9538 I/O expander ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67509/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22041/ : SUCCESS -- To view, visit https://review.coreboot.org/23749 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98c667fe4dccf0698ab4cb5ede6082f020c70ec6 Gerrit-Change-Number: 23749 Gerrit-PatchSet: 4 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Feb 2018 05:29:43 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2018