coreboot-gerrit February 2018

coreboot-gerrit@coreboot.org

1 participants
1573 discussions

Change in coreboot[master]: intel/sandybridge: Add RAM voltage hooks
by build bot (Jenkins) (Code Review) 17 Feb '18

17 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22806 ) Change subject: intel/sandybridge: Add RAM voltage hooks ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67659/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22167/ : SUCCESS -- To view, visit https://review.coreboot.org/22806 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic714c0717a66089dad4423d4eca5a0a29b7af817 Gerrit-Change-Number: 22806 Gerrit-PatchSet: 4 Gerrit-Owner: Tobias Diedrich <ranma+coreboot(a)tdiedrich.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tobias Diedrich <ranma+coreboot(a)tdiedrich.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 17 Feb 2018 23:51:38 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: intel/dcp847ske: Enable GBE ACPI device DSM label
by build bot (Jenkins) (Code Review) 17 Feb '18

17 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22834 ) Change subject: intel/dcp847ske: Enable GBE ACPI device DSM label ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67658/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22166/ : SUCCESS -- To view, visit https://review.coreboot.org/22834 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I505d13c5644674da251db352c0bd622e85d5148f Gerrit-Change-Number: 22834 Gerrit-PatchSet: 3 Gerrit-Owner: Tobias Diedrich <ranma+coreboot(a)tdiedrich.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 17 Feb 2018 23:47:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: chromeec: Make google_chromeec_wait_for_display wait for HPD
by build bot (Jenkins) (Code Review) 17 Feb '18

17 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23801 ) Change subject: chromeec: Make google_chromeec_wait_for_display wait for HPD ...................................................................... Patch Set 2: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/67656/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/22164/ : SUCCESS -- To view, visit https://review.coreboot.org/23801 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07aee3bcca3bca93db66578014500b578402a4de Gerrit-Change-Number: 23801 Gerrit-PatchSet: 2 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 17 Feb 2018 20:14:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/nvidia/tegra210: add missing bl31 params to ATF config
by build bot (Jenkins) (Code Review) 17 Feb '18

17 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23783 ) Change subject: soc/nvidia/tegra210: add missing bl31 params to ATF config ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67655/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22163/ : SUCCESS -- To view, visit https://review.coreboot.org/23783 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a47647216a154894e6c2c1fd3b304e18e85c6a5 Gerrit-Change-Number: 23783 Gerrit-PatchSet: 4 Gerrit-Owner: Andre Heider <a.heider(a)gmail.com> Gerrit-Reviewer: Andre Heider <a.heider(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 17 Feb 2018 17:46:58 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/nvidia/tegra210: define missing UART clocks sources
by build bot (Jenkins) (Code Review) 17 Feb '18

17 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23794 ) Change subject: soc/nvidia/tegra210: define missing UART clocks sources ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67652/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22160/ : SUCCESS -- To view, visit https://review.coreboot.org/23794 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7243812fba6f30f1db4db868b258794e7b248be8 Gerrit-Change-Number: 23794 Gerrit-PatchSet: 2 Gerrit-Owner: Andre Heider <a.heider(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 17 Feb 2018 17:12:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/nvidia/tegra210: add console UART helper functions
by build bot (Jenkins) (Code Review) 17 Feb '18

17 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23795 ) Change subject: soc/nvidia/tegra210: add console UART helper functions ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67653/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22161/ : SUCCESS -- To view, visit https://review.coreboot.org/23795 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71423a0424927ff383bcbf194c9fbaa452d810a1 Gerrit-Change-Number: 23795 Gerrit-PatchSet: 2 Gerrit-Owner: Andre Heider <a.heider(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 17 Feb 2018 17:11:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/nvidia/tegra210: set up the clock of the chosen UART
by build bot (Jenkins) (Code Review) 17 Feb '18

17 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23796 ) Change subject: soc/nvidia/tegra210: set up the clock of the chosen UART ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67654/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22162/ : SUCCESS -- To view, visit https://review.coreboot.org/23796 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife209d42af83459136a019c21c2a069396ab36db Gerrit-Change-Number: 23796 Gerrit-PatchSet: 2 Gerrit-Owner: Andre Heider <a.heider(a)gmail.com> Gerrit-Reviewer: Andre Heider <a.heider(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 17 Feb 2018 17:08:51 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: chromeec: Make google_chromeec_wait_for_display wait for HPD
by Julius Werner (Code Review) 17 Feb '18

17 Feb '18

Julius Werner has posted comments on this change. ( https://review.coreboot.org/23801 ) Change subject: chromeec: Make google_chromeec_wait_for_display wait for HPD ...................................................................... Patch Set 1: (3 comments) https://review.coreboot.org/#/c/23801/1/src/ec/google/chromeec/ec.c File src/ec/google/chromeec/ec.c: https://review.coreboot.org/#/c/23801/1/src/ec/google/chromeec/ec.c@999 PS1, Line 999: return google_chromeec_command(&cmd) == EC_RES_SUCCESS ? 1 : 0; Should this also return 1 (true), 0 (false) or -1 (error) for consistency with get_amode()? https://review.coreboot.org/#/c/23801/1/src/ec/google/chromeec/ec.c@1003 PS1, Line 1003: other monitor port (e.g. HDMI) is used The second part here doesn't sound great. I think it's fine to let the timeout expire if we have no monitor at all, but if we have HDMI attached it should really not need to wait. Doesn't get_amode() return an SID for HDMI that you could check for so you can abort when you see that? https://review.coreboot.org/#/c/23801/1/src/ec/google/chromeec/ec_commands.h File src/ec/google/chromeec/ec_commands.h: https://review.coreboot.org/#/c/23801/1/src/ec/google/chromeec/ec_commands.… PS1, Line 4423: #define EC_CMD_GET_HPD 0x0121 I do not see this landed in the EC source tree? Again please never touch ec_commands.h directly in a downstream repository like coreboot. Instead, always land the change in the EC repository first, then copy the whole file from the ToT EC repository over to coreboot (preferably as a separate commit). -- To view, visit https://review.coreboot.org/23801 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07aee3bcca3bca93db66578014500b578402a4de Gerrit-Change-Number: 23801 Gerrit-PatchSet: 1 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 17 Feb 2018 04:26:53 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: chromeec: Make google_chromeec_wait_for_display wait for HPD
by build bot (Jenkins) (Code Review) 17 Feb '18

17 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23801 ) Change subject: chromeec: Make google_chromeec_wait_for_display wait for HPD ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67649/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22157/ : SUCCESS -- To view, visit https://review.coreboot.org/23801 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07aee3bcca3bca93db66578014500b578402a4de Gerrit-Change-Number: 23801 Gerrit-PatchSet: 1 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 17 Feb 2018 03:06:38 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: chromeec: Make google_chromeec_wait_for_display wait for HPD
by Daisuke Nojiri (Code Review) 17 Feb '18

17 Feb '18

Daisuke Nojiri has uploaded this change for review. ( https://review.coreboot.org/23801 Change subject: chromeec: Make google_chromeec_wait_for_display wait for HPD ...................................................................... chromeec: Make google_chromeec_wait_for_display wait for HPD Some type-c monitors do not immediately assert HPD. If we continue to boot without HPD asserted, Depthcharge fails to show pictures on a monitor even if HPD is asserted later. This patch makes google_chromeec_wait_for_display wait until EC_CMD_GET_HPD returns EC_RES_SUCCESS. BUG=b:72387533 BRANCH=none TEST=Verify Depthcharge can show dev warning screen on a type-c monitor. Change-Id: I07aee3bcca3bca93db66578014500b578402a4de Signed-off-by: Daisuke Nojiri <dnojiri(a)chromium.org> --- M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/ec_commands.h 2 files changed, 38 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/23801/1 diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c index c902c3f..1005266 100644 --- a/src/ec/google/chromeec/ec.c +++ b/src/ec/google/chromeec/ec.c @@ -986,7 +986,25 @@ return 0; } -const static long wait_for_display_timeout_ms = 2000; +static int google_chromeec_get_hpd(void) +{ + struct chromeec_command cmd; + cmd.cmd_code = EC_CMD_GET_HPD; + cmd.cmd_version = 0; + cmd.cmd_data_in = NULL; + cmd.cmd_size_in = 0; + cmd.cmd_data_out = NULL; + cmd.cmd_size_out = 0; + cmd.cmd_dev_index = 0; + return google_chromeec_command(&cmd) == EC_RES_SUCCESS ? 1 : 0; +} + +/* + * TODO: If no monitor is plugged in or other monitor port (e.g. HDMI) is used, + * this timeout always needs to expire. Make EC detect type-c device presence + * and abort earlier when waiting does not make sense. + */ +const static long wait_for_display_timeout_ms = 3000; #define USB_SID_DISPLAYPORT 0xff01 @@ -994,17 +1012,31 @@ { struct stopwatch sw; - printk(BIOS_INFO, "Waiting for display\n"); + printk(BIOS_INFO, "Waiting for DisplayPort\n"); stopwatch_init_msecs_expire(&sw, wait_for_display_timeout_ms); while (google_chromeec_pd_get_amode(USB_SID_DISPLAYPORT) != 1) { if (stopwatch_expired(&sw)) { printk(BIOS_WARNING, - "Display not ready after %ldms. Abort.\n", + "DisplayPort not ready after %ldms. Abort.\n", wait_for_display_timeout_ms); return; } mdelay(200); } - printk(BIOS_INFO, "Display ready after %lu ms\n", + printk(BIOS_INFO, "DisplayPort ready after %lu ms\n", + stopwatch_duration_msecs(&sw)); + + printk(BIOS_INFO, "Waiting for HPD\n"); + stopwatch_init_msecs_expire(&sw, wait_for_display_timeout_ms); + while (!google_chromeec_get_hpd()) { + if (stopwatch_expired(&sw)) { + printk(BIOS_WARNING, + "HPD not ready after %ldms. Abort.\n", + wait_for_display_timeout_ms); + return; + } + mdelay(200); + } + printk(BIOS_INFO, "HPD ready after %lu ms\n", stopwatch_duration_msecs(&sw)); } diff --git a/src/ec/google/chromeec/ec_commands.h b/src/ec/google/chromeec/ec_commands.h index 4f46fab..a5a5623 100644 --- a/src/ec/google/chromeec/ec_commands.h +++ b/src/ec/google/chromeec/ec_commands.h @@ -4420,6 +4420,8 @@ uint8_t data[]; /* For string and raw data */ }; +#define EC_CMD_GET_HPD 0x0121 + /*****************************************************************************/ /* The command range 0x200-0x2FF is reserved for Rotor. */ -- To view, visit https://review.coreboot.org/23801 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I07aee3bcca3bca93db66578014500b578402a4de Gerrit-Change-Number: 23801 Gerrit-PatchSet: 1 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2018