coreboot-gerrit February 2018

coreboot-gerrit@coreboot.org

1 participants
1573 discussions

Change in coreboot[master]: libpayload/drivers/usb: Fix leaks
by build bot (Jenkins) (Code Review) 18 Feb '18

18 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23689 ) Change subject: libpayload/drivers/usb: Fix leaks ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67665/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22171/ : SUCCESS -- To view, visit https://review.coreboot.org/23689 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2d80dd4590aa0dacdf2da3b614c6505c931d0be Gerrit-Change-Number: 23689 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 18 Feb 2018 17:18:52 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: tlibpayload/drivers/usb/uhci: Fix infinite loop
by build bot (Jenkins) (Code Review) 18 Feb '18

18 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23687 ) Change subject: tlibpayload/drivers/usb/uhci: Fix infinite loop ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67666/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22172/ : SUCCESS -- To view, visit https://review.coreboot.org/23687 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic652311e995e7addd807d2dda8e1c8f385a0d45c Gerrit-Change-Number: 23687 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 18 Feb 2018 17:14:42 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src/mainboard/ibase/mb899: Fix typo in comment
by build bot (Jenkins) (Code Review) 18 Feb '18

18 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23790 ) Change subject: src/mainboard/ibase/mb899: Fix typo in comment ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67664/ : SUCCESS -- To view, visit https://review.coreboot.org/23790 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia79a42ed60e82a84b60f254a0895ec52c1fcda0b Gerrit-Change-Number: 23790 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 18 Feb 2018 14:45:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: Fizz: Check HDMI HPD and DisplayPort HPD
by build bot (Jenkins) (Code Review) 18 Feb '18

18 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23803 ) Change subject: Fizz: Check HDMI HPD and DisplayPort HPD ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67663/ : SUCCESS -- To view, visit https://review.coreboot.org/23803 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f80c3058b0d4ddc5056d20688e794cd8415da2d Gerrit-Change-Number: 23803 Gerrit-PatchSet: 2 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 18 Feb 2018 01:27:34 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: chromeec: Update google_chromeec_wait_for_display API
by build bot (Jenkins) (Code Review) 18 Feb '18

18 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23801 ) Change subject: chromeec: Update google_chromeec_wait_for_display API ...................................................................... Patch Set 3: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/67661/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/22169/ : SUCCESS -- To view, visit https://review.coreboot.org/23801 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07aee3bcca3bca93db66578014500b578402a4de Gerrit-Change-Number: 23801 Gerrit-PatchSet: 3 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 18 Feb 2018 01:16:59 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Fizz: Check HDMI HPD and DisplayPort HPD
by build bot (Jenkins) (Code Review) 18 Feb '18

18 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23803 ) Change subject: Fizz: Check HDMI HPD and DisplayPort HPD ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/67662/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/22170/ : SUCCESS -- To view, visit https://review.coreboot.org/23803 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f80c3058b0d4ddc5056d20688e794cd8415da2d Gerrit-Change-Number: 23803 Gerrit-PatchSet: 1 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 18 Feb 2018 01:16:56 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Fizz: Check HDMI HPD and DisplayPort HPD
by Daisuke Nojiri (Code Review) 18 Feb '18

18 Feb '18

Hello Julius Werner, Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/23803 to look at the new patch set (#2). Change subject: Fizz: Check HDMI HPD and DisplayPort HPD ...................................................................... Fizz: Check HDMI HPD and DisplayPort HPD Some type-c monitors do not immediately assert HPD. If we continue to boot without HPD asserted, Depthcharge fails to show pictures on a monitor even if HPD is asserted later. Also, if HDMI monitor is connected, no wait is needed. If only HDMI monitor is connected, the API always loops until stopwatch expires. This patch will make google_chromeec_wait_for_displayport first check HDMI HPD. If it's asserted, it returns immediately. If not, it loops until DP HPD is asserted. This patch also extends the wait time to 3 seconds. BUG=b:72387533 BRANCH=none TEST=Verify firmware screen is displayed even when a type-c monitor does not imeediately assert HPD. Verify if HDMI monitor is connected, AP does not wait (and firmware screen is displayed on HDMI monitor). Change-Id: I8f80c3058b0d4ddc5056d20688e794cd8415da2d Signed-off-by: Daisuke Nojiri <dnojiri(a)chromium.org> --- M src/mainboard/google/fizz/ramstage.c 1 file changed, 38 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/23803/2 -- To view, visit https://review.coreboot.org/23803 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8f80c3058b0d4ddc5056d20688e794cd8415da2d Gerrit-Change-Number: 23803 Gerrit-PatchSet: 2 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>

1 0

Change in coreboot[master]: Fizz: Check HDMI HPD and DisplayPort HPD
by Daisuke Nojiri (Code Review) 18 Feb '18

18 Feb '18

Daisuke Nojiri has uploaded this change for review. ( https://review.coreboot.org/23803 Change subject: Fizz: Check HDMI HPD and DisplayPort HPD ...................................................................... Fizz: Check HDMI HPD and DisplayPort HPD Some type-c monitors do not immediately assert HPD. If we continue to boot without HPD asserted, Depthcharge fails to show pictures on a monitor even if HPD is asserted later. Also, if HDMI monitor is connected, no wait is needed. If only HDMI monitor is connected, the API always loops until stopwatch expires. This patch makes google_chromeec_wait_for_display first check HDMI HPD. If it's asserted, it returns immediately. If not, it loops until DP HPD is asserted. This patch also extends the wait time to 3 seconds. BUG=b:72387533 BRANCH=none TEST=Verify firmware screen is displayed even when a type-c monitor does not imeediately assert HPD. Verify if HDMI monitor is connected, AP does not wait (and firmware screen is displayed on HDMI monitor). Change-Id: I8f80c3058b0d4ddc5056d20688e794cd8415da2d Signed-off-by: Daisuke Nojiri <dnojiri(a)chromium.org> --- M src/mainboard/google/fizz/ramstage.c 1 file changed, 38 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/23803/1 diff --git a/src/mainboard/google/fizz/ramstage.c b/src/mainboard/google/fizz/ramstage.c index e5215f8..f7520fa 100644 --- a/src/mainboard/google/fizz/ramstage.c +++ b/src/mainboard/google/fizz/ramstage.c @@ -14,15 +14,51 @@ */ #include <bootmode.h> +#include <console/console.h> +#include <delay.h> #include <ec/google/chromeec/ec.h> +#include <gpio.h> +#include <mainboard/google/fizz/gpio.h> +#include <soc/gpio.h> #include <soc/ramstage.h> +#include <timer.h> #include "gpio.h" +#define GPIO_HDMI_HPD GPP_E13 +#define GPIO_DP_HPD GPP_E14 + +const static long display_timeout_ms = 3000; + +/* TODO: This can be moved to common directory */ +static void wait_for_hpd(gpio_t gpio, long timeout) +{ + struct stopwatch sw; + + printk(BIOS_INFO, "Waiting for HPD\n"); + gpio_input(gpio); + + stopwatch_init_msecs_expire(&sw, timeout); + while (!gpio_get(gpio)) { + if (stopwatch_expired(&sw)) { + printk(BIOS_WARNING, + "HPD not ready after %ldms. Abort.\n", timeout); + return; + } + mdelay(200); + } + printk(BIOS_INFO, "HPD ready after %lu ms\n", + stopwatch_duration_msecs(&sw)); +} + void mainboard_silicon_init_params(FSP_SIL_UPD *params) { - if (display_init_required()) + gpio_input(GPIO_HDMI_HPD); + if (display_init_required() && !gpio_get(GPIO_HDMI_HPD)) { /* This has to be done before FSP-S runs. */ - google_chromeec_wait_for_display(); + if (google_chromeec_wait_for_displayport(display_timeout_ms)) + wait_for_hpd(GPIO_DP_HPD, display_timeout_ms); + } + gpio_configure_pads(gpio_table, ARRAY_SIZE(gpio_table)); } -- To view, visit https://review.coreboot.org/23803 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8f80c3058b0d4ddc5056d20688e794cd8415da2d Gerrit-Change-Number: 23803 Gerrit-PatchSet: 1 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org>

1 0

Change in coreboot[master]: intel/dcp847ske: Enable RAM voltage setting
by build bot (Jenkins) (Code Review) 18 Feb '18

18 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22836 ) Change subject: intel/dcp847ske: Enable RAM voltage setting ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67660/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22168/ : SUCCESS -- To view, visit https://review.coreboot.org/22836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib0e2b4e90b5eda2da14834f4721649fd77ec1025 Gerrit-Change-Number: 22836 Gerrit-PatchSet: 3 Gerrit-Owner: Tobias Diedrich <ranma+coreboot(a)tdiedrich.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tobias Diedrich <ranma+coreboot(a)tdiedrich.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 18 Feb 2018 00:00:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: intel/bd82x6x: Add GBE ACPI device
by build bot (Jenkins) (Code Review) 17 Feb '18

17 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22807 ) Change subject: intel/bd82x6x: Add GBE ACPI device ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67657/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22165/ : SUCCESS -- To view, visit https://review.coreboot.org/22807 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I02613169498eed3d6d9ea5963ea3c2c08a40ef99 Gerrit-Change-Number: 22807 Gerrit-PatchSet: 4 Gerrit-Owner: Tobias Diedrich <ranma+coreboot(a)tdiedrich.de> Gerrit-Reviewer: Jean Lucas <jean(a)4ray.co> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tobias Diedrich <ranma+coreboot(a)tdiedrich.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 17 Feb 2018 23:52:49 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2018