Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/23800
Change subject: util/cbmem: Re-order regex for "cbmem -1"
......................................................................
util/cbmem: Re-order regex for "cbmem -1"
In case of console dump for only the last boot, cbmem utility checks
for a list of regex in provided order. When pre-cbmem console
overflows, "Pre-CBMEM <stage> console overflowed.. " message is added
before "... <stage> starting" message. This change fixes the order of
regex in cbmem utility to match this.
Test=Verified on soraka that "cbmem -1" correctly dumps the data
starting from Pre-CBMEM romstage overflowed.
Change-Id: I9c5667bbd02ed3e93ac77a4f42e87d754a062919
Signed-off-by: Furquan Shaikh <furquan(a)chromium.org>
---
M util/cbmem/cbmem.c
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/23800/1
diff --git a/util/cbmem/cbmem.c b/util/cbmem/cbmem.c
index 09957ba..eae5da3 100644
--- a/util/cbmem/cbmem.c
+++ b/util/cbmem/cbmem.c
@@ -727,10 +727,10 @@
#define BANNER_REGEX(stage) "\n\ncoreboot-[^\n]* " stage " starting\\.\\.\\.\n"
#define OVERFLOW_REGEX(stage) "\n\\*\\*\\* Pre-CBMEM " stage " console overflow"
const char *regex[] = { BANNER_REGEX("bootblock"),
- BANNER_REGEX("romstage"),
OVERFLOW_REGEX("romstage"),
- BANNER_REGEX("ramstage"),
- OVERFLOW_REGEX("ramstage") };
+ BANNER_REGEX("romstage"),
+ OVERFLOW_REGEX("ramstage"),
+ BANNER_REGEX("ramstage") };
int i;
for (i = 0; !cursor && i < ARRAY_SIZE(regex); i++) {
--
To view, visit https://review.coreboot.org/23800
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c5667bbd02ed3e93ac77a4f42e87d754a062919
Gerrit-Change-Number: 23800
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23071 )
Change subject: payloads: Add LinuxBoot payload in u-root mode
......................................................................
Patch Set 18: Verified+1
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/67647/ : SUCCESS
https://qa.coreboot.org/job/coreboot-checkpatch/22155/ : SUCCESS
--
To view, visit https://review.coreboot.org/23071
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a25ff6812e046acc688cbbb203cf262ad751659
Gerrit-Change-Number: 23071
Gerrit-PatchSet: 18
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Alex Thiessen <alex.thiessen.de+coreboot(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Chris K <c(a)chrisko.ch>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich
Gerrit-Comment-Date: Sat, 17 Feb 2018 01:16:10 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes