coreboot-gerrit February 2018

coreboot-gerrit@coreboot.org

1 participants
1573 discussions

Change in coreboot[master]: mb/siemens/mc_bdx1: Avoid dereferencing a NULL pointer
by build bot (Jenkins) (Code Review) 19 Feb '18

19 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23808 ) Change subject: mb/siemens/mc_bdx1: Avoid dereferencing a NULL pointer ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67674/ : SUCCESS -- To view, visit https://review.coreboot.org/23808 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75e271d86c16fa3938420c43575ebba910f6a2fd Gerrit-Change-Number: 23808 Gerrit-PatchSet: 3 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 19 Feb 2018 11:37:10 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/siemens/mc_bdx1: Avoid dereferencing a NULL pointer
by build bot (Jenkins) (Code Review) 19 Feb '18

19 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23808 ) Change subject: mb/siemens/mc_bdx1: Avoid dereferencing a NULL pointer ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/67673/ : ABORTED -- To view, visit https://review.coreboot.org/23808 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75e271d86c16fa3938420c43575ebba910f6a2fd Gerrit-Change-Number: 23808 Gerrit-PatchSet: 2 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 19 Feb 2018 11:33:17 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/common/block/smm: Add option to have SOC specific SMI Handler
by build bot (Jenkins) (Code Review) 19 Feb '18

19 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23810 ) Change subject: soc/intel/common/block/smm: Add option to have SOC specific SMI Handler ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67672/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22178/ : SUCCESS -- To view, visit https://review.coreboot.org/23810 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50fb154cc1ad4b3459bc352d2065f2c582711c20 Gerrit-Change-Number: 23810 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 19 Feb 2018 10:33:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/common/block/pcr: Function for executing PCH SBI message
by build bot (Jenkins) (Code Review) 19 Feb '18

19 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23809 ) Change subject: soc/intel/common/block/pcr: Function for executing PCH SBI message ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67671/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22177/ : SUCCESS -- To view, visit https://review.coreboot.org/23809 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e49311564e20cedbfabaaceaf5f72c480e5ea26 Gerrit-Change-Number: 23809 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 19 Feb 2018 10:31:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/common/block/smm: Add option to have SOC specific SMI Handler
by Subrata Banik (Code Review) 19 Feb '18

19 Feb '18

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/23810 Change subject: soc/intel/common/block/smm: Add option to have SOC specific SMI Handler ...................................................................... soc/intel/common/block/smm: Add option to have SOC specific SMI Handler This patch ensures common code provides an option to register a SOC specific SMI handler. Change-Id: I50fb154cc1ad4b3459bc352d2065f2c582711c20 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/soc/intel/common/block/include/intelblocks/smihandler.h M src/soc/intel/common/block/smm/smihandler.c 2 files changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/23810/1 diff --git a/src/soc/intel/common/block/include/intelblocks/smihandler.h b/src/soc/intel/common/block/include/intelblocks/smihandler.h index df2d17c..565b1e8 100644 --- a/src/soc/intel/common/block/include/intelblocks/smihandler.h +++ b/src/soc/intel/common/block/include/intelblocks/smihandler.h @@ -148,6 +148,9 @@ /* SoC overrides. */ +/* SMI handlers implemented inside SOC for MISC operation */ +void smihandler_soc_misc(void); + /* * This function returns a 1 or 0 depending on whether disable_busmaster * needs to be done for the specified device on S5 entry diff --git a/src/soc/intel/common/block/smm/smihandler.c b/src/soc/intel/common/block/smm/smihandler.c index 8a877c3..1dc61d1 100644 --- a/src/soc/intel/common/block/smm/smihandler.c +++ b/src/soc/intel/common/block/smm/smihandler.c @@ -38,6 +38,12 @@ /* SoC overrides. */ +/* SMI handlers implemented inside SOC for MISC operation */ +__attribute__((weak)) void smihandler_soc_misc(void) +{ + return; +} + __attribute__((weak)) int smihandler_soc_disable_busmaster(device_t dev) { return 1; @@ -278,6 +284,9 @@ if (IS_ENABLED(CONFIG_SPI_FLASH_SMM)) /* Re-init SPI driver to handle locked BAR */ fast_spi_init(); + + /* Specific SOC SMI handler */ + smihandler_soc_misc(); } void smihandler_southbridge_apmc( -- To view, visit https://review.coreboot.org/23810 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I50fb154cc1ad4b3459bc352d2065f2c582711c20 Gerrit-Change-Number: 23810 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>

1 0

Change in coreboot[master]: soc/intel/common/block/pcr: Function for executing PCH SBI message
by Subrata Banik (Code Review) 19 Feb '18

19 Feb '18

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/23809 Change subject: soc/intel/common/block/pcr: Function for executing PCH SBI message ...................................................................... soc/intel/common/block/pcr: Function for executing PCH SBI message This function to perform SBI communication Input: * PID: Port ID of the SBI message * Offset: Register offset of the SBI message * Opcode: Opcode * Posted: Posted message * Fast_Byte_Enable: First Byte Enable * BAR: base address * FID: Function ID * Data: Read/Write Data * Response: Response Output: * 0: SBI message is Successfully completed * -1: SBI message failure Change-Id: I4e49311564e20cedbfabaaceaf5f72c480e5ea26 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/soc/intel/common/block/include/intelblocks/pcr.h M src/soc/intel/common/block/pcr/pcr.c 2 files changed, 233 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/23809/1 diff --git a/src/soc/intel/common/block/include/intelblocks/pcr.h b/src/soc/intel/common/block/include/intelblocks/pcr.h index cfe0015..0127f17 100644 --- a/src/soc/intel/common/block/include/intelblocks/pcr.h +++ b/src/soc/intel/common/block/include/intelblocks/pcr.h @@ -38,6 +38,39 @@ void pcr_or16(uint8_t pid, uint16_t offset, uint16_t ordata); void pcr_or8(uint8_t pid, uint16_t offset, uint8_t ordata); +/* SBI command */ +enum { + MEM_READ = 0, + MEM_WRITE = 1, + PCI_CONFIG_READ = 4, + PCI_CONFIG_WRITE = 5, + PCR_READ = 6, + PCR_WRITE = 7, + GPIO_LOCK_UNLOCK = 13, +}; + +/* + * API to perform sideband communication + * + * Input: + * PID: Port ID of the SBI message + * Offset: Register offset of the SBI message + * Opcode: Opcode + * Posted: Posted message + * Fast_Byte_Enable: First Byte Enable + * BAR: base address + * FID: Function ID + * Data: Read/Write Data + * Response: Response + * + * Output: + * 0: SBI message is Successfully completed + * -1: SBI message failure + */ +int pcr_execute_sideband_msg(uint8_t pid, uint32_t offset, uint8_t opcode, + bool is_posted, uint16_t fast_byte_enable, uint16_t bar, + uint16_t fid, uint32_t *data, uint8_t *response); + /* Get the starting address of the port's registers. */ void *pcr_reg_address(uint8_t pid, uint16_t offset); #endif /* if !defined(__ACPI__) */ diff --git a/src/soc/intel/common/block/pcr/pcr.c b/src/soc/intel/common/block/pcr/pcr.c index 4264cdf..28c93c2 100644 --- a/src/soc/intel/common/block/pcr/pcr.c +++ b/src/soc/intel/common/block/pcr/pcr.c @@ -15,13 +15,41 @@ #include <arch/io.h> #include <assert.h> +#include <console/console.h> #include <intelblocks/pcr.h> +#include <soc/pci_devs.h> #include <soc/pcr_ids.h> #if !defined(CONFIG_PCR_BASE_ADDRESS) || (CONFIG_PCR_BASE_ADDRESS == 0) #error "PCR_BASE_ADDRESS need to be non-zero!" #endif +/* P2SB PCI configuration register */ +#define P2SB_CR_SBI_ADDR 0xd0 +#define P2SB_CR_SBI_DESTID 24 +#define P2SB_CR_SBI_DATA 0xd4 +#define P2SB_CR_SBI_STATUS 0xd8 +/* Bit 15:8 */ +#define P2SB_CR_SBI_OPCODE 8 +/* Bit 7 */ +#define P2SB_CR_SBI_POSTED 7 +/* Bit 2-1 */ +#define P2SB_CR_SBI_STATUS_SUCCESS 0 +#define P2SB_CR_SBI_STATUS_NOT_SUPPORTED 1 +#define P2SB_CR_SBI_STATUS_POWERED_DOWN 2 +#define P2SB_CR_SBI_STATUS_MULTI_CAST_MIXED 3 +/* Bit 0 */ +#define P2SB_CR_SBI_STATUS_READY 0 +#define P2SB_CR_SBI_STATUS_BUSY 1 +#define P2SB_CR_SBI_ROUTE_IDEN 0xda +/* Bit 15-12 */ +#define P2SB_CR_SBI_FBE 12 +/* Bit 10-8 */ +#define P2SB_CR_SBI_BAR 8 +/* Bit 7-0 */ +#define P2SB_CR_SBI_FID 0 +#define P2SB_CR_SBI_EXT_ADDR 0xdc + static void *__pcr_reg_address(uint8_t pid, uint16_t offset) { uintptr_t reg_addr; @@ -178,3 +206,175 @@ data8 |= ordata; pcr_write8(pid, offset, data8); } + +static int pcr_check_for_timeout(device_t dev) +{ + uint32_t timeout; + + timeout = 0xFFFFFFF; + while (timeout > 0) { + if ((pci_read_config16 (dev, P2SB_CR_SBI_STATUS) & + P2SB_CR_SBI_STATUS_BUSY) == 0) + break; + timeout--; + } + + /* Timed out */ + if (timeout == 0) + return -1; + + return 0; +} + +/* + * API to perform sideband communication + * + * Input: + * PID: Port ID of the SBI message + * Offset: Register offset of the SBI message + * Opcode: Opcode + * Posted: Posted message + * Fast_Byte_Enable: First Byte Enable + * BAR: base address + * FID: Function ID + * Data: Read/Write Data + * Response: Response + * + * Output: + * 0: SBI message is Successfully completed + * -1: SBI message failure + */ +int pcr_execute_sideband_msg(uint8_t pid, uint32_t offset, uint8_t opcode, + bool is_posted, uint16_t fast_byte_enable, uint16_t bar, + uint16_t fid, uint32_t *data, uint8_t *response) +{ + device_t dev = PCH_DEV_P2SB; + uint32_t sbi_data; + uint16_t sbi_status; + + switch(opcode) { + case MEM_READ: + case MEM_WRITE: + case PCI_CONFIG_READ: + case PCI_CONFIG_WRITE: + case PCR_READ: + case PCR_WRITE: + case GPIO_LOCK_UNLOCK: + break; + default: + printk(BIOS_DEBUG, "SBI Failure: Wrong Input!\n"); + return -1; + break; + } + + if (pci_read_config16(dev, PCI_VENDOR_ID) == 0xffff) { + printk(BIOS_DEBUG, "SBI Failure: P2SB device Hidden!\n"); + return -1; + } + + /* + * BWG Section 2.2.1 + * 1. Poll P2SB PCI offset D8h[0] = 0b + * Make sure the previous opeartion is completed. + */ + if (pcr_check_for_timeout(dev)) { + printk(BIOS_DEBUG, "SBI Failure: Time Out!\n"); + return -1; + } + + /* Initial Response status */ + *response = 0xFF; + sbi_status = 0; + + /* + * 2. Write P2SB PCI offset D0h[31:0] with Address + * and Destination Port ID + */ + pci_write_config32 (dev, P2SB_CR_SBI_ADDR, + (uint32_t) ((pid << P2SB_CR_SBI_DESTID) | (uint16_t) offset)); + + /* + * 3. Write P2SB PCI offset DCh[31:0] with extended address, + * which is expected to be 0 in CNL PCH + */ + pci_write_config32 (dev, P2SB_CR_SBI_EXT_ADDR, + (uint32_t) (offset >> 16)); + + /* + * 4. Set P2SB PCI offset D8h[15:8] = 00000110b for read + * Set P2SB PCI offset D8h[15:8] = 00000111b for write + * + * Set SBISTAT[15:8] to the opcode passed in + * Set SBISTAT[7] to the posted passed in + */ + sbi_status = pci_read_config16 (dev, P2SB_CR_SBI_STATUS); + sbi_status &= ~(0xFF00 | (1 << P2SB_CR_SBI_POSTED)); + sbi_status |= ((opcode << P2SB_CR_SBI_OPCODE) | + (is_posted << P2SB_CR_SBI_POSTED)); + pci_write_config16 (dev, P2SB_CR_SBI_STATUS, sbi_status); + + /* + * 5. Write P2SB PCI offset DAh[15:0] = F000h + * + * Set RID[15:0] = Fbe << 12 | Bar << 8 | Fid + */ + pci_write_config16 (dev, P2SB_CR_SBI_ROUTE_IDEN, (uint16_t) ( + ((fast_byte_enable & 0x000F) << P2SB_CR_SBI_FBE) | + ((bar & 0x0007) << P2SB_CR_SBI_BAR) | + (fid & 0x00FF))); + + switch(opcode) { + case MEM_WRITE: + case PCI_CONFIG_WRITE: + case PCR_WRITE: + /* + * 6. Write P2SB PCI offset D4h[31:0] with the + * intended data accordingly + */ + sbi_data = *data; + pci_write_config32 (dev, P2SB_CR_SBI_DATA, sbi_data); + break; + default: + /* 6. Write P2SB PCI offset D4h[31:0] with dummy data */ + sbi_data = 0; + pci_write_config32 (dev, P2SB_CR_SBI_DATA, sbi_data); + break; + } + + /* + * 7. Set P2SB PCI offset D8h[0] = 1b, Poll P2SB PCI offset D8h[0] = 0b + * + * Set SBISTAT[0] = 1b, trigger the SBI operation + */ + sbi_status = pci_read_config16 (dev, P2SB_CR_SBI_STATUS); + sbi_status |= P2SB_CR_SBI_STATUS_BUSY; + pci_write_config16 (dev, P2SB_CR_SBI_STATUS, sbi_status); + + /* Poll SBISTAT[0] = 0b, Polling for Busy bit */ + if (pcr_check_for_timeout(dev)) { + printk(BIOS_DEBUG, "SBI Failure: Time Out!\n"); + return -1; + } + + /* + * 8. Check if P2SB PCI offset D8h[2:1] = 00b for + * successful transaction + */ + *response = (uint8_t) ((sbi_status & 0x0006) >> 1); + if (*response == P2SB_CR_SBI_STATUS_SUCCESS) { + switch(opcode) { + case MEM_READ: + case PCI_CONFIG_READ: + case PCR_READ: + sbi_data = pci_read_config32 (dev, P2SB_CR_SBI_DATA); + *data = sbi_data; + break; + default: + break; + } + return 0; + } else { + printk(BIOS_DEBUG, "SBI Failure: Transaction Failure!\n"); + return -1; + } +} -- To view, visit https://review.coreboot.org/23809 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4e49311564e20cedbfabaaceaf5f72c480e5ea26 Gerrit-Change-Number: 23809 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>

1 0

Change in coreboot[master]: mb/scaleway/tagada: Add Scalway Tagada Board
by Julien Viard de Galbert (Code Review) 19 Feb '18

19 Feb '18

Julien Viard de Galbert has abandoned this change. ( https://review.coreboot.org/23782 ) Change subject: mb/scaleway/tagada: Add Scalway Tagada Board ...................................................................... Abandoned The multi commit version is merged in -- To view, visit https://review.coreboot.org/23782 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Id4ecb760b9ab07ab168b252542dcaaea4636d655 Gerrit-Change-Number: 23782 Gerrit-PatchSet: 1 Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert(a)online.net> Gerrit-Reviewer: Julien Viard de Galbert <jviarddegalbert(a)online.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mc_bdx1: Fix coverity error
by build bot (Jenkins) (Code Review) 19 Feb '18

19 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23808 ) Change subject: mc_bdx1: Fix coverity error ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67670/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22176/ : SUCCESS -- To view, visit https://review.coreboot.org/23808 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75e271d86c16fa3938420c43575ebba910f6a2fd Gerrit-Change-Number: 23808 Gerrit-PatchSet: 1 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 19 Feb 2018 09:27:59 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mc_bdx1: Fix coverity error
by Werner Zeh (Code Review) 19 Feb '18

19 Feb '18

Werner Zeh has uploaded this change for review. ( https://review.coreboot.org/23808 Change subject: mc_bdx1: Fix coverity error ...................................................................... mc_bdx1: Fix coverity error Coverity scan has found an error (CID 1386126) where a NULL pointer is dereferenced. The bug would happen if the devicetree does not contain a valid entry for PCA9538. In this case the code * if (dev->path.i2c.device == PCA9538_SLAVE_ADR) would dereference to a NULL pointer. This patch fixes this issue. Thanks coverity! Change-Id: I75e271d86c16fa3938420c43575ebba910f6a2fd Signed-off-by: Werner Zeh <werner.zeh(a)siemens.com> --- M src/mainboard/siemens/mc_bdx1/mainboard.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/23808/1 diff --git a/src/mainboard/siemens/mc_bdx1/mainboard.c b/src/mainboard/siemens/mc_bdx1/mainboard.c index ebc6d40..da7da91 100644 --- a/src/mainboard/siemens/mc_bdx1/mainboard.c +++ b/src/mainboard/siemens/mc_bdx1/mainboard.c @@ -259,11 +259,11 @@ struct device *pca9538_get_dev(void) { struct device *dev = NULL; - do { - dev = dev_find_path(dev, DEVICE_PATH_I2C); + + while ((dev = dev_find_path(dev, DEVICE_PATH_I2C))) { if (dev->path.i2c.device == PCA9538_SLAVE_ADR) break; - } while (dev); + }; return dev; } -- To view, visit https://review.coreboot.org/23808 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I75e271d86c16fa3938420c43575ebba910f6a2fd Gerrit-Change-Number: 23808 Gerrit-PatchSet: 1 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com>

1 0

Change in coreboot[master]: libpayload/usb: Disable ports for unused devices
by build bot (Jenkins) (Code Review) 18 Feb '18

18 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23768 ) Change subject: libpayload/usb: Disable ports for unused devices ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67667/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22173/ : SUCCESS -- To view, visit https://review.coreboot.org/23768 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4882ba81cc0bed8dc0001f31142dc783e1f4259d Gerrit-Change-Number: 23768 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 18 Feb 2018 17:21:05 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2018