coreboot-gerrit February 2018

coreboot-gerrit@coreboot.org

1 participants
1573 discussions

Change in coreboot[master]: amd/stoneyridge: Move model_15_init.c to cpu.c
by build bot (Jenkins) (Code Review) 16 Feb '18

16 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23724 ) Change subject: amd/stoneyridge: Move model_15_init.c to cpu.c ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67629/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22138/ : SUCCESS -- To view, visit https://review.coreboot.org/23724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8c62b09209fcdaa50ff8ffc7773ef155f979a1b Gerrit-Change-Number: 23724 Gerrit-PatchSet: 2 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 16 Feb 2018 22:23:29 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/nvidia/tegra210: add missing bl31 params to ATF config
by Andre Heider (Code Review) 16 Feb '18

16 Feb '18

Andre Heider has posted comments on this change. ( https://review.coreboot.org/23783 ) Change subject: soc/nvidia/tegra210: add missing bl31 params to ATF config ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/23783/3/src/soc/nvidia/tegra210/arm_tf.c File src/soc/nvidia/tegra210/arm_tf.c: https://review.coreboot.org/#/c/23783/3/src/soc/nvidia/tegra210/arm_tf.c@46 PS3, Line 46: switch (console_uart_get_id()) { > I don't really care, whatever you prefer Okay, so lets keep it this way then. The switch statement has the bonus of additional compiler checks in case the enum gets changed in the future. Thanks for the reviews! -- To view, visit https://review.coreboot.org/23783 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a47647216a154894e6c2c1fd3b304e18e85c6a5 Gerrit-Change-Number: 23783 Gerrit-PatchSet: 3 Gerrit-Owner: Andre Heider <a.heider(a)gmail.com> Gerrit-Reviewer: Andre Heider <a.heider(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 16 Feb 2018 21:41:49 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/kahlee/OemCustomize.c: Disable bank interleave
by build bot (Jenkins) (Code Review) 16 Feb '18

16 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23763 ) Change subject: mb/google/kahlee/OemCustomize.c: Disable bank interleave ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67626/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22135/ : SUCCESS -- To view, visit https://review.coreboot.org/23763 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice9270f9b10051dbb622344919223cf5439f5d7b Gerrit-Change-Number: 23763 Gerrit-PatchSet: 2 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 16 Feb 2018 21:40:27 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/nvidia/tegra210: add missing bl31 params to ATF config
by Julius Werner (Code Review) 16 Feb '18

16 Feb '18

Julius Werner has posted comments on this change. ( https://review.coreboot.org/23783 ) Change subject: soc/nvidia/tegra210: add missing bl31 params to ATF config ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/23783/3/src/soc/nvidia/tegra210/arm_tf.c File src/soc/nvidia/tegra210/arm_tf.c: https://review.coreboot.org/#/c/23783/3/src/soc/nvidia/tegra210/arm_tf.c@46 PS3, Line 46: switch (console_uart_get_id()) { > Hehe yeah, I was thinking about that too. […] I don't really care, whatever you prefer -- To view, visit https://review.coreboot.org/23783 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a47647216a154894e6c2c1fd3b304e18e85c6a5 Gerrit-Change-Number: 23783 Gerrit-PatchSet: 3 Gerrit-Owner: Andre Heider <a.heider(a)gmail.com> Gerrit-Reviewer: Andre Heider <a.heider(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 16 Feb 2018 21:37:04 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/nvidia/tegra210: add missing bl31 params to ATF config
by Andre Heider (Code Review) 16 Feb '18

16 Feb '18

Andre Heider has posted comments on this change. ( https://review.coreboot.org/23783 ) Change subject: soc/nvidia/tegra210: add missing bl31 params to ATF config ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/23783/3/src/soc/nvidia/tegra210/arm_tf.c File src/soc/nvidia/tegra210/arm_tf.c: https://review.coreboot.org/#/c/23783/3/src/soc/nvidia/tegra210/arm_tf.c@46 PS3, Line 46: switch (console_uart_get_id()) { > nit: if you just shifted your enum in the other patch by one you wouldn't need this ;) Hehe yeah, I was thinking about that too. But I want to use those console_uart.h helpers in src/mainboard/ code too, and this ordering (none/invalid<0, first uart=0) felt more natural. But I don't have a strong preference either way, do you want me to change it? -- To view, visit https://review.coreboot.org/23783 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a47647216a154894e6c2c1fd3b304e18e85c6a5 Gerrit-Change-Number: 23783 Gerrit-PatchSet: 3 Gerrit-Owner: Andre Heider <a.heider(a)gmail.com> Gerrit-Reviewer: Andre Heider <a.heider(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 16 Feb 2018 21:34:45 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Normalize GPIO init
by build bot (Jenkins) (Code Review) 16 Feb '18

16 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23679 ) Change subject: soc/amd/stoneyridge: Normalize GPIO init ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67625/ : SUCCESS -- To view, visit https://review.coreboot.org/23679 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic97db96581a69798b193a6bdeb93644f6a74fc9d Gerrit-Change-Number: 23679 Gerrit-PatchSet: 6 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 16 Feb 2018 21:19:38 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Normalize GPIO init
by build bot (Jenkins) (Code Review) 16 Feb '18

16 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23679 ) Change subject: soc/amd/stoneyridge: Normalize GPIO init ...................................................................... Patch Set 5: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/67624/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/22134/ : SUCCESS -- To view, visit https://review.coreboot.org/23679 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic97db96581a69798b193a6bdeb93644f6a74fc9d Gerrit-Change-Number: 23679 Gerrit-PatchSet: 5 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 16 Feb 2018 21:10:52 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: payloads: Add LinuxBoot payload in u-root mode
by Philipp Deppenwiese (Code Review) 16 Feb '18

16 Feb '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/23071 ) Change subject: payloads: Add LinuxBoot payload in u-root mode ...................................................................... Patch Set 17: (28 comments) https://review.coreboot.org/#/c/23071/11/payloads/external/LinuxBoot/Makefi… File payloads/external/LinuxBoot/Makefile: https://review.coreboot.org/#/c/23071/11/payloads/external/LinuxBoot/Makefi… PS11, Line 26: > why not fail when mkdir fails? Done https://review.coreboot.org/#/c/23071/11/payloads/external/LinuxBoot/Makefi… PS11, Line 28: > why not fail when tar fails? Done https://review.coreboot.org/#/c/23071/11/payloads/external/LinuxBoot/Makefi… PS11, Line 31: config: $(kernel_dir)/.config > depends on $(kernel_dir) Done https://review.coreboot.org/#/c/23071/11/payloads/external/LinuxBoot/Makefi… PS11, Line 33: ifneq ($(CONFIG_LINUXBOOT_KERNEL_CON > ifneq ($(CONFIG_LINUXBOOT_KERNEL_CONFIGFILE),"") Done https://review.coreboot.org/#/c/23071/11/payloads/external/LinuxBoot/Makefi… PS11, Line 35: endif > else. otherwise the default config always override it. Done https://review.coreboot.org/#/c/23071/11/payloads/external/LinuxBoot/Makefi… PS11, Line 43: $(project_dir)/kernel-image: config > depends on $(kernel_dir)/. […] Done https://review.coreboot.org/#/c/23071/11/payloads/external/LinuxBoot/Makefi… PS11, Line 46: CPUS) > don't we have CPUS variable for this? Done https://review.coreboot.org/#/c/23071/11/payloads/external/LinuxBoot/Makefi… PS11, Line 51: x86 > ok, seems confusing though Done https://review.coreboot.org/#/c/23071/11/payloads/external/LinuxBoot/Makefi… PS11, Line 54: $(project_dir)/kernel-image > not a direct dependency Done https://review.coreboot.org/#/c/23071/11/payloads/external/LinuxBoot/Makefi… PS11, Line 56: $(MAKE) > I mean, does it make sense to maybe translate `CPUS` be to `--jobs` here? Will it accelerate anythin […] Done https://review.coreboot.org/#/c/23071/11/payloads/external/LinuxBoot/Makefi… PS11, Line 60: test -e $(project_dir)/kernel-image & > isn't needed, its result isn't even used Done https://review.coreboot.org/#/c/23071/11/payloads/external/LinuxBoot/Makefi… PS11, Line 61: test -e $(project_dir)/initramfs.cpio.xz & > isn't needed, its result isn't even used Done https://review.coreboot.org/#/c/23071/11/payloads/external/LinuxBoot/Makefi… PS11, Line 62: > not needed Done https://review.coreboot.org/#/c/23071/11/payloads/external/LinuxBoot/Makefi… PS11, Line 65: > If deleting fails, `make distclean` should fail too, shouldn't it? If so, no `exit 0` should be here […] Done https://review.coreboot.org/#/c/23071/11/payloads/external/LinuxBoot/Makefi… PS11, Line 65: > globbing will spare hidden files and directories, is this intentional? Done https://review.coreboot.org/#/c/23071/11/payloads/external/LinuxBoot/Makefi… PS11, Line 70: > contains non-existent targets […] Done https://review.coreboot.org/#/c/23071/11/payloads/external/LinuxBoot/target… File payloads/external/LinuxBoot/targets/u-root.mk: https://review.coreboot.org/#/c/23071/11/payloads/external/LinuxBoot/target… PS11, Line 18: ir=$(shell pwd)/linuxboot > command -v go 1>/dev/null 2>&1 && echo go […] Done https://review.coreboot.org/#/c/23071/11/payloads/external/LinuxBoot/target… PS11, Line 29: > Was the intent here that we not fail if the directory exists? mkdir -p won't fail in that case: […] Done https://review.coreboot.org/#/c/23071/11/payloads/external/LinuxBoot/target… PS11, Line 51: exit 1 > did you test whether a `git am` failure will make `make` stop here? Cause it's in a subshell... Done https://review.coreboot.org/#/c/23071/11/payloads/external/LinuxBoot/target… PS11, Line 55: $(project_dir)/initramfs.cpio.xz: checkout > depends on checkout Done https://review.coreboot.org/#/c/23071/11/payloads/external/LinuxBoot/target… PS11, Line 60: cd $(uroot_dir); GOARCH=$(CONFIG_LINUXBOOT_ARCH) GOPATH=$(go_path_dir) ./u-root -build=bb -files $(CONFIG_LINUXBOOT_UROOT_FILES) -o $(project_dir)/initramfs.cpio ./cmds/{$(CONFIG_LINUXBOOT_UROOT_COMMANDS)} > a too long line Done https://review.coreboot.org/#/c/23071/11/payloads/external/LinuxBoot/target… PS11, Line 60: $(project_dir) > where is it going, I don't know Done https://review.coreboot.org/#/c/23071/11/payloads/external/LinuxBoot/target… PS11, Line 62: {$(CONFIG_LINUXBOOT_UROOT_COMMANDS)} > my `dash` doesn't support the '{}' notation Done https://review.coreboot.org/#/c/23071/11/payloads/external/LinuxBoot/target… PS11, Line 62: cd $(uroot_dir); GOARCH=$(CONFIG_LINUXBOOT_ARCH) GOPATH=$(go_path_dir) ./u-root -build=bb -o $(project_dir)/initramfs.cpio ./cmds/{$(CONFIG_LINUXBOOT_UROOT_COMMANDS)} > a too long line Done https://review.coreboot.org/#/c/23071/11/payloads/external/LinuxBoot/target… PS11, Line 66: cd $(uroot_dir); GOARCH=$(CONFIG_LINUXBOOT_ARCH) GOPATH=$(go_path_dir) ./u-root -build=bb -files $(CONFIG_LINUXBOOT_UROOT_FILES) -o $(project_dir)/initramfs.cpio > a too long line Done https://review.coreboot.org/#/c/23071/11/payloads/external/LinuxBoot/target… PS11, Line 68: cd $(uroot_dir); GOARCH=$(CONFIG_LINUXBOOT_ARCH) GOPATH=$(go_path_dir) ./u-root -build=bb -o $(project_dir)/initramfs.cpio > a too long line Done https://review.coreboot.org/#/c/23071/11/payloads/external/LinuxBoot/target… PS11, Line 73: $(projec > not a direct dependency, this is likely to break parallel build Done https://review.coreboot.org/#/c/23071/11/payloads/external/LinuxBoot/target… PS11, Line 75: .PHONY: build checkout fetch all check > isn't complete (e.g. […] Done -- To view, visit https://review.coreboot.org/23071 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a25ff6812e046acc688cbbb203cf262ad751659 Gerrit-Change-Number: 23071 Gerrit-PatchSet: 17 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Alex Thiessen <alex.thiessen.de+coreboot(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Chris K <c(a)chrisko.ch> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich Gerrit-Comment-Date: Fri, 16 Feb 2018 20:28:05 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/nvidia/tegra210: add missing bl31 params to ATF config
by Julius Werner (Code Review) 16 Feb '18

16 Feb '18

Julius Werner has posted comments on this change. ( https://review.coreboot.org/23783 ) Change subject: soc/nvidia/tegra210: add missing bl31 params to ATF config ...................................................................... Patch Set 3: Code-Review+2 (1 comment) https://review.coreboot.org/#/c/23783/3/src/soc/nvidia/tegra210/arm_tf.c File src/soc/nvidia/tegra210/arm_tf.c: https://review.coreboot.org/#/c/23783/3/src/soc/nvidia/tegra210/arm_tf.c@46 PS3, Line 46: switch (console_uart_get_id()) { nit: if you just shifted your enum in the other patch by one you wouldn't need this ;) -- To view, visit https://review.coreboot.org/23783 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a47647216a154894e6c2c1fd3b304e18e85c6a5 Gerrit-Change-Number: 23783 Gerrit-PatchSet: 3 Gerrit-Owner: Andre Heider <a.heider(a)gmail.com> Gerrit-Reviewer: Andre Heider <a.heider(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 16 Feb 2018 19:13:13 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/nvidia/tegra210: set up the clock of the chosen UART
by Julius Werner (Code Review) 16 Feb '18

16 Feb '18

Julius Werner has posted comments on this change. ( https://review.coreboot.org/23796 ) Change subject: soc/nvidia/tegra210: set up the clock of the chosen UART ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/23796 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife209d42af83459136a019c21c2a069396ab36db Gerrit-Change-Number: 23796 Gerrit-PatchSet: 1 Gerrit-Owner: Andre Heider <a.heider(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 16 Feb 2018 19:12:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2018