Jonathan Neuschäfer has posted comments on this change. ( https://review.coreboot.org/23783 )
Change subject: soc/nvidia/tegra210: add missing bl31 params to ATF config
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/23783
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a47647216a154894e6c2c1fd3b304e18e85c6a5
Gerrit-Change-Number: 23783
Gerrit-PatchSet: 3
Gerrit-Owner: Andre Heider <a.heider(a)gmail.com>
Gerrit-Reviewer: Andre Heider <a.heider(a)gmail.com>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 16 Feb 2018 14:59:26 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Andre Heider has posted comments on this change. ( https://review.coreboot.org/23783 )
Change subject: soc/nvidia/tegra210: add missing bl31 params to ATF config
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/23783/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/23783/2//COMMIT_MSG@7
PS2, Line 7: ms
> "soc/nvidia/tegra210: add missing bl31 params to ATF config" maybe? […]
Sounds good to me! Done, thanks!
--
To view, visit https://review.coreboot.org/23783
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a47647216a154894e6c2c1fd3b304e18e85c6a5
Gerrit-Change-Number: 23783
Gerrit-PatchSet: 3
Gerrit-Owner: Andre Heider <a.heider(a)gmail.com>
Gerrit-Reviewer: Andre Heider <a.heider(a)gmail.com>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 16 Feb 2018 14:56:42 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Hello Julius Werner, Jonathan Neuschäfer, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/23783
to look at the new patch set (#3).
Change subject: soc/nvidia/tegra210: add missing bl31 params to ATF config
......................................................................
soc/nvidia/tegra210: add missing bl31 params to ATF config
The ATF tegra210 platform supports more than the currently used
'tzdram_size' parameter, see plat/nvidia/tegra/include/tegra_private.h
in the ATF tree.
Add the missing parameters and set them accordingly. The passed UART id
is based on CONFIG_CONSOLE_SERIAL_TEGRA210_UARTx, so ATF now uses the
same port for console output as coreboot.
Successfully tested with UARTB.
Change-Id: I7a47647216a154894e6c2c1fd3b304e18e85c6a5
Signed-off-by: Andre Heider <a.heider(a)gmail.com>
---
M src/soc/nvidia/tegra210/arm_tf.c
1 file changed, 31 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/23783/3
--
To view, visit https://review.coreboot.org/23783
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a47647216a154894e6c2c1fd3b304e18e85c6a5
Gerrit-Change-Number: 23783
Gerrit-PatchSet: 3
Gerrit-Owner: Andre Heider <a.heider(a)gmail.com>
Gerrit-Reviewer: Andre Heider <a.heider(a)gmail.com>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23071 )
Change subject: payloads: Add LinuxBoot payload in u-root mode
......................................................................
Patch Set 15:
Build Unstable
https://qa.coreboot.org/job/coreboot-gerrit/67609/ : UNSTABLE
https://qa.coreboot.org/job/coreboot-checkpatch/22126/ : SUCCESS
--
To view, visit https://review.coreboot.org/23071
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a25ff6812e046acc688cbbb203cf262ad751659
Gerrit-Change-Number: 23071
Gerrit-PatchSet: 15
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Alex Thiessen <alex.thiessen.de+coreboot(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Chris K <c(a)chrisko.ch>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich
Gerrit-Comment-Date: Fri, 16 Feb 2018 14:53:39 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No