coreboot-gerrit February 2018

coreboot-gerrit@coreboot.org

1 participants
1573 discussions

Change in coreboot[master]: mb/google/nautilus: To work around the power issue of MIPI and USB ca...
by build bot (Jenkins) (Code Review) 02 Feb '18

02 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23546 ) Change subject: mb/google/nautilus: To work around the power issue of MIPI and USB cameras ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66946/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21528/ : SUCCESS -- To view, visit https://review.coreboot.org/23546 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icaaf7e17447492f2e2f2d03eb9a35bcc53667f28 Gerrit-Change-Number: 23546 Gerrit-PatchSet: 2 Gerrit-Owner: Andy Yeh <andy.yeh(a)intel.corp-partner.google.com> Gerrit-Reviewer: Andy Yeh Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Feb 2018 03:05:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: google/scarlet: Innolux P097PFG panel use new version initial code
by Matthias Kaehlcke (Code Review) 02 Feb '18

02 Feb '18

Matthias Kaehlcke has posted comments on this change. ( https://review.coreboot.org/23561 ) Change subject: google/scarlet: Innolux P097PFG panel use new version initial code ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Verified to be working on dru. Matches the kernel sequence from https://crosreview.com/890565 LGTM besides the comments on the commit message. https://review.coreboot.org/#/c/23561/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/23561/1//COMMIT_MSG@7 PS1, Line 7: google/scarlet: Innolux P097PFG panel use new version initial code : : There is artifact line in the lower third of the display with now : initial code. So update this initial code to fix this issue. You could also mention that this is a sequence provided by Innolux, as opposed to the register dump hack that we merged initially. https://review.coreboot.org/#/c/23561/1//COMMIT_MSG@12 PS1, Line 12: BUG=b:69689064, b:72191820 : BRANCH=gru : TEST=boot on dru with an Innolux panel and artifact line disappear. I'm not really familiar with coreboot upstream work, but I suppose these Chrome OS specific tags are meaningless here. -- To view, visit https://review.coreboot.org/23561 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9679c4f7f706fd6cd2e1dba7ec79e772fe3f227a Gerrit-Change-Number: 23561 Gerrit-PatchSet: 1 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Matthias Kaehlcke <mka(a)chromium.org> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Feb 2018 02:55:32 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: google/scarlet: Innolux P097PFG panel use new version initial code
by build bot (Jenkins) (Code Review) 02 Feb '18

02 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23561 ) Change subject: google/scarlet: Innolux P097PFG panel use new version initial code ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66945/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21527/ : SUCCESS -- To view, visit https://review.coreboot.org/23561 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9679c4f7f706fd6cd2e1dba7ec79e772fe3f227a Gerrit-Change-Number: 23561 Gerrit-PatchSet: 1 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Matthias Kaehlcke <mka(a)chromium.org> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Feb 2018 02:18:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: google/scarlet: Innolux P097PFG panel use new version initial code
by Lin Huang (Code Review) 02 Feb '18

02 Feb '18

Lin Huang has removed Philip Chen from this change. ( https://review.coreboot.org/23561 ) Change subject: google/scarlet: Innolux P097PFG panel use new version initial code ...................................................................... Removed reviewer Philip Chen. -- To view, visit https://review.coreboot.org/23561 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: I9679c4f7f706fd6cd2e1dba7ec79e772fe3f227a Gerrit-Change-Number: 23561 Gerrit-PatchSet: 1 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Matthias Kaehlcke <mka(a)chromium.org>

1 0

Change in coreboot[master]: google/scarlet: Innolux P097PFG panel use new version initial code
by Lin Huang (Code Review) 02 Feb '18

02 Feb '18

Lin Huang has uploaded this change for review. ( https://review.coreboot.org/23561 Change subject: google/scarlet: Innolux P097PFG panel use new version initial code ...................................................................... google/scarlet: Innolux P097PFG panel use new version initial code There is artifact line in the lower third of the display with now initial code. So update this initial code to fix this issue. BUG=b:69689064, b:72191820 BRANCH=gru TEST=boot on dru with an Innolux panel and artifact line disappear. Change-Id: I9679c4f7f706fd6cd2e1dba7ec79e772fe3f227a Signed-off-by: Lin Huang <hl(a)rock-chips.com> --- M src/mainboard/google/gru/mainboard.c 1 file changed, 91 insertions(+), 82 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/23561/1 diff --git a/src/mainboard/google/gru/mainboard.c b/src/mainboard/google/gru/mainboard.c index 3ab26fc..7cd9acd 100644 --- a/src/mainboard/google/gru/mainboard.c +++ b/src/mainboard/google/gru/mainboard.c @@ -378,100 +378,109 @@ static struct panel_init_command innolux_p097pfg_init_cmds[] = { /* page 0 */ - MIPI_INIT_CMD(0xf0, 0x55, 0xaa, 0x52, 0x08, 0x00), - MIPI_INIT_CMD(0xb1, 0xe8, 0x11), - MIPI_INIT_CMD(0xb2, 0x25, 0x02), - MIPI_INIT_CMD(0xb5, 0x08, 0x00), - MIPI_INIT_CMD(0xbc, 0x0f, 0x00), - MIPI_INIT_CMD(0xb8, 0x03, 0x06, 0x00, 0x00), - MIPI_INIT_CMD(0xbd, 0x01, 0x90, 0x14, 0x14), - MIPI_INIT_CMD(0xc0, 0x17), - MIPI_INIT_CMD(0xc1, 0x17), - MIPI_INIT_CMD(0xd9, 0x01, 0x09, 0x70), - MIPI_INIT_CMD(0xc5, 0x12, 0x21, 0x00), - MIPI_INIT_CMD(0xbb, 0x23, 0x23), + MIPI_INIT_CMD(0xF0, 0x55, 0xAA, 0x52, 0x08, 0x00), + MIPI_INIT_CMD(0xB1, 0xE8, 0x11), + MIPI_INIT_CMD(0xB2, 0x25, 0x02), + MIPI_INIT_CMD(0xB5, 0x08, 0x00), + MIPI_INIT_CMD(0xBC, 0x0F, 0x00), + MIPI_INIT_CMD(0xB8, 0x03, 0x06, 0x00, 0x00), + MIPI_INIT_CMD(0xBD, 0x01, 0x90, 0x14, 0x14), + MIPI_INIT_CMD(0x6F, 0x01), + MIPI_INIT_CMD(0xC0, 0x03), + MIPI_INIT_CMD(0x6F, 0x02), + MIPI_INIT_CMD(0xC1, 0x0D), + MIPI_INIT_CMD(0xD9, 0x01, 0x09, 0x70), + MIPI_INIT_CMD(0xC5, 0x12, 0x21, 0x00), + MIPI_INIT_CMD(0xBB, 0x93, 0x93), /* page 1 */ - MIPI_INIT_CMD(0xf0, 0x55, 0xaa, 0x52, 0x08, 0x01), - MIPI_INIT_CMD(0xb3, 0x2d, 0x2d), - MIPI_INIT_CMD(0xb4, 0x19, 0x19), - MIPI_INIT_CMD(0xb9, 0x36, 0x36), - MIPI_INIT_CMD(0xba, 0x35, 0x35), - MIPI_INIT_CMD(0xca, 0x01), - MIPI_INIT_CMD(0xce, 0x04), - MIPI_INIT_CMD(0xc3, 0x14, 0x14), - MIPI_INIT_CMD(0xd8, 0xc0, 0x03), - MIPI_INIT_CMD(0xbc, 0x5a, 0x01), - MIPI_INIT_CMD(0xbd, 0x76, 0x01), + MIPI_INIT_CMD(0xF0, 0x55, 0xAA, 0x52, 0x08, 0x01), + MIPI_INIT_CMD(0xB3, 0x3C, 0x3C), + MIPI_INIT_CMD(0xB4, 0x0F, 0x0F), + MIPI_INIT_CMD(0xB9, 0x45, 0x45), + MIPI_INIT_CMD(0xBA, 0x14, 0x14), + MIPI_INIT_CMD(0xCA, 0x02), + MIPI_INIT_CMD(0xCE, 0x04), + MIPI_INIT_CMD(0xC3, 0x9B, 0x9B), + MIPI_INIT_CMD(0xD8, 0xC0, 0x03), + MIPI_INIT_CMD(0xBC, 0x82, 0x01), + MIPI_INIT_CMD(0xBD, 0x9E, 0x01), /* page 2 */ - MIPI_INIT_CMD(0xf0, 0x55, 0xaa, 0x52, 0x08, 0x02), - MIPI_INIT_CMD(0xb0, 0x00), - MIPI_INIT_CMD(0xd1, 0x00, 0x37, 0x00, 0x61, 0x00, 0x92), - MIPI_INIT_CMD(0xd2, 0x01, 0x6b, 0x01, 0xa7, 0x01, 0xd3), - MIPI_INIT_CMD(0xd3, 0x02, 0xe2, 0x03, 0x0f, 0x03, 0x30), - MIPI_INIT_CMD(0xd4, 0x03, 0xba, 0x03, 0xc1), - MIPI_INIT_CMD(0xe0, 0x00, 0x37, 0x00, 0x61, 0x00, 0x92), - MIPI_INIT_CMD(0xe1, 0x01, 0x6b, 0x01, 0xa7, 0x01, 0xd3), - MIPI_INIT_CMD(0xe2, 0x02, 0xe2, 0x03, 0x0f, 0x03, 0x30), - MIPI_INIT_CMD(0xe3, 0x03, 0xba, 0x03, 0xc1), + MIPI_INIT_CMD(0xF0, 0x55, 0xAA, 0x52, 0x08, 0x02), + MIPI_INIT_CMD(0xB0, 0x82), + MIPI_INIT_CMD(0xD1, 0x00, 0x00, 0x00, 0x3E, 0x00, 0x82, 0x00, 0xA5, + 0x00, 0xC1, 0x00, 0xEA, 0x01, 0x0D, 0x01, 0x40), + MIPI_INIT_CMD(0xD2, 0x01, 0x6A, 0x01, 0xA8, 0x01, 0xDC, 0x02, 0x29, + 0x02, 0x67, 0x02, 0x68, 0x02, 0xA8, 0x02, 0xF0), + MIPI_INIT_CMD(0xD3, 0x03, 0x19, 0x03, 0x49, 0x03, 0x67, 0x03, 0x8C, + 0x03, 0xA6, 0x03, 0xC7, 0x03, 0xDE, 0x03, 0xEC), + MIPI_INIT_CMD(0xD4, 0x03, 0xFF, 0x03, 0xFF), + MIPI_INIT_CMD(0xE0, 0x00, 0x00, 0x00, 0x86, 0x00, 0xC5, 0x00, 0xE5, + 0x00, 0xFF, 0x01, 0x26, 0x01, 0x45, 0x01, 0x75), + MIPI_INIT_CMD(0xE1, 0x01, 0x9C, 0x01, 0xD5, 0x02, 0x05, 0x02, 0x4D, + 0x02, 0x86, 0x02, 0x87, 0x02, 0xC3, 0x03, 0x03), + MIPI_INIT_CMD(0xE2, 0x03, 0x2A, 0x03, 0x56, 0x03, 0x72, 0x03, 0x94, + 0x03, 0xAC, 0x03, 0xCB, 0x03, 0xE0, 0x03, 0xED), + MIPI_INIT_CMD(0xE3, 0x03, 0xFF, 0x03, 0xFF), /* page 3 */ - MIPI_INIT_CMD(0xf0, 0x55, 0xaa, 0x52, 0x08, 0x03), - MIPI_INIT_CMD(0xb0, 0x00, 0x00, 0x00, 0x00), - MIPI_INIT_CMD(0xb1, 0x00, 0x00, 0x00, 0x00), - MIPI_INIT_CMD(0xb2, 0x00, 0x00, 0x06, 0x04, 0x00, 0xb0, 0x75), - MIPI_INIT_CMD(0xb3, 0x10, 0x07, 0xfd, 0x04, 0x00, 0xb0, 0x75), - MIPI_INIT_CMD(0xb6, 0xf0, 0x05, 0x07, 0x03, 0x00), - MIPI_INIT_CMD(0xba, 0xc5, 0x07, 0x00, 0x04, 0x01, 0xb0, 0x75), - MIPI_INIT_CMD(0xbb, 0xc5, 0x07, 0x00, 0x03, 0x01, 0xb0, 0x75), - MIPI_INIT_CMD(0xc0, 0x00, 0x3c, 0x00, 0x00, 0x00, 0x80, 0x80), - MIPI_INIT_CMD(0xc1, 0x00, 0x3c, 0x00, 0x00, 0x00, 0x80, 0x80), - MIPI_INIT_CMD(0xc4, 0x00, 0x00), - MIPI_INIT_CMD(0xef, 0x41), + MIPI_INIT_CMD(0xF0, 0x55, 0xAA, 0x52, 0x08, 0x03), + MIPI_INIT_CMD(0xB0, 0x00, 0x00, 0x00, 0x00), + MIPI_INIT_CMD(0xB1, 0x00, 0x00, 0x00, 0x00), + MIPI_INIT_CMD(0xB2, 0x00, 0x00, 0x06, 0x04, 0x01, 0x40, 0x85), + MIPI_INIT_CMD(0xB3, 0x10, 0x07, 0xFC, 0x04, 0x01, 0x40, 0x80), + MIPI_INIT_CMD(0xB6, 0xF0, 0x08, 0x00, 0x04, 0x00, 0x00, 0x00, 0x01, + 0x40, 0x80), + MIPI_INIT_CMD(0xBA, 0xC5, 0x07, 0x00, 0x04, 0x11, 0x25, 0x8C), + MIPI_INIT_CMD(0xBB, 0xC5, 0x07, 0x00, 0x03, 0x11, 0x25, 0x8C), + MIPI_INIT_CMD(0xC0, 0x00, 0x3C, 0x00, 0x00, 0x00, 0x80, 0x80), + MIPI_INIT_CMD(0xC1, 0x00, 0x3C, 0x00, 0x00, 0x00, 0x80, 0x80), + MIPI_INIT_CMD(0xC4, 0x00, 0x00), + MIPI_INIT_CMD(0xEF, 0x41), /* page 4 */ - MIPI_INIT_CMD(0xf0, 0x55, 0xaa, 0x52, 0x08, 0x04), - MIPI_INIT_CMD(0xec, 0x4c), + MIPI_INIT_CMD(0xF0, 0x55, 0xAA, 0x52, 0x08, 0x04), + MIPI_INIT_CMD(0xEC, 0x4C), /* page 5 */ - MIPI_INIT_CMD(0xf0, 0x55, 0xaa, 0x52, 0x08, 0x05), - MIPI_INIT_CMD(0xb0, 0x13, 0x03, 0x03, 0x01), - MIPI_INIT_CMD(0xb1, 0x30, 0x00), - MIPI_INIT_CMD(0xb2, 0x02, 0x02, 0x00), - MIPI_INIT_CMD(0xb3, 0x82, 0x23, 0x82, 0x38), - MIPI_INIT_CMD(0xb4, 0xc5, 0x75, 0x24, 0x57), - MIPI_INIT_CMD(0xb5, 0x00, 0xd4, 0x72, 0x11, 0x11, 0xab, 0x0a), - MIPI_INIT_CMD(0xb6, 0x00, 0x00, 0xd5, 0x72, 0x24, 0x56), - MIPI_INIT_CMD(0xb7, 0x5c, 0xdc, 0x5c, 0x5c), - MIPI_INIT_CMD(0xb9, 0x0c, 0x00, 0x00, 0x01, 0x00), - MIPI_INIT_CMD(0xc0, 0x75, 0x11, 0x11, 0x54, 0x05), - MIPI_INIT_CMD(0xc6, 0x00, 0x00, 0x00, 0x00), - MIPI_INIT_CMD(0xd0, 0x00, 0x48, 0x0a, 0x00, 0x00), - MIPI_INIT_CMD(0xd1, 0x00, 0x48, 0x0b, 0x00, 0x00), + MIPI_INIT_CMD(0xF0, 0x55, 0xAA, 0x52, 0x08, 0x05), + MIPI_INIT_CMD(0xB0, 0x13, 0x03, 0x03, 0x01), + MIPI_INIT_CMD(0xB1, 0x30, 0x00), + MIPI_INIT_CMD(0xB2, 0x02, 0x02, 0x00), + MIPI_INIT_CMD(0xB3, 0x82, 0x23, 0x82, 0x9D), + MIPI_INIT_CMD(0xB4, 0xC5, 0x75, 0x24, 0x57), + MIPI_INIT_CMD(0xB5, 0x00, 0xD4, 0x72, 0x11, 0x11, 0xAB, 0x0A), + MIPI_INIT_CMD(0xB6, 0x00, 0x00, 0xD5, 0x72, 0x24, 0x56), + MIPI_INIT_CMD(0xB7, 0x5C, 0xDC, 0x5C, 0x5C), + MIPI_INIT_CMD(0xB9, 0x0C, 0x00, 0x00, 0x01, 0x00), + MIPI_INIT_CMD(0xC0, 0x75, 0x11, 0x11, 0x54, 0x05), + MIPI_INIT_CMD(0xC6, 0x00, 0x00, 0x00, 0x00), + MIPI_INIT_CMD(0xD0, 0x00, 0x48, 0x08, 0x00, 0x00), + MIPI_INIT_CMD(0xD1, 0x00, 0x48, 0x09, 0x00, 0x00), /* page 6 */ - MIPI_INIT_CMD(0xf0, 0x55, 0xaa, 0x52, 0x08, 0x06), - MIPI_INIT_CMD(0xb0, 0x02, 0x32, 0x32, 0x08, 0x2f), - MIPI_INIT_CMD(0xb1, 0x2e, 0x15, 0x14, 0x13, 0x12), - MIPI_INIT_CMD(0xb2, 0x11, 0x10, 0x00, 0x3d, 0x3d), - MIPI_INIT_CMD(0xb3, 0x3d, 0x3d, 0x3d, 0x3d, 0x3d), - MIPI_INIT_CMD(0xb4, 0x3d, 0x32), - MIPI_INIT_CMD(0xb5, 0x03, 0x32, 0x32, 0x09, 0x2f), - MIPI_INIT_CMD(0xb6, 0x2e, 0x1b, 0x1a, 0x19, 0x18), - MIPI_INIT_CMD(0xb7, 0x17, 0x16, 0x01, 0x3d, 0x3d), - MIPI_INIT_CMD(0xb8, 0x3d, 0x3d, 0x3d, 0x3d, 0x3d), - MIPI_INIT_CMD(0xb9, 0x3d, 0x32), - MIPI_INIT_CMD(0xc0, 0x00, 0x32, 0x32, 0x08, 0x2f), - MIPI_INIT_CMD(0xc1, 0x2e, 0x10, 0x11, 0x12, 0x13), - MIPI_INIT_CMD(0xc2, 0x14, 0x15, 0x02, 0x3d, 0x3d), - MIPI_INIT_CMD(0xc3, 0x3d, 0x3d, 0x3d, 0x3d, 0x3d), - MIPI_INIT_CMD(0xc4, 0x3d, 0x3d), - MIPI_INIT_CMD(0xc5, 0x01, 0x32, 0x32, 0x09, 0x2f), - MIPI_INIT_CMD(0xc6, 0x2e, 0x16, 0x17, 0x18, 0x19), - MIPI_INIT_CMD(0xc7, 0x1a, 0x1b, 0x03, 0x3d, 0x3d), - MIPI_INIT_CMD(0xc8, 0x3d, 0x3d, 0x3d, 0x3d, 0x3d), - MIPI_INIT_CMD(0xc9, 0x3d, 0x3d), + MIPI_INIT_CMD(0xF0, 0x55, 0xAA, 0x52, 0x08, 0x06), + MIPI_INIT_CMD(0xB0, 0x02, 0x32, 0x32, 0x08, 0x2F), + MIPI_INIT_CMD(0xB1, 0x2E, 0x15, 0x14, 0x13, 0x12), + MIPI_INIT_CMD(0xB2, 0x11, 0x10, 0x00, 0x3D, 0x3D), + MIPI_INIT_CMD(0xB3, 0x3D, 0x3D, 0x3D, 0x3D, 0x3D), + MIPI_INIT_CMD(0xB4, 0x3D, 0x32), + MIPI_INIT_CMD(0xB5, 0x03, 0x32, 0x32, 0x09, 0x2F), + MIPI_INIT_CMD(0xB6, 0x2E, 0x1B, 0x1A, 0x19, 0x18), + MIPI_INIT_CMD(0xB7, 0x17, 0x16, 0x01, 0x3D, 0x3D), + MIPI_INIT_CMD(0xB8, 0x3D, 0x3D, 0x3D, 0x3D, 0x3D), + MIPI_INIT_CMD(0xB9, 0x3D, 0x32), + MIPI_INIT_CMD(0xC0, 0x01, 0x32, 0x32, 0x09, 0x2F), + MIPI_INIT_CMD(0xC1, 0x2E, 0x1A, 0x1B, 0x16, 0x17), + MIPI_INIT_CMD(0xC2, 0x18, 0x19, 0x03, 0x3D, 0x3D), + MIPI_INIT_CMD(0xC3, 0x3D, 0x3D, 0x3D, 0x3D, 0x3D), + MIPI_INIT_CMD(0xC4, 0x3D, 0x32), + MIPI_INIT_CMD(0xC5, 0x00, 0x32, 0x32, 0x08, 0x2F), + MIPI_INIT_CMD(0xC6, 0x2E, 0x14, 0x15, 0x10, 0x11), + MIPI_INIT_CMD(0xC7, 0x12, 0x13, 0x02, 0x3D, 0x3D), + MIPI_INIT_CMD(0xC8, 0x3D, 0x3D, 0x3D, 0x3D, 0x3D), + MIPI_INIT_CMD(0xC9, 0x3D, 0x32), {}, }; -- To view, visit https://review.coreboot.org/23561 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9679c4f7f706fd6cd2e1dba7ec79e772fe3f227a Gerrit-Change-Number: 23561 Gerrit-PatchSet: 1 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com>

1 0

Change in coreboot[master]: soc/intel/cannonlake: Increase heap size
by build bot (Jenkins) (Code Review) 02 Feb '18

02 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23560 ) Change subject: soc/intel/cannonlake: Increase heap size ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66944/ : SUCCESS -- To view, visit https://review.coreboot.org/23560 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icb0f3c626b784d73e417e5722b3b4da29ab5acce Gerrit-Change-Number: 23560 Gerrit-PatchSet: 2 Gerrit-Owner: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Feb 2018 01:57:44 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/cannonlake: Increase heap size
by build bot (Jenkins) (Code Review) 02 Feb '18

02 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23560 ) Change subject: soc/intel/cannonlake: Increase heap size ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/66943/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/21526/ : SUCCESS -- To view, visit https://review.coreboot.org/23560 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icb0f3c626b784d73e417e5722b3b4da29ab5acce Gerrit-Change-Number: 23560 Gerrit-PatchSet: 1 Gerrit-Owner: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Feb 2018 01:52:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/cannonlake: Increase heap size
by John Zhao (Code Review) 02 Feb '18

02 Feb '18

Hello Bora Guvendik, Sathyanarayana Nujella, Hannah Williams, Lijian Zhao, I'd like you to reexamine a change. Please visit https://review.coreboot.org/23560 to look at the new patch set (#2). Change subject: soc/intel/cannonlake: Increase heap size ...................................................................... soc/intel/cannonlake: Increase heap size After adding NHLT and max98373 amp support, cnlrvp fails to boot with error: out of memory (free_mem_ptr >= free_mem_end_ptr). Increase HEAP_SIZE from 0x4000 to 0x8000. BUG=None TEST= emerge-cnlrvp coreboot nhlt-blobs chromeos-bootimage coreboot-private-files-cnlrvp and verify cnlrvp boots to kernel. Change-Id: Icb0f3c626b784d73e417e5722b3b4da29ab5acce Signed-off-by: John Zhao <john.zhao(a)intel.com> --- M src/soc/intel/cannonlake/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/23560/2 -- To view, visit https://review.coreboot.org/23560 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icb0f3c626b784d73e417e5722b3b4da29ab5acce Gerrit-Change-Number: 23560 Gerrit-PatchSet: 2 Gerrit-Owner: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com>

1 0

Change in coreboot[master]: soc/intel/cannonlake: Increase heap size
by John Zhao (Code Review) 02 Feb '18

02 Feb '18

John Zhao has uploaded this change for review. ( https://review.coreboot.org/23560 Change subject: soc/intel/cannonlake: Increase heap size ...................................................................... soc/intel/cannonlake: Increase heap size After adding NHLT and max98373 amp support, cnlrvp fails to boot with error: out of memory (free_mem_ptr >= free_mem_end_ptr). Increase HEAP_SIZE from 0x4000 to 0x8000. BUG=None TEST= emerge-cnlrvp coreboot nhlt-blobs chromeos-bootimage coreboot-private-files-cnlrvp Change-Id: Icb0f3c626b784d73e417e5722b3b4da29ab5acce Signed-off-by: John Zhao <john.zhao(a)intel.com> --- M src/soc/intel/cannonlake/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/23560/1 diff --git a/src/soc/intel/cannonlake/Kconfig b/src/soc/intel/cannonlake/Kconfig index e832d71..c3193e6 100644 --- a/src/soc/intel/cannonlake/Kconfig +++ b/src/soc/intel/cannonlake/Kconfig @@ -115,6 +115,10 @@ hex default 0x400000 +config HEAP_SIZE + hex + default 0x8000 + config NHLT_DMIC_1CH_16B bool depends on ACPI_NHLT -- To view, visit https://review.coreboot.org/23560 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Icb0f3c626b784d73e417e5722b3b4da29ab5acce Gerrit-Change-Number: 23560 Gerrit-PatchSet: 1 Gerrit-Owner: John Zhao <john.zhao(a)intel.com>

1 0

Change in coreboot[master]: mainboard/google/zoombini/variants/meowth: enable touchscreen
by build bot (Jenkins) (Code Review) 02 Feb '18

02 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23551 ) Change subject: mainboard/google/zoombini/variants/meowth: enable touchscreen ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66942/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21525/ : SUCCESS -- To view, visit https://review.coreboot.org/23551 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iad3f0b77a02552266435e523fdbb74b14ada101a Gerrit-Change-Number: 23551 Gerrit-PatchSet: 3 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Feb 2018 01:42:05 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2018