Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/23563
Change subject: ec/google/chromeec: Remove wake flag from keyboard IRQ
......................................................................
ec/google/chromeec: Remove wake flag from keyboard IRQ
The keyboard IRQ was changed to ExclusiveAndWake in order to support
waking from suspend-to-idle (S0ix) with commit
f611fcfacac5be14a51e04ae4d0b1e25cd5439c0 (http://review.coreboot.org/11712)
However this is triggering a kernel panic on Windows 10 because it
apparently does not like legacy devices interrupts to to be set as
wake capable.
This change is no longer necessary because the linux kernel was
changed to always treat the keyboard as wake capable:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/d…
Change-Id: I26e27de68095f8d176108f39312338522d7cfba0
Signed-off-by: Duncan Laurie <dlaurie(a)chromium.org>
---
M src/ec/google/chromeec/acpi/superio.asl
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/23563/1
diff --git a/src/ec/google/chromeec/acpi/superio.asl b/src/ec/google/chromeec/acpi/superio.asl
index 0f06e30..7cd6523 100644
--- a/src/ec/google/chromeec/acpi/superio.asl
+++ b/src/ec/google/chromeec/acpi/superio.asl
@@ -151,7 +151,7 @@
#ifdef SIO_EC_PS2K_IRQ
SIO_EC_PS2K_IRQ
#else
- IRQ (Edge, ActiveHigh, ExclusiveAndWake) {1}
+ IRQ (Edge, ActiveHigh, Exclusive) {1}
#endif
})
@@ -163,7 +163,7 @@
#ifdef SIO_EC_PS2K_IRQ
SIO_EC_PS2K_IRQ
#else
- IRQ (Edge, ActiveHigh, ExclusiveAndWake) {1}
+ IRQ (Edge, ActiveHigh, Exclusive) {1}
#endif
}
EndDependentFn ()
--
To view, visit https://review.coreboot.org/23563
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I26e27de68095f8d176108f39312338522d7cfba0
Gerrit-Change-Number: 23563
Gerrit-PatchSet: 1
Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org>
Marc Jones has uploaded this change for review. ( https://review.coreboot.org/23562
Change subject: Update blobs submodule to upstream master
......................................................................
Update blobs submodule to upstream master
Updating from commit id a5efee5:
2018-01-04 16:24:19 -0700 - (Kahlee/Grunt: Move remaining stoneyridge blobs)
to commit id 19dea8d:
2018-02-01 08:51:06 -0700 - (soc/amd/Stoneyridge: Update PSP binaries to AGESA 1.3.0.9)
This brings in 2 new commits.
Change-Id: I7858ad8be13d9992949effb0216723d2480fa74d
Signed-off-by: Marc Jones <marcj303(a)gmail.com>
---
M 3rdparty/blobs
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/23562/1
diff --git a/3rdparty/blobs b/3rdparty/blobs
index a5efee5..19dea8d 160000
--- a/3rdparty/blobs
+++ b/3rdparty/blobs
@@ -1 +1 @@
-Subproject commit a5efee5fdea55f398decc9cabebce3744bbd8147
+Subproject commit 19dea8d171544f01f12ee6b78af0cc356ab994aa
--
To view, visit https://review.coreboot.org/23562
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7858ad8be13d9992949effb0216723d2480fa74d
Gerrit-Change-Number: 23562
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com>
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23546 )
Change subject: mb/google/nautilus: Work around the power issue of MIPI and USB cameras
......................................................................
Patch Set 4:
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/66954/ : SUCCESS
--
To view, visit https://review.coreboot.org/23546
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icaaf7e17447492f2e2f2d03eb9a35bcc53667f28
Gerrit-Change-Number: 23546
Gerrit-PatchSet: 4
Gerrit-Owner: Andy Yeh <andy.yeh(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Andy Yeh
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 02 Feb 2018 11:29:17 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No