coreboot-gerrit February 2018

coreboot-gerrit@coreboot.org

1 participants
1573 discussions

Change in coreboot[master]: google/gru: Use newer version of Innolux P097PFG panel init code
by build bot (Jenkins) (Code Review) 02 Feb '18

02 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23561 ) Change subject: google/gru: Use newer version of Innolux P097PFG panel init code ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66951/ : SUCCESS -- To view, visit https://review.coreboot.org/23561 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9679c4f7f706fd6cd2e1dba7ec79e772fe3f227a Gerrit-Change-Number: 23561 Gerrit-PatchSet: 3 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Matthias Kaehlcke <mka(a)chromium.org> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Feb 2018 06:38:56 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: google/gru: Use newer version of Innolux P097PFG panel init code
by Julius Werner (Code Review) 02 Feb '18

02 Feb '18

Julius Werner has posted comments on this change. ( https://review.coreboot.org/23561 ) Change subject: google/gru: Use newer version of Innolux P097PFG panel init code ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/23561 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9679c4f7f706fd6cd2e1dba7ec79e772fe3f227a Gerrit-Change-Number: 23561 Gerrit-PatchSet: 3 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Matthias Kaehlcke <mka(a)chromium.org> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Feb 2018 06:33:54 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: google/gru: Use newer version of Innolux P097PFG panel init code
by Julius Werner (Code Review) 02 Feb '18

02 Feb '18

Julius Werner has uploaded a new patch set (#3) to the change originally created by Lin Huang. ( https://review.coreboot.org/23561 ) Change subject: google/gru: Use newer version of Innolux P097PFG panel init code ...................................................................... google/gru: Use newer version of Innolux P097PFG panel init code There is a line artifact in the lower third of the display with the current initialization code. So update it with code provided by Innolux to fix this issue. BUG=b:69689064, b:72191820 TEST=boot on dru with an Innolux panel and artifact line disappear. Change-Id: I9679c4f7f706fd6cd2e1dba7ec79e772fe3f227a Signed-off-by: Lin Huang <hl(a)rock-chips.com> --- M src/mainboard/google/gru/mainboard.c 1 file changed, 91 insertions(+), 82 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/23561/3 -- To view, visit https://review.coreboot.org/23561 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9679c4f7f706fd6cd2e1dba7ec79e772fe3f227a Gerrit-Change-Number: 23561 Gerrit-PatchSet: 3 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Matthias Kaehlcke <mka(a)chromium.org> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: arm64: Pass COREBOOT flag to ARM TF, always enable logging
by build bot (Jenkins) (Code Review) 02 Feb '18

02 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23558 ) Change subject: arm64: Pass COREBOOT flag to ARM TF, always enable logging ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66950/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21530/ : SUCCESS -- To view, visit https://review.coreboot.org/23558 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c52a536dc6067da1378b3f15c4a4d6cf0be7ce7 Gerrit-Change-Number: 23558 Gerrit-PatchSet: 3 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Feb 2018 06:32:15 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: google/scarlet: Innolux P097PFG panel use new version initial code
by Julius Werner (Code Review) 02 Feb '18

02 Feb '18

Julius Werner has posted comments on this change. ( https://review.coreboot.org/23561 ) Change subject: google/scarlet: Innolux P097PFG panel use new version initial code ...................................................................... Patch Set 2: (2 comments) https://review.coreboot.org/#/c/23561/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/23561/1//COMMIT_MSG@13 PS1, Line 13: BUG=b:69689064, b:72191820 This is wrong btw, we don't intend to use the gru branch for Scarlet. https://review.coreboot.org/#/c/23561/1//COMMIT_MSG@12 PS1, Line 12: : BUG=b:69689064, b:72191820 : BRANCH=gru > Last time i do not add these tags and Julius request me to add it back. So i think we need it. Yeah... they are no required, but allowed and encouraged where they provide value. -- To view, visit https://review.coreboot.org/23561 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9679c4f7f706fd6cd2e1dba7ec79e772fe3f227a Gerrit-Change-Number: 23561 Gerrit-PatchSet: 2 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Matthias Kaehlcke <mka(a)chromium.org> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Feb 2018 06:32:08 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: rockchip/rk3399: Pass coreboot table pointer to ARM TF
by build bot (Jenkins) (Code Review) 02 Feb '18

02 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23557 ) Change subject: rockchip/rk3399: Pass coreboot table pointer to ARM TF ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66949/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21529/ : SUCCESS -- To view, visit https://review.coreboot.org/23557 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cb2f13ce71e374207d0fa7a71c38852d680dc56 Gerrit-Change-Number: 23557 Gerrit-PatchSet: 3 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Feb 2018 06:31:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/nautilus: To work around the power issue of MIPI and USB ca...
by build bot (Jenkins) (Code Review) 02 Feb '18

02 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23546 ) Change subject: mb/google/nautilus: To work around the power issue of MIPI and USB cameras ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66948/ : SUCCESS -- To view, visit https://review.coreboot.org/23546 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icaaf7e17447492f2e2f2d03eb9a35bcc53667f28 Gerrit-Change-Number: 23546 Gerrit-PatchSet: 3 Gerrit-Owner: Andy Yeh <andy.yeh(a)intel.corp-partner.google.com> Gerrit-Reviewer: Andy Yeh Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Feb 2018 05:39:10 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: google/scarlet: Innolux P097PFG panel use new version initial code
by build bot (Jenkins) (Code Review) 02 Feb '18

02 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23561 ) Change subject: google/scarlet: Innolux P097PFG panel use new version initial code ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66947/ : SUCCESS -- To view, visit https://review.coreboot.org/23561 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9679c4f7f706fd6cd2e1dba7ec79e772fe3f227a Gerrit-Change-Number: 23561 Gerrit-PatchSet: 2 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Matthias Kaehlcke <mka(a)chromium.org> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Feb 2018 03:14:48 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: google/scarlet: Innolux P097PFG panel use new version initial code
by Lin Huang (Code Review) 02 Feb '18

02 Feb '18

Lin Huang has posted comments on this change. ( https://review.coreboot.org/23561 ) Change subject: google/scarlet: Innolux P097PFG panel use new version initial code ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/#/c/23561/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/23561/1//COMMIT_MSG@7 PS1, Line 7: google/scarlet: Innolux P097PFG panel use new version initial code : : There is artifact line in the lower third of the display with now : initial code. So update this initial code to fix this issue. > You could also mention that this is a sequence provided by Innolux, as opposed to the register dump […] Done https://review.coreboot.org/#/c/23561/1//COMMIT_MSG@12 PS1, Line 12: BUG=b:69689064, b:72191820 : BRANCH=gru : TEST=boot on dru with an Innolux panel and artifact line disappear. > I'm not really familiar with coreboot upstream work, but I suppose these Chrome OS specific tags are […] Last time i do not add these tags and Julius request me to add it back. So i think we need it. -- To view, visit https://review.coreboot.org/23561 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9679c4f7f706fd6cd2e1dba7ec79e772fe3f227a Gerrit-Change-Number: 23561 Gerrit-PatchSet: 1 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Matthias Kaehlcke <mka(a)chromium.org> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Feb 2018 03:11:05 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: google/scarlet: Innolux P097PFG panel use new version initial code
by Lin Huang (Code Review) 02 Feb '18

02 Feb '18

Hello Julius Werner, Philip Chen, build bot (Jenkins), Matthias Kaehlcke, Brian Norris, I'd like you to reexamine a change. Please visit https://review.coreboot.org/23561 to look at the new patch set (#2). Change subject: google/scarlet: Innolux P097PFG panel use new version initial code ...................................................................... google/scarlet: Innolux P097PFG panel use new version initial code There is artifact line in the lower third of the display with now initial code. So update this initial code which provided by Innolux to fix this issue. BUG=b:69689064, b:72191820 BRANCH=gru TEST=boot on dru with an Innolux panel and artifact line disappear. Change-Id: I9679c4f7f706fd6cd2e1dba7ec79e772fe3f227a Signed-off-by: Lin Huang <hl(a)rock-chips.com> --- M src/mainboard/google/gru/mainboard.c 1 file changed, 91 insertions(+), 82 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/23561/2 -- To view, visit https://review.coreboot.org/23561 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9679c4f7f706fd6cd2e1dba7ec79e772fe3f227a Gerrit-Change-Number: 23561 Gerrit-PatchSet: 2 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Matthias Kaehlcke <mka(a)chromium.org> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2018