coreboot-gerrit February 2018

coreboot-gerrit@coreboot.org

1 participants
1573 discussions

Change in coreboot[master]: mb/google/kahlee: Enable wlan card so it can be detected
by build bot (Jenkins) (Code Review) 01 Feb '18

01 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23552 ) Change subject: mb/google/kahlee: Enable wlan card so it can be detected ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66922/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21507/ : SUCCESS -- To view, visit https://review.coreboot.org/23552 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a1e83298af35aa80c67c75cd6ec0a2c3213891e Gerrit-Change-Number: 23552 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 01 Feb 2018 22:22:34 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/stoneyridge: initialize i2c buses marked as early init
by Daniel Kurtz (Code Review) 01 Feb '18

01 Feb '18

Hello Daniel Kurtz, I'd like you to do a code review. Please visit https://review.coreboot.org/23553 to review the following change. Change subject: soc/amd/stoneyridge: initialize i2c buses marked as early init ...................................................................... soc/amd/stoneyridge: initialize i2c buses marked as early init Initialize the i2c buses that are not marked as early init in the device tree during ramstage. BUG=b:69407112 TEST=Boot depthcharge w/ CLI enabled on grunt. devbeep => plays beep BRANCH=None Change-Id: I6e49b0de9116138ba102377d283e22d7b50d7dca Signed-off-by: Daniel Kurtz <djkurtz(a)chromium.org> --- M src/mainboard/google/kahlee/mainboard.c M src/soc/amd/stoneyridge/i2c.c M src/soc/amd/stoneyridge/include/soc/southbridge.h 3 files changed, 18 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/23553/1 diff --git a/src/mainboard/google/kahlee/mainboard.c b/src/mainboard/google/kahlee/mainboard.c index b080682..b1a449d 100644 --- a/src/mainboard/google/kahlee/mainboard.c +++ b/src/mainboard/google/kahlee/mainboard.c @@ -138,6 +138,9 @@ gpes = get_gpe_table(&num); gpe_configure_sci(gpes, num); + /* Initialize i2c busses that were not initialized in bootblock */ + i2c_soc_init(); + /* Set GenIntDisable so that GPIO 90 is configured as a GPIO. */ if (!IS_ENABLED(CONFIG_BOARD_GOOGLE_KAHLEE)) pm_write8(PM_PCIB_CFG, diff --git a/src/soc/amd/stoneyridge/i2c.c b/src/soc/amd/stoneyridge/i2c.c index 947c43f..543de07 100644 --- a/src/soc/amd/stoneyridge/i2c.c +++ b/src/soc/amd/stoneyridge/i2c.c @@ -101,7 +101,7 @@ return -1; } -void i2c_soc_early_init(void) +static void dw_i2c_soc_init(int is_early_init) { size_t i; const struct soc_amd_stoneyridge_config *config; @@ -114,7 +114,7 @@ for (i = 0; i < ARRAY_SIZE(config->i2c); i++) { const struct dw_i2c_bus_config *cfg = &config->i2c[i]; - if (!cfg->early_init) + if (cfg->early_init != is_early_init) continue; if (dw_i2c_init(i, cfg)) @@ -122,6 +122,16 @@ } } +void i2c_soc_early_init(void) +{ + dw_i2c_soc_init(1); +} + +void i2c_soc_init(void) +{ + dw_i2c_soc_init(0); +} + struct device_operations stoneyridge_i2c_mmio_ops = { /* TODO(teravest): Move I2C resource info here. */ .read_resources = DEVICE_NOOP, diff --git a/src/soc/amd/stoneyridge/include/soc/southbridge.h b/src/soc/amd/stoneyridge/include/soc/southbridge.h index 2f9d9f9..7838f30 100644 --- a/src/soc/amd/stoneyridge/include/soc/southbridge.h +++ b/src/soc/amd/stoneyridge/include/soc/southbridge.h @@ -392,4 +392,7 @@ /* Initialize all the i2c buses that are marked with early init. */ void i2c_soc_early_init(void); +/* Initialize all the i2c buses that are not marked with early init. */ +void i2c_soc_init(void) + #endif /* __STONEYRIDGE_H__ */ -- To view, visit https://review.coreboot.org/23553 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6e49b0de9116138ba102377d283e22d7b50d7dca Gerrit-Change-Number: 23553 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)chromium.org>

1 0

Change in coreboot[master]: mb/google/kahlee: Enable wlan card so it can be detected
by Martin Roth (Code Review) 01 Feb '18

01 Feb '18

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/23552 Change subject: mb/google/kahlee: Enable wlan card so it can be detected ...................................................................... mb/google/kahlee: Enable wlan card so it can be detected The wifi card was not being powered, and was being held in reset during PCI enumeration, so it was not being brought up. BUG=b:72738963 TEST=Verify wlan card shows up in lspci Change-Id: I5a1e83298af35aa80c67c75cd6ec0a2c3213891e Signed-off-by: Martin Roth <martinroth(a)google.com> --- M src/mainboard/google/kahlee/variants/baseboard/gpio.c 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/23552/1 diff --git a/src/mainboard/google/kahlee/variants/baseboard/gpio.c b/src/mainboard/google/kahlee/variants/baseboard/gpio.c index 6954f63..a6bcea5 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/gpio.c +++ b/src/mainboard/google/kahlee/variants/baseboard/gpio.c @@ -38,6 +38,9 @@ /* GPIO_3 - MEM_VOLT_SEL */ { GPIO_3, Function0, FCH_GPIO_PULL_UP_ENABLE | INPUT }, + /* GPIO_4 - EN_PP3300_WLAN */ + { GPIO_4, Function0, OUTPUT_H }, + /* GPIO_5 - PCH_TRACKPAD_INT_3V3_ODL, SCI */ { GPIO_5, Function0, FCH_GPIO_PULL_UP_ENABLE | INPUT }, @@ -90,6 +93,9 @@ /* GPIO_42 - S5_MUX_CTRL */ { GPIO_42, Function0, OUTPUT_H }, + /* GPIO_70 - WLAN_PE_RST_L */ + { GPIO_70, Function0, OUTPUT_H }, + /* GPIO_74 - LPC_CLK0_EC_R */ { GPIO_74, Function0, FCH_GPIO_PULL_DOWN_ENABLE | INPUT }, @@ -197,9 +203,6 @@ /* GPIO_2 - WLAN_PCIE_WAKE_3V3_ODL */ { GPIO_2, Function0, FCH_GPIO_PULL_UP_ENABLE | INPUT }, - /* GPIO_4 - EN_PP3300_WLAN */ - { GPIO_4, Function0, OUTPUT_H }, - /* GPIO_10 - SLP_S0_L (currently not used) */ { GPIO_10, Function0, FCH_GPIO_PULL_UP_ENABLE | INPUT }, @@ -221,9 +224,6 @@ /* GPIO_67 - PEN_RESET */ { GPIO_67, Function0, OUTPUT_L }, - /* GPIO_70 - WLAN_PE_RST_L */ - { GPIO_70, Function0, OUTPUT_H }, - /* GPIO_75 - Unused (strap) (R139/R130) */ { GPIO_75, Function1, FCH_GPIO_PULL_UP_ENABLE | INPUT }, -- To view, visit https://review.coreboot.org/23552 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5a1e83298af35aa80c67c75cd6ec0a2c3213891e Gerrit-Change-Number: 23552 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: mb/google/kahlee/mainboard.c: Create mainboard_pirq_data
by build bot (Jenkins) (Code Review) 01 Feb '18

01 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22940 ) Change subject: mb/google/kahlee/mainboard.c: Create mainboard_pirq_data ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66920/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21505/ : SUCCESS -- To view, visit https://review.coreboot.org/22940 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If07d2f54f06f6cf77566c43eddc8ee8a314e7a3a Gerrit-Change-Number: 22940 Gerrit-PatchSet: 8 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 01 Feb 2018 22:09:34 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/zoombini/variants/meowth: enable touchscreen
by build bot (Jenkins) (Code Review) 01 Feb '18

01 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23551 ) Change subject: mainboard/google/zoombini/variants/meowth: enable touchscreen ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66921/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21506/ : SUCCESS -- To view, visit https://review.coreboot.org/23551 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iad3f0b77a02552266435e523fdbb74b14ada101a Gerrit-Change-Number: 23551 Gerrit-PatchSet: 2 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 01 Feb 2018 21:48:50 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/zoombini/variants/meowth: enable touchscreen
by build bot (Jenkins) (Code Review) 01 Feb '18

01 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23551 ) Change subject: mainboard/google/zoombini/variants/meowth: enable touchscreen ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/66919/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/21504/ : ABORTED -- To view, visit https://review.coreboot.org/23551 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iad3f0b77a02552266435e523fdbb74b14ada101a Gerrit-Change-Number: 23551 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 01 Feb 2018 21:43:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/zoombini/variants/meowth: enable touchscreen
by Nick Vaccaro (Code Review) 01 Feb '18

01 Feb '18

Nick Vaccaro has uploaded a new patch set (#2). ( https://review.coreboot.org/23551 ) Change subject: mainboard/google/zoombini/variants/meowth: enable touchscreen ...................................................................... mainboard/google/zoombini/variants/meowth: enable touchscreen BUG=b:69011806, b:72179988 BRANCH=master TEST=Verify touchscreen on meowth works with this change. Change-Id: Iad3f0b77a02552266435e523fdbb74b14ada101a Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com> --- M src/mainboard/google/zoombini/Kconfig M src/mainboard/google/zoombini/variants/meowth/devicetree.cb M src/mainboard/google/zoombini/variants/meowth/gpio.c 3 files changed, 20 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/23551/2 -- To view, visit https://review.coreboot.org/23551 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iad3f0b77a02552266435e523fdbb74b14ada101a Gerrit-Change-Number: 23551 Gerrit-PatchSet: 2 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com>

1 0

Change in coreboot[master]: mainboard/google/zoombini/variants/meowth: enable touchscreen
by Nick Vaccaro (Code Review) 01 Feb '18

01 Feb '18

Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/23551 Change subject: mainboard/google/zoombini/variants/meowth: enable touchscreen ...................................................................... mainboard/google/zoombini/variants/meowth: enable touchscreen BUG=b:69011806, b:72179988 BRANCH=master TEST=Verify touchscreen on meowth works with this change. Change-Id: Iad3f0b77a02552266435e523fdbb74b14ada101a Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com> --- M src/mainboard/google/zoombini/Kconfig M src/mainboard/google/zoombini/variants/meowth/devicetree.cb M src/mainboard/google/zoombini/variants/meowth/gpio.c 3 files changed, 21 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/23551/1 diff --git a/src/mainboard/google/zoombini/Kconfig b/src/mainboard/google/zoombini/Kconfig index 64180f3..31b8cc9 100644 --- a/src/mainboard/google/zoombini/Kconfig +++ b/src/mainboard/google/zoombini/Kconfig @@ -3,6 +3,7 @@ def_bool n select BOARD_ROMSIZE_KB_16384 select DRIVERS_I2C_GENERIC + select DRIVERS_I2C_HID select DRIVERS_SPI_ACPI select EC_GOOGLE_CHROMEEC select EC_GOOGLE_CHROMEEC_LPC diff --git a/src/mainboard/google/zoombini/variants/meowth/devicetree.cb b/src/mainboard/google/zoombini/variants/meowth/devicetree.cb index 88de878..4d40b63 100644 --- a/src/mainboard/google/zoombini/variants/meowth/devicetree.cb +++ b/src/mainboard/google/zoombini/variants/meowth/devicetree.cb @@ -53,6 +53,13 @@ register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC2)" register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC3)" + # Touchscreen + register "i2c[0]" = "{ + .speed = I2C_SPEED_FAST_PLUS, + .rise_time_ns = 98, + .fall_time_ns = 38, + }" + device domain 0 on device pci 00.0 on end # Host Bridge device pci 02.0 on end # Integrated Graphics Device @@ -63,7 +70,16 @@ device pci 14.0 on end # USB xHCI device pci 14.1 off end # USB xDCI (OTG) device pci 14.5 off end # SDCard - device pci 15.0 on end # I2C #0 + device pci 15.0 on + chip drivers/i2c/hid + register "generic.hid" = ""WCOM50C1"" + register "generic.desc" = ""WCOM Digitizer"" + register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C14_IRQ)" + register "generic.speed" = "I2C_SPEED_FAST_PLUS" + register "hid_desc_reg_offset" = "0x1" + device i2c 0a on end + end + end # I2C #0 device pci 15.1 on end # I2C #1 device pci 15.2 on end # I2C #2 device pci 15.3 on end # I2C #3 @@ -110,6 +126,7 @@ device spi 0 on end end end # GSPI #1 + device pci 1e.3 on end # GSPI #1 device pci 1f.0 on chip ec/google/chromeec device pnp 0c09.0 on end diff --git a/src/mainboard/google/zoombini/variants/meowth/gpio.c b/src/mainboard/google/zoombini/variants/meowth/gpio.c index 19c028e..21c4bbc 100644 --- a/src/mainboard/google/zoombini/variants/meowth/gpio.c +++ b/src/mainboard/google/zoombini/variants/meowth/gpio.c @@ -94,13 +94,13 @@ NF1), /* UART_PCH_RX_DEBUG_TX */ /* UART0_TXD */ PAD_CFG_NF(GPP_C9, NONE, DEEP, NF1), /* UART_PCH_TX_DEBUG_RX */ -/* UART0_RTS# */ PAD_CFG_GPO(GPP_C10, 0, DEEP), /* PP3300_TOUCH_EN */ +/* UART0_RTS# */ PAD_CFG_GPO(GPP_C10, 1, DEEP), /* PP3300_TOUCH_EN */ /* UART0_CTS# */ PAD_NC(GPP_C11, NONE), /* Only P0 boards need an internal pullup */ /* UART1_RXD */ PAD_CFG_GPI_APIC(GPP_C12, UP_20K, DEEP, EDGE_SINGLE, INVERT), /* H1_PCH_INT_ODL */ /* UART1_TXD */ PAD_NC(GPP_C13, NONE), -/* UART1_RTS# */ PAD_CFG_GPI_SCI(GPP_C14, NONE, DEEP, EDGE_SINGLE, +/* UART1_RTS# */ PAD_CFG_GPI_APIC(GPP_C14, NONE, DEEP, LEVEL, NONE), /* TOUCHSCREEN_INT_ODL */ /* UART1_CTS# */ PAD_NC(GPP_C15, NONE), /* I2C0_SDA */ PAD_CFG_NF(GPP_C16, NONE, DEEP, -- To view, visit https://review.coreboot.org/23551 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iad3f0b77a02552266435e523fdbb74b14ada101a Gerrit-Change-Number: 23551 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com>

1 0

Change in coreboot[master]: mb/google/fizz: Get OEM ID and SKU ID from EC
by build bot (Jenkins) (Code Review) 01 Feb '18

01 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23548 ) Change subject: mb/google/fizz: Get OEM ID and SKU ID from EC ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66918/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21503/ : SUCCESS -- To view, visit https://review.coreboot.org/23548 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06d3a205275b46660b3974bc3673d4be8e13f6d1 Gerrit-Change-Number: 23548 Gerrit-PatchSet: 6 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 01 Feb 2018 20:24:07 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: ec/google: Get OEM ID and SKU ID from EC
by build bot (Jenkins) (Code Review) 01 Feb '18

01 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23549 ) Change subject: ec/google: Get OEM ID and SKU ID from EC ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66917/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21502/ : SUCCESS -- To view, visit https://review.coreboot.org/23549 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff69a2dc0e562d87dd287f79c407f23aeb09fb9e Gerrit-Change-Number: 23549 Gerrit-PatchSet: 3 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 01 Feb 2018 20:23:29 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2018