coreboot-gerrit February 2018

coreboot-gerrit@coreboot.org

1 participants
1573 discussions

Change in coreboot[master]: nb/intel/pineview: Avoid holes between TOM and cbmem_top
by build bot (Jenkins) (Code Review) 01 Feb '18

01 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23550 ) Change subject: nb/intel/pineview: Avoid holes between TOM and cbmem_top ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66916/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21501/ : SUCCESS -- To view, visit https://review.coreboot.org/23550 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If5146cda1020b494af6d43e5d8055e0045fa5b82 Gerrit-Change-Number: 23550 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 01 Feb 2018 19:12:52 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: nb/intel/pineview: Avoid holes between TOM and cbmem_top
by Arthur Heymans (Code Review) 01 Feb '18

01 Feb '18

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/23550 Change subject: nb/intel/pineview: Avoid holes between TOM and cbmem_top ...................................................................... nb/intel/pineview: Avoid holes between TOM and cbmem_top Having usable memory between top of lower usable memory and cbmem_top creates problems for some payloads like tianocore and some versions of memtest86+ don't like it either. The solution is to mark that memory as reserved. Change-Id: If5146cda1020b494af6d43e5d8055e0045fa5b82 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/intel/pineview/northbridge.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/23550/1 diff --git a/src/northbridge/intel/pineview/northbridge.c b/src/northbridge/intel/pineview/northbridge.c index ea55974..ca6a1c2 100644 --- a/src/northbridge/intel/pineview/northbridge.c +++ b/src/northbridge/intel/pineview/northbridge.c @@ -98,6 +98,8 @@ /* Subtract TSEG size */ tseg_sizek = gtt_basek - tseg_basek; tomk -= tseg_sizek; + /* Align top of ram down to cbmem_top */ + tomk = ALIGN_DOWN(tomk, 4 << 10); /* Report the memory regions */ ram_resource(dev, index++, 0, 640); -- To view, visit https://review.coreboot.org/23550 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If5146cda1020b494af6d43e5d8055e0045fa5b82 Gerrit-Change-Number: 23550 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: mb/google/fizz: Get OEM ID and SKU ID from EC
by build bot (Jenkins) (Code Review) 01 Feb '18

01 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23548 ) Change subject: mb/google/fizz: Get OEM ID and SKU ID from EC ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66915/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21500/ : SUCCESS -- To view, visit https://review.coreboot.org/23548 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06d3a205275b46660b3974bc3673d4be8e13f6d1 Gerrit-Change-Number: 23548 Gerrit-PatchSet: 5 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 01 Feb 2018 18:56:42 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: ec/google: Get OEM ID and SKU ID from EC
by build bot (Jenkins) (Code Review) 01 Feb '18

01 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23549 ) Change subject: ec/google: Get OEM ID and SKU ID from EC ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66914/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21499/ : SUCCESS -- To view, visit https://review.coreboot.org/23549 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff69a2dc0e562d87dd287f79c407f23aeb09fb9e Gerrit-Change-Number: 23549 Gerrit-PatchSet: 2 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 01 Feb 2018 18:53:26 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/fizz: Get OEM ID and SKU ID from EC
by build bot (Jenkins) (Code Review) 01 Feb '18

01 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23548 ) Change subject: mb/google/fizz: Get OEM ID and SKU ID from EC ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66912/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21497/ : SUCCESS -- To view, visit https://review.coreboot.org/23548 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06d3a205275b46660b3974bc3673d4be8e13f6d1 Gerrit-Change-Number: 23548 Gerrit-PatchSet: 4 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 01 Feb 2018 17:11:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: ec/google: Get OEM ID and SKU ID from EC
by build bot (Jenkins) (Code Review) 01 Feb '18

01 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23549 ) Change subject: ec/google: Get OEM ID and SKU ID from EC ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66911/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21496/ : SUCCESS -- To view, visit https://review.coreboot.org/23549 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff69a2dc0e562d87dd287f79c407f23aeb09fb9e Gerrit-Change-Number: 23549 Gerrit-PatchSet: 1 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 01 Feb 2018 16:59:26 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/fizz: Get OEM ID and SKU ID from EC
by build bot (Jenkins) (Code Review) 01 Feb '18

01 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23548 ) Change subject: mb/google/fizz: Get OEM ID and SKU ID from EC ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66910/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21495/ : SUCCESS -- To view, visit https://review.coreboot.org/23548 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06d3a205275b46660b3974bc3673d4be8e13f6d1 Gerrit-Change-Number: 23548 Gerrit-PatchSet: 3 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 01 Feb 2018 16:50:23 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: ec/google: Get OEM ID and SKU ID from EC
by Daisuke Nojiri (Code Review) 01 Feb '18

01 Feb '18

Daisuke Nojiri has uploaded this change for review. ( https://review.coreboot.org/23549 Change subject: ec/google: Get OEM ID and SKU ID from EC ...................................................................... ec/google: Get OEM ID and SKU ID from EC This patch adds EC_CMD_GET_CROS_BOARD_INFO to cros EC. It allows coreboot to fetch OEM ID and SKU ID from EC. BUG=b:70294260 BRANCH=none TEST=Verify AP log shows expected OEM ID and SKU ID on Fizz. Change-Id: Iff69a2dc0e562d87dd287f79c407f23aeb09fb9e Signed-off-by: Daisuke Nojiri <dnojiri(a)chromium.org> --- M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/ec.h M src/ec/google/chromeec/ec_commands.h 3 files changed, 103 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/23549/1 diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c index 89241da..3f81716 100644 --- a/src/ec/google/chromeec/ec.c +++ b/src/ec/google/chromeec/ec.c @@ -558,6 +558,40 @@ return google_chromeec_command(&cec_cmd); } +static int cbi_get_uint32(uint32_t *id, uint32_t type) +{ + struct chromeec_command cmd; + struct ec_params_get_cbi p; + uint32_t r; + int rv; + + p.type = type; + + cmd.cmd_code = EC_CMD_GET_CROS_BOARD_INFO; + cmd.cmd_version = 0; + cmd.cmd_data_in = &p; + cmd.cmd_data_out = &r; + cmd.cmd_size_in = sizeof(p); + cmd.cmd_size_out = sizeof(r); + cmd.cmd_dev_index = 0; + + rv = google_chromeec_command(&cmd); + if (rv < 0) + return rv; + *id = r; + return 0; +} + +int google_chromeec_get_sku_id2(uint32_t *id) +{ + return cbi_get_uint32(id, CBI_DATA_SKU_ID); +} + +int google_chromeec_get_oem_id(uint32_t *id) +{ + return cbi_get_uint32(id, CBI_DATA_OEM_ID); +} + #ifndef __SMM__ u16 google_chromeec_get_board_version(void) { diff --git a/src/ec/google/chromeec/ec.h b/src/ec/google/chromeec/ec.h index 90bb6fa..7192315 100644 --- a/src/ec/google/chromeec/ec.h +++ b/src/ec/google/chromeec/ec.h @@ -64,6 +64,15 @@ success, < 0 otherwise. */ int google_chromeec_reboot(int dev_idx, enum ec_reboot_cmd type, uint8_t flags); +/** + * Get OEM (or SKU) ID from EC + * + * @param id [OUT] oem/sku id + * @return 0 on success or negative integer for errors. + */ +int google_chromeec_get_oem_id(uint32_t *id); +int google_chromeec_get_sku_id2(uint32_t *id); + /* MEC uses 0x800/0x804 as register/index pair, thus an 8-byte resource. */ #define MEC_EMI_BASE 0x800 #define MEC_EMI_SIZE 8 diff --git a/src/ec/google/chromeec/ec_commands.h b/src/ec/google/chromeec/ec_commands.h index 92fb2a8..a8d6b30 100644 --- a/src/ec/google/chromeec/ec_commands.h +++ b/src/ec/google/chromeec/ec_commands.h @@ -4363,6 +4363,66 @@ uint32_t action; }; +/* Run verification on a slot */ +#define EC_CMD_EFS_VERIFY 0x011E + +struct __ec_align1 ec_params_efs_verify { + uint8_t region; /* enum ec_flash_region */ +}; + +/* + * Retrieve info from Cros Board Info store. Response is based on the data + * type. Integers return a uint32. Strings return a string, using the response + * size to determine how big it is. + */ +#define EC_CMD_GET_CROS_BOARD_INFO 0x011F +/* + * Write info into Cros Board Info on EEPROM. Write fails if the board has + * hardware write-protect enabled. + */ +#define EC_CMD_SET_CROS_BOARD_INFO 0x0120 + +enum cbi_data_type { + /* integer types */ + CBI_DATA_BOARD_VERSION = 0, + CBI_DATA_OEM_ID = 1, + CBI_DATA_SKU_ID = 2, + /* string types */ + CBI_FIRST_STRING_PARAM = 0x1000, + CBI_DATA_COUNT, +}; + +/* + * Flags to control read operation + * + * RELOAD: Invalidate cache and read data from EEPROM. Useful to verify + * write was successful without reboot. + */ +#define CBI_GET_RELOAD (1 << 0) + +struct __ec_align4 ec_params_get_cbi { + uint32_t type; /* enum cbi_data_type */ + uint32_t flag; /* CBI_GET_* */ +}; + +/* + * Flags to control write behavior. + * + * NO_SYNC: Makes EC update data in RAM but skip writing to EEPROM. It's + * useful when writing multiple fields in a row. + * INIT: Need to be set when creating a new CBI from scratch. All fields + * will be initialized to zero first. + */ +#define CBI_SET_NO_SYNC (1 << 0) +#define CBI_SET_INIT (1 << 1) + +struct __ec_align1 ec_params_set_cbi { + uint32_t type; /* enum cbi_data_type */ + uint32_t flag; /* CBI_SET_* */ + uint32_t data; /* For numeric value */ + uint8_t raw[]; /* For string and raw data */ +}; + /*****************************************************************************/ /* The command range 0x200-0x2FF is reserved for Rotor. */ -- To view, visit https://review.coreboot.org/23549 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iff69a2dc0e562d87dd287f79c407f23aeb09fb9e Gerrit-Change-Number: 23549 Gerrit-PatchSet: 1 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org>

1 0

Change in coreboot[master]: vendorcode/amd/pi/00670f00: Update headers to AGESA 1.3.0.9
by build bot (Jenkins) (Code Review) 01 Feb '18

01 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23547 ) Change subject: vendorcode/amd/pi/00670f00: Update headers to AGESA 1.3.0.9 ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66907/ : SUCCESS -- To view, visit https://review.coreboot.org/23547 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I783b7318e8273913f753b70f12bfe8b71274e27f Gerrit-Change-Number: 23547 Gerrit-PatchSet: 2 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 01 Feb 2018 16:24:26 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Fizz: Get OEM ID and SKU ID from EC
by build bot (Jenkins) (Code Review) 01 Feb '18

01 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23548 ) Change subject: Fizz: Get OEM ID and SKU ID from EC ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66909/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21494/ : SUCCESS -- To view, visit https://review.coreboot.org/23548 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06d3a205275b46660b3974bc3673d4be8e13f6d1 Gerrit-Change-Number: 23548 Gerrit-PatchSet: 2 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 01 Feb 2018 16:10:30 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2018