coreboot-gerrit February 2018

coreboot-gerrit@coreboot.org

1 participants
1573 discussions

Change in coreboot[master]: soc/intel/skylake: Set PsysPmax value
by build bot (Jenkins) (Code Review) 02 Feb '18

02 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23268 ) Change subject: soc/intel/skylake: Set PsysPmax value ...................................................................... Patch Set 9: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66985/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21559/ : SUCCESS -- To view, visit https://review.coreboot.org/23268 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I44f2e2917a8eb9ce3bb69d9c15899d4c7c5b2883 Gerrit-Change-Number: 23268 Gerrit-PatchSet: 9 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.corp-partner.google.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rajneesh Bhardwaj <rajneesh.bhardwaj(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Rushikesh S Kadam <rushikesh.s.kadam(a)intel.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Feb 2018 22:25:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: google/fizz: Determine PsysPl3 and Pl4 values
by build bot (Jenkins) (Code Review) 02 Feb '18

02 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23528 ) Change subject: google/fizz: Determine PsysPl3 and Pl4 values ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66983/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21557/ : SUCCESS -- To view, visit https://review.coreboot.org/23528 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06a4c5bc25f6ec036b79f6941f80e26058d64930 Gerrit-Change-Number: 23528 Gerrit-PatchSet: 3 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Feb 2018 22:16:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: google/fizz: Set Pmax value based on SKU id
by build bot (Jenkins) (Code Review) 02 Feb '18

02 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23576 ) Change subject: google/fizz: Set Pmax value based on SKU id ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66982/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21556/ : SUCCESS -- To view, visit https://review.coreboot.org/23576 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I47aa7f363781ae877e29bcebf9fae4d59b98027f Gerrit-Change-Number: 23576 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Feb 2018 20:57:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/skylake: Set PsysPmax value
by build bot (Jenkins) (Code Review) 02 Feb '18

02 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23268 ) Change subject: soc/intel/skylake: Set PsysPmax value ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66981/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21555/ : SUCCESS -- To view, visit https://review.coreboot.org/23268 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I44f2e2917a8eb9ce3bb69d9c15899d4c7c5b2883 Gerrit-Change-Number: 23268 Gerrit-PatchSet: 8 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.corp-partner.google.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rajneesh Bhardwaj <rajneesh.bhardwaj(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Rushikesh S Kadam <rushikesh.s.kadam(a)intel.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Feb 2018 20:56:17 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: google/fizz: Set Pmax value based on SKU id
by Shelley Chen (Code Review) 02 Feb '18

02 Feb '18

Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/23576 Change subject: google/fizz: Set Pmax value based on SKU id ...................................................................... google/fizz: Set Pmax value based on SKU id BUG=b:71594855 BRANCH=None TEST=Make sure correct pmax value is being passed into fsp Change-Id: I47aa7f363781ae877e29bcebf9fae4d59b98027f Signed-off-by: Shelley Chen <shchen(a)chromium.org> --- M src/mainboard/google/fizz/mainboard.c M src/soc/intel/skylake/chip_fsp20.c 2 files changed, 10 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/23576/1 diff --git a/src/mainboard/google/fizz/mainboard.c b/src/mainboard/google/fizz/mainboard.c index e4d2199..0d97fd4 100644 --- a/src/mainboard/google/fizz/mainboard.c +++ b/src/mainboard/google/fizz/mainboard.c @@ -41,6 +41,8 @@ #define FIZZ_PSYSPL2_U42 90 #define FIZZ_MAX_TIME_WINDOW 6 #define FIZZ_MIN_DUTYCYCLE 4 +#define FIZZ_PMAX_U42 120 +#define FIZZ_PMAX_U22 91 /* * For type-C chargers, set PL2 to 90% of max power to account for * cable loss and FET Rdson loss in the path from the source. @@ -137,7 +139,8 @@ */ static void mainboard_set_power_limits(u32 *pl2_val, u32 *psyspl2_val, u32 *psyspl3_val, u32 *psyspl3_time_val, - u32 *psyspl3_dutycycle_val, u32 *pl4_val) + u32 *psyspl3_dutycycle_val, u32 *pl4_val, + u16 *pmax_val) { enum usb_chg_type type; u32 watts; @@ -150,8 +153,11 @@ /* PL2 value is sku-based, no matter what charger we are using */ pl2 = FIZZ_PL2_U22; - if ((1 << sku) & u42_mask) + *pmax_val = FIZZ_PMAX_U22; + if ((1 << sku) & u42_mask) { pl2 = FIZZ_PL2_U42; + *pmax_val = FIZZ_PMAX_U42; + } *psyspl3_val = *pl4_val = 0; /* If we can't get charger info or not PD charger, assume barrel jack */ @@ -269,7 +275,7 @@ mainboard_set_power_limits(&conf->tdp_pl2_override, &conf->tdp_psyspl2, &conf->tdp_psyspl3, &conf->tdp_psyspl3_time, &conf->tdp_psyspl3_dutycycle, - &conf->tdp_pl4); + &conf->tdp_pl4, &conf->psys_pmax); set_bj_adapter_limit(); diff --git a/src/soc/intel/skylake/chip_fsp20.c b/src/soc/intel/skylake/chip_fsp20.c index ce1ad4c..3660f43 100644 --- a/src/soc/intel/skylake/chip_fsp20.c +++ b/src/soc/intel/skylake/chip_fsp20.c @@ -108,6 +108,7 @@ /* Set PsysPmax if it is available from DT */ if (config->psys_pmax) { /* PsysPmax is in unit of 1/8 Watt */ + printk(BIOS_DEBUG, "psys_pmax = %d\n", tconfig->PsysPmax); tconfig->PsysPmax = config->psys_pmax * 8; } -- To view, visit https://review.coreboot.org/23576 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I47aa7f363781ae877e29bcebf9fae4d59b98027f Gerrit-Change-Number: 23576 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen <shchen(a)google.com>

1 0

Change in coreboot[master]: mainboard/winent: Remove unnecessary braces {}
by build bot (Jenkins) (Code Review) 02 Feb '18

02 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23524 ) Change subject: mainboard/winent: Remove unnecessary braces {} ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66980/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21554/ : SUCCESS -- To view, visit https://review.coreboot.org/23524 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48a7bd4bd98d1a9d7b0ce4c12e09284fa4be6c7a Gerrit-Change-Number: 23524 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Feb 2018 20:09:43 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/kahlee/mainboard.c: Create mainboard_pirq_data
by build bot (Jenkins) (Code Review) 02 Feb '18

02 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22940 ) Change subject: mb/google/kahlee/mainboard.c: Create mainboard_pirq_data ...................................................................... Patch Set 11: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66979/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21553/ : SUCCESS -- To view, visit https://review.coreboot.org/22940 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If07d2f54f06f6cf77566c43eddc8ee8a314e7a3a Gerrit-Change-Number: 22940 Gerrit-PatchSet: 11 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Feb 2018 19:43:53 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/cannonlake: Add more HDA Audio Link settings
by build bot (Jenkins) (Code Review) 02 Feb '18

02 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23400 ) Change subject: soc/intel/cannonlake: Add more HDA Audio Link settings ...................................................................... Patch Set 6: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66978/ : SUCCESS -- To view, visit https://review.coreboot.org/23400 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2a75f554ddf9919a62c78a162ec1b9e602f1f5d Gerrit-Change-Number: 23400 Gerrit-PatchSet: 6 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Feb 2018 19:26:18 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: google/lars, lili: Update GPIO mapping
by build bot (Jenkins) (Code Review) 02 Feb '18

02 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23571 ) Change subject: google/lars,lili: Update GPIO mapping ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66975/ : SUCCESS -- To view, visit https://review.coreboot.org/23571 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2d188fbf913a11fbf6ad1f0eb3a5e72ba4cb1cf Gerrit-Change-Number: 23571 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: David Wu <david_wu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Feb 2018 19:23:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: google/lars: Turn on keyboard backlight in romstage
by build bot (Jenkins) (Code Review) 02 Feb '18

02 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23572 ) Change subject: google/lars: Turn on keyboard backlight in romstage ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66976/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21551/ : SUCCESS -- To view, visit https://review.coreboot.org/23572 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b1fed10d9bd1ae1b265e848417836f816f252f3 Gerrit-Change-Number: 23572 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Jenny Tc <jenny.tc(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Feb 2018 19:20:52 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2018