coreboot-gerrit February 2018

coreboot-gerrit@coreboot.org

1 participants
1573 discussions

Change in coreboot[master]: mainboard/google/reef/sand: Add USB2 phy setting override for sand
by build bot (Jenkins) (Code Review) 27 Feb '18

27 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23879 ) Change subject: mainboard/google/reef/sand: Add USB2 phy setting override for sand ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67988/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22467/ : SUCCESS -- To view, visit https://review.coreboot.org/23879 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4051aefbec4583bb1f8babec08fdbeb27f749769 Gerrit-Change-Number: 23879 Gerrit-PatchSet: 1 Gerrit-Owner: Katherine Hsieh <Katherine.Hsieh(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Feb 2018 12:32:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/reef/sand: Add USB2 phy setting override for sand
by Katherine Hsieh (Code Review) 27 Feb '18

27 Feb '18

Katherine Hsieh has uploaded this change for review. ( https://review.coreboot.org/23879 Change subject: mainboard/google/reef/sand: Add USB2 phy setting override for sand ...................................................................... mainboard/google/reef/sand: Add USB2 phy setting override for sand Due to there are some chances USB devices can not be detected. USB2 port#1 and #4 PHY register need to be overridden. port#1: PERPORTPETXISET = 4 PERPORTTXISET = 4 IUSBTXEMPHASISEN= 1 PERPORTTXPEHALF= 0 port#4: PERPORTPETXISET = 7 PERPORTTXISET = 7 IUSBTXEMPHASISEN= 1 PERPORTTXPEHALF= 0 BUG=b:72623892 BRANCH=master TEST=emerge-sand coreboot chromeos-bootimage Change-Id: I4051aefbec4583bb1f8babec08fdbeb27f749769 Signed-off-by: Katherine Hsieh <Katherine.Hsieh(a)quantatw.com> --- M src/mainboard/google/reef/variants/sand/devicetree.cb 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/23879/1 diff --git a/src/mainboard/google/reef/variants/sand/devicetree.cb b/src/mainboard/google/reef/variants/sand/devicetree.cb index 0735a35..a6692e6 100644 --- a/src/mainboard/google/reef/variants/sand/devicetree.cb +++ b/src/mainboard/google/reef/variants/sand/devicetree.cb @@ -112,6 +112,22 @@ # Minimum SLP S3 assertion width 28ms. register "slp_s3_assertion_width_usecs" = "28000" + # Override USB2 PER PORT register (PORT 1) + register "usb2eye[1]" = "{ + .Usb20PerPortPeTxiSet = 4, + .Usb20PerPortTxiSet = 4, + .Usb20IUsbTxEmphasisEn = 1, + .Usb20PerPortTxPeHalf = 0, + }" + + # Override USB2 PER PORT register (PORT 4) + register "usb2eye[4]" = "{ + .Usb20PerPortPeTxiSet = 7, + .Usb20PerPortTxiSet = 7, + .Usb20IUsbTxEmphasisEn = 1, + .Usb20PerPortTxPeHalf = 0, + }" + device domain 0 on device pci 00.0 on end # - Host Bridge device pci 00.1 on end # - DPTF -- To view, visit https://review.coreboot.org/23879 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4051aefbec4583bb1f8babec08fdbeb27f749769 Gerrit-Change-Number: 23879 Gerrit-PatchSet: 1 Gerrit-Owner: Katherine Hsieh <Katherine.Hsieh(a)quantatw.com>

1 0

Change in coreboot[master]: mainboard/google/reef: Add USB2 phy setting override for reef
by build bot (Jenkins) (Code Review) 27 Feb '18

27 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23878 ) Change subject: mainboard/google/reef: Add USB2 phy setting override for reef ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67987/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22466/ : SUCCESS -- To view, visit https://review.coreboot.org/23878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab782ac6dfd81af839fff0e60e2b2460ce722733 Gerrit-Change-Number: 23878 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Chen <Tim-Chen(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Feb 2018 12:06:59 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/reef: Add USB2 phy setting override for reef
by Tim Chen (Code Review) 27 Feb '18

27 Feb '18

Tim Chen has uploaded this change for review. ( https://review.coreboot.org/23878 Change subject: mainboard/google/reef: Add USB2 phy setting override for reef ...................................................................... mainboard/google/reef: Add USB2 phy setting override for reef Due to there are some chances USB devices can not be detected. USB2 port#1 and #4 PHY register need to be overridden. port#1: PERPORTPETXISET = 4 PERPORTTXISET = 4 IUSBTXEMPHASISEN= 1 PERPORTTXPEHALF= 0 port#4: PERPORTPETXISET = 7 PERPORTTXISET = 7 IUSBTXEMPHASISEN= 1 PERPORTTXPEHALF= 0 BUG=b:72623892 BRANCH=master TEST=emerge-reef coreboot chromeos-bootimage Change-Id: Iab782ac6dfd81af839fff0e60e2b2460ce722733 Signed-off-by: Tim Chen <Tim-Chen(a)quantatw.com> --- M src/mainboard/google/reef/variants/baseboard/devicetree.cb 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/23878/1 diff --git a/src/mainboard/google/reef/variants/baseboard/devicetree.cb b/src/mainboard/google/reef/variants/baseboard/devicetree.cb index d5f546c..0f11f63 100644 --- a/src/mainboard/google/reef/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/reef/variants/baseboard/devicetree.cb @@ -116,6 +116,22 @@ # Minimum SLP S3 assertion width 28ms. register "slp_s3_assertion_width_usecs" = "28000" + # Override USB2 PER PORT register (PORT 1) + register "usb2eye[1]" = "{ + .Usb20PerPortPeTxiSet = 4, + .Usb20PerPortTxiSet = 4, + .Usb20IUsbTxEmphasisEn = 1, + .Usb20PerPortTxPeHalf = 0, + }" + + # Override USB2 PER PORT register (PORT 4) + register "usb2eye[4]" = "{ + .Usb20PerPortPeTxiSet = 7, + .Usb20PerPortTxiSet = 7, + .Usb20IUsbTxEmphasisEn = 1, + .Usb20PerPortTxPeHalf = 0, + }" + device domain 0 on device pci 00.0 on end # - Host Bridge device pci 00.1 on end # - DPTF -- To view, visit https://review.coreboot.org/23878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iab782ac6dfd81af839fff0e60e2b2460ce722733 Gerrit-Change-Number: 23878 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Chen <Tim-Chen(a)quantatw.com>

1 0

Change in coreboot[master]: Kconfig: Add option to select the enclosure type
by build bot (Jenkins) (Code Review) 27 Feb '18

27 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23841 ) Change subject: Kconfig: Add option to select the enclosure type ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67986/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22465/ : SUCCESS -- To view, visit https://review.coreboot.org/23841 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I35bc913af69565531831746040a0afe0cabe1c58 Gerrit-Change-Number: 23841 Gerrit-PatchSet: 6 Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert(a)online.net> Gerrit-Reviewer: Julien Viard de Galbert <jviarddegalbert(a)online.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Feb 2018 10:52:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Kconfig: Add option to select the enclosure type
by build bot (Jenkins) (Code Review) 27 Feb '18

27 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23841 ) Change subject: Kconfig: Add option to select the enclosure type ...................................................................... Patch Set 5: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/67985/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/22464/ : SUCCESS -- To view, visit https://review.coreboot.org/23841 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I35bc913af69565531831746040a0afe0cabe1c58 Gerrit-Change-Number: 23841 Gerrit-PatchSet: 5 Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert(a)online.net> Gerrit-Reviewer: Julien Viard de Galbert <jviarddegalbert(a)online.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Feb 2018 10:30:06 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/cbfstool: Add ARM64 Image support
by Patrick Rudolph (Code Review) 27 Feb '18

27 Feb '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/23869 ) Change subject: util/cbfstool: Add ARM64 Image support ...................................................................... Patch Set 2: > I'm a little confused why we need a trampoline and relocation code > just to boot an ARM64 kernel. ARM64 kernels always want to be > loaded at the start of physical memory (+0x80000). ARM64 boards in > coreboot can statically position their ramstage wherever they want > in memlayout. Why not just make sure that the ramstage is always > far enough away from the start of physical memory to avoid the > possibility of an overlap and be done with it? I mean, all relevant > systems have more than enough DRAM available. > > This just seems to add loads of complication to the process with no > clear gain. The trampoline: Coreboot passes a pointer to the coreboot tables in x0, but we have to pass a pointer to the devicetree in x0. My first idea was to include the devicetree in the payload and load it to a known address right before the kernel. But we need to be able to modify it, like it's done with ACPI tables. The trampoline's purpose is to find the devicetree in coreboot tables and pass the address to the kernel in x0. The load address: I can place the kernel anywhere in DRAM, the start of DRAM is prefered. Using static address has the following disadvantages: I need to know start of DRAM, but that's only set in memlayout.ld. Extracting it seems a bit tricky. I would need to modify all memlayout.ld to have enough free space for the kernel image. I need to add a sanity check, that the start of dram is usable. That could be done with a new REGION called payload for example. With the dynamic loader I don't have to care about all that, it just places the kernel and executes it. -- To view, visit https://review.coreboot.org/23869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a8183a87de4dc3a4c4f038fe5b4912ada5d75f9 Gerrit-Change-Number: 23869 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Feb 2018 08:26:51 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/skylake: Add support to print ME version
by build bot (Jenkins) (Code Review) 26 Feb '18

26 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23857 ) Change subject: soc/intel/skylake: Add support to print ME version ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67984/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22463/ : SUCCESS -- To view, visit https://review.coreboot.org/23857 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I360d5d7420950d5aa255df08be6d7123621b87a8 Gerrit-Change-Number: 23857 Gerrit-PatchSet: 3 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Feb 2018 06:09:18 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variant/nautilus: Change SlowSlewRateForSa setting
by build bot (Jenkins) (Code Review) 26 Feb '18

26 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23877 ) Change subject: mb/google/poppy/variant/nautilus: Change SlowSlewRateForSa setting ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67983/ : SUCCESS -- To view, visit https://review.coreboot.org/23877 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id1d4bd8b1316c02c783de708ec4658e030193a26 Gerrit-Change-Number: 23877 Gerrit-PatchSet: 2 Gerrit-Owner: Seunghwan Kim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Seunghwan Kim <sh_.kim(a)samsung.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Feb 2018 06:00:59 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variant/nautilus: Change SlowSlewRateForSa setting
by build bot (Jenkins) (Code Review) 26 Feb '18

26 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23877 ) Change subject: mb/google/poppy/variant/nautilus: Change SlowSlewRateForSa setting ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/67982/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/22462/ : ABORTED -- To view, visit https://review.coreboot.org/23877 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id1d4bd8b1316c02c783de708ec4658e030193a26 Gerrit-Change-Number: 23877 Gerrit-PatchSet: 1 Gerrit-Owner: Seunghwan Kim <sh_.kim(a)samsung.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Feb 2018 05:43:39 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2018