coreboot-gerrit February 2018

coreboot-gerrit@coreboot.org

1 participants
1573 discussions

Change in coreboot[master]: mb/google/fizz: Set Pmax to 120 for all SKUs
by build bot (Jenkins) (Code Review) 07 Feb '18

07 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23633 ) Change subject: mb/google/fizz: Set Pmax to 120 for all SKUs ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67160/ : SUCCESS -- To view, visit https://review.coreboot.org/23633 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic27fef87c869094b20438e6ee0e1eb0b35122b8d Gerrit-Change-Number: 23633 Gerrit-PatchSet: 2 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Feb 2018 16:14:49 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: payloads: Add an option to compress secondary payloads
by build bot (Jenkins) (Code Review) 07 Feb '18

07 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23639 ) Change subject: payloads: Add an option to compress secondary payloads ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67159/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21721/ : SUCCESS -- To view, visit https://review.coreboot.org/23639 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddfd6fcf4112d255cc7b2b49b99bf5ea4d6f8db4 Gerrit-Change-Number: 23639 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Feb 2018 12:43:28 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Revise AC/DC loadlines
by build bot (Jenkins) (Code Review) 07 Feb '18

07 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23635 ) Change subject: mb/google/poppy/variants/nami: Revise AC/DC loadlines ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67158/ : SUCCESS -- To view, visit https://review.coreboot.org/23635 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib8aeb82973c42723d7b623967f8085c8f1d926eb Gerrit-Change-Number: 23635 Gerrit-PatchSet: 2 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Feb 2018 12:33:28 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/poopy/variants/nami: Add Pmax setting
by build bot (Jenkins) (Code Review) 07 Feb '18

07 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23640 ) Change subject: mb/google/poopy/variants/nami: Add Pmax setting ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67157/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21720/ : SUCCESS -- To view, visit https://review.coreboot.org/23640 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief6a134dc5b6bd2b8e07b4a44450e99ff26402d9 Gerrit-Change-Number: 23640 Gerrit-PatchSet: 1 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Feb 2018 12:21:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: payloads: Add an option to compress secondary payloads
by build bot (Jenkins) (Code Review) 07 Feb '18

07 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23639 ) Change subject: payloads: Add an option to compress secondary payloads ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67156/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21719/ : SUCCESS -- To view, visit https://review.coreboot.org/23639 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddfd6fcf4112d255cc7b2b49b99bf5ea4d6f8db4 Gerrit-Change-Number: 23639 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Feb 2018 12:21:46 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poopy/variants/nami: Add Pmax setting
by Gaggery Tsai (Code Review) 07 Feb '18

07 Feb '18

Gaggery Tsai has uploaded this change for review. ( https://review.coreboot.org/23640 Change subject: mb/google/poopy/variants/nami: Add Pmax setting ...................................................................... mb/google/poopy/variants/nami: Add Pmax setting This patch adds the Pmax setting in device tree. The Pmax is from MAX(PL4_sku1, PL4_sku2, ..) + ROPmax. Given ROPmax is 30W and the maximum PL4 is from U42, hence the Pmax = 71W + 30W = 101W. BUG=b:72138778 BRANCH=None TEST=USE=fw_debug emerge-nami chromeos-mrc coreboot chromeos-bootimage & ensure the Pmax value is passed to FSP-S. Change-Id: Ief6a134dc5b6bd2b8e07b4a44450e99ff26402d9 Signed-off-by: Gaggery Tsai <gaggery.tsai(a)intel.com> --- M src/mainboard/google/poppy/variants/nami/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/23640/1 diff --git a/src/mainboard/google/poppy/variants/nami/devicetree.cb b/src/mainboard/google/poppy/variants/nami/devicetree.cb index 55ecb26..7c38a3a 100644 --- a/src/mainboard/google/poppy/variants/nami/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nami/devicetree.cb @@ -229,6 +229,7 @@ register "speed_shift_enable" = "1" register "tcc_offset" = "10" # TCC of 90C + register "psys_pmax" = "101" # Lock Down register "chipset_lockdown" = "CHIPSET_LOCKDOWN_COREBOOT" -- To view, visit https://review.coreboot.org/23640 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ief6a134dc5b6bd2b8e07b4a44450e99ff26402d9 Gerrit-Change-Number: 23640 Gerrit-PatchSet: 1 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com>

1 0

Change in coreboot[master]: payloads: Add an option to compress secondary payloads
by Arthur Heymans (Code Review) 07 Feb '18

07 Feb '18

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/23639 Change subject: payloads: Add an option to compress secondary payloads ...................................................................... payloads: Add an option to compress secondary payloads Both grub and SeaBIOS can chainload lzma compressed payloads. Therefore it is beneficiary to compress secondary payloads like memtest86+, coreinfo, nvramcui,... for both size reasons and often also speed reasons since the limiting factor is generally the IO of the boot device. Tested with SeaBIOS and memtest86+ master on Thinkpad X220. Change-Id: Iddfd6fcf4112d255cc7b2b49b99bf5ea4d6f8db4 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M Makefile.inc M payloads/Kconfig M payloads/Makefile.inc M payloads/external/Makefile.inc 4 files changed, 16 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/23639/1 diff --git a/Makefile.inc b/Makefile.inc index 0593d31..379215b 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -350,6 +350,11 @@ CBFS_PAYLOAD_COMPRESS_FLAG:=LZ4 endif +CBFS_SECONDARY_PAYLOAD_COMPRESS_FLAG:=none +ifeq ($(CONFIG_COMPRESS_SECONDARY_PAYLOAD),y) +CBFS_SECONDARY_PAYLOAD_COMPRESS_FLAG:=LZMA +endif + CBFS_PRERAM_COMPRESS_FLAG:=none ifeq ($(CONFIG_COMPRESS_PRERAM_STAGES),y) CBFS_PRERAM_COMPRESS_FLAG:=LZ4 diff --git a/payloads/Kconfig b/payloads/Kconfig index 125ca61..4dd733f 100644 --- a/payloads/Kconfig +++ b/payloads/Kconfig @@ -82,6 +82,13 @@ Add the payload to cbfs as a flat binary type instead of as an elf payload +config COMPRESS_SECONDARY_PAYLOAD + bool "Use LZMA compression for secondary payloads" + default y + help + In order to reduce the size secondary payloads take up in the + ROM chip coreboot can compress them using the LZMA algorithm. + menu "Secondary Payloads" config COREINFO_SECONDARY_PAYLOAD diff --git a/payloads/Makefile.inc b/payloads/Makefile.inc index b27d7fe..d894dec 100644 --- a/payloads/Makefile.inc +++ b/payloads/Makefile.inc @@ -16,10 +16,12 @@ cbfs-files-$(CONFIG_COREINFO_SECONDARY_PAYLOAD) += img/coreinfo img/coreinfo-file := payloads/coreinfo/build/coreinfo.elf img/coreinfo-type := payload +img/coreinfo-compression := $(CBFS_SECONDARY_PAYLOAD_COMPRESS_FLAG) cbfs-files-$(CONFIG_NVRAMCUI_SECONDARY_PAYLOAD) += img/nvramcui img/nvramcui-file := payloads/nvramcui/nvramcui.elf img/nvramcui-type := payload +img/nvramcui-compression := $(CBFS_SECONDARY_PAYLOAD_COMPRESS_FLAG) PAYLOADS_LIST=\ payloads/coreinfo \ diff --git a/payloads/external/Makefile.inc b/payloads/external/Makefile.inc index 62d8a44..ec7d9a8 100644 --- a/payloads/external/Makefile.inc +++ b/payloads/external/Makefile.inc @@ -185,12 +185,14 @@ cbfs-files-$(CONFIG_TINT_SECONDARY_PAYLOAD) += img/tint img/tint-file := payloads/external/tint/tint/tint.elf img/tint-type := payload +img/tint-compression := $(CBFS_SECONDARY_PAYLOAD_COMPRESS_FLAG) # Memtest86+ cbfs-files-$(CONFIG_MEMTEST_SECONDARY_PAYLOAD) += img/memtest img/memtest-file := payloads/external/Memtest86Plus/memtest86plus/memtest img/memtest-type := payload +img/memtest-compression := $(CBFS_SECONDARY_PAYLOAD_COMPRESS_FLAG) ifeq ($(CONFIG_CONSOLE_SERIAL)$(CONFIG_DRIVERS_UART_8250IO),yy) MEMTEST_SERIAL_OPTIONS=SERIAL_CONSOLE_DEFAULT=1 \ -- To view, visit https://review.coreboot.org/23639 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iddfd6fcf4112d255cc7b2b49b99bf5ea4d6f8db4 Gerrit-Change-Number: 23639 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in libgfxinit[master]: [WIP] gfx_test: Move Cursors
by Nico Huber (Code Review) 07 Feb '18

07 Feb '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/23638 Change subject: [WIP] gfx_test: Move Cursors ...................................................................... [WIP] gfx_test: Move Cursors Change-Id: I5187379c0b6c3c20f43c323fa6b4a903746a02a8 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M gfxtest/hw-gfx-gma-gfx_test.adb 1 file changed, 154 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/38/23638/1 diff --git a/gfxtest/hw-gfx-gma-gfx_test.adb b/gfxtest/hw-gfx-gma-gfx_test.adb index 0c29fbe..aa83aa8 100644 --- a/gfxtest/hw-gfx-gma-gfx_test.adb +++ b/gfxtest/hw-gfx-gma-gfx_test.adb @@ -15,9 +15,9 @@ is pragma Disable_Atomic_Synchronization; - package Rand_P is new Ada.Numerics.Discrete_Random (Pos_Type); + package Rand_P is new Ada.Numerics.Discrete_Random (Natural); Gen : Rand_P.Generator; - function Rand return Pos_Type is (Rand_P.Random (Gen)); + function Rand return Int32 is (Int32 (Rand_P.Random (Gen))); Start_X : constant := 0; Start_Y : constant := 0; @@ -371,6 +371,147 @@ GMA.Dump_Configs (Pipes); end Prepare_Configs; + procedure Script_Cursors + (Pipes : in out GMA.Pipe_Configs; + Time_S : in Natural) + is + type Corner is (UL, UR, LR, LL); + type Cursor_Script_Entry is record + Rel : Corner; + X, Y : Int32; + end record; + Cursor_Script : constant array (Natural range 0 .. 19) of Cursor_Script_Entry := + ((UL, 16, 16), (UL, 16, 16), (UL, 16, 16), (UL, -32, 0), (UL, 16, 16), + (UR, -16, 16), (UR, -16, 16), (UR, -16, 16), (UR, 0, -32), (UR, -16, 16), + (LR, -16, -16), (LR, -16, -16), (LR, -16, -16), (LR, 32, 0), (LR, -16, -16), + (LL, 16, -16), (LL, 16, -16), (LL, 16, -16), (LL, 0, 32), (LL, 16, -16)); + + Deadline : constant Time.T := Time.MS_From_Now (1_000 * Time_S); + Timed_Out : Boolean := False; + Cnt : Word32 := 0; + begin + loop + for Pipe in Pipe_Index loop + exit when Pipes (Pipe).Port = GMA.Disabled; + declare + C : Cursor_Type renames Pipes (Pipe).Cursor; + FB : Framebuffer_Type renames Pipes (Pipe).Framebuffer; + Width : constant Int32 := Int32 (Rotated_Width (FB)); + Height : constant Int32 := Int32 (Rotated_Height (FB)); + CS : Cursor_Script_Entry renames Cursor_Script + (Natural (Cnt) mod (Cursor_Script'Last + 1)); + begin + C.Center_X := CS.X; + C.Center_Y := CS.Y; + case CS.Rel is + when UL => null; + when UR => C.Center_X := CS.X + Width; + when LR => C.Center_X := CS.X + Width; + C.Center_Y := CS.Y + Height; + when LL => C.Center_Y := CS.Y + Height; + end case; + GMA.Place_Cursor (Pipe, C.Center_X, C.Center_Y); + end; + end loop; + Timed_Out := Time.Timed_Out (Deadline); + exit when Timed_Out; + Time.M_Delay (160); + Cnt := Cnt + 1; + end loop; + end Script_Cursors; + + type Cursor_Info is record + X_Velo, Y_Velo : Int32; + X_Acc, Y_Acc : Int32; + Color : Pipe_Index; + Size : Cursor_Size; + end record; + function Cursor_Rand return Int32 is (Rand mod 51 - 25); + Cursor_Infos : array (Pipe_Index) of Cursor_Info := + (others => + (Color => Pipe_Index'Val (Rand mod 3), + Size => Cursor_Size'Val (Rand mod 3), + X_Velo => 3 * Cursor_Rand, + Y_Velo => 3 * Cursor_Rand, + others => Cursor_Rand)); + + procedure Move_Cursors + (Pipes : in out GMA.Pipe_Configs; + Time_S : in Natural) + is + procedure Select_New_Cursor + (P : in Pipe_Index; + C : in out Cursor_Type; + CI : in out Cursor_Info) + is + Old_C : constant Cursor_Type := C; + begin + -- change either size or color + if Rand mod 2 = 0 then + CI.Color := Pipe_Index'Val + ((Pipe_Index'Pos (CI.Color) + 1 + Rand mod 2) mod 3); + else + CI.Size := Cursor_Size'Val + ((Cursor_Size'Pos (CI.Size) + 1 + Rand mod 2) mod 3); + end if; + C := Cursors (CI.Color) (CI.Size); + C.Center_X := Old_C.Center_X; + C.Center_Y := Old_C.Center_Y; + GMA.Update_Cursor (P, C); + end Select_New_Cursor; + + Deadline : constant Time.T := Time.MS_From_Now (1_000 * Time_S); + Timed_Out : Boolean := False; + Cnt : Word32 := 0; + begin + for Pipe in Pipe_Index loop + exit when Pipes (Pipe).Port = GMA.Disabled; + Select_New_Cursor (Pipe, Pipes (Pipe).Cursor, Cursor_Infos (Pipe)); + end loop; + loop + for Pipe in Pipe_Index loop + exit when Pipes (Pipe).Port = GMA.Disabled; + declare + C : Cursor_Type renames Pipes (Pipe).Cursor; + CI : Cursor_Info renames Cursor_Infos (Pipe); + FB : Framebuffer_Type renames Pipes (Pipe).Framebuffer; + Width : constant Int32 := Int32 (Rotated_Width (FB)); + Height : constant Int32 := Int32 (Rotated_Height (FB)); + + Update : Boolean := False; + begin + if Cnt mod 16 = 0 then + CI.X_Acc := Cursor_Rand; + CI.Y_Acc := Cursor_Rand; + end if; + CI.X_Velo := CI.X_Velo + CI.X_Acc; + CI.Y_Velo := CI.Y_Velo + CI.Y_Acc; + C.Center_X := C.Center_X + CI.X_Velo / 100; + C.Center_Y := C.Center_Y + CI.Y_Velo / 100; + if C.Center_X not in 0 .. Width - 1 then + C.Center_X := Int32'Max (0, Int32'Min (Width, C.Center_X)); + CI.X_Velo := -CI.X_Velo; + Update := True; + end if; + if C.Center_Y not in 0 .. Height - 1 then + C.Center_Y := Int32'Max (0, Int32'Min (Height, C.Center_Y)); + CI.Y_Velo := -CI.Y_Velo; + Update := True; + end if; + if Update then + Select_New_Cursor (Pipe, C, CI); + else + GMA.Place_Cursor (Pipe, C.Center_X, C.Center_Y); + end if; + end; + end loop; + Timed_Out := Time.Timed_Out (Deadline); + exit when Timed_Out; + Time.M_Delay (16); -- ~60 fps + Cnt := Cnt + 1; + end loop; + end Move_Cursors; + procedure Print_Usage is begin @@ -465,8 +606,10 @@ end loop; end loop; - if Delay_S >= 12 then -- getting bored? - Time.M_Delay (8_000); + if Delay_S < 12 then + Script_Cursors (Pipes, Delay_S); + else -- getting bored? + Script_Cursors (Pipes, 8); Delay_S := Delay_S - 8; declare New_Pipes : GMA.Pipe_Configs := Pipes; @@ -485,6 +628,7 @@ declare New_FB : Framebuffer_Type renames New_Pipes (Pipe).Framebuffer; + Cursor : Cursor_Type renames New_Pipes (Pipe).Cursor; Width : constant Width_Type := Pipes (Pipe).Framebuffer.Width; Height : constant Height_Type := @@ -498,16 +642,20 @@ (320, Width - New_FB.Start_X - Rand_Div (Width)); New_FB.Height := Height_Type'Max (320, Height - New_FB.Start_Y - Rand_Div (Height)); + + Cursor.Center_X := Int32 (Rotated_Width (New_FB)) / 2; + Cursor.Center_Y := Int32 (Rotated_Height (New_FB)) / 2; + GMA.Update_Cursor (Pipe, Cursor); end; end loop; GMA.Dump_Configs (New_Pipes); GMA.Update_Outputs (New_Pipes); - Time.M_Delay (4_000); + Move_Cursors (New_Pipes, 4); Delay_S := Delay_S - 4; end loop; + Move_Cursors (New_Pipes, Delay_S); end; end if; - Time.M_Delay (Delay_S * 1_000); for Pipe in GMA.Pipe_Index loop if Pipes (Pipe).Port /= GMA.Disabled then -- To view, visit https://review.coreboot.org/23638 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5187379c0b6c3c20f43c323fa6b4a903746a02a8 Gerrit-Change-Number: 23638 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in libgfxinit[master]: [WIP] gfx_test: Refactor "bored" loop
by Nico Huber (Code Review) 07 Feb '18

07 Feb '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/23637 Change subject: [WIP] gfx_test: Refactor "bored" loop ...................................................................... [WIP] gfx_test: Refactor "bored" loop Change-Id: I44920c35b4ea3f0a08ce306dcf8203379c15791b Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M gfxtest/hw-gfx-gma-gfx_test.adb 1 file changed, 25 insertions(+), 21 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/37/23637/1 diff --git a/gfxtest/hw-gfx-gma-gfx_test.adb b/gfxtest/hw-gfx-gma-gfx_test.adb index 231d5dd..0c29fbe 100644 --- a/gfxtest/hw-gfx-gma-gfx_test.adb +++ b/gfxtest/hw-gfx-gma-gfx_test.adb @@ -465,9 +465,11 @@ end loop; end loop; - if Delay_S > 8 then -- getting bored? + if Delay_S >= 12 then -- getting bored? + Time.M_Delay (8_000); + Delay_S := Delay_S - 8; declare - New_Pipes : GMA.Pipe_Configs; + New_Pipes : GMA.Pipe_Configs := Pipes; function Rand_Div (Num : Pos_Type) return Pos_Type is (case Rand mod 4 is @@ -476,30 +478,32 @@ when 1 => Rand mod Num, when others => 0); begin - Time.M_Delay (4_000); - Delay_S := Delay_S - 4; - while Delay_S > 4 loop - Time.M_Delay (4_000); - Delay_S := Delay_S - 4; + while Delay_S >= 4 loop New_Pipes := Pipes; for Pipe in GMA.Pipe_Index loop - New_Pipes (Pipe).Framebuffer.Start_X := - Rand_Div (Pipes (Pipe).Framebuffer.Width); - New_Pipes (Pipe).Framebuffer.Start_Y := - Rand_Div (Pipes (Pipe).Framebuffer.Height); - New_Pipes (Pipe).Framebuffer.Width := - Width_Type'Max (320, - Pipes (Pipe).Framebuffer.Width - - New_Pipes (Pipe).Framebuffer.Start_X - - Rand_Div (Pipes (Pipe).Framebuffer.Width)); - New_Pipes (Pipe).Framebuffer.Height := - Height_Type'Max (320, - Pipes (Pipe).Framebuffer.Height - - New_Pipes (Pipe).Framebuffer.Start_Y - - Rand_Div (Pipes (Pipe).Framebuffer.Height)); + exit when Pipes (Pipe).Port = Disabled; + declare + New_FB : Framebuffer_Type renames + New_Pipes (Pipe).Framebuffer; + Width : constant Width_Type := + Pipes (Pipe).Framebuffer.Width; + Height : constant Height_Type := + Pipes (Pipe).Framebuffer.Height; + begin + New_FB.Start_X := Pos_Type'Min + (Width - 320, Rand_Div (Width)); + New_FB.Start_Y := Pos_Type'Min + (Height - 320, Rand_Div (Height)); + New_FB.Width := Width_Type'Max + (320, Width - New_FB.Start_X - Rand_Div (Width)); + New_FB.Height := Height_Type'Max + (320, Height - New_FB.Start_Y - Rand_Div (Height)); + end; end loop; GMA.Dump_Configs (New_Pipes); GMA.Update_Outputs (New_Pipes); + Time.M_Delay (4_000); + Delay_S := Delay_S - 4; end loop; end; end if; -- To view, visit https://review.coreboot.org/23637 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I44920c35b4ea3f0a08ce306dcf8203379c15791b Gerrit-Change-Number: 23637 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: soc/intel/skylake: Clean up SMBIOS Table Type 17 creation
by build bot (Jenkins) (Code Review) 07 Feb '18

07 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23636 ) Change subject: soc/intel/skylake: Clean up SMBIOS Table Type 17 creation ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67155/ : SUCCESS -- To view, visit https://review.coreboot.org/23636 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ad99de53e280a3db431f706310e6cb22b8b3953 Gerrit-Change-Number: 23636 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Feb 2018 10:37:31 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2018