coreboot-gerrit February 2018

coreboot-gerrit@coreboot.org

1 participants
1573 discussions

Change in coreboot[master]: nb/x4x: Get rid off device_t
by build bot (Jenkins) (Code Review) 08 Feb '18

08 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23655 ) Change subject: nb/x4x: Get rid off device_t ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67214/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21768/ : SUCCESS -- To view, visit https://review.coreboot.org/23655 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib3e708a7fa9f0a78dc704a502a2f01ee0fe209ae Gerrit-Change-Number: 23655 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Feb 2018 14:05:52 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: cpu/amd: Get rid off device_t
by Elyes HAOUAS (Code Review) 08 Feb '18

08 Feb '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/23653 to look at the new patch set (#7). Change subject: cpu/amd: Get rid off device_t ...................................................................... cpu/amd: Get rid off device_t Use of `device_t` has been abandoned in ramstage Change-Id: I4b930a191130941c8349861cdd803a5be4219274 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/cpu/amd/agesa/family12/model_12_init.c M src/cpu/amd/agesa/family14/model_14_init.c M src/cpu/amd/agesa/family15tn/model_15_init.c M src/cpu/amd/agesa/family16kb/model_16_init.c M src/cpu/amd/dualcore/amd_sibling.c M src/cpu/amd/family_10h-family_15h/model_10xxx_init.c M src/cpu/amd/family_10h-family_15h/processor_name.c M src/cpu/amd/family_10h-family_15h/ram_calc.c M src/cpu/amd/geode_lx/geode_lx_init.c M src/cpu/amd/model_fxx/model_fxx_init.c M src/cpu/amd/pi/00630F01/model_15_init.c M src/cpu/amd/pi/00660F01/model_15_init.c M src/cpu/amd/pi/00730F01/model_16_init.c 13 files changed, 18 insertions(+), 18 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/23653/7 -- To view, visit https://review.coreboot.org/23653 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4b930a191130941c8349861cdd803a5be4219274 Gerrit-Change-Number: 23653 Gerrit-PatchSet: 7 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: cpu/amd: Get rid off device_t
by build bot (Jenkins) (Code Review) 08 Feb '18

08 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23653 ) Change subject: cpu/amd: Get rid off device_t ...................................................................... Patch Set 6: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/67213/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/21767/ : SUCCESS -- To view, visit https://review.coreboot.org/23653 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b930a191130941c8349861cdd803a5be4219274 Gerrit-Change-Number: 23653 Gerrit-PatchSet: 6 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Feb 2018 14:00:10 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: nb/x4x: Get rid off device_t
by Elyes HAOUAS (Code Review) 08 Feb '18

08 Feb '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/23655 Change subject: nb/x4x: Get rid off device_t ...................................................................... nb/x4x: Get rid off device_t Use of `device_t` has been abandoned in ramstage Change-Id: Ib3e708a7fa9f0a78dc704a502a2f01ee0fe209ae Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/northbridge/intel/x4x/acpi.c M src/northbridge/intel/x4x/gma.c M src/northbridge/intel/x4x/northbridge.c M src/northbridge/intel/x4x/x4x.h 4 files changed, 12 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/23655/1 diff --git a/src/northbridge/intel/x4x/acpi.c b/src/northbridge/intel/x4x/acpi.c index 21f7aa9..678486c 100644 --- a/src/northbridge/intel/x4x/acpi.c +++ b/src/northbridge/intel/x4x/acpi.c @@ -30,7 +30,7 @@ unsigned long acpi_fill_mcfg(unsigned long current) { - device_t dev; + struct device *dev; u32 pciexbar = 0; u32 length = 0; @@ -44,7 +44,7 @@ return current; } -unsigned long northbridge_write_acpi_tables(device_t device, +unsigned long northbridge_write_acpi_tables(struct device *device, unsigned long start, struct acpi_rsdp *rsdp) { diff --git a/src/northbridge/intel/x4x/gma.c b/src/northbridge/intel/x4x/gma.c index cf3804d..8ce1a5d 100644 --- a/src/northbridge/intel/x4x/gma.c +++ b/src/northbridge/intel/x4x/gma.c @@ -430,7 +430,7 @@ pci_write_config16(dev_host, D0F0_GGC, ggc); } -static void gma_set_subsystem(device_t dev, unsigned int vendor, +static void gma_set_subsystem(struct device *dev, unsigned int vendor, unsigned int device) { if (!vendor || !device) { @@ -446,14 +446,14 @@ const struct i915_gpu_controller_info * intel_gma_get_controller_info(void) { - device_t dev = dev_find_slot(0, PCI_DEVFN(0x2, 0)); + struct device *dev = dev_find_slot(0, PCI_DEVFN(0x2, 0)); if (!dev) return NULL; struct northbridge_intel_x4x_config *chip = dev->chip_info; return &chip->gfx; } -static void gma_ssdt(device_t device) +static void gma_ssdt(struct device *device) { const struct i915_gpu_controller_info *gfx = intel_gma_get_controller_info(); if (!gfx) diff --git a/src/northbridge/intel/x4x/northbridge.c b/src/northbridge/intel/x4x/northbridge.c index 6ba45fe..e51c587 100644 --- a/src/northbridge/intel/x4x/northbridge.c +++ b/src/northbridge/intel/x4x/northbridge.c @@ -31,7 +31,7 @@ static const int legacy_hole_base_k = 0xa0000 / 1024; -static void mch_domain_read_resources(device_t dev) +static void mch_domain_read_resources(struct device *dev) { u8 index, reg8; u64 tom, touud; @@ -136,7 +136,7 @@ } } -static void mch_domain_set_resources(device_t dev) +static void mch_domain_set_resources(struct device *dev) { struct resource *res; @@ -146,7 +146,7 @@ assign_resources(dev->link_list); } -static void mch_domain_init(device_t dev) +static void mch_domain_init(struct device *dev) { u32 reg32; @@ -167,7 +167,7 @@ }; -static void cpu_bus_init(device_t dev) +static void cpu_bus_init(struct device *dev) { initialize_cpus(dev->link_list); } @@ -180,7 +180,7 @@ }; -static void enable_dev(device_t dev) +static void enable_dev(struct device *dev) { /* Set the operations if it is a special bus type */ if (dev->path.type == DEVICE_PATH_DOMAIN) diff --git a/src/northbridge/intel/x4x/x4x.h b/src/northbridge/intel/x4x/x4x.h index cbb1853..6904cb8 100644 --- a/src/northbridge/intel/x4x/x4x.h +++ b/src/northbridge/intel/x4x/x4x.h @@ -338,7 +338,8 @@ struct acpi_rsdp; #ifndef __SIMPLE_DEVICE__ -unsigned long northbridge_write_acpi_tables(device_t device, unsigned long start, struct acpi_rsdp *rsdp); +unsigned long northbridge_write_acpi_tables(struct device *device, + unsigned long start, struct acpi_rsdp *rsdp); #endif /* __SIMPLE_DEVICE__ */ #endif #endif /* __NORTHBRIDGE_INTEL_X4X_H__ */ -- To view, visit https://review.coreboot.org/23655 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib3e708a7fa9f0a78dc704a502a2f01ee0fe209ae Gerrit-Change-Number: 23655 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: nb/intel/i945: Get rid off device_t
by build bot (Jenkins) (Code Review) 08 Feb '18

08 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23654 ) Change subject: nb/intel/i945: Get rid off device_t ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67212/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21766/ : SUCCESS -- To view, visit https://review.coreboot.org/23654 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2cc938958097e416b85f6592cb8a4e645a3746ed Gerrit-Change-Number: 23654 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Feb 2018 13:58:33 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: cpu/amd: Get rid off device_t
by Elyes HAOUAS (Code Review) 08 Feb '18

08 Feb '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/23653 to look at the new patch set (#6). Change subject: cpu/amd: Get rid off device_t ...................................................................... cpu/amd: Get rid off device_t Use of `device_t` has been abandoned in ramstage Change-Id: I4b930a191130941c8349861cdd803a5be4219274 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/cpu/amd/agesa/family12/model_12_init.c M src/cpu/amd/agesa/family14/model_14_init.c M src/cpu/amd/agesa/family15tn/model_15_init.c M src/cpu/amd/agesa/family16kb/model_16_init.c M src/cpu/amd/dualcore/amd_sibling.c M src/cpu/amd/family_10h-family_15h/model_10xxx_init.c M src/cpu/amd/family_10h-family_15h/processor_name.c M src/cpu/amd/family_10h-family_15h/ram_calc.c M src/cpu/amd/geode_lx/geode_lx_init.c M src/cpu/amd/model_fxx/model_fxx_init.c M src/cpu/amd/pi/00630F01/model_15_init.c M src/cpu/amd/pi/00660F01/model_15_init.c M src/cpu/amd/pi/00730F01/model_16_init.c 13 files changed, 19 insertions(+), 18 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/23653/6 -- To view, visit https://review.coreboot.org/23653 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4b930a191130941c8349861cdd803a5be4219274 Gerrit-Change-Number: 23653 Gerrit-PatchSet: 6 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: nb/intel/i945: Get rid off device_t
by build bot (Jenkins) (Code Review) 08 Feb '18

08 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23654 ) Change subject: nb/intel/i945: Get rid off device_t ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/67211/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/21765/ : ABORTED -- To view, visit https://review.coreboot.org/23654 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2cc938958097e416b85f6592cb8a4e645a3746ed Gerrit-Change-Number: 23654 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Feb 2018 13:48:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: nb/intel/i945: Get rid off device_t
by Elyes HAOUAS (Code Review) 08 Feb '18

08 Feb '18

Elyes HAOUAS has uploaded a new patch set (#2). ( https://review.coreboot.org/23654 ) Change subject: nb/intel/i945: Get rid off device_t ...................................................................... nb/intel/i945: Get rid off device_t Use of `device_t`has been abandoned in ramstage Change-Id: I2cc938958097e416b85f6592cb8a4e645a3746ed Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/northbridge/intel/i945/acpi.c M src/northbridge/intel/i945/gma.c M src/northbridge/intel/i945/northbridge.c 3 files changed, 11 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/23654/2 -- To view, visit https://review.coreboot.org/23654 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2cc938958097e416b85f6592cb8a4e645a3746ed Gerrit-Change-Number: 23654 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: nb/intel/i945: Get rid off device_t
by Elyes HAOUAS (Code Review) 08 Feb '18

08 Feb '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/23654 Change subject: nb/intel/i945: Get rid off device_t ...................................................................... nb/intel/i945: Get rid off device_t Use of `device_t`has been abandoned in ramstage Change-Id: I2cc938958097e416b85f6592cb8a4e645a3746ed Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/northbridge/intel/i945/acpi.c M src/northbridge/intel/i945/gma.c M src/northbridge/intel/i945/northbridge.c 3 files changed, 10 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/23654/1 diff --git a/src/northbridge/intel/i945/acpi.c b/src/northbridge/intel/i945/acpi.c index c1a3d17..990d3de 100644 --- a/src/northbridge/intel/i945/acpi.c +++ b/src/northbridge/intel/i945/acpi.c @@ -29,7 +29,7 @@ unsigned long acpi_fill_mcfg(unsigned long current) { - device_t dev; + struct device *dev; u32 pciexbar = 0; u32 pciexbar_reg; int max_buses; diff --git a/src/northbridge/intel/i945/gma.c b/src/northbridge/intel/i945/gma.c index 8d60bc9..da9c1e2 100644 --- a/src/northbridge/intel/i945/gma.c +++ b/src/northbridge/intel/i945/gma.c @@ -739,7 +739,7 @@ pci_write_config8(dev, 0xf4, 0xff); } -static void gma_set_subsystem(device_t dev, unsigned int vendor, +static void gma_set_subsystem(struct device *dev, unsigned int vendor, unsigned int device) { if (!vendor || !device) { @@ -763,7 +763,7 @@ return &chip->gfx; } -static void gma_ssdt(device_t device) +static void gma_ssdt(struct device *device) { const struct i915_gpu_controller_info *gfx = intel_gma_get_controller_info(); if (!gfx) @@ -772,7 +772,7 @@ drivers_intel_gma_displays_ssdt_generate(gfx); } -static void gma_func0_read_resources(device_t dev) +static void gma_func0_read_resources(struct device *dev) { u8 reg8; diff --git a/src/northbridge/intel/i945/northbridge.c b/src/northbridge/intel/i945/northbridge.c index fdb37b1..794c61e 100644 --- a/src/northbridge/intel/i945/northbridge.c +++ b/src/northbridge/intel/i945/northbridge.c @@ -28,7 +28,7 @@ static int get_pcie_bar(u32 *base) { - device_t dev; + struct device *dev; u32 pciexbar_reg; *base = 0; @@ -57,7 +57,7 @@ return 0; } -static void pci_domain_set_resources(device_t dev) +static void pci_domain_set_resources(struct device *dev) { uint32_t pci_tolm; uint8_t tolud, reg8; @@ -149,7 +149,7 @@ .ops_pci_bus = pci_bus_default_ops, }; -static void mc_read_resources(device_t dev) +static void mc_read_resources(struct device *dev) { u32 pcie_config_base; int buses; @@ -163,7 +163,7 @@ } } -static void intel_set_subsystem(device_t dev, unsigned int vendor, +static void intel_set_subsystem(struct device *dev, unsigned int vendor, unsigned int device) { if (!vendor || !device) { @@ -199,7 +199,7 @@ .devices = pci_device_ids, }; -static void cpu_bus_init(device_t dev) +static void cpu_bus_init(struct device *dev) { initialize_cpus(dev->link_list); } @@ -212,7 +212,7 @@ .scan_bus = 0, }; -static void enable_dev(device_t dev) +static void enable_dev(struct device *dev) { /* Set the operations if it is a special bus type */ if (dev->path.type == DEVICE_PATH_DOMAIN) -- To view, visit https://review.coreboot.org/23654 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2cc938958097e416b85f6592cb8a4e645a3746ed Gerrit-Change-Number: 23654 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: cpu/intel: Get rid off device_t
by build bot (Jenkins) (Code Review) 08 Feb '18

08 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23652 ) Change subject: cpu/intel: Get rid off device_t ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67210/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21764/ : SUCCESS -- To view, visit https://review.coreboot.org/23652 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17675b004023453f137abd387cfacd308d9b98b5 Gerrit-Change-Number: 23652 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Feb 2018 13:42:49 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2018