coreboot-gerrit February 2018

coreboot-gerrit@coreboot.org

1 participants
1573 discussions

Change in coreboot[master]: soc/amd/stoneyridge: Add gpio_io_set_config function
by build bot (Jenkins) (Code Review) 08 Feb '18

08 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23624 ) Change subject: soc/amd/stoneyridge: Add gpio_io_set_config function ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67222/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21776/ : SUCCESS -- To view, visit https://review.coreboot.org/23624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1addd3abcb6a57d916b1c93480bacb0450abddf2 Gerrit-Change-Number: 23624 Gerrit-PatchSet: 4 Gerrit-Owner: Chris Ching <chingcodes(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Chris Ching (using chromium account) <chingcodes+old(a)google.com> Gerrit-Reviewer: Chris Ching <chingcodes(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Feb 2018 17:31:01 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/lenovo/w520: Add ThinkPad W520 support
by build bot (Jenkins) (Code Review) 08 Feb '18

08 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23564 ) Change subject: mb/lenovo/w520: Add ThinkPad W520 support ...................................................................... Patch Set 6: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/67221/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/21775/ : SUCCESS -- To view, visit https://review.coreboot.org/23564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1deb0436a807950c605dcd590deedcb3169bf8c5 Gerrit-Change-Number: 23564 Gerrit-PatchSet: 6 Gerrit-Owner: Nico Rikken <nico(a)nicorikken.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Rikken <nico(a)nicorikken.eu> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Feb 2018 17:27:29 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: sb/intel/i82801ix: Use the common ACPI pirq generator
by build bot (Jenkins) (Code Review) 08 Feb '18

08 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22980 ) Change subject: sb/intel/i82801ix: Use the common ACPI pirq generator ...................................................................... Patch Set 12: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67220/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21774/ : SUCCESS -- To view, visit https://review.coreboot.org/22980 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I62e520f53fa3f928a8e6f3b3cf33af2acdd53ed9 Gerrit-Change-Number: 22980 Gerrit-PatchSet: 12 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Feb 2018 17:07:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: sb/intel/i82801ix: Use common RCBA code
by build bot (Jenkins) (Code Review) 08 Feb '18

08 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23288 ) Change subject: sb/intel/i82801ix: Use common RCBA code ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67219/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21771/ : SUCCESS -- To view, visit https://review.coreboot.org/23288 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56a1dbf9c364f040ffb110121b6a28494ddb8f90 Gerrit-Change-Number: 23288 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Feb 2018 16:46:20 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: sb/intel/{bd82x6, ibexpeak}: Move RCBA macros to a common location
by build bot (Jenkins) (Code Review) 08 Feb '18

08 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23287 ) Change subject: sb/intel/{bd82x6,ibexpeak}: Move RCBA macros to a common location ...................................................................... Patch Set 6: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67218/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21773/ : SUCCESS -- To view, visit https://review.coreboot.org/23287 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33ec6801b115c0d64de1d2a0dc5d439186f3580a Gerrit-Change-Number: 23287 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Feb 2018 16:44:06 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: sb/intel/common/pirq_gen: Rework generating pin-route tables
by build bot (Jenkins) (Code Review) 08 Feb '18

08 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22979 ) Change subject: sb/intel/common/pirq_gen: Rework generating pin-route tables ...................................................................... Patch Set 13: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67217/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21772/ : SUCCESS -- To view, visit https://review.coreboot.org/22979 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic68a91d0cb55942a4d928b30f73e1c779142420d Gerrit-Change-Number: 22979 Gerrit-PatchSet: 13 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Feb 2018 16:43:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mainboard/hp: Add HP Elitebook 8770w
by Robert Reeves (Code Review) 08 Feb '18

08 Feb '18

Robert Reeves has posted comments on this change. ( https://review.coreboot.org/23651 ) Change subject: mainboard/hp: Add HP Elitebook 8770w ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/#/c/23651/1/src/mainboard/hp/8770w/cmos.layout File src/mainboard/hp/8770w/cmos.layout: https://review.coreboot.org/#/c/23651/1/src/mainboard/hp/8770w/cmos.layout@… PS1, Line 91: 6 0 Emergency : 6 1 Alert : 6 2 Critical : 6 3 Error : 6 4 Warning : 6 5 Notice : 6 6 Info : 6 7 Debug : 6 8 Spew Applied the change recommended by Arthur Heymans on the previous version of this submission. Funnily enough, I had never changed this to begin with, that was just how it was on the original file when I started this port in December. https://review.coreboot.org/#/c/23651/1/src/mainboard/hp/8770w/romstage.c File src/mainboard/hp/8770w/romstage.c: https://review.coreboot.org/#/c/23651/1/src/mainboard/hp/8770w/romstage.c@42 PS1, Line 42: { : } Got rid of the whitespace here. -- To view, visit https://review.coreboot.org/23651 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic4ff64e9cf0c7a51ac48ca2fe6fe8beab02e9f9a Gerrit-Change-Number: 23651 Gerrit-PatchSet: 1 Gerrit-Owner: Robert Reeves <xiinc37(a)gmail.com> Gerrit-Reviewer: Robert Reeves <xiinc37(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Feb 2018 14:33:47 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: cpu/x86: Get rid off device_t
by build bot (Jenkins) (Code Review) 08 Feb '18

08 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23656 ) Change subject: cpu/x86: Get rid off device_t ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67216/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21770/ : SUCCESS -- To view, visit https://review.coreboot.org/23656 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c8acebb4a957a9600de15ea844f620a8909977b Gerrit-Change-Number: 23656 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Feb 2018 14:15:59 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: cpu/amd: Get rid off device_t
by build bot (Jenkins) (Code Review) 08 Feb '18

08 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23653 ) Change subject: cpu/amd: Get rid off device_t ...................................................................... Patch Set 7: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/67215/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/21769/ : SUCCESS -- To view, visit https://review.coreboot.org/23653 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b930a191130941c8349861cdd803a5be4219274 Gerrit-Change-Number: 23653 Gerrit-PatchSet: 7 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Feb 2018 14:10:02 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: cpu/x86: Get rid off device_t
by Elyes HAOUAS (Code Review) 08 Feb '18

08 Feb '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/23656 Change subject: cpu/x86: Get rid off device_t ...................................................................... cpu/x86: Get rid off device_t Use of `device_t` has been abandoned in ramstage Change-Id: I4c8acebb4a957a9600de15ea844f620a8909977b Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/cpu/x86/lapic/lapic_cpu_init.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/23656/1 diff --git a/src/cpu/x86/lapic/lapic_cpu_init.c b/src/cpu/x86/lapic/lapic_cpu_init.c index 825739c..137b93c 100644 --- a/src/cpu/x86/lapic/lapic_cpu_init.c +++ b/src/cpu/x86/lapic/lapic_cpu_init.c @@ -464,9 +464,9 @@ } -static void smm_other_cpus(struct bus *cpu_bus, device_t bsp_cpu) +static void smm_other_cpus(struct bus *cpu_bus, struct device *bsp_cpu) { - device_t cpu; + struct device *cpu; int pre_count = atomic_read(&active_cpus); /* Loop through the cpus once to let them run through SMM relocator */ -- To view, visit https://review.coreboot.org/23656 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4c8acebb4a957a9600de15ea844f620a8909977b Gerrit-Change-Number: 23656 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2018