coreboot-gerrit February 2018

coreboot-gerrit@coreboot.org

1 participants
1573 discussions

Change in coreboot[master]: sb/intel/i82801gx: Automatically handle disabling functions
by Arthur Heymans (Code Review) 08 Feb '18

08 Feb '18

Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/23662 to look at the new patch set (#5). Change subject: sb/intel/i82801gx: Automatically handle disabling functions ...................................................................... sb/intel/i82801gx: Automatically handle disabling functions Disable functions based on the devicetree and implement pcie port coalescing to handle cases when the first PCIe port is disabled. TODO: * check if devicetrees matched removed FD writes in romstage * check if it actually works on hardware Change-Id: I2f6f270c631b97ececf1bd3c23f19b27828e6885 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/apple/macbook21/romstage.c M src/mainboard/asrock/g41c-gs/romstage.c M src/mainboard/asus/p5gc-mx/romstage.c M src/mainboard/foxconn/g41s-k/romstage.c M src/mainboard/getac/p470/romstage.c M src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c M src/mainboard/gigabyte/ga-g41m-es2l/romstage.c M src/mainboard/ibase/mb899/romstage.c M src/mainboard/intel/d510mo/romstage.c M src/mainboard/intel/d945gclf/romstage.c M src/mainboard/kontron/986lcd-m/romstage.c M src/mainboard/lenovo/t60/romstage.c M src/mainboard/lenovo/x60/romstage.c M src/mainboard/lenovo/z61t/romstage.c M src/mainboard/roda/rk886ex/romstage.c M src/southbridge/intel/i82801gx/i82801gx.c M src/southbridge/intel/i82801gx/i82801gx.h 17 files changed, 95 insertions(+), 80 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/23662/5 -- To view, visit https://review.coreboot.org/23662 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2f6f270c631b97ececf1bd3c23f19b27828e6885 Gerrit-Change-Number: 23662 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: sb/intel/i82801gx: Automatically handle disabling functions
by Nico Huber (Code Review) 08 Feb '18

08 Feb '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/23662 ) Change subject: sb/intel/i82801gx: Automatically handle disabling functions ...................................................................... Patch Set 4: (7 comments) https://review.coreboot.org/#/c/23662/4/src/mainboard/kontron/986lcd-m/devi… File src/mainboard/kontron/986lcd-m/devicetree.cb: https://review.coreboot.org/#/c/23662/4/src/mainboard/kontron/986lcd-m/devi… PS4, Line 43: register "pcie_port_coalesce" = "1" Why? it would be enabled automatically if needed. https://review.coreboot.org/#/c/23662/4/src/mainboard/kontron/986lcd-m/roms… File src/mainboard/kontron/986lcd-m/romstage.c: https://review.coreboot.org/#/c/23662/4/src/mainboard/kontron/986lcd-m/roms… PS4, Line 221: reg32 |= 1; Drop? https://review.coreboot.org/#/c/23662/4/src/southbridge/intel/i82801gx/i828… File src/southbridge/intel/i82801gx/i82801gx.c: https://review.coreboot.org/#/c/23662/4/src/southbridge/intel/i82801gx/i828… PS4, Line 43: BIOS_EMERG It's not that bad, is it? https://review.coreboot.org/#/c/23662/4/src/southbridge/intel/i82801gx/i828… PS4, Line 105: chip_info->pcie_port_coalesce = 1; Why? who else reads it? https://review.coreboot.org/#/c/23662/4/src/southbridge/intel/i82801gx/i828… PS4, Line 113: reg32 |= next_port++ << (i * 4); Shouldn't `reg32` be written to some reg or something? https://review.coreboot.org/#/c/23662/4/src/southbridge/intel/i82801gx/i828… PS4, Line 118: reg32 |= next_port++ << (i * 4); Ditto. https://review.coreboot.org/#/c/23662/4/src/southbridge/intel/i82801gx/i828… PS4, Line 120: } Looks pretty simple, don't we have to patch the devicetree like bd82x6x does? -- To view, visit https://review.coreboot.org/23662 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f6f270c631b97ececf1bd3c23f19b27828e6885 Gerrit-Change-Number: 23662 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Feb 2018 21:51:09 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: sb/intel/i82801gx: Automatically handle disabling functions
by build bot (Jenkins) (Code Review) 08 Feb '18

08 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23662 ) Change subject: sb/intel/i82801gx: Automatically handle disabling functions ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67240/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21791/ : SUCCESS -- To view, visit https://review.coreboot.org/23662 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f6f270c631b97ececf1bd3c23f19b27828e6885 Gerrit-Change-Number: 23662 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Feb 2018 21:38:01 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: sb/intel/i82801gx: Automatically handle disabling functions
by Arthur Heymans (Code Review) 08 Feb '18

08 Feb '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/23662 to look at the new patch set (#4). Change subject: sb/intel/i82801gx: Automatically handle disabling functions ...................................................................... sb/intel/i82801gx: Automatically handle disabling functions Disable functions based on the devicetree and implement pcie port coalescing to handle cases when the first PCIe port is disabled. TODO: * check if devicetrees matched removed FD writes in romstage * check if it actually works on hardware Change-Id: I2f6f270c631b97ececf1bd3c23f19b27828e6885 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/apple/macbook21/romstage.c M src/mainboard/asrock/g41c-gs/romstage.c M src/mainboard/asus/p5gc-mx/romstage.c M src/mainboard/foxconn/g41s-k/romstage.c M src/mainboard/getac/p470/romstage.c M src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c M src/mainboard/gigabyte/ga-g41m-es2l/romstage.c M src/mainboard/ibase/mb899/romstage.c M src/mainboard/intel/d510mo/romstage.c M src/mainboard/intel/d945gclf/romstage.c M src/mainboard/kontron/986lcd-m/devicetree.cb M src/mainboard/kontron/986lcd-m/romstage.c M src/mainboard/lenovo/t60/romstage.c M src/mainboard/lenovo/x60/romstage.c M src/mainboard/lenovo/z61t/romstage.c M src/mainboard/roda/rk886ex/romstage.c M src/southbridge/intel/i82801gx/chip.h M src/southbridge/intel/i82801gx/i82801gx.c M src/southbridge/intel/i82801gx/i82801gx.h 19 files changed, 100 insertions(+), 80 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/23662/4 -- To view, visit https://review.coreboot.org/23662 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2f6f270c631b97ececf1bd3c23f19b27828e6885 Gerrit-Change-Number: 23662 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: sb/intel/i82801gx: Automatically handle disabling functions
by build bot (Jenkins) (Code Review) 08 Feb '18

08 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23662 ) Change subject: sb/intel/i82801gx: Automatically handle disabling functions ...................................................................... Patch Set 3: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/67239/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/21790/ : SUCCESS -- To view, visit https://review.coreboot.org/23662 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f6f270c631b97ececf1bd3c23f19b27828e6885 Gerrit-Change-Number: 23662 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Feb 2018 21:28:14 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: sb/intel/i82801gx: Automatically handle disabling functions
by Arthur Heymans (Code Review) 08 Feb '18

08 Feb '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/23662 to look at the new patch set (#3). Change subject: sb/intel/i82801gx: Automatically handle disabling functions ...................................................................... sb/intel/i82801gx: Automatically handle disabling functions Disable functions based on the devicetree and implement pcie port coalescing to handle cases when the first PCIe port is disabled. TODO: * check if devicetrees matched removed FD writes in romstage * check if it actually works on hardware Change-Id: I2f6f270c631b97ececf1bd3c23f19b27828e6885 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/apple/macbook21/romstage.c M src/mainboard/asrock/g41c-gs/romstage.c M src/mainboard/asus/p5gc-mx/romstage.c M src/mainboard/foxconn/g41s-k/romstage.c M src/mainboard/getac/p470/romstage.c M src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c M src/mainboard/gigabyte/ga-g41m-es2l/romstage.c M src/mainboard/ibase/mb899/romstage.c M src/mainboard/intel/d510mo/romstage.c M src/mainboard/intel/d945gclf/romstage.c M src/mainboard/kontron/986lcd-m/devicetree.cb M src/mainboard/kontron/986lcd-m/romstage.c M src/mainboard/lenovo/t60/romstage.c M src/mainboard/lenovo/x60/romstage.c M src/mainboard/lenovo/z61t/romstage.c M src/mainboard/roda/rk886ex/romstage.c M src/southbridge/intel/i82801gx/chip.h M src/southbridge/intel/i82801gx/i82801gx.c M src/southbridge/intel/i82801gx/i82801gx.h 19 files changed, 99 insertions(+), 81 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/23662/3 -- To view, visit https://review.coreboot.org/23662 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2f6f270c631b97ececf1bd3c23f19b27828e6885 Gerrit-Change-Number: 23662 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: sb/intel/i82801gx: Automatically handle disabling functions
by build bot (Jenkins) (Code Review) 08 Feb '18

08 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23662 ) Change subject: sb/intel/i82801gx: Automatically handle disabling functions ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/67238/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/21789/ : SUCCESS -- To view, visit https://review.coreboot.org/23662 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f6f270c631b97ececf1bd3c23f19b27828e6885 Gerrit-Change-Number: 23662 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Feb 2018 21:20:22 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: sb/intel/i82801gx: Automatically handle disabling functions
by build bot (Jenkins) (Code Review) 08 Feb '18

08 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23662 ) Change subject: sb/intel/i82801gx: Automatically handle disabling functions ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/67237/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/21788/ : SUCCESS -- To view, visit https://review.coreboot.org/23662 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f6f270c631b97ececf1bd3c23f19b27828e6885 Gerrit-Change-Number: 23662 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Feb 2018 21:15:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: sb/intel/i82801gx: Automatically handle disabling functions
by Arthur Heymans (Code Review) 08 Feb '18

08 Feb '18

Arthur Heymans has uploaded a new patch set (#2). ( https://review.coreboot.org/23662 ) Change subject: sb/intel/i82801gx: Automatically handle disabling functions ...................................................................... sb/intel/i82801gx: Automatically handle disabling functions Disable functions based on the devicetree and implement pcie port coalescing to handle cases when the first PCIe port is disabled. TODO: * check if devicetrees matched removed FD writes in romstage * check if it actually works on hardware Change-Id: I2f6f270c631b97ececf1bd3c23f19b27828e6885 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/apple/macbook21/romstage.c M src/mainboard/asrock/g41c-gs/romstage.c M src/mainboard/asus/p5gc-mx/romstage.c M src/mainboard/foxconn/g41s-k/romstage.c M src/mainboard/getac/p470/romstage.c M src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c M src/mainboard/gigabyte/ga-g41m-es2l/romstage.c M src/mainboard/ibase/mb899/romstage.c M src/mainboard/intel/d510mo/romstage.c M src/mainboard/intel/d945gclf/romstage.c M src/mainboard/kontron/986lcd-m/devicetree.cb M src/mainboard/kontron/986lcd-m/romstage.c M src/mainboard/lenovo/t60/romstage.c M src/mainboard/lenovo/x60/romstage.c M src/mainboard/lenovo/z61t/romstage.c M src/mainboard/roda/rk886ex/romstage.c M src/southbridge/intel/i82801gx/chip.h M src/southbridge/intel/i82801gx/i82801gx.c M src/southbridge/intel/i82801gx/i82801gx.h 19 files changed, 99 insertions(+), 81 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/23662/2 -- To view, visit https://review.coreboot.org/23662 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2f6f270c631b97ececf1bd3c23f19b27828e6885 Gerrit-Change-Number: 23662 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: chromeec: Fix ACPI compile warning
by build bot (Jenkins) (Code Review) 08 Feb '18

08 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23661 ) Change subject: chromeec: Fix ACPI compile warning ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67236/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21787/ : SUCCESS -- To view, visit https://review.coreboot.org/23661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iae12c5d1aa749948ef4025c8b5e60c97e1b747a5 Gerrit-Change-Number: 23661 Gerrit-PatchSet: 1 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nicolas Boichat <drinkcat(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Feb 2018 21:12:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2018