coreboot-gerrit February 2018

coreboot-gerrit@coreboot.org

1 participants
1573 discussions

Change in coreboot[master]: mb/google/grunt: Add ADAU7002 to devicetree
by Daniel Kurtz (Code Review) 08 Feb '18

08 Feb '18

Hello Daniel Kurtz, I'd like you to do a code review. Please visit https://review.coreboot.org/23660 to review the following change. Change subject: mb/google/grunt: Add ADAU7002 to devicetree ...................................................................... mb/google/grunt: Add ADAU7002 to devicetree Add an entry to the grunt devicetree defining the ADAU7002 PDM-to-I2S converter. BUG=b:72121803 TEST=With grunt audio kernel patches, "aplay -l" shows playback devices: **** List of PLAYBACK Hardware Devices **** card 0: acpd7219m98357 [acpd7219m98357], device 0: Playback da7219-hifi-0 [] Subdevices: 1/1 Subdevice #0: subdevice #0 card 0: acpd7219m98357 [acpd7219m98357], device 2: HiFi Playback HiFi-2 [] Subdevices: 1/1 Subdevice #0: subdevice #0 Change-Id: I90b59ec64f4b841932db42b8a8970ed924283613 Signed-off-by: Daniel Kurtz <djkurtz(a)chromium.org> --- M src/mainboard/google/kahlee/Kconfig M src/mainboard/google/kahlee/variants/grunt/devicetree.cb 2 files changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/23660/1 diff --git a/src/mainboard/google/kahlee/Kconfig b/src/mainboard/google/kahlee/Kconfig index 988afc3..3dd0614 100644 --- a/src/mainboard/google/kahlee/Kconfig +++ b/src/mainboard/google/kahlee/Kconfig @@ -124,6 +124,7 @@ config GRUNT_AUDIO bool default y if !BOARD_GOOGLE_KAHLEE + select DRIVERS_GENERIC_ADAU7002 select DRIVERS_GENERIC_MAX98357A select DRIVERS_I2C_DA7219 diff --git a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb index 8601af8..55372d4 100644 --- a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb +++ b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb @@ -83,6 +83,9 @@ device pci 18.5 on end end #domain device mmio 0xfedc2000 on + chip drivers/generic/adau7002 + device generic 0.0 on end + end chip drivers/i2c/da7219 register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_14)" register "btn_cfg" = "50" -- To view, visit https://review.coreboot.org/23660 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I90b59ec64f4b841932db42b8a8970ed924283613 Gerrit-Change-Number: 23660 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)chromium.org>

1 0

Change in coreboot[master]: drivers/adau7002: Add driver for handling ADAU7002
by Daniel Kurtz (Code Review) 08 Feb '18

08 Feb '18

Hello Daniel Kurtz, I'd like you to do a code review. Please visit https://review.coreboot.org/23659 to review the following change. Change subject: drivers/adau7002: Add driver for handling ADAU7002 ...................................................................... drivers/adau7002: Add driver for handling ADAU7002 The ADAU7002 is a family of Stereo PDM-to-I2S/TDM conversion ICs from Analog Devices. On some boards they are a used to convert a PDM audio data stream from a DMIC to an I2S signal. Add a driver for populating ACPI table entries for this part. BUG=b:72121803 TEST=With grunt audio kernel patches, "aplay -l" shows playback devices: **** List of PLAYBACK Hardware Devices **** card 0: acpd7219m98357 [acpd7219m98357], device 0: Playback da7219-hifi-0 [] Subdevices: 1/1 Subdevice #0: subdevice #0 card 0: acpd7219m98357 [acpd7219m98357], device 2: HiFi Playback HiFi-2 [] Subdevices: 1/1 Subdevice #0: subdevice #0 Change-Id: I2b64c8e1cbc0a68984482a7d496f8c4498cb6cbe Signed-off-by: Daniel Kurtz <djkurtz(a)chromium.org> --- A src/drivers/generic/adau7002/Kconfig A src/drivers/generic/adau7002/Makefile.inc A src/drivers/generic/adau7002/adau7002.c A src/drivers/generic/adau7002/chip.h 4 files changed, 83 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/23659/1 diff --git a/src/drivers/generic/adau7002/Kconfig b/src/drivers/generic/adau7002/Kconfig new file mode 100644 index 0000000..b981a30 --- /dev/null +++ b/src/drivers/generic/adau7002/Kconfig @@ -0,0 +1,2 @@ +config DRIVERS_GENERIC_ADAU7002 + bool diff --git a/src/drivers/generic/adau7002/Makefile.inc b/src/drivers/generic/adau7002/Makefile.inc new file mode 100644 index 0000000..b2f7dfe --- /dev/null +++ b/src/drivers/generic/adau7002/Makefile.inc @@ -0,0 +1 @@ +ramstage-$(CONFIG_DRIVERS_GENERIC_ADAU7002) += adau7002.c diff --git a/src/drivers/generic/adau7002/adau7002.c b/src/drivers/generic/adau7002/adau7002.c new file mode 100644 index 0000000..17950f0 --- /dev/null +++ b/src/drivers/generic/adau7002/adau7002.c @@ -0,0 +1,76 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2018 Google Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <arch/acpi_device.h> +#include <arch/acpigen.h> +#include <console/console.h> +#include <device/device.h> +#include <device/path.h> +#include <stdint.h> +#include <string.h> +#include "chip.h" + +#if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES) + +#define ADAU7002_ACPI_NAME "ADAU" +#define ADAU7002_ACPI_HID "ADAU7002" + +static void adau7002_fill_ssdt(struct device *dev) +{ + struct drivers_generic_adau7002_config *config = dev->chip_info; + + if (!dev->enabled || !config) + return; + + /* Device */ + acpigen_write_scope(acpi_device_scope(dev)); + acpigen_write_device(acpi_device_name(dev)); + acpigen_write_name_string("_HID", ADAU7002_ACPI_HID); + acpigen_write_name_integer("_UID", 0); + acpigen_write_name_string("_DDN", dev->chip_ops->name); + acpigen_write_STA(ACPI_STATUS_DEVICE_ALL_ON); + + acpigen_pop_len(); /* Device */ + acpigen_pop_len(); /* Scope */ + + printk(BIOS_INFO, "%s: %s\n", acpi_device_path(dev), + dev->chip_ops->name); +} + +static const char *adau7002_acpi_name(const struct device *dev) +{ + return ADAU7002_ACPI_NAME; +} +#endif + +static struct device_operations adau7002_ops = { + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, +#if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES) + .acpi_name = &adau7002_acpi_name, + .acpi_fill_ssdt_generator = &adau7002_fill_ssdt, +#endif +}; + +static void adau7002_enable(struct device *dev) +{ + dev->ops = &adau7002_ops; +} + +struct chip_operations drivers_generic_adau7002_ops = { + CHIP_NAME("Analog Digital DMIC") + .enable_dev = &adau7002_enable +}; diff --git a/src/drivers/generic/adau7002/chip.h b/src/drivers/generic/adau7002/chip.h new file mode 100644 index 0000000..809a680 --- /dev/null +++ b/src/drivers/generic/adau7002/chip.h @@ -0,0 +1,4 @@ +#include <arch/acpi_device.h> + +struct drivers_generic_adau7002_config { +}; -- To view, visit https://review.coreboot.org/23659 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2b64c8e1cbc0a68984482a7d496f8c4498cb6cbe Gerrit-Change-Number: 23659 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)chromium.org>

1 0

Change in coreboot[master]: mb/google/kahlee: Add grunt audio codecs to devicetree
by Daniel Kurtz (Code Review) 08 Feb '18

08 Feb '18

Hello Daniel Kurtz, I'd like you to do a code review. Please visit https://review.coreboot.org/23658 to review the following change. Change subject: mb/google/kahlee: Add grunt audio codecs to devicetree ...................................................................... mb/google/kahlee: Add grunt audio codecs to devicetree Remove manually written asl entries for grunt's DA7219 and MAX98357A audio codecs, and replace them with equivalent devicetree entries. BUG=b:72121803 TEST=With grunt audio kernel patches, "aplay -l" shows playback devices: **** List of PLAYBACK Hardware Devices **** card 0: acpd7219m98357 [acpd7219m98357], device 0: Playback da7219-hifi-0 [] Subdevices: 1/1 Subdevice #0: subdevice #0 card 0: acpd7219m98357 [acpd7219m98357], device 2: HiFi Playback HiFi-2 [] Subdevices: 1/1 Subdevice #0: subdevice #0 Change-Id: Ia658c54a28a5363aabb4c50478adaca1f46d166a Signed-off-by: Daniel Kurtz <djkurtz(a)chromium.org> --- M src/mainboard/google/kahlee/Kconfig M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl M src/mainboard/google/kahlee/variants/grunt/devicetree.cb 3 files changed, 30 insertions(+), 108 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/23658/1 diff --git a/src/mainboard/google/kahlee/Kconfig b/src/mainboard/google/kahlee/Kconfig index 6e4e971..988afc3 100644 --- a/src/mainboard/google/kahlee/Kconfig +++ b/src/mainboard/google/kahlee/Kconfig @@ -121,4 +121,10 @@ depends on KAHLEE_USE_I2C_TPM default 0x50 +config GRUNT_AUDIO + bool + default y if !BOARD_GOOGLE_KAHLEE + select DRIVERS_GENERIC_MAX98357A + select DRIVERS_I2C_DA7219 + endif # BOARD_GOOGLE_BASEBOARD_KAHLEE diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl index 520c0d1..ea58f89 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl +++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl @@ -21,111 +21,3 @@ Name (_HID, "AMD7219") Name (_CID, "AMD7219") } - -/* DA7219 codec */ -Device (DLG7) -{ - Name (_HID, "DLGS7219") - Name (_UID, 1) - Name (_DDN, "Dialog Semiconductor DA7219 Audio Codec") - Name (_S0W, 0x04) - - Name(_CRS, ResourceTemplate () - { - I2cSerialBus ( - 0x001A, - ControllerInitiated, - 0x00061A80, - AddressingMode7Bit, - "\\_SB.I2CA", - 0x00, - ResourceConsumer, - , - ) - - /* Jack Detect AGPIO14 */ - GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,, - "\\_SB.GPIO") { 14 } - }) - - /* Device-Specific Data */ - Name (_DSD, Package () - { - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () - { - Package () { "dlg,micbias-lvl", 2600 }, - Package () { "dlg,mic-amp-in-sel", "diff" } - }, - - ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), - Package () - { - Package () { "da7219_aad", "DAAD" } - } - }) - - /* Device Properties for _DSD */ - Name (DAAD, Package () - { - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () - { - Package () { "dlg,btn-cfg", 50 }, - Package () { "dlg,mic-det-thr", 500 }, - Package () { "dlg,jack-ins-deb", 20 }, - Package () { "dlg,jack-det-rate", "32ms_64ms" }, - Package () { "dlg,jack-rem-deb", 1 }, - Package () { "dlg,a-d-btn-thr", 0xa }, - Package () { "dlg,d-b-btn-thr", 0x16 }, - Package () { "dlg,b-c-btn-thr", 0x21 }, - Package () { "dlg,c-mic-btn-thr", 0x3e }, - Package () { "dlg,btn-avg", 4 }, - Package () { "dlg,adc-1bit-rpt", 1 }, - Package () { "dlg,micbias-pulse-lvl", 0 }, - Package () { "dlg,micbias-pulse-time", 0 } - } - }) /* DAAD */ - - Method (_STA, 0, NotSerialized) - { - Return (0x0F) - } -} - -/* MAX98357 codec */ -Device (MAXM) -{ - Name (_HID, "MX98357A") - Name (_UID, 0) - Name (_DDN, "Maxim Integrated 98357A Amplifier") - - Name (_CRS, ResourceTemplate () - { - GpioIo (Exclusive, PullDefault, 0x0000, 0x0000, - IoRestrictionOutputOnly, - "\\_SB.GPIO", 0x00, ResourceConsumer, ,) { 119 } - }) - - Name (_DSD, Package () - { - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () - { - Package () - { - "sdmode-gpio", Package () { \MAXM, 0, 0, 0 } - }, - - Package () - { - "sdmode-delay", 5 - } - } - }) - - Method (_STA, 0, NotSerialized) - { - Return (0x0F) - } -} diff --git a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb index 7ffc0ac..8601af8 100644 --- a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb +++ b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb @@ -82,6 +82,30 @@ device pci 18.4 on end device pci 18.5 on end end #domain + device mmio 0xfedc2000 on + chip drivers/i2c/da7219 + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_14)" + register "btn_cfg" = "50" + register "mic_det_thr" = "500" + register "jack_ins_deb" = "20" + register "jack_det_rate" = ""32ms_64ms"" + register "jack_rem_deb" = "1" + register "a_d_btn_thr" = "0xa" + register "d_b_btn_thr" = "0x16" + register "b_c_btn_thr" = "0x21" + register "c_mic_btn_thr" = "0x3e" + register "btn_avg" = "4" + register "adc_1bit_rpt" = "1" + register "micbias_lvl" = "2600" + register "mic_amp_in_sel" = ""diff"" + device i2c 1a on end + end + chip drivers/generic/max98357a + register "sdmode_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_119)" + register "sdmode_delay" = "5" + device generic 0.1 on end + end + end device mmio 0xfedc3000 on chip drivers/i2c/tpm register "hid" = ""GOOG0005"" -- To view, visit https://review.coreboot.org/23658 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia658c54a28a5363aabb4c50478adaca1f46d166a Gerrit-Change-Number: 23658 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)chromium.org>

1 0

Change in coreboot[master]: drivers/i2c/da7219: Allow GPIO based interrupt
by Daniel Kurtz (Code Review) 08 Feb '18

08 Feb '18

Hello Daniel Kurtz, I'd like you to do a code review. Please visit https://review.coreboot.org/23657 to review the following change. Change subject: drivers/i2c/da7219: Allow GPIO based interrupt ...................................................................... drivers/i2c/da7219: Allow GPIO based interrupt Allow specifying the DA7219 interrupt pin as either an Interrupt or GpioInt. BUG=b:72121803 TEST=(with whole patch series) Grunt Kernel discovers DA7219 on i2c0 Change-Id: I2d26731bf4c0ad590dad2c5d26c252371f415f9a Signed-off-by: Daniel Kurtz <djkurtz(a)chromium.org> --- M src/drivers/i2c/da7219/chip.h M src/drivers/i2c/da7219/da7219.c 2 files changed, 8 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/23657/1 diff --git a/src/drivers/i2c/da7219/chip.h b/src/drivers/i2c/da7219/chip.h index 823b940..572d727 100644 --- a/src/drivers/i2c/da7219/chip.h +++ b/src/drivers/i2c/da7219/chip.h @@ -8,6 +8,9 @@ /* Interrupt configuration */ struct acpi_irq irq; + /* Use GPIO based interrupt instead of PIRQ */ + struct acpi_gpio irq_gpio; + /* I2C Bus Frequency in Hertz (default 400kHz) */ unsigned bus_speed; diff --git a/src/drivers/i2c/da7219/da7219.c b/src/drivers/i2c/da7219/da7219.c index 4eef00c..c0f152d 100644 --- a/src/drivers/i2c/da7219/da7219.c +++ b/src/drivers/i2c/da7219/da7219.c @@ -57,7 +57,11 @@ acpigen_write_name("_CRS"); acpigen_write_resourcetemplate_header(); acpi_device_write_i2c(&i2c); - acpi_device_write_interrupt(&config->irq); + /* Use either Interrupt() or GpioInt() */ + if (config->irq_gpio.pin_count) + acpi_device_write_gpio(&config->irq_gpio); + else + acpi_device_write_interrupt(&config->irq); acpigen_write_resourcetemplate_footer(); /* AAD Child Device Properties */ -- To view, visit https://review.coreboot.org/23657 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2d26731bf4c0ad590dad2c5d26c252371f415f9a Gerrit-Change-Number: 23657 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Akshu Agrawal <akshu.agrawal(a)amd.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)chromium.org>

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: set oem_id, oem_table_id fields of...
by build bot (Jenkins) (Code Review) 08 Feb '18

08 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23648 ) Change subject: mb/google/poppy/variants/nautilus: set oem_id, oem_table_id fields of acpi_header_t ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67228/ : SUCCESS -- To view, visit https://review.coreboot.org/23648 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I041f2838f07a2525be7a28fdc69b7f1af46d16f1 Gerrit-Change-Number: 23648 Gerrit-PatchSet: 5 Gerrit-Owner: Naveen Manohar <naveen.m(a)intel.com> Gerrit-Assignee: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Feb 2018 19:07:02 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: payloads: Add an option to compress secondary payloads
by build bot (Jenkins) (Code Review) 08 Feb '18

08 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23639 ) Change subject: payloads: Add an option to compress secondary payloads ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67227/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21780/ : SUCCESS -- To view, visit https://review.coreboot.org/23639 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddfd6fcf4112d255cc7b2b49b99bf5ea4d6f8db4 Gerrit-Change-Number: 23639 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Feb 2018 18:14:21 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: payloads: Add an option to compress secondary payloads
by build bot (Jenkins) (Code Review) 08 Feb '18

08 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23639 ) Change subject: payloads: Add an option to compress secondary payloads ...................................................................... Patch Set 3: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/67226/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/21779/ : SUCCESS -- To view, visit https://review.coreboot.org/23639 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddfd6fcf4112d255cc7b2b49b99bf5ea4d6f8db4 Gerrit-Change-Number: 23639 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Feb 2018 18:07:15 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/meowth: Enable ECT again
by build bot (Jenkins) (Code Review) 08 Feb '18

08 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23645 ) Change subject: mainboard/google/meowth: Enable ECT again ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67225/ : SUCCESS -- To view, visit https://review.coreboot.org/23645 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7dd0a7dfe2993ad9cfaf00050175e5a47468b471 Gerrit-Change-Number: 23645 Gerrit-PatchSet: 2 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Feb 2018 17:53:06 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mainboard/google/kahlee: Add tis_plat_irq_status
by build bot (Jenkins) (Code Review) 08 Feb '18

08 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23626 ) Change subject: mainboard/google/kahlee: Add tis_plat_irq_status ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67224/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21778/ : SUCCESS -- To view, visit https://review.coreboot.org/23626 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5786d334b6c1cc70f4c7107c75b07a7e27ac4428 Gerrit-Change-Number: 23626 Gerrit-PatchSet: 4 Gerrit-Owner: Chris Ching <chingcodes(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Chris Ching (using chromium account) <chingcodes+old(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Feb 2018 17:38:06 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Add gpio_interrupt_status
by build bot (Jenkins) (Code Review) 08 Feb '18

08 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23625 ) Change subject: soc/amd/stoneyridge: Add gpio_interrupt_status ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67223/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21777/ : SUCCESS -- To view, visit https://review.coreboot.org/23625 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ed76eaf56338a314a8d0ee6faad1ab8dbf8dfb0 Gerrit-Change-Number: 23625 Gerrit-PatchSet: 4 Gerrit-Owner: Chris Ching <chingcodes(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Chris Ching <chingcodes(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Feb 2018 17:34:28 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2018