coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in ...coreboot[master]: lib/cbfs: Remove cbfs_boot_map_optionrom from cbfs impl
by Philipp Deppenwiese (Code Review) 28 Nov '18

28 Nov '18

Philipp Deppenwiese has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/24994 ) Change subject: lib/cbfs: Remove cbfs_boot_map_optionrom from cbfs impl ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/24994 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I57a35d3ce95850d22f79a1045a30b7c6b011bb68 Gerrit-Change-Number: 24994 Gerrit-PatchSet: 11 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: lib: Add blob_provider
by Philipp Deppenwiese (Code Review) 28 Nov '18

28 Nov '18

Philipp Deppenwiese has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/24992 ) Change subject: lib: Add blob_provider ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/24992 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30abc5be5d47a4c697c0b94babb068b0f0ae4794 Gerrit-Change-Number: 24992 Gerrit-PatchSet: 15 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-CC: Youness Alaoui <snifikino(a)gmail.com> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: soc/intel: Remove legacy static TPM asl code
by Philipp Deppenwiese (Code Review) 28 Nov '18

28 Nov '18

Philipp Deppenwiese has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/27688 ) Change subject: soc/intel: Remove legacy static TPM asl code ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/27688 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36a99cbc420ecfa55aa5c89787151d482225adf2 Gerrit-Change-Number: 27688 Gerrit-PatchSet: 2 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: security/general: Add section for general security features
by Philipp Deppenwiese (Code Review) 28 Nov '18

28 Nov '18

Philipp Deppenwiese has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/25297 ) Change subject: security/general: Add section for general security features ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/25297 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7bb63e2769c7bfd65dc9e4237300b583bd09ad3 Gerrit-Change-Number: 25297 Gerrit-PatchSet: 2 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: payloads/SeaBIOS: Add NO_HARDWARE_IRQ option
by Philipp Deppenwiese (Code Review) 28 Nov '18

28 Nov '18

Philipp Deppenwiese has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/22632 ) Change subject: payloads/SeaBIOS: Add NO_HARDWARE_IRQ option ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/22632 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5a5f40c58b595075940e5d6d3d10b06caa322714 Gerrit-Change-Number: 22632 Gerrit-PatchSet: 3 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: security/crypto: Add common code and errors
by Philipp Deppenwiese (Code Review) 28 Nov '18

28 Nov '18

Philipp Deppenwiese has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/23217 ) Change subject: security/crypto: Add common code and errors ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/23217 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I38441349b46dc142993fd351878847fdd814bae6 Gerrit-Change-Number: 23217 Gerrit-PatchSet: 7 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: broadcom: Remove SoC and board support
by Philipp Deppenwiese (Code Review) 28 Nov '18

28 Nov '18

Hello Julius Werner, build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/29905 to look at the new patch set (#3). Change subject: broadcom: Remove SoC and board support ...................................................................... broadcom: Remove SoC and board support The reason for this code cleanup is the legacy Google Purin board which isn't available anymore and AFAIK never made it into the stores. * Remove broadcom cygnus SoC support * Remove /util/broadcom tool * Remove Google Purin mainboard * Remove MAINTAINERS entries Change-Id: I148dd7eb0192d396cb69bc26c4062f88a764771a Signed-off-by: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> --- M Documentation/util.md M MAINTAINERS M Makefile.inc D src/mainboard/google/purin/Kconfig D src/mainboard/google/purin/Kconfig.name D src/mainboard/google/purin/Makefile.inc D src/mainboard/google/purin/board_info.txt D src/mainboard/google/purin/boardid.c D src/mainboard/google/purin/bootblock.c D src/mainboard/google/purin/chromeos.c D src/mainboard/google/purin/chromeos.fmd D src/mainboard/google/purin/devicetree.cb D src/mainboard/google/purin/mainboard.c D src/mainboard/google/purin/memlayout.ld D src/mainboard/google/purin/reset.c D src/soc/broadcom/Kconfig D src/soc/broadcom/cygnus/Kconfig D src/soc/broadcom/cygnus/Makefile.inc D src/soc/broadcom/cygnus/bootblock.c D src/soc/broadcom/cygnus/cbmem.c D src/soc/broadcom/cygnus/ddr_init.c D src/soc/broadcom/cygnus/ddr_init_table.c D src/soc/broadcom/cygnus/gpio.c D src/soc/broadcom/cygnus/hw_init.c D src/soc/broadcom/cygnus/i2c.c D src/soc/broadcom/cygnus/include/soc/addressmap.h D src/soc/broadcom/cygnus/include/soc/config.h D src/soc/broadcom/cygnus/include/soc/cygnus.h D src/soc/broadcom/cygnus/include/soc/cygnus_types.h D src/soc/broadcom/cygnus/include/soc/ddr_bist.h D src/soc/broadcom/cygnus/include/soc/gpio.h D src/soc/broadcom/cygnus/include/soc/halapis/ddr_regs.h D src/soc/broadcom/cygnus/include/soc/hw_init.h D src/soc/broadcom/cygnus/include/soc/i2c.h D src/soc/broadcom/cygnus/include/soc/memlayout.ld D src/soc/broadcom/cygnus/include/soc/ns16550.h D src/soc/broadcom/cygnus/include/soc/reg_utils.h D src/soc/broadcom/cygnus/include/soc/sdram.h D src/soc/broadcom/cygnus/include/soc/shmoo_and28/phy_and28_e2.h D src/soc/broadcom/cygnus/include/soc/shmoo_and28/phy_reg_access.h D src/soc/broadcom/cygnus/include/soc/shmoo_and28/shmoo_and28.h D src/soc/broadcom/cygnus/include/soc/shmoo_and28/ydc_ddr_bist.h D src/soc/broadcom/cygnus/include/soc/tz.h D src/soc/broadcom/cygnus/iomux.c D src/soc/broadcom/cygnus/ns16550.c D src/soc/broadcom/cygnus/phy_reg_access.c D src/soc/broadcom/cygnus/romstage.c D src/soc/broadcom/cygnus/sdram.c D src/soc/broadcom/cygnus/shmoo_and28.c D src/soc/broadcom/cygnus/soc.c D src/soc/broadcom/cygnus/spi.c D src/soc/broadcom/cygnus/timer.c D src/soc/broadcom/cygnus/tz.c D src/soc/broadcom/cygnus/usb.c D src/soc/broadcom/cygnus/ydc_ddr_bist.c M util/README.md D util/broadcom/Makefile.inc D util/broadcom/description.md D util/broadcom/khmacsha256 D util/broadcom/secimage/Makefile D util/broadcom/secimage/Makefile.inc D util/broadcom/secimage/crypto.c D util/broadcom/secimage/io.c D util/broadcom/secimage/misc.c D util/broadcom/secimage/sbi.c D util/broadcom/secimage/secimage.h D util/broadcom/secimage/test/data/expected/binary.xxdump D util/broadcom/secimage/test/data/input/binary.xxdump D util/broadcom/secimage/test/data/input/configfile.xxdump D util/broadcom/secimage/test/data/input/hmac_binary_key.xxdump D util/broadcom/secimage/test/hmac.sh D util/broadcom/unauth.cfg M util/testing/Makefile.inc 73 files changed, 1 insertion(+), 29,729 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/29905/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/29905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I148dd7eb0192d396cb69bc26c4062f88a764771a Gerrit-Change-Number: 29905 Gerrit-PatchSet: 3 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: broadcom: Remove SoC and board support
by Philipp Deppenwiese (Code Review) 28 Nov '18

28 Nov '18

Hello Julius Werner, Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/29905 to look at the new patch set (#2). Change subject: broadcom: Remove SoC and board support ...................................................................... broadcom: Remove SoC and board support * Remove broadcom SoC support * Remove /util/broadcom tool * Remove Google Purin mainboard * Remove MAINTAINERS entries Change-Id: I148dd7eb0192d396cb69bc26c4062f88a764771a Signed-off-by: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> --- M Documentation/util.md M MAINTAINERS M Makefile.inc D src/mainboard/google/purin/Kconfig D src/mainboard/google/purin/Kconfig.name D src/mainboard/google/purin/Makefile.inc D src/mainboard/google/purin/board_info.txt D src/mainboard/google/purin/boardid.c D src/mainboard/google/purin/bootblock.c D src/mainboard/google/purin/chromeos.c D src/mainboard/google/purin/chromeos.fmd D src/mainboard/google/purin/devicetree.cb D src/mainboard/google/purin/mainboard.c D src/mainboard/google/purin/memlayout.ld D src/mainboard/google/purin/reset.c D src/soc/broadcom/Kconfig D src/soc/broadcom/cygnus/Kconfig D src/soc/broadcom/cygnus/Makefile.inc D src/soc/broadcom/cygnus/bootblock.c D src/soc/broadcom/cygnus/cbmem.c D src/soc/broadcom/cygnus/ddr_init.c D src/soc/broadcom/cygnus/ddr_init_table.c D src/soc/broadcom/cygnus/gpio.c D src/soc/broadcom/cygnus/hw_init.c D src/soc/broadcom/cygnus/i2c.c D src/soc/broadcom/cygnus/include/soc/addressmap.h D src/soc/broadcom/cygnus/include/soc/config.h D src/soc/broadcom/cygnus/include/soc/cygnus.h D src/soc/broadcom/cygnus/include/soc/cygnus_types.h D src/soc/broadcom/cygnus/include/soc/ddr_bist.h D src/soc/broadcom/cygnus/include/soc/gpio.h D src/soc/broadcom/cygnus/include/soc/halapis/ddr_regs.h D src/soc/broadcom/cygnus/include/soc/hw_init.h D src/soc/broadcom/cygnus/include/soc/i2c.h D src/soc/broadcom/cygnus/include/soc/memlayout.ld D src/soc/broadcom/cygnus/include/soc/ns16550.h D src/soc/broadcom/cygnus/include/soc/reg_utils.h D src/soc/broadcom/cygnus/include/soc/sdram.h D src/soc/broadcom/cygnus/include/soc/shmoo_and28/phy_and28_e2.h D src/soc/broadcom/cygnus/include/soc/shmoo_and28/phy_reg_access.h D src/soc/broadcom/cygnus/include/soc/shmoo_and28/shmoo_and28.h D src/soc/broadcom/cygnus/include/soc/shmoo_and28/ydc_ddr_bist.h D src/soc/broadcom/cygnus/include/soc/tz.h D src/soc/broadcom/cygnus/iomux.c D src/soc/broadcom/cygnus/ns16550.c D src/soc/broadcom/cygnus/phy_reg_access.c D src/soc/broadcom/cygnus/romstage.c D src/soc/broadcom/cygnus/sdram.c D src/soc/broadcom/cygnus/shmoo_and28.c D src/soc/broadcom/cygnus/soc.c D src/soc/broadcom/cygnus/spi.c D src/soc/broadcom/cygnus/timer.c D src/soc/broadcom/cygnus/tz.c D src/soc/broadcom/cygnus/usb.c D src/soc/broadcom/cygnus/ydc_ddr_bist.c M util/README.md D util/broadcom/Makefile.inc D util/broadcom/description.md D util/broadcom/khmacsha256 D util/broadcom/secimage/Makefile D util/broadcom/secimage/Makefile.inc D util/broadcom/secimage/crypto.c D util/broadcom/secimage/io.c D util/broadcom/secimage/misc.c D util/broadcom/secimage/sbi.c D util/broadcom/secimage/secimage.h D util/broadcom/secimage/test/data/expected/binary.xxdump D util/broadcom/secimage/test/data/input/binary.xxdump D util/broadcom/secimage/test/data/input/configfile.xxdump D util/broadcom/secimage/test/data/input/hmac_binary_key.xxdump D util/broadcom/secimage/test/hmac.sh D util/broadcom/unauth.cfg M util/testing/Makefile.inc 73 files changed, 1 insertion(+), 29,729 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/29905/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I148dd7eb0192d396cb69bc26c4062f88a764771a Gerrit-Change-Number: 29905 Gerrit-PatchSet: 2 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: broadcom: Remove SoC and board support
by Philipp Deppenwiese (Code Review) 28 Nov '18

28 Nov '18

Philipp Deppenwiese has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29905 Change subject: broadcom: Remove SoC and board support ...................................................................... broadcom: Remove SoC and board support * Remove broadcom SoC support * Remove /util/broadcom tool * Reomve Google Purin mainboard Change-Id: I148dd7eb0192d396cb69bc26c4062f88a764771a Signed-off-by: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> --- D src/mainboard/google/purin/Kconfig D src/mainboard/google/purin/Kconfig.name D src/mainboard/google/purin/Makefile.inc D src/mainboard/google/purin/board_info.txt D src/mainboard/google/purin/boardid.c D src/mainboard/google/purin/bootblock.c D src/mainboard/google/purin/chromeos.c D src/mainboard/google/purin/chromeos.fmd D src/mainboard/google/purin/devicetree.cb D src/mainboard/google/purin/mainboard.c D src/mainboard/google/purin/memlayout.ld D src/mainboard/google/purin/reset.c D src/soc/broadcom/Kconfig D src/soc/broadcom/cygnus/Kconfig D src/soc/broadcom/cygnus/Makefile.inc D src/soc/broadcom/cygnus/bootblock.c D src/soc/broadcom/cygnus/cbmem.c D src/soc/broadcom/cygnus/ddr_init.c D src/soc/broadcom/cygnus/ddr_init_table.c D src/soc/broadcom/cygnus/gpio.c D src/soc/broadcom/cygnus/hw_init.c D src/soc/broadcom/cygnus/i2c.c D src/soc/broadcom/cygnus/include/soc/addressmap.h D src/soc/broadcom/cygnus/include/soc/config.h D src/soc/broadcom/cygnus/include/soc/cygnus.h D src/soc/broadcom/cygnus/include/soc/cygnus_types.h D src/soc/broadcom/cygnus/include/soc/ddr_bist.h D src/soc/broadcom/cygnus/include/soc/gpio.h D src/soc/broadcom/cygnus/include/soc/halapis/ddr_regs.h D src/soc/broadcom/cygnus/include/soc/hw_init.h D src/soc/broadcom/cygnus/include/soc/i2c.h D src/soc/broadcom/cygnus/include/soc/memlayout.ld D src/soc/broadcom/cygnus/include/soc/ns16550.h D src/soc/broadcom/cygnus/include/soc/reg_utils.h D src/soc/broadcom/cygnus/include/soc/sdram.h D src/soc/broadcom/cygnus/include/soc/shmoo_and28/phy_and28_e2.h D src/soc/broadcom/cygnus/include/soc/shmoo_and28/phy_reg_access.h D src/soc/broadcom/cygnus/include/soc/shmoo_and28/shmoo_and28.h D src/soc/broadcom/cygnus/include/soc/shmoo_and28/ydc_ddr_bist.h D src/soc/broadcom/cygnus/include/soc/tz.h D src/soc/broadcom/cygnus/iomux.c D src/soc/broadcom/cygnus/ns16550.c D src/soc/broadcom/cygnus/phy_reg_access.c D src/soc/broadcom/cygnus/romstage.c D src/soc/broadcom/cygnus/sdram.c D src/soc/broadcom/cygnus/shmoo_and28.c D src/soc/broadcom/cygnus/soc.c D src/soc/broadcom/cygnus/spi.c D src/soc/broadcom/cygnus/timer.c D src/soc/broadcom/cygnus/tz.c D src/soc/broadcom/cygnus/usb.c D src/soc/broadcom/cygnus/ydc_ddr_bist.c D util/broadcom/Makefile.inc D util/broadcom/description.md D util/broadcom/khmacsha256 D util/broadcom/secimage/Makefile D util/broadcom/secimage/Makefile.inc D util/broadcom/secimage/crypto.c D util/broadcom/secimage/io.c D util/broadcom/secimage/misc.c D util/broadcom/secimage/sbi.c D util/broadcom/secimage/secimage.h D util/broadcom/secimage/test/data/expected/binary.xxdump D util/broadcom/secimage/test/data/input/binary.xxdump D util/broadcom/secimage/test/data/input/configfile.xxdump D util/broadcom/secimage/test/data/input/hmac_binary_key.xxdump D util/broadcom/secimage/test/hmac.sh D util/broadcom/unauth.cfg 68 files changed, 0 insertions(+), 29,723 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/29905/1 -- To view, visit https://review.coreboot.org/c/coreboot/+/29905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I148dd7eb0192d396cb69bc26c4062f88a764771a Gerrit-Change-Number: 29905 Gerrit-PatchSet: 1 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: [WIP]mb/intel/x200: Add data.vbt
by build bot (Jenkins) (Code Review) 28 Nov '18

28 Nov '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29904 ) Change subject: [WIP]mb/intel/x200: Add data.vbt ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/29904/3/src/mainboard/lenovo/x200/blc.c File src/mainboard/lenovo/x200/blc.c: https://review.coreboot.org/#/c/29904/3/src/mainboard/lenovo/x200/blc.c@68 PS3, Line 68: } else { else is not generally useful after a break or return -- To view, visit https://review.coreboot.org/c/coreboot/+/29904 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4c4a7011ce03cdd511fa2e2160c2f006ba2707ba Gerrit-Change-Number: 29904 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Wed, 28 Nov 2018 17:50:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018