coreboot-gerrit October 2018

coreboot-gerrit@coreboot.org

1 participants
1285 discussions

Change in coreboot[master]: soc/intel/cannonlake: Move the FSP related callbacks to separate files
by build bot (Jenkins) (Code Review) 02 Oct '18

02 Oct '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28661 ) Change subject: soc/intel/cannonlake: Move the FSP related callbacks to separate files ...................................................................... Patch Set 6: (2 comments) https://review.coreboot.org/#/c/28661/6/src/soc/intel/cannonlake/fsp_params… File src/soc/intel/cannonlake/fsp_params.c: https://review.coreboot.org/#/c/28661/6/src/soc/intel/cannonlake/fsp_params… PS6, Line 82: for (i = 0; i < ARRAY_SIZE(params->Usb2OverCurrentPin); i++) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/28661/6/src/soc/intel/cannonlake/fsp_params… PS6, Line 86: for (i = 0; i < ARRAY_SIZE(params->Usb3OverCurrentPin); i++) { braces {} are not necessary for single statement blocks -- To view, visit https://review.coreboot.org/28661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iffadc57f6986e688aa1bbe4e5444d105386ad92e Gerrit-Change-Number: 28661 Gerrit-PatchSet: 6 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Boon Tiong Teo <boon.tiong.teo(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 02 Oct 2018 20:12:37 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: src/nb/i945: Fix "CONFIG_DEFAULT_CONSOLE_LOGLEVEL > 8" if statement
by Elyes HAOUAS (Code Review) 02 Oct '18

02 Oct '18

Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/28878 ) Change subject: src/nb/i945: Fix "CONFIG_DEFAULT_CONSOLE_LOGLEVEL > 8" if statement ...................................................................... Patch Set 3: > Using #if is a bad habit. Also, what are the outer parentheses for? If I'm not wrong, '#if' is used in (romstage) to bypass the code if the statement is not true. -- To view, visit https://review.coreboot.org/28878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ff87c76b3aef4af93d88dd9c02a743656aacfc0 Gerrit-Change-Number: 28878 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 02 Oct 2018 19:37:14 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: src/nb/i945: Fix "CONFIG_DEFAULT_CONSOLE_LOGLEVEL > 8" if statement
by Elyes HAOUAS (Code Review) 02 Oct '18

02 Oct '18

Hello Angel Pons, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/28878 to look at the new patch set (#3). Change subject: src/nb/i945: Fix "CONFIG_DEFAULT_CONSOLE_LOGLEVEL > 8" if statement ...................................................................... src/nb/i945: Fix "CONFIG_DEFAULT_CONSOLE_LOGLEVEL > 8" if statement 8 is the highest level. Change-Id: I1ff87c76b3aef4af93d88dd9c02a743656aacfc0 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/northbridge/intel/i945/early_init.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/28878/3 -- To view, visit https://review.coreboot.org/28878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1ff87c76b3aef4af93d88dd9c02a743656aacfc0 Gerrit-Change-Number: 28878 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: src/lib/edid.c: Replace #if 1 with something useful
by Nico Huber (Code Review) 02 Oct '18

02 Oct '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28872 ) Change subject: src/lib/edid.c: Replace #if 1 with something useful ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/28872 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93dcab3db958480626fea6d99ab5289ebff04e8f Gerrit-Change-Number: 28872 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 02 Oct 2018 19:24:10 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src/nb/i945: Fix "CONFIG_DEFAULT_CONSOLE_LOGLEVEL > 8" if statement
by Nico Huber (Code Review) 02 Oct '18

02 Oct '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28878 ) Change subject: src/nb/i945: Fix "CONFIG_DEFAULT_CONSOLE_LOGLEVEL > 8" if statement ...................................................................... Patch Set 2: Using #if is a bad habit. Also, what are the outer parentheses for? -- To view, visit https://review.coreboot.org/28878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ff87c76b3aef4af93d88dd9c02a743656aacfc0 Gerrit-Change-Number: 28878 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 02 Oct 2018 18:57:31 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: src/mb: Remove dead code
by Elyes HAOUAS (Code Review) 02 Oct '18

02 Oct '18

Hello Angel Pons, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/28876 to look at the new patch set (#4). Change subject: src/mb: Remove dead code ...................................................................... src/mb: Remove dead code 8 is highest level, so "CONFIG_DEFAULT_CONSOLE_LOGLEVEL > 8" will never happen Change-Id: I318de3e7c807bb5b5efdf61fef387d34225a8149 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/apple/macbook21/romstage.c M src/mainboard/asus/p5gc-mx/romstage.c M src/mainboard/getac/p470/romstage.c M src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c M src/mainboard/ibase/mb899/romstage.c M src/mainboard/intel/d945gclf/romstage.c M src/mainboard/kontron/986lcd-m/romstage.c M src/mainboard/lenovo/t60/romstage.c M src/mainboard/lenovo/x60/romstage.c M src/mainboard/lenovo/z61t/romstage.c M src/mainboard/roda/rk886ex/romstage.c 11 files changed, 0 insertions(+), 44 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/28876/4 -- To view, visit https://review.coreboot.org/28876 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I318de3e7c807bb5b5efdf61fef387d34225a8149 Gerrit-Change-Number: 28876 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: src/mb: Fix "CONFIG_DEFAULT_CONSOLE_LOGLEVEL > 8" if statement
by Elyes HAOUAS (Code Review) 02 Oct '18

02 Oct '18

Hello Angel Pons, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/28876 to look at the new patch set (#3). Change subject: src/mb: Fix "CONFIG_DEFAULT_CONSOLE_LOGLEVEL > 8" if statement ...................................................................... src/mb: Fix "CONFIG_DEFAULT_CONSOLE_LOGLEVEL > 8" if statement 8 is highest level, so "CONFIG_DEFAULT_CONSOLE_LOGLEVEL > 8" will never happen Change-Id: I318de3e7c807bb5b5efdf61fef387d34225a8149 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/apple/macbook21/romstage.c M src/mainboard/asus/p5gc-mx/romstage.c M src/mainboard/getac/p470/romstage.c M src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c M src/mainboard/ibase/mb899/romstage.c M src/mainboard/intel/d945gclf/romstage.c M src/mainboard/kontron/986lcd-m/romstage.c M src/mainboard/lenovo/t60/romstage.c M src/mainboard/lenovo/x60/romstage.c M src/mainboard/lenovo/z61t/romstage.c M src/mainboard/roda/rk886ex/romstage.c 11 files changed, 11 insertions(+), 22 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/28876/3 -- To view, visit https://review.coreboot.org/28876 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I318de3e7c807bb5b5efdf61fef387d34225a8149 Gerrit-Change-Number: 28876 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: src/nb/i945: Fix "CONFIG_DEFAULT_CONSOLE_LOGLEVEL > 8" if statement
by Angel Pons (Code Review) 02 Oct '18

02 Oct '18

Angel Pons has posted comments on this change. ( https://review.coreboot.org/28878 ) Change subject: src/nb/i945: Fix "CONFIG_DEFAULT_CONSOLE_LOGLEVEL > 8" if statement ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/28878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ff87c76b3aef4af93d88dd9c02a743656aacfc0 Gerrit-Change-Number: 28878 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 02 Oct 2018 17:55:45 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src/lib/edid.c: Replace #if 1 with something useful
by Angel Pons (Code Review) 02 Oct '18

02 Oct '18

Angel Pons has posted comments on this change. ( https://review.coreboot.org/28872 ) Change subject: src/lib/edid.c: Replace #if 1 with something useful ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/28872/1/src/lib/edid.c File src/lib/edid.c: https://review.coreboot.org/#/c/28872/1/src/lib/edid.c@207 PS1, Line 207: > `> 8` means BIOS_NEVER. Probably not the intention, writing […] Whoops, I guess copying code isn't always a good idea... Fixed. -- To view, visit https://review.coreboot.org/28872 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93dcab3db958480626fea6d99ab5289ebff04e8f Gerrit-Change-Number: 28872 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 02 Oct 2018 17:53:08 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: src/lib/edid.c: Replace #if 1 with something useful
by Angel Pons (Code Review) 02 Oct '18

02 Oct '18

Hello Jonathan Neuschäfer, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/28872 to look at the new patch set (#2). Change subject: src/lib/edid.c: Replace #if 1 with something useful ...................................................................... src/lib/edid.c: Replace #if 1 with something useful Since `#if 1` is rather useless, and the code inside it is just several `printk(BIOS_SPEW)`, using `IS_ENABLED(CONFIG_DEFAULT_CONSOLE_LOGLEVEL_8)` instead seems more reasonable. Change-Id: I93dcab3db958480626fea6d99ab5289ebff04e8f Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/lib/edid.c 1 file changed, 7 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/28872/2 -- To view, visit https://review.coreboot.org/28872 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I93dcab3db958480626fea6d99ab5289ebff04e8f Gerrit-Change-Number: 28872 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2018