coreboot-gerrit October 2018

coreboot-gerrit@coreboot.org

1 participants
1285 discussions

Change in coreboot[master]: src/mb: Remove dead code
by Elyes HAOUAS (Code Review) 04 Oct '18

04 Oct '18

Hello Angel Pons, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/28876 to look at the new patch set (#5). Change subject: src/mb: Remove dead code ...................................................................... src/mb: Remove dead code 8 is highest level, so "CONFIG_DEFAULT_CONSOLE_LOGLEVEL > 8" will never happen Change-Id: I318de3e7c807bb5b5efdf61fef387d34225a8149 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/apple/macbook21/romstage.c M src/mainboard/asus/p5gc-mx/romstage.c M src/mainboard/getac/p470/romstage.c M src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c M src/mainboard/ibase/mb899/romstage.c M src/mainboard/intel/d945gclf/romstage.c M src/mainboard/kontron/986lcd-m/romstage.c M src/mainboard/lenovo/t60/romstage.c M src/mainboard/lenovo/x60/romstage.c M src/mainboard/lenovo/z61t/romstage.c M src/mainboard/roda/rk886ex/romstage.c M src/northbridge/intel/i945/debug.c M src/northbridge/intel/i945/i945.h 13 files changed, 0 insertions(+), 69 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/28876/5 -- To view, visit https://review.coreboot.org/28876 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I318de3e7c807bb5b5efdf61fef387d34225a8149 Gerrit-Change-Number: 28876 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: src/mb: Remove dead code
by Elyes HAOUAS (Code Review) 04 Oct '18

04 Oct '18

Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/28876 ) Change subject: src/mb: Remove dead code ...................................................................... Patch Set 2: > Ah, looks like my doubts were misplaced. It should have compiled. > The > errors in PS#3 were introduced by the patch... > > I wouldn't object if we drop the code but if, we should also drop > the > then obsolete implementation. I would ack it, if you think it's the > right thing. But I can't ack it if you are just following my > examples > what could be done. I think that we can drop it ... -- To view, visit https://review.coreboot.org/28876 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I318de3e7c807bb5b5efdf61fef387d34225a8149 Gerrit-Change-Number: 28876 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 04 Oct 2018 08:15:52 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: src/nb/i945: Fix "CONFIG_DEFAULT_CONSOLE_LOGLEVEL > 8" if statement
by Elyes HAOUAS (Code Review) 04 Oct '18

04 Oct '18

Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/28878 ) Change subject: src/nb/i945: Fix "CONFIG_DEFAULT_CONSOLE_LOGLEVEL > 8" if statement ...................................................................... Patch Set 3: > >> Using #if is a bad habit. Also, what are the outer parentheses > for? > > > > If I'm not wrong, '#if' is used in (romstage) to bypass the code > if > > the statement is not true. > > You can use it like that. But that's not specific to any stage. And > it's a bad choice because the guarded code won't be compile tested. > > There is no other way to do this in romcc bootblock code, maybe > that is what you had in mind? I mean this code is for debugging purpose only and probably we don't need it in side the ROM. I'm wondering if it will compile and if 'sdram_dump_mchbar_registers' makes sense before RAM init. -- To view, visit https://review.coreboot.org/28878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ff87c76b3aef4af93d88dd9c02a743656aacfc0 Gerrit-Change-Number: 28878 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 04 Oct 2018 08:09:21 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/kahlee: Set 100MHz fast spi read for supported boards
by Kevin Chiu (Code Review) 04 Oct '18

04 Oct '18

Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/28906 ) Change subject: mb/google/kahlee: Set 100MHz fast spi read for supported boards ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28906 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ad95c858376ad0e6c9e787055d3fa72b5682191 Gerrit-Change-Number: 28906 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 04 Oct 2018 05:19:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/kahlee: Set 100MHz fast spi read for supported boards
by Daniel Kurtz (Code Review) 03 Oct '18

03 Oct '18

Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/28906 ) Change subject: mb/google/kahlee: Set 100MHz fast spi read for supported boards ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/#/c/28906/1/src/mainboard/google/kahlee/bootblo… File src/mainboard/google/kahlee/bootblock/bootblock.c: https://review.coreboot.org/#/c/28906/1/src/mainboard/google/kahlee/bootblo… PS1, Line 36: on on one too many 'on' https://review.coreboot.org/#/c/28906/1/src/mainboard/google/kahlee/bootblo… PS1, Line 37: set_100mhz_fast_read perhaps "supports_100mhz_fast_spi_read()" ? To me set_ implies a function that will change something. -- To view, visit https://review.coreboot.org/28906 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ad95c858376ad0e6c9e787055d3fa72b5682191 Gerrit-Change-Number: 28906 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 03 Oct 2018 19:57:22 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: libpayload/x86/exception: Add ability to ignore unknown interrupts
by Martin Roth (Code Review) 03 Oct '18

03 Oct '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/28882 ) Change subject: libpayload/x86/exception: Add ability to ignore unknown interrupts ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28882 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4ed566ec284d69786c369f37e4e331d7f892c74 Gerrit-Change-Number: 28882 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 03 Oct 2018 19:17:48 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: libpayload/x86/exception.c: Remove exception_install_hook
by Martin Roth (Code Review) 03 Oct '18

03 Oct '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/28881 ) Change subject: libpayload/x86/exception.c: Remove exception_install_hook ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28881 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I25ad3903989a5433ce73d657cfdb93dd1f34f7b5 Gerrit-Change-Number: 28881 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 03 Oct 2018 19:15:14 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: libpayload/apic: Register a spurious interrupt vector
by Martin Roth (Code Review) 03 Oct '18

03 Oct '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/28880 ) Change subject: libpayload/apic: Register a spurious interrupt vector ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28880 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e49e617f4375eb5eb00d0715c1902f77e2bf284 Gerrit-Change-Number: 28880 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 03 Oct 2018 19:14:56 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: libpayload/apic: Only ACK interrupts triggered by the APIC
by Martin Roth (Code Review) 03 Oct '18

03 Oct '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/28879 ) Change subject: libpayload/apic: Only ACK interrupts triggered by the APIC ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28879 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00bd1e7a0fcf2fc004feadc40d22ebfefe68b384 Gerrit-Change-Number: 28879 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 03 Oct 2018 19:13:46 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Allow mainboard to update I2C at runtime
by build bot (Jenkins) (Code Review) 03 Oct '18

03 Oct '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28904 ) Change subject: soc/amd/stoneyridge: Allow mainboard to update I2C at runtime ...................................................................... Patch Set 3: (3 comments) https://review.coreboot.org/#/c/28904/3/src/soc/amd/stoneyridge/i2c.c File src/soc/amd/stoneyridge/i2c.c: https://review.coreboot.org/#/c/28904/3/src/soc/amd/stoneyridge/i2c.c@59 PS3, Line 59: void __weak mb_update_i2c(unsigned int bus, open brace '{' following function definitions go on the next line https://review.coreboot.org/#/c/28904/3/src/soc/amd/stoneyridge/i2c.c@60 PS3, Line 60: const struct dw_i2c_bus_config **i2c_vals) {} code indent should use tabs where possible https://review.coreboot.org/#/c/28904/3/src/soc/amd/stoneyridge/i2c.c@60 PS3, Line 60: const struct dw_i2c_bus_config **i2c_vals) {} please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/28904 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id00c352a04b3d7845027882bcfcee09518787067 Gerrit-Change-Number: 28904 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Comment-Date: Wed, 03 Oct 2018 19:11:12 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2018