coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: arch/riscv: Document mprv_{read, write}_* functions
by build bot (Jenkins) (Code Review) 18 Sep '17

18 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21342 ) Change subject: arch/riscv: Document mprv_{read,write}_* functions ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60686/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15888/ : SUCCESS -- To view, visit https://review.coreboot.org/21342 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaf0cb241f0eb4de241f0983c0b32dbcc28f96480 Gerrit-Change-Number: 21342 Gerrit-PatchSet: 3 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Anonymous Coward #1001664 Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 18 Sep 2017 19:51:07 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/purism/librem13v2: Remove redundant MAINBOARD_VENDOR setting
by Matt DeVillier (Code Review) 18 Sep '17

18 Sep '17

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/21591 ) Change subject: mb/purism/librem13v2: Remove redundant MAINBOARD_VENDOR setting ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/21591 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0b33df01ff3327272d089b7efb8e64fa1233fdf Gerrit-Change-Number: 21591 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Comment-Date: Mon, 18 Sep 2017 19:50:13 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Use EBDA area to store cbmem_top address
by build bot (Jenkins) (Code Review) 18 Sep '17

18 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21424 ) Change subject: soc/intel/skylake: Use EBDA area to store cbmem_top address ...................................................................... Patch Set 9: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60681/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15883/ : SUCCESS -- To view, visit https://review.coreboot.org/21424 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1a674efa5ab3a4fc076fc93236edd911d28b398 Gerrit-Change-Number: 21424 Gerrit-PatchSet: 9 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Mon, 18 Sep 2017 19:35:07 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Calculate soc reserved memory size
by build bot (Jenkins) (Code Review) 18 Sep '17

18 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21540 ) Change subject: soc/intel/skylake: Calculate soc reserved memory size ...................................................................... Patch Set 7: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60683/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15884/ : SUCCESS -- To view, visit https://review.coreboot.org/21540 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19583f7d18ca11c3a58eb61c927e5c3c3b65d2ec Gerrit-Change-Number: 21540 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 18 Sep 2017 19:33:17 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common: Add function to get soc reserved memory size
by build bot (Jenkins) (Code Review) 18 Sep '17

18 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21539 ) Change subject: soc/intel/common: Add function to get soc reserved memory size ...................................................................... Patch Set 7: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60682/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15885/ : SUCCESS -- To view, visit https://review.coreboot.org/21539 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I587a9c1ea44f2dbf67099fef03d0ff92bc44f242 Gerrit-Change-Number: 21539 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 18 Sep 2017 19:30:17 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/purism/librem13v2: Remove redundant MAINBOARD_VENDOR setting
by Jonathan Neuschäfer (Code Review) 18 Sep '17

18 Sep '17

Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/21591 Change subject: mb/purism/librem13v2: Remove redundant MAINBOARD_VENDOR setting ...................................................................... mb/purism/librem13v2: Remove redundant MAINBOARD_VENDOR setting Unlike Chromebooks, Purism laptops are only sold under one vendor name, so MAINBOARD_VENDOR only needs to be set in src/mainboard/purism/Kconfig. Change-Id: If0b33df01ff3327272d089b7efb8e64fa1233fdf Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- M src/mainboard/purism/librem13v2/Kconfig 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/21591/1 diff --git a/src/mainboard/purism/librem13v2/Kconfig b/src/mainboard/purism/librem13v2/Kconfig index 4138865..bdb294d 100644 --- a/src/mainboard/purism/librem13v2/Kconfig +++ b/src/mainboard/purism/librem13v2/Kconfig @@ -14,10 +14,6 @@ int default 18 -config MAINBOARD_VENDOR - string - default "Purism" - config MAINBOARD_FAMILY string default "Librem 13" -- To view, visit https://review.coreboot.org/21591 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If0b33df01ff3327272d089b7efb8e64fa1233fdf Gerrit-Change-Number: 21591 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>

1 0

Change in coreboot[master]: Use stopwatch_wait_until_expired where applicable
by Jonathan Neuschäfer (Code Review) 18 Sep '17

18 Sep '17

Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/21590 Change subject: Use stopwatch_wait_until_expired where applicable ...................................................................... Use stopwatch_wait_until_expired where applicable Change-Id: I4d6c6810b91294a7e401a4a1a446218c04c98e55 Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- M src/drivers/i2c/rx6110sa/rx6110sa.c M src/ec/google/chromeec/ec_spi.c M src/lib/timer.c M src/mainboard/google/oak/romstage.c M src/mainboard/siemens/mc_apl1/mainboard.c 5 files changed, 7 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/21590/1 diff --git a/src/drivers/i2c/rx6110sa/rx6110sa.c b/src/drivers/i2c/rx6110sa/rx6110sa.c index aad1097..69ea9fe 100644 --- a/src/drivers/i2c/rx6110sa/rx6110sa.c +++ b/src/drivers/i2c/rx6110sa/rx6110sa.c @@ -149,8 +149,7 @@ * Take the needed delay after a reset sequence into account before the * VLF-bit can be cleared. */ - while (!stopwatch_expired(&sw)) - ; + stopwatch_wait_until_expired(&sw); flags &= ~VLF_BIT; rx6110sa_write(dev, FLAG_REGISTER, flags); diff --git a/src/ec/google/chromeec/ec_spi.c b/src/ec/google/chromeec/ec_spi.c index 810979e..3611814 100644 --- a/src/ec/google/chromeec/ec_spi.c +++ b/src/ec/google/chromeec/ec_spi.c @@ -51,8 +51,9 @@ struct spi_slave *slave = (struct spi_slave *)context; int ret = 0; - while (!stopwatch_expired(&cs_cooldown_sw)) - /* Wait minimum delay between CS assertions. */; + /* Wait minimum delay between CS assertions. */ + stopwatch_wait_until_expired(&cs_cooldown_sw); + spi_claim_bus(slave); /* Allow EC to ramp up clock after being awaken. diff --git a/src/lib/timer.c b/src/lib/timer.c index 58d32ee..adc0d07 100644 --- a/src/lib/timer.c +++ b/src/lib/timer.c @@ -34,7 +34,5 @@ return; stopwatch_init_usecs_expire(&sw, usec); - - while (!stopwatch_expired(&sw)) - ; + stopwatch_wait_until_expired(&sw); } diff --git a/src/mainboard/google/oak/romstage.c b/src/mainboard/google/oak/romstage.c index a92e4fb..1f56547 100644 --- a/src/mainboard/google/oak/romstage.c +++ b/src/mainboard/google/oak/romstage.c @@ -55,8 +55,7 @@ /* init memory */ mt_mem_init(get_sdram_config()); - while (!stopwatch_expired(&sw)) - ; + stopwatch_wait_until_expired(&sw); /* Set to maximum frequency */ if (board_id() + CONFIG_BOARD_ID_ADJUSTMENT < 5) diff --git a/src/mainboard/siemens/mc_apl1/mainboard.c b/src/mainboard/siemens/mc_apl1/mainboard.c index fb849f9..f77ef75 100644 --- a/src/mainboard/siemens/mc_apl1/mainboard.c +++ b/src/mainboard/siemens/mc_apl1/mainboard.c @@ -165,8 +165,7 @@ stopwatch_init_msecs_expire(&sw, (legacy_delay - us_since_boot) / 1000); printk(BIOS_NOTICE, "Wait remaining %d of %d us for legacy devices...", legacy_delay - us_since_boot, legacy_delay); - while (!stopwatch_expired(&sw)) - ; + stopwatch_wait_until_expired(&sw); printk(BIOS_NOTICE, "done!\n"); } -- To view, visit https://review.coreboot.org/21590 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4d6c6810b91294a7e401a4a1a446218c04c98e55 Gerrit-Change-Number: 21590 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>

1 0

Change in coreboot[master]: timer: Add helper function stopwatch_wait_until_expired
by Jonathan Neuschäfer (Code Review) 18 Sep '17

18 Sep '17

Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/21589 Change subject: timer: Add helper function stopwatch_wait_until_expired ...................................................................... timer: Add helper function stopwatch_wait_until_expired Change-Id: Ia888907028d687e3d17e5a088657086a3c839ad3 Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- M src/include/timer.h 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/21589/1 diff --git a/src/include/timer.h b/src/include/timer.h index 6b7baaf..7264250 100644 --- a/src/include/timer.h +++ b/src/include/timer.h @@ -166,6 +166,15 @@ } /* + * Tick and check the stopwatch as long as it has not expired. + */ +static inline void stopwatch_wait_until_expired(struct stopwatch *sw) +{ + while (stopwatch_expired(sw)) + ; +} + +/* * Return number of microseconds since starting the stopwatch. */ static inline long stopwatch_duration_usecs(struct stopwatch *sw) -- To view, visit https://review.coreboot.org/21589 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia888907028d687e3d17e5a088657086a3c839ad3 Gerrit-Change-Number: 21589 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>

1 0

Change in coreboot[master]: soc/intel/common: Add intel common EBDA support
by build bot (Jenkins) (Code Review) 18 Sep '17

18 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21538 ) Change subject: soc/intel/common: Add intel common EBDA support ...................................................................... Patch Set 6: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60680/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15882/ : SUCCESS -- To view, visit https://review.coreboot.org/21538 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8355a1dd528b111f1391e6d28a9b174edddc9ca0 Gerrit-Change-Number: 21538 Gerrit-PatchSet: 6 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 18 Sep 2017 19:24:25 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: arch/x86: Add ebda read/write functions into EBDA library
by build bot (Jenkins) (Code Review) 18 Sep '17

18 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21536 ) Change subject: arch/x86: Add ebda read/write functions into EBDA library ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60678/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15880/ : SUCCESS -- To view, visit https://review.coreboot.org/21536 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26d5c0ba82c842f0b734a8e0f03abf148737c5c4 Gerrit-Change-Number: 21536 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Mon, 18 Sep 2017 19:16:29 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017