coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: util/cbfstool: Add "expand" command to make CBFS span an fmap region
by build bot (Jenkins) (Code Review) 19 Sep '17

19 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21598 ) Change subject: util/cbfstool: Add "expand" command to make CBFS span an fmap region ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60706/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15908/ : SUCCESS -- To view, visit https://review.coreboot.org/21598 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I160c8529ce4bfcc28685166b6d9035ade4f6f1d1 Gerrit-Change-Number: 21598 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Sep 2017 13:14:06 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/cbfstool: Add "expand" command to make CBFS span an fmap region
by Patrick Georgi (Code Review) 19 Sep '17

19 Sep '17

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/21598 Change subject: util/cbfstool: Add "expand" command to make CBFS span an fmap region ...................................................................... util/cbfstool: Add "expand" command to make CBFS span an fmap region vboot images come with multiple regions carrying CBFS file systems. To expedite hashing (from slow flash memory), the FW_MAIN_* regions are truncated since they typically have pretty large unused space at the end that is of no interest. For test purposes it can be useful to re-engage that space, so add a command that creates a new empty file entry covering that area (except for the last 4 bytes for the master header pointer, as usual). BUG=b:65853903 BRANCH=none TEST=`cbfstool test.bin expand -r FW_MAIN_A` creates a new empty file of the expected size on a Chrome OS firmware image. Change-Id: I160c8529ce4bfcc28685166b6d9035ade4f6f1d1 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M util/cbfstool/cbfs_image.c M util/cbfstool/cbfs_image.h M util/cbfstool/cbfstool.c 3 files changed, 61 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/21598/1 diff --git a/util/cbfstool/cbfs_image.c b/util/cbfstool/cbfs_image.c index 1f4b49a..e3bc624 100644 --- a/util/cbfstool/cbfs_image.c +++ b/util/cbfstool/cbfs_image.c @@ -442,6 +442,41 @@ return 0; } +int cbfs_expand_to_region(struct buffer *region) +{ + struct cbfs_image image; + memset(&image, 0, sizeof(image)); + if (cbfs_image_from_buffer(&image, region, 0)) { + ERROR("reading CBFS failed!\n"); + return 1; + } + + uint32_t region_sz = buffer_size(region); + + struct cbfs_file *entry; + for (entry = buffer_get(region); + entry && cbfs_is_valid_entry(&image, entry); + entry = cbfs_find_next_entry(&image, entry)) { + /* just iterate through */ + } + + /* entry now points to the first aligned address after the last valid + * file header. That's either outside the image or exactly the place + * where we need to create a new file. + */ + int last_entry_size = region_sz - ((void *)entry - buffer_get(region)) + - cbfs_calculate_file_header_size("") - sizeof(int32_t); + + if (last_entry_size > 0) { + cbfs_create_empty_entry(entry, CBFS_COMPONENT_NULL, + last_entry_size, ""); + /* If the last entry was an empty file, merge them. */ + cbfs_walk(&image, cbfs_merge_empty_entry, NULL); + } + + return 0; +} + static size_t cbfs_file_entry_metadata_size(const struct cbfs_file *f) { return ntohl(f->offset); diff --git a/util/cbfstool/cbfs_image.h b/util/cbfstool/cbfs_image.h index 0d7877a..1bd74ce 100644 --- a/util/cbfstool/cbfs_image.h +++ b/util/cbfstool/cbfs_image.h @@ -80,6 +80,10 @@ * beginning of the image. Returns 0 on success, otherwise non-zero. */ int cbfs_compact_instance(struct cbfs_image *image); +/* Expand a CBFS image inside an fmap region to the entire region's space. + Returns 0 on success, otherwise non-zero. */ +int cbfs_expand_to_region(struct buffer *region); + /* Releases the CBFS image. Returns 0 on success, otherwise non-zero. */ int cbfs_image_delete(struct cbfs_image *image); diff --git a/util/cbfstool/cbfstool.c b/util/cbfstool/cbfstool.c index cc31751..9925358 100644 --- a/util/cbfstool/cbfstool.c +++ b/util/cbfstool/cbfstool.c @@ -1107,6 +1107,25 @@ return cbfs_compact_instance(&image); } +static int cbfs_expand(void) +{ + struct buffer src_buf; + + if (!param.region_name) { + ERROR("You need to specify -r/--fmap-regions.\n"); + return 1; + } + + /* Obtain the source region. */ + if (!partitioned_file_read_region(&src_buf, param.image_file, + param.region_name)) { + ERROR("Region not found in image: %s\n", param.source_region); + return 1; + } + + return cbfs_expand_to_region(param.image_region); +} + static const struct command commands[] = { {"add", "H:r:f:n:t:c:b:a:yvA:gh?", cbfs_add, true, true}, {"add-flat-binary", "H:r:f:n:l:e:c:b:vA:gh?", cbfs_add_flat_binary, @@ -1127,6 +1146,7 @@ {"remove", "H:r:n:vh?", cbfs_remove, true, true}, {"update-fit", "H:r:n:x:vh?", cbfs_update_fit, true, true}, {"write", "r:f:i:Fudvh?", cbfs_write, true, true}, + {"expand", "r:h?", cbfs_expand, true, true}, }; static struct option long_options[] = { @@ -1276,6 +1296,8 @@ "Write file into same-size [or larger] raw region\n" " read [-r fmap-region] -f file " "Extract raw region contents into binary file\n" + " expand [-r fmap-region] " + "Expand CBFS to span entire region\n" " update-fit [-r image,regions] -n MICROCODE_BLOB_NAME \\\n" " -x EMTPY_FIT_ENTRIES " "Updates the FIT table with microcode entries\n" -- To view, visit https://review.coreboot.org/21598 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I160c8529ce4bfcc28685166b6d9035ade4f6f1d1 Gerrit-Change-Number: 21598 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: ifdtool: port the feature to set AltMeDisable/HAP bit here
by build bot (Jenkins) (Code Review) 19 Sep '17

19 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21437 ) Change subject: ifdtool: port the feature to set AltMeDisable/HAP bit here ...................................................................... Patch Set 27: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60705/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15907/ : SUCCESS -- To view, visit https://review.coreboot.org/21437 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a2ecc60cfbb9ee9d96f15be3d53226cb428729a Gerrit-Change-Number: 21437 Gerrit-PatchSet: 27 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Sep 2017 03:44:30 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: refactor region-permission-related feature
by build bot (Jenkins) (Code Review) 19 Sep '17

19 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21416 ) Change subject: ifdtool: refactor region-permission-related feature ...................................................................... Patch Set 33: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60704/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15906/ : SUCCESS -- To view, visit https://review.coreboot.org/21416 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d34606545db4d970ce3ec202da4bf4c5cbad18c Gerrit-Change-Number: 21416 Gerrit-PatchSet: 33 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Shawn Chang <citypw(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Sep 2017 03:39:25 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: refactor region_name(s) and new_layout
by build bot (Jenkins) (Code Review) 19 Sep '17

19 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21315 ) Change subject: ifdtool: refactor region_name(s) and new_layout ...................................................................... Patch Set 41: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60703/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15905/ : SUCCESS -- To view, visit https://review.coreboot.org/21315 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2b92c3f835f9849a243a48c37588c2dbe7449bf Gerrit-Change-Number: 21315 Gerrit-PatchSet: 41 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Sep 2017 03:36:30 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/i945/raminit: Use common ddr2 decode functions
by build bot (Jenkins) (Code Review) 19 Sep '17

19 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18305 ) Change subject: nb/i945/raminit: Use common ddr2 decode functions ...................................................................... Patch Set 59: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60702/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15904/ : SUCCESS -- To view, visit https://review.coreboot.org/18305 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97c93939d11807752797785dd88c70b43a236ee3 Gerrit-Change-Number: 18305 Gerrit-PatchSet: 59 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: coreboot org <coreboot.org(a)gmail.com> Gerrit-Comment-Date: Tue, 19 Sep 2017 03:34:38 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/lenovo/x2?0/devicetree: Fix regression of BDC detection
by Arthur Heymans (Code Review) 19 Sep '17

19 Sep '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/21587 ) Change subject: mb/lenovo/x2?0/devicetree: Fix regression of BDC detection ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/21587/1/src/mainboard/lenovo/x220/devicetre… File src/mainboard/lenovo/x220/devicetree.cb: https://review.coreboot.org/#/c/21587/1/src/mainboard/lenovo/x220/devicetre… PS1, Line 171: 54 maybe change to 14 to avoid confusion with comment? -- To view, visit https://review.coreboot.org/21587 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id1ccc2c4387370e284ff8964e1c41d945cefe74c Gerrit-Change-Number: 21587 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Sep 2017 03:11:31 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: google/kahlee: Don't set AGESA memory clear
by build bot (Jenkins) (Code Review) 19 Sep '17

19 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21596 ) Change subject: google/kahlee: Don't set AGESA memory clear ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60701/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15903/ : SUCCESS -- To view, visit https://review.coreboot.org/21596 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b8286ade718fa80bf3badd478ab9a7df643ab98 Gerrit-Change-Number: 21596 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Sep 2017 02:24:09 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/kahee: Fix number of memory channels
by build bot (Jenkins) (Code Review) 19 Sep '17

19 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21595 ) Change subject: google/kahee: Fix number of memory channels ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60700/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15902/ : SUCCESS -- To view, visit https://review.coreboot.org/21595 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic263d2677a480448beaf3850391b1a3d4ed38657 Gerrit-Change-Number: 21595 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Sep 2017 02:16:58 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/stoneyridge: Put S5-S0 AGESA heap into cbmem
by build bot (Jenkins) (Code Review) 19 Sep '17

19 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21594 ) Change subject: amd/stoneyridge: Put S5-S0 AGESA heap into cbmem ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60699/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15901/ : SUCCESS -- To view, visit https://review.coreboot.org/21594 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ff35eefb2a68879ff44c6e29f58635831b19848 Gerrit-Change-Number: 21594 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Sep 2017 02:07:01 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017